From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C58A43315; Mon, 13 Nov 2023 04:58:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E047F402A6; Mon, 13 Nov 2023 04:58:24 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 29D504029A for ; Mon, 13 Nov 2023 04:58:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699847903; x=1731383903; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=3z6DgbC+rhMCE115B8+rGjru8Wwt8hfysyYGqciKrR8=; b=mmmfi8IS+dkjqqIjURFBxKEJEr4dO3VQ5kUO+DW2pp5V/aruxI/SySVp 6hym5mJUvS7XMfX8qy1Mh4AY17uTdFZU4xx60MroPaPVb1EU99ECiGYw5 ZcVZ2PG7DCFUaYLApL2eHe24LXZYMEGFobEAzb/O8cpD4eH0IOiLPKzSs XXKDLrG9nhSB5nbVP9arxCkqp5Il2mwIAM/8JpCu+oadXOyqkpx6ExOn9 Xt7ANBVahBwxc6hPQoKkaA7swYR91FHZALaWaI5Schku3ZaIWtSZN2NuF ZwFjYIIYpnMLH3qsywqzr6UO2tPBqYlTwKSGUpWehlDfrREIlT0ma+SF3 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10892"; a="454676003" X-IronPort-AV: E=Sophos;i="6.03,298,1694761200"; d="scan'208";a="454676003" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Nov 2023 19:58:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10892"; a="757689193" X-IronPort-AV: E=Sophos;i="6.03,298,1694761200"; d="scan'208";a="757689193" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga007.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 12 Nov 2023 19:58:21 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Sun, 12 Nov 2023 19:58:20 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Sun, 12 Nov 2023 19:58:20 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Sun, 12 Nov 2023 19:58:20 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I2pF7zOvHDQwkm8+Ky7Q1g1xVCAWs6yDx6HFd4Vi0l4kJ8M2SDU4LxIjgoltpjlY+YY6t7reApX3QHmHXm5YMnFmwVc8CMLbTqtSfE0pgan5io17oetpka6jK+R+BV43W5o+nZvHdESfU6VvaC4lrAf1Mx5l1ps/lj9W3c8FY8kSFgS7WSPzmaV+de5T5575RoAklSPx83cUylFnvQVN1KFLsrnTUKdg9CwTcxMDn8xXb/QbXpxuRhHm03qqIdGDcoy+30+VjAHr3nEXZRxJNjAnnY898W5nv0woeJnXj7F1ilwS403WTBiog7v9+x41MQH+KU08YrkLDli1kAI0MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3z6DgbC+rhMCE115B8+rGjru8Wwt8hfysyYGqciKrR8=; b=QkAfss0KIbhmGxGJzN6YSKEJiNG6aepnB0DgBpAI/JjUf8TW03OT6H/j24kxB3kc1Q13KdLUVjdxyFgzwf7jo4iLLpirGplCv9aGzod1dszqywc9vJjy86fKvDYZTL6uTh5brG/SjvApNDidwSXtTeXg9GyvaU0//OZmvBLwF5Rd4CTLs/UE+HsJbFb2+dfvBEdglQ7sFodCeV+RDhxiPLsa0fInu0D45zqaJoXlk/EoXhqgHP+P+nRFQ3RqCOdWOid3IAuSc2GL/aIpgVvkrWSTvjdTT+hL1uPNbOc3PIEAp9vMf3JHwIvAx041bUSbXCeCAytpKcg6Gvhl24nh5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by MW4PR11MB6692.namprd11.prod.outlook.com (2603:10b6:303:20e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.28; Mon, 13 Nov 2023 03:58:17 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::62e2:b53a:6a07:f136]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::62e2:b53a:6a07:f136%7]) with mapi id 15.20.6977.029; Mon, 13 Nov 2023 03:58:17 +0000 From: "Zhang, Qi Z" To: Thomas Monjalon , "Qiao, Wenjing" CC: "Wu, Jingjing" , "Xing, Beilei" , "dev@dpdk.org" , "Marchand, David" Subject: RE: [PATCH] net/cpfl: refactor flow parser Thread-Topic: [PATCH] net/cpfl: refactor flow parser Thread-Index: AQHaEVXX0cK6QonVrEarX12hdEZ7/LB2+6cAgACdg/A= Date: Mon, 13 Nov 2023 03:58:16 +0000 Message-ID: References: <20231107083456.1259255-1-wenjing.qiao@intel.com> <22077230.EfDdHjke4D@thomas> In-Reply-To: <22077230.EfDdHjke4D@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|MW4PR11MB6692:EE_ x-ms-office365-filtering-correlation-id: e084fe47-5bcd-4a84-7a0f-08dbe3fcc438 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sKxn6wZL/lbRDo4w8Ju2KrIbk/4NbtVL3y88XEynfUdHTf/gXGATtLWOwUn2olXpZvNEqWzNRQR3GyWR0gNKEANhKnYh78VQmETe0n5vJzsUchRepKOjx2YovkPM9iGeDJAmCaNKB9mb8daIyzf/wkD7PTDLEMqSYtVAgGKLW+KW/JXl0Ica2HNNaGC1KjY873hXMetK2ujI2MAmVCXUyw8ATWZDVwDodShVado/IVk2apMq67Oci+QDLURfEc0lBRmOiLlYRio42oYrGn4FlBsn5TT/F3N2SDaN8L22+bYxQZvybkLXWSWIjM5A6YNJa0SftwOEfq/psbYCjtbi6dVH6LR5iRb9RCbc7Y0WmNZd5Uo80nSxQZZRguJvGwTRpXsdAP+H2m9bN1Fc7YHVfLpEHKPQMJV2wn5tB6TzXlQhXfJXoa5/6DaRygdy/kHWPoO7PPNZ/AvFd+wlT5dHTt4TDHKQsL7x1xCnKEBm+zun564L2CM0pBzFMQdvAL+WGZlQU18B8kLol4K32kb0ta/HiEF2KHBlf/YmkFuXqRivCBlgPHxEJs4FrNFCafVDpJswN2J77XEym04uJAChmtmhFaJy5VTXQg2oN6YM4wd6wEyQv0UPA5PUVVSSQzRYF5qd8sXuEp5pniVM1dfPng== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(366004)(376002)(396003)(136003)(346002)(230273577357003)(230922051799003)(230173577357003)(451199024)(1800799009)(186009)(64100799003)(4326008)(8936002)(8676002)(82960400001)(122000001)(52536014)(38100700002)(66946007)(71200400001)(76116006)(6506007)(7696005)(66556008)(66476007)(66446008)(64756008)(54906003)(110136005)(53546011)(478600001)(966005)(26005)(83380400001)(9686003)(6636002)(316002)(33656002)(41300700001)(5660300002)(86362001)(2906002)(4744005)(38070700009)(55016003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Y2LzHYYgI/7vJLXNtL28VJTSBvJK+iSnNpynqem8k9Pbu3QEDirlZs4HAeKD?= =?us-ascii?Q?JmOzBiFzDv6103bQcQSPCPaYzn21glb6gYafz8J0qCHQq+eYM+tSoE7C+KQo?= =?us-ascii?Q?JpRS6WV24Er0FYXBr7iIUsBURthXLk0DU/U2z8IOw/3cQeN3Iotdw1H1pVah?= =?us-ascii?Q?q+d8B/sKpvDnWk0fqSzf/9hSU+MoKqaTmCabijfXWe8SpuwOQ/UyGOxJUnO1?= =?us-ascii?Q?+DV/nqeQ9t9DtfWEnWtyRTaX2jJnzQpAVzbk/guCfqIGMb1wNb4f9E6tXmCu?= =?us-ascii?Q?jewkdytqbVyEO0WomM+ytr1sUiv+soCSzr9CWN2M6ODTIT59YJ4l0Cf2hitb?= =?us-ascii?Q?t+D6IJqJqW67Wcrj7H/1tt6tngBK3MxqQwOyh7sqcIQNUTwXbEkXNS9I0/TU?= =?us-ascii?Q?Nd4+cyUX/9zUkeZMvI6xM89R2vT+9hnJa7/bWKY9YxJlCElKqKpk4awJZ7HJ?= =?us-ascii?Q?7tVgxkXm8QIA4DQzx87U8ZceiMpe0GEROInVE/MgMAs9td69IPdPVQwlEZox?= =?us-ascii?Q?Cd8d3h4pzHAF2TVEMX6IBPgK4YsMW1CyHFiWNSUnPrAT5Z6YuRDvxxZqNyYy?= =?us-ascii?Q?Lu3Y2PYfVf8u4RsuvBZoNRs5VEASCIaby+7xcQXXT2JBGYzuiMbMtJ+PIWAr?= =?us-ascii?Q?so1rGLsen2R1dIaRfjBBaaOourYkig8R9QDJ3CQ1G/EJWnr3vblWJ0ZViRAA?= =?us-ascii?Q?VTcxLBFNQ7tgzc/q+dnt5z0HuQfewu0xMccD8fcZ9n2Wx5PgcCtRUmysFzFE?= =?us-ascii?Q?2wMVRzr1zH7Gbk4CRKoIAvCRj+LW3D6o3aGZFLmylS7dT/yFSC6JhIUcJT4p?= =?us-ascii?Q?pFLOSaZUYkDwrDXaoUYt9KtAetEYoI9mng8my73ywsOMwkqVqYVXB5/0reqR?= =?us-ascii?Q?XxToXz+U2wBA143vXpOBqAKDJ2rPR7hXSY0/cvGeZBmWvZbmUI3ozkZpCXTb?= =?us-ascii?Q?bZdfZ8KfkY3VqW6P8q42BKpjDLeJ3POA/FyTmajije24CGJXzNezEkUVbWy0?= =?us-ascii?Q?y87OEKeMiGfKOnz6gFfTTa82fyQ9kLY3uP5QMI7yigTrGPXWTrEBHMRDNLIM?= =?us-ascii?Q?VXfeqnuMXgSgvZDHEvtMyNOydKTqQpBbMEo8FcuIKRD6tK7dkEwcz6Ztb4Pb?= =?us-ascii?Q?jw8gwTg/LW2uN4f4+7hIWZBnzMAWa5hpt+kk/hrMUnAfUvwKiy7/qBZyqQRj?= =?us-ascii?Q?4dIehd/JRh3hi/pcMZIEC7s2u9KxJA2mStqG0i+2L0+Yot5vmt8Ie8XIZLuq?= =?us-ascii?Q?wATRnocOfQv+QeShF8GlKrmzlGnLY1E/Ls8042qdCbOhUxxIvPP6zBON6Jbd?= =?us-ascii?Q?9kT6nGcfqbHBFXZ6rPb2/s/JnQr/nsWXKSC216+Cs9YCCigwqZ7abWr1vyn0?= =?us-ascii?Q?mTIx6lbeUlXvoO/3ajKTzs37wNjNBu2GC9uvMrmaI+2bO1Tx8Nwy9CViKIOA?= =?us-ascii?Q?g8Gs/DrhMkxTwL7RdAJwHrPhKvuHRXkCSEQNlk0l7CasqFlc3tc5lhGZzggM?= =?us-ascii?Q?QNyKtV/O+PqJj2ukRVOlDn9nH/7iE284jtMf54CvXUzcMiV5SI+4J5SLmRba?= =?us-ascii?Q?V98sgQe9t3OZnjN1o8I8ycPzM90fM7l3XSsUBMRe?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e084fe47-5bcd-4a84-7a0f-08dbe3fcc438 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2023 03:58:16.5886 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ORmoMlSV5Hs6ger/DbRV7onSCnS5aMac9FnzjtqrEUZLYaFcq62t5zwnp0RcIRQEePO5U62GNgNVfP6Nlb2zZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6692 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Monday, November 13, 2023 1:39 AM > To: Qiao, Wenjing ; Zhang, Qi Z > > Cc: Wu, Jingjing ; Xing, Beilei ; > dev@dpdk.org; Marchand, David > Subject: Re: [PATCH] net/cpfl: refactor flow parser >=20 > 07/11/2023 09:34, wenjing.qiao@intel.com: > > From: Wenjing Qiao > > > > Use strncpy instead of memcpy for string copy and rename macro. >=20 > I really wonder why memcpy was used for string copy. > As you fix it, why not using strlcpy, as recommended by checkpatch? >=20 > Qi, why do you keep ignoring warnings reported in patchwork? Have to nack this, there is no related patchwork error and warning was repo= rted for the original patches. https://patchwork.dpdk.org/project/dpdk/list/?series=3D29767&state=3D* And I agree strlcpy is better than strncpy , thanks for the suggestion. >=20