From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55A9B42C46; Wed, 7 Jun 2023 06:03:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4751D427F5; Wed, 7 Jun 2023 06:03:36 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 01B7040A84; Wed, 7 Jun 2023 06:03:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686110614; x=1717646614; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Htr1kTByXhL8FCeXIXv4dd7xZF6LKBOtsUO4aPyK9EA=; b=iJopeiZyqdkaqOW1RcbWNIFkjthE1UplMh6laHU/IhY8mVfLeMBSSom8 rd08i9YuY+xHyOcA+Bpo81JpkdteEoeQ/rDVTQ20YDRFrbduHKhcQfJwe FWN9mE7F9kVDd8NonPZpztMOhvwv0yyUn6jA/kLveF3oid+GqhcXr48wL 8KiduySFK2XzmqnwUayQSM/RwWY+JPDy3n+m6alSHlXXY0tg/Mq0Q/Sab TpXTJ80Vi+/rWJc1+I13Lpod3LfI0fGL7oZZAZjyE5pDPxNLKJxHRmsPW YAOd2dDTE50aokpv+D0q/HU7gUc0VVO/eQfX6eMrs/+aox/4BFMltkQOQ g==; X-IronPort-AV: E=McAfee;i="6600,9927,10733"; a="337232713" X-IronPort-AV: E=Sophos;i="6.00,222,1681196400"; d="scan'208";a="337232713" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jun 2023 21:01:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10733"; a="739042439" X-IronPort-AV: E=Sophos;i="6.00,222,1681196400"; d="scan'208";a="739042439" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga008.jf.intel.com with ESMTP; 06 Jun 2023 21:01:52 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 6 Jun 2023 21:01:53 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 6 Jun 2023 21:01:52 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 6 Jun 2023 21:01:52 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.44) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 6 Jun 2023 21:01:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gKpliHTUo5nES2qKaBRR2l3INCOI5IVOzWDyv9eOKkKo7+o93kSLFB7yljoGqS6ekATrb0/gBwa2elAW8iNyvGgj/B9d622sspwsbU1obwLKuAESRVcio45epU98JVlIOZrcpsjpOVHvfyoyvkYLciD93ABwnYIbZsIi4pcmMtdGc6Yy102t6HQKDrK6NIVnOSg/rr87EVbSrdDtTM1UZsFVRt45WBxmuV+zzSJ7K3x3zt1+WXd2QgpXmcHtMS6yuCtl0fU36rcIGZdPX5AP95/1twV4zlrbNpIhMv8L1Kdmbt2/nFckw9/XiQseucOf+Zi87BvboMRQzSth62bEqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Htr1kTByXhL8FCeXIXv4dd7xZF6LKBOtsUO4aPyK9EA=; b=GqvSqqGHNGBVzfmrKoACg3d20nBJWfSkXhhVLVW6bxUzI2gxFPnR6/u/4D+kuCUfjFoxCa/cPQR06u0ihUec9pg/v1lMnGibeQ2P82irod4RPi5jTPQgPj0Gc9GacykFXpKKkDjhjZd+RW2Ea06116BOQCbzWvMW3aVeYQ0zG5hQauykhcY2Y3jWyQ2VgrLGFcYdNC1xA52Iaj5aHg7KLzDI0CHcSN+agtfXIduZ+SI+5VHHxMI+DXLb61maW95ZYlIDtchtgaBXyBanrLdIbJxEet9GU8drSbGFFAL/jYCzzCWsA5+asGSPexoeb4yflSIZ5DN4nbWZ5A5DMGY9YQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by SA2PR11MB5003.namprd11.prod.outlook.com (2603:10b6:806:11e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.19; Wed, 7 Jun 2023 04:01:51 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e570:d9a7:df1b:1589]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e570:d9a7:df1b:1589%6]) with mapi id 15.20.6455.030; Wed, 7 Jun 2023 04:01:51 +0000 From: "Zhang, Qi Z" To: "Deng, KaiwenX" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Yang, Qiming" , "Zhou, YidingX" , "Chas Williams" , "Min Hu (Connor)" , "Wu, Jingjing" , "Xing, Beilei" , Mike Pattrick , "Doherty, Declan" , "Mrzyglod, Daniel T" , Dapeng Yu Subject: RE: [PATCH v4] net/iavf: fix iavf query stats in intr thread Thread-Topic: [PATCH v4] net/iavf: fix iavf query stats in intr thread Thread-Index: AQHZmOo5wzlXh+S+OU2ufYnj0DEA+K9+tBWg Date: Wed, 7 Jun 2023 04:01:51 +0000 Message-ID: References: <20230322072615.179196-1-kaiwenx.deng@intel.com> <20230607020350.409080-1-kaiwenx.deng@intel.com> In-Reply-To: <20230607020350.409080-1-kaiwenx.deng@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|SA2PR11MB5003:EE_ x-ms-office365-filtering-correlation-id: 2aa39084-a140-4f6c-58cf-08db670bec7c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IufZWjG2xy6Vj/YHQ3BS9XvfZ7XoZPA+i37RepWCHZxaCWEVy/fasiDdtZp24J+fHNKplgl3xltkk1ZgBLTjfcGuAqg2Oblb17SueUR5CyBbvg7HCXcR2D3JYXS4ByUAlxd32t8epVE1QNKYfMzrzcSatEZ9UAwCabm4TxBfRrIFgY/Kjzye+ewpNDnS+Gbtd3UnLCWlGjX5hEzayhFN2DC0OGIXFccSBLyoiu9lKz8jHdMQJE97QAF/aGYigbaHLyftaRKLw/6HMaAI5i5W8+NaR07PfJlBHcnZ0ihIOZclHSofiSl64jQvIXEXn/+qzDtI758L3Xu/TJAFYndJ9kP/UCmDXkxPjQwqZM7lhJuVjoSAdyDtzhebsyWbmIfJK9zoFXJ/TJ5eX/IAR7NP9mkKCwYyLIE1htma5o2cB8W6gsqv4LP6bJgiMBYiX/Evbs8mqTR07HXqO2Swp7i4Lq2Ouj0lx1pAJrvSfCqEKddTT0kklv606aHYtx7yWott/UZ7akRAGhmpAX2HIOovqBK2ephT0y1ct8mJdmN5NEEbV+c6rrdALnBfQQvrnK5sivi7xkK/kDPQOSG4JKcKFJHPjcMtX07wluOxZ35UddGsw6A3o/0GzizOz+V6rkDj x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(39860400002)(346002)(366004)(376002)(136003)(451199021)(41300700001)(52536014)(107886003)(33656002)(8936002)(8676002)(54906003)(478600001)(7696005)(55016003)(316002)(38100700002)(82960400001)(66556008)(66946007)(66476007)(76116006)(66446008)(64756008)(4326008)(122000001)(5660300002)(110136005)(71200400001)(186003)(86362001)(38070700005)(2906002)(83380400001)(26005)(9686003)(6506007)(53546011); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?eTzudLX5nRa4u7Y6AKR7LN52p2da88kp9Os5OEoMFQ9xwJKRVyiItjgqCyM1?= =?us-ascii?Q?qH2XHMFd6ysqA5G7bwGaoRXqLkBRe0con9GsfgXLjIukk7JtIELAe3rojzeS?= =?us-ascii?Q?xRqDBFok7E8b/9W6xEcZiXU63xF67NiiY40x9iMaU8llBZft8JMG6DUuiAJi?= =?us-ascii?Q?vQK7X5XYwLaUZSxO47O6xHQ8pg0aCn7QIjtGvWguUlu8vVaLy7Lcr58ln+2v?= =?us-ascii?Q?OVlrSs5oGiD1pAQ+M7UiXQntN+ix8IB4GF2sc+yih33YvQZBxr/rV+RY1OKV?= =?us-ascii?Q?6R/dNaleWAG5JZ37jSDGmcbn0J/c0y6rfV44StRJPsQeKTWbAAbQxEPxk1vG?= =?us-ascii?Q?5lv3jKwwafn9VaWTZmjmIfxaOmK8m7GhI8GYi7gtB7WlnkRhouJ9dzBNZfxR?= =?us-ascii?Q?txDM4zs9SbehGmi8y8QHnye8V5FZp2gyxxHtQtOlIItK4a/yrwUDJBgdnAh7?= =?us-ascii?Q?xNXgUdr59aq+duhuBilbd71ezXxW4VH1DQub8AZDEoLU3kjBp0j69Xuy4bnn?= =?us-ascii?Q?UzjUB6qRr02FzsVJkaMqm0X6b2GL1EVbxGwQi+1AkumZ1qG85aWLUoZ25EFx?= =?us-ascii?Q?P3YemWzDdu8S/h3qauujHq2JVnBq2fr9U7TFTp25HTsL0oV208ztxFkCSBSe?= =?us-ascii?Q?b30Rm5Rt0dPR/Bfz4O9hh7BpnnUakpZEgJUmuEk25/iJPz6DRIdb8p9210kV?= =?us-ascii?Q?epUGs/sTLcpSAGHKfC37NWmLy6/vl+5CsjqnsZoBSjpNv1vFm67dAPUGYudu?= =?us-ascii?Q?9T/9aduN9J7xvuoEyFUN506V46dN2v0IY+odrsYuJKYcc0+oHI2rTz3jR05t?= =?us-ascii?Q?ypcxexFpcUTvpL6tGup1S5j5DlXZGDjviOB2BEGDOAOgXwEotGc8g0FWD+kk?= =?us-ascii?Q?R3V3KK6DBWMXcLez2riq98ALmT636tsojmbpqKkqoW8nkq2JUSkJ003nUsj7?= =?us-ascii?Q?BHkY8xViVIWsBvUgbQ1f2/KpOJHNP6ytxW+c8V67MmvD4Z3DdVjlXEiFLh6Y?= =?us-ascii?Q?9hoelHZljSyEf7m9qC4kkgO+7jdiKW7wfNZyg+k/kJeB1RBYKnKPlSMcwWtJ?= =?us-ascii?Q?5ZIDhc/On/qLh2vYc9N8eEMy08JRUe/9FJFqX0kYhdUfFn6Eiws8u9p7Pdkt?= =?us-ascii?Q?jmIl8PzgbZdY45063jd/2fZSImvbIOl+HAyct7Ygua46S+ARHZ//v4fLn0us?= =?us-ascii?Q?9hZ0/rsDW/4dS3foyfH+FDPPa7XqGkOlxPDKh3+oF2QdZBVnwFCHJvacSaIW?= =?us-ascii?Q?erzk6TyUAzNUK0DqCDm3JeX/hes1NphqbnS6OpzwozP+mw7rKEfmvGNiPTIp?= =?us-ascii?Q?GEPeMbylOtTrFMjNAXzLw5NA2bLnnWoaqAdMJU9sDxUoUz48IKzOxGHPyiNe?= =?us-ascii?Q?rH3iIjnSmrUlC3Qe3w+aFY4j0OHuHoiplUpvYKJ3F9a2PKy4VZ+NhnB6cbh7?= =?us-ascii?Q?GmJcF80US4K5nfLoPXTppvTXoqKxwTHKmTfjM3iA0IiSolB1g/O6KVBwko7U?= =?us-ascii?Q?NceKhsJ08vVfd/7LqBm2PAQdqVdtvHZmVPQHcEr5LaXvVoDoDVNNfqpcw2Ub?= =?us-ascii?Q?AMkPx/r3UPy8jnayds8nApDugniLUUcMPSLgKRHJ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2aa39084-a140-4f6c-58cf-08db670bec7c X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jun 2023 04:01:51.2698 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2wZH8/8VnIlOLEl56LfsQjOfsezmDGE9nZ6wUzrfi/pNZgQ8HDKR6bj6I7rahhGsYGRDGZ1hXXlFW1q3+wTSew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5003 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Deng, KaiwenX > Sent: Wednesday, June 7, 2023 10:04 AM > To: dev@dpdk.org > Cc: stable@dpdk.org; Yang, Qiming ; Zhou, YidingX > ; Deng, KaiwenX ; Chas > Williams ; Min Hu (Connor) ; Wu, > Jingjing ; Xing, Beilei ; Z= hang, > Qi Z ; Mike Pattrick ; Doherty, > Declan ; Mrzyglod, Daniel T > ; Dapeng Yu > Subject: [PATCH v4] net/iavf: fix iavf query stats in intr thread >=20 > When iavf send query-stats command in eal-intr-thread through virtual > channel, there will be no response received from iavf_dev_virtchnl_handle= r > for this command during block and wait. > Because iavf_dev_virtchnl_handler is also registered in eal-intr-thread. >=20 > When vf device is bonded as BONDING_MODE_TLB mode, the slave device > update callback will registered in alarm and called by eal-intr-thread, i= t would > also raise the above issue. >=20 > This commit add to poll the response for VIRTCHNL_OP_GET_STATS when it > is called by eal-intr-thread to fix this issue. >=20 > Fixes: 91bf37d250aa ("net/iavf: add lock for VF commands") > Fixes: 22b123a36d07 ("net/avf: initialize PMD") > Fixes: 7c76a747e68c ("bond: add mode 5") > Fixes: 435d523112cc ("net/iavf: fix multi-process shared data") > Fixes: cb5c1b91f76f ("net/iavf: add thread for event callbacks") To comply with the principles of modularity and separation of concerns, ple= ase separate the patch into two distinct fixes, addressing each PMD individ= ually for the bond PMD and iavf PMD. btw, it would be better to only list the patch that introduced the issue.=20 Regarding the missing part of the iavf PMD, it is unable to handle VC comma= nds in the interrupt handler.=20 This aspect was not initially considered, so I assume that the following fi= x line should be sufficient. Fixes: 22b123a36d07 ("net/avf: initialize PMD")