From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE9F94381B; Fri, 5 Jan 2024 01:44:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6E4B6402AC; Fri, 5 Jan 2024 01:44:37 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by mails.dpdk.org (Postfix) with ESMTP id 4212D4027C for ; Fri, 5 Jan 2024 01:44:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1704415475; x=1735951475; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=66KzlDtAgquMy5EZzj8NY80UItwEqLCaBP1V8NI+d+o=; b=iiHvReJBP6aPBmw5Uqf0Jy2AFPN7rSrOTYJ3Zxr4SnyUINHSboICdRXG ViN/JQviSz+5muDakovHK8iU9/85HBrqnvCpOrJDXx4W925y72x85ltKm TUtdXfX8GCfS2aZ0c9V9hEgu6jVVdGkhwmtcOv/ZcyHey3OAVT35jrtlQ fVKMZW42Qo47aJKcdrkzNhNp+fLBWHj/u/3P+nzqXR9OJNpe77PUBxHPD 3wzhOdZDWOn+pSMGE1dkLURc1sFSDuKm+WLVKehGMtq5m7qsE8Bi+12aM X+RbPQzEIQjarJVAJ6wT74RxnFcPczBFfit7Sog5KZgGYfwfJp7A11Z8K g==; X-IronPort-AV: E=McAfee;i="6600,9927,10943"; a="4177749" X-IronPort-AV: E=Sophos;i="6.04,332,1695711600"; d="scan'208";a="4177749" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2024 16:44:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10943"; a="846412736" X-IronPort-AV: E=Sophos;i="6.04,332,1695711600"; d="scan'208";a="846412736" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 04 Jan 2024 16:44:34 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 4 Jan 2024 16:44:33 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 4 Jan 2024 16:44:27 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 4 Jan 2024 16:44:27 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fJdjqBQIUJ08ljRKQwm5JANEkuqubAuecMmukbUIJTTRQxY5FMVzs8Llu98rbqItxRegBITUF7EZ6fx9uvGQXzN1ZUapfmRDUnj35Kvr9y3VcJI2VFYIdynFDrkf1h0aGKLmwO1bPv9naWiTkoR3Bqb/3xLPwVQ4pidwBf0d9tRoGP0M8DnFbymB9g+8IeRGLAKbxPEarbAz8Jv5s/+/SOicV75oTmYbfU5JWU6HBFpZEOntWnFWypgfy65ZW3F+23wqavv2kyykFw2y8f8DR0W5HQAexZCoRSTrylgZsqOHGZIvEpWwWpfQJm+F6HzU8bh5NZVTjviRF4PGW/IaSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6b10ZStylOY2muBXvskcPbxpjPstycLOqu0Rf7HL7k0=; b=jh4eNLWKAhlN9ADGvipoA736L1oSzKmOvFp/XNJ14Rj14DUkBLys8VD3db9pWKGnWumfw0dDeonDB950s5l6+fTTmqsjRmicVXW0PTt02nj6jOE6lg4e96rdN/qn42hRzRaBYjAHqMz61hfEJXNwypIR0hl4i2APvKJbDbBydaONiWdQSS4wAgvtvDar4tKvjBumxc66Eg6pNN3V+rCpWiRMEJzrpIUyC2270KScnNQkKFUpsAfjFlD8QCySg7ZVXIT5r80E3vW1evm37B3DuElwFH1YjClLk4jMVji19ofGD9Hy/MtVX9vL+dK7S2YTjoW6QjCUtLNpFK44JpM1QA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by SA2PR11MB4857.namprd11.prod.outlook.com (2603:10b6:806:fa::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.15; Fri, 5 Jan 2024 00:44:25 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::fc91:526:bead:4f73]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::fc91:526:bead:4f73%4]) with mapi id 15.20.7159.015; Fri, 5 Jan 2024 00:44:25 +0000 From: "Zhang, Qi Z" To: "Ye, MingjinX" , "dev@dpdk.org" CC: "Yang, Qiming" , "Ye, MingjinX" , "Su, Simei" , "Wu, Wenjun1" , "Zhang, Yuying" , "Xing, Beilei" , "Wu, Jingjing" Subject: RE: [PATCH v8 2/2] net/iavf: add diagnostic support in TX path Thread-Topic: [PATCH v8 2/2] net/iavf: add diagnostic support in TX path Thread-Index: AQHaPi+bkA2lLttvDESJIQtSxkcfRbDKYfxw Date: Fri, 5 Jan 2024 00:44:25 +0000 Message-ID: References: <20240102105211.788819-3-mingjinx.ye@intel.com> <20240103101054.1330081-1-mingjinx.ye@intel.com> <20240103101054.1330081-3-mingjinx.ye@intel.com> In-Reply-To: <20240103101054.1330081-3-mingjinx.ye@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|SA2PR11MB4857:EE_ x-ms-office365-filtering-correlation-id: a4d6fd1c-db41-469a-5b30-08dc0d87773d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TUv78MketKQrdCQGXpEVrY+K342+4G4hthyZJz/XC4MXhjOw8AKHFHH0DfTRP832r9kA5OHAgZEg+L5lvVrdHpDIXmDnSQFiyqbKOzE6Qw1sC/4xmrfhwW/QQ5eZEDE6faLBJ+rWx+sfo0WMy402ALZ8t66hcKu/lBE0QbsbOaPRAe9U45E+tUkmHgyncZXVI75HzO7Af1Rvxvle2X0+g2sLf09qF3QsbUVd07hEzFmXtXbf8VYDrNQJ5kwHiSBJZ5m7+BtLFh0kCsDrgsEX1RXCmINKVCvWSjNkLlES8+9DUT0p8rqdKj9KXg9ftdLPaQdzdOFjBTSuM64pMNGx4J0pDSwE38krkMCGR2aZiF6uzxSMHlqQFMorqKTgKrkEWxoOdbCCHR7BL8Cguqh+dGI54Y29SK+UHbwh3jg9Av6iHz1KKZs5+efPy8fNZaqcA3HHCQitRVPxdKLW0+M3O3SmHIV9wj3p/JVAfDE1U4LhEfiN8oDAFCbsQH5XlI7hHAtsFR9CHWiu2lSQrU+rlrRRl37PDSeYEVTzAoTebAf+PnAVKAWhPcU9I0JQ/gkBlFwY4ZjYV7PpccWqB7ASQxrcfJNHRd2+Kz9TEI9V8SPUy5KU8PrpgfwqXkpOEJ/S x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(396003)(136003)(346002)(39860400002)(376002)(230922051799003)(64100799003)(186009)(451199024)(1800799012)(6506007)(7696005)(9686003)(55016003)(86362001)(71200400001)(38070700009)(53546011)(478600001)(26005)(83380400001)(54906003)(66476007)(64756008)(66446008)(76116006)(110136005)(66556008)(66946007)(107886003)(316002)(4326008)(52536014)(8676002)(8936002)(33656002)(2906002)(82960400001)(38100700002)(41300700001)(5660300002)(122000001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?asOqy1Bbk5/2v3f1+N2Q4Umg6ZCezHMbqSG9fWwUgTlN3pmd4snE8XbKLWep?= =?us-ascii?Q?uSu06RpEYCv+cvBbB/C0ijbYlCvIWO4fpTT0ZLN73S3bQ6yyIz03/oJhHMnS?= =?us-ascii?Q?IEL2FJj1S3lYXMJHHrCC7HXb8dbcv9yEG270hpjN6/jXX0CCKJx2eLCvN7VQ?= =?us-ascii?Q?zQiJGqahxrcUjBcebv+92eDn3R1Ciau0fRCe3GWAH8qlA40CByclH9N8h/IF?= =?us-ascii?Q?9oil1WWX8ywQoXZWlgXDyVDZzGfKDq5SjtmbsPRCMkioCupd05s+quiCwuok?= =?us-ascii?Q?XOnutJ/1T8XX+Fdxavjl7/2T2X4BYaYMWBFGVIFQEm8mQtNXulVw+cF1I0Zz?= =?us-ascii?Q?OB6mGlUhJDgzFHmn+skf1WAKf1GJSDuUnWyTmNRc6Oel1yOGUJglycQG476m?= =?us-ascii?Q?lKKireCLoZORucBqdBEwSOT4GMO24U0JW2+bgDXdunOP3qWmHE+3ua2bud3d?= =?us-ascii?Q?TSHO/WD9wAjtj1vmVOHMRzp4AZCQQ3c6GwHtWdT+gpnoHW3Sm/aK8pVDt2vD?= =?us-ascii?Q?Kb+sQyil3CMIoln9OkFHvUNEzVKjmWZcryMWwo3hfD8idbqrPNGyq7d/hzBB?= =?us-ascii?Q?gEmhqB8L7til0sasuO/Rmtr6EXsjmlfhI5KMvaqvP179K09OYZOAlkwHEXHU?= =?us-ascii?Q?AU/xHFDn1JSmy3g3cyjGWrNpC9oxzTeezzso81VnBLepsY3f/4IpnN0kpUke?= =?us-ascii?Q?oAuNJRQCt64/mgFrhbVVfv01dcdc50NelDfTfxv9E/Z2AEWxWg5CUddgqhlK?= =?us-ascii?Q?v4QcEUH1msR9FWSHr4EiQE9BPAqb/Kd7RqpIgvbsgdxuDRsSCvlqcW1nkWC8?= =?us-ascii?Q?O9wwmPHeqUt7D8nT+dQdbUM1kTa5kPMAMrFi+X01Ag6clEP2siT8TXaSTOBy?= =?us-ascii?Q?T1SexQMg3otoEzPyGqWYeIEDYYlHkiCuwtoSUImBChKh/H52mkO62dcN5v9f?= =?us-ascii?Q?gvGf9ypSRb1cfDlu5XtPYdo3vJkCVdh6fgZgUenX52IOu20ogsT2T42NsTM7?= =?us-ascii?Q?bq2Pa49r8j6DUnwNwASG+vsFeTXqHtojEleTmfBT97tHiIylzqyLIejMzoF0?= =?us-ascii?Q?/ul4GwgOvynJsUmvBhDiLnKFhl8smr6a/AylCi8z1wiv2JOzCXQISEPuwvT5?= =?us-ascii?Q?QY2MIW6GFcpuMWybtvmODi911j4oNSLCYmVGGa4vYYSBusTjG3AxLWlzqhYB?= =?us-ascii?Q?VKzIPWqP8tXPJch/qWac+jSXWPmZV4+TpDPB25FXOP9aHdG8n8KTGr/4Dukv?= =?us-ascii?Q?hZlgat/UlVwUpZga/en4MmcRRCtCKaTeRS8IFlgTvHvwWcq3HnV4jE8QM3k/?= =?us-ascii?Q?Xw0QzFBjJOX8TGpEg0Sksnq5QiqXLIYNofULf8IpoPqlxW5UtZEp34ANMDcJ?= =?us-ascii?Q?q2Nn7r/sjKNrbPW23Lzrbv8x0+xU/ggIk1wWpbi3FL5P7Y8tmu4AFGyirY5S?= =?us-ascii?Q?Ou5uIU1jfK+jWTRGvrine8uoyHSZOlGYqis2iEPjHgwBnnZUl5NgapaIlHGM?= =?us-ascii?Q?+A8yLPFZE57EMIVduXmZDI/hmG/QWVvqgLJBS1QOuVg5MToWVkFFRqnc2IE9?= =?us-ascii?Q?6pSVFSYIGdy3GY+53NzAq8hZpUssA27/edtRLWwk?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a4d6fd1c-db41-469a-5b30-08dc0d87773d X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2024 00:44:25.2001 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Eip8dCt57YfRlhpIDhkST5nHj9XtV83F1ki8u7JoVSOi3aoMHmgXz2OzN6uljWtgQr9qjhv9ZhM3rOztkroNnA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4857 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Mingjin Ye > Sent: Wednesday, January 3, 2024 6:11 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Ye, MingjinX > ; Su, Simei ; Wu, Wenjun1 > ; Zhang, Yuying ; Xing, > Beilei ; Wu, Jingjing > Subject: [PATCH v8 2/2] net/iavf: add diagnostic support in TX path >=20 > The only way to enable diagnostics for TX paths is to modify the applicat= ion > source code. Making it difficult to diagnose faults. >=20 > In this patch, the devarg option "mbuf_check" is introduced and the > parameters are configured to enable the corresponding diagnostics. >=20 > supported cases: mbuf, size, segment, offload. > 1. mbuf: check for corrupted mbuf. > 2. size: check min/max packet length according to hw spec. > 3. segment: check number of mbuf segments not exceed hw limitation. > 4. offload: check any unsupported offload flag. >=20 > parameter format: mbuf_check=3D[mbuf,,] > eg: dpdk-testpmd -a 0000:81:01.0,mbuf_check=3D[mbuf,size] -- -i >=20 > Signed-off-by: Mingjin Ye > --- > v2: Remove call chain. > --- > v3: Optimisation implementation. > --- > v4: Fix Windows os compilation error. > --- > v5: Split Patch. > --- > v6: remove strict. > --- > v7: Modify the description document. > --- > doc/guides/nics/intel_vf.rst | 9 ++++ > drivers/net/iavf/iavf.h | 12 +++++ > drivers/net/iavf/iavf_ethdev.c | 76 ++++++++++++++++++++++++++ > drivers/net/iavf/iavf_rxtx.c | 98 ++++++++++++++++++++++++++++++++++ > drivers/net/iavf/iavf_rxtx.h | 2 + > 5 files changed, 197 insertions(+) >=20 > diff --git a/doc/guides/nics/intel_vf.rst b/doc/guides/nics/intel_vf.rst = index > ad08198f0f..bda6648726 100644 > --- a/doc/guides/nics/intel_vf.rst > +++ b/doc/guides/nics/intel_vf.rst > @@ -111,6 +111,15 @@ For more detail on SR-IOV, please refer to the > following documents: > by setting the ``devargs`` parameter like ``-a 18:01.0,no-poll-on-li= nk- > down=3D1`` > when IAVF is backed by an Intel\ |reg| E810 device or an Intel\ |reg= | 700 > Series Ethernet device. >=20 > + When IAVF is backed by an Intel\ |reg| E810 device or an Intel\ |reg= | 700 > series Ethernet devices. > + Set the ``devargs`` parameter ``mbuf_check`` to enable TX diagnostic= s. For > example, > + ``-a 18:01.0,mbuf_check=3Dmbuf`` or ``-a 18:01.0,mbuf_check=3D[mbuf,= size]``. > Supported cases: ``-a 18:01.0,mbuf_check=3D`` or ``-a 18:01.0,mbuf_check=3D[,...]`` > + > + * mbuf: Check for corrupted mbuf. > + * size: Check min/max packet length according to hw spec. > + * segment: Check number of mbuf segments not exceed hw limitation. > + * offload: Check any unsupported offload flag. please also describe how to get the error count by xstats_get, a testpmd co= mmand is suggested Btw, PATCH 1/2 as a fix has been merged seperately, new version can only ta= rget to this patch only.