From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "He, ShiyangX" <shiyangx.he@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Zhou, YidingX" <yidingx.zhou@intel.com>,
"He, ShiyangX" <shiyangx.he@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Xu, Ting" <ting.xu@intel.com>
Subject: RE: [PATCH] net/iavf: fix large vf queues cannot re-use.
Date: Mon, 15 May 2023 02:25:38 +0000 [thread overview]
Message-ID: <DM4PR11MB59942424AA8EFC720139BD50D7789@DM4PR11MB5994.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230508165824.2086818-1-shiyangx.he@intel.com>
> -----Original Message-----
> From: Shiyang He <shiyangx.he@intel.com>
> Sent: Tuesday, May 9, 2023 12:58 AM
> To: dev@dpdk.org
> Cc: Zhou, YidingX <yidingx.zhou@intel.com>; He, ShiyangX
> <shiyangx.he@intel.com>; stable@dpdk.org; Wu, Jingjing
> <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Xu, Ting
> <ting.xu@intel.com>
> Subject: [PATCH] net/iavf: fix large vf queues cannot re-use.
>
> Multiple vfs created based on one PF. If one of the vf requests a large
> number of queues, the queue resources are not released when exiting the
> program, resulting in these queues cannot be available to other vfs.
>
> This commit fixes the issue by resetting the number of queues to default
> when closing the dev (refer to the kernel driver) .
>
> Fixes: e436cd43835b ("net/iavf: negotiate large VF and request more
> queues")
> Cc: stable@dpdk.org
>
> Signed-off-by: Shiyang He <shiyangx.he@intel.com>
I assume this is a workaround, as the queue resources may not be released if the PMD quits abnormally. A robust solution would rely on the kernel driver to reclaim the resources during a VF reset.
Nevertheless, this fix is not harmful and provides temporary relief for the issue until a proper solution can be implemented in the kernel driver.
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
prev parent reply other threads:[~2023-05-15 2:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 16:58 Shiyang He
2023-05-15 2:25 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR11MB59942424AA8EFC720139BD50D7789@DM4PR11MB5994.namprd11.prod.outlook.com \
--to=qi.z.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=shiyangx.he@intel.com \
--cc=stable@dpdk.org \
--cc=ting.xu@intel.com \
--cc=yidingx.zhou@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).