From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB4E242651; Wed, 27 Sep 2023 14:36:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F36A4402F0; Wed, 27 Sep 2023 14:36:18 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id BFB64402D0; Wed, 27 Sep 2023 14:36:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695818177; x=1727354177; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=foELNq7H9QdV6jzhFpa6mvu4Z7suHtvsXlI1Qq/2o24=; b=gDasXIfPQbXOmlgBppHZEf/75W6tFkOnuukGbVa4eiD66+0Du9T2oRfL jLg22HDXTX3vvqn2LbV2VH7FvLmh0gVIAoDBiA/rhkAScDjMnaZdm25vu GaGJIOmmzQw0kR+RqD0JxUYo0fq3djOFgqtSA0vaCNQ9UstgNzxqxsk2N 8uiwdv9epce1EsInD3E7MLTa79I0lyOwBOKB0CI1WI95/+qcNZZV1lto5 F9chXGuppE6Ez5aSRdDuBYS+U0wafz0N2BV2xBuAxIFUtb3iSuk2cGDZq 2j1CcaO4nJyao35K8FFbJFvithvo1j2doNU5cecgLNOCefagtJ4h6nNSr A==; X-IronPort-AV: E=McAfee;i="6600,9927,10845"; a="448303963" X-IronPort-AV: E=Sophos;i="6.03,181,1694761200"; d="scan'208";a="448303963" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2023 05:36:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10845"; a="698861499" X-IronPort-AV: E=Sophos;i="6.03,181,1694761200"; d="scan'208";a="698861499" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 27 Sep 2023 05:36:03 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Wed, 27 Sep 2023 05:36:03 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Wed, 27 Sep 2023 05:36:02 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Wed, 27 Sep 2023 05:36:02 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.173) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Wed, 27 Sep 2023 05:36:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mmisbXcfSlrs46PXmJ7iVa8m7+oi7qQbltAj1hvpM7LS3PecbrLM1yoxtjwq2PIwyDs+G3BfBhTJnPdFzR70gSMbPn0J0k/BLQO99nyQYjX4em7Dg39VxPPlUxrjkk1RkwiN8/5iStLE427fRv//Ppvua1zFiihwPZvWHXQb/E8ZDhLYyQyjusbnammRImRkmvL8/RHCJ3V3kwVWGMUpgjrJ2Tm276gpXhpZZb3bRx/+W5lEhSAcpySTwEoNAbhqkd/QHCCAd0I8eWbmlKFdRsncSmKUDqdOP84cgCMLuOzUsO4d5t3j9i1Xo6pdKAsmaE+tby6H4hh/GrMhVVFhPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sst/38BDGJ8d+vIVQ5QMAqBCJT2H0+v9Tz/v9eMd8cs=; b=X8HJBc1KulpNLQqGvIeQSVXBHJcpr35lzI/o5tcbWRrJ5dobY4W+c2KLX2zayIM2gHkK0SAKA3rrMzkPIctXS5c8qHDKpM4XCwJ9zSG5O7lWayOW1UaqBc/dBNNeSrXDKDOmLC/bjsq2/0vQgHPjbJQ/ssH6YaqiiOdaOA4Erul1fX4+SCAV5rxKRJmZ0uVwv8cHh/NnG+C/cjWLFbW85YR/dsBX4bYlARRcd9rGtgzly/RzqaYXqhij2tAjNPP93OwcphNh+2Qfe276eiQhw7PrUlptqZlBKjUbVRuqYm0mG5Jrj+dQSZAHwVhUVQ7clRFg6N897layGFR78cEpng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by DS7PR11MB7858.namprd11.prod.outlook.com (2603:10b6:8:da::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.28; Wed, 27 Sep 2023 12:36:00 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::27ea:67e:2966:23e3]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::27ea:67e:2966:23e3%3]) with mapi id 15.20.6813.017; Wed, 27 Sep 2023 12:36:00 +0000 From: "Zhang, Qi Z" To: David Marchand , "dev@dpdk.org" CC: "stable@dpdk.org" , "Yang, Qiming" , Kevin Liu Subject: RE: [PATCH v2 4/4] net/ice: fix TSO with big segments Thread-Topic: [PATCH v2 4/4] net/ice: fix TSO with big segments Thread-Index: AQHZ8SbtF8ZRZQdV5EaVPgY7wDW6frAum8KA Date: Wed, 27 Sep 2023 12:36:00 +0000 Message-ID: References: <20230919140430.3251493-1-david.marchand@redhat.com> <20230927094148.1129330-1-david.marchand@redhat.com> <20230927094148.1129330-4-david.marchand@redhat.com> In-Reply-To: <20230927094148.1129330-4-david.marchand@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|DS7PR11MB7858:EE_ x-ms-office365-filtering-correlation-id: df595a50-80ef-4482-2dec-08dbbf564e0a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: B4rSOLIEL4saRENWHNDO294n/LXwLk6j2rmBL2luTSF3qjgZNyntKUZ6v8Ahw7cDtRgwzfV/JU6PCmWsj8v+kA+wET0jaaSSdg5P1Ckmxq1MRhLaonRSKXC/YioxAly4grsOqXl8RIVQ+MAKQqCpBl0pUVCpW7CENAkuKhOMH9sZyeJ0qUE4oO/WJYJI0km6T2sPWj304lfvtUmaHATTZRAJbU6SFjFce14u2kGe5/AaBx373dKoDx424DL7bvNWJoORX56y1lxxtBXjbuHinOAGeD8x9Xt6IMc5vOh2EtWaZueBaSJi3NsSPhAbZY8S3n3hHaBbNLj+P/0eQlUhj39m8+o5S4d+soW5wx4m5VlZQI7VOWqW5WlD57CGVnU7Za95RY4dpUgBmzIQ2xrpo9aI7VqFh7t+983Lwm/gEGcmksEqD+DOq2I/8GYMMIE/x8ZDBR63P57AOEDGcxjxJtY8esHRRbWBP6lupH+3CpBBRWMxwlVlqNeQmhFlVqpQxJXX5hYfZug8bBhKFxjvSk5BHQzuo+4zDQWgO1qgQMN1eC2cuSoPUBPaUEuXH6R4Hl9Jl16iakmdcW2yDZf+HNgshXxistP51VRvZi3xyQ4= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(396003)(376002)(39860400002)(346002)(366004)(230922051799003)(1800799009)(451199024)(186009)(107886003)(26005)(7696005)(53546011)(6506007)(9686003)(86362001)(122000001)(38070700005)(38100700002)(82960400001)(55016003)(33656002)(64756008)(83380400001)(54906003)(316002)(66446008)(66476007)(52536014)(4326008)(8936002)(66556008)(8676002)(66946007)(5660300002)(41300700001)(76116006)(110136005)(2906002)(71200400001)(478600001)(966005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GfLHtYcEN86dOck5BfsQi8O96VoeI3OoSuyAlmx1IsXQ69RW1Pvi/gpy1nDU?= =?us-ascii?Q?dAyurWrLkjiqGo06cdpBKVwOF4XGS8b7tGlfMzHyg26Wf67xKfOWmnuj8/PV?= =?us-ascii?Q?Cpqv/85uv+4HWKRA7FwevfWShHV7UsLal+WRkbbMngNwSehf67dEt6Fcy+Bv?= =?us-ascii?Q?K6QvrFBbqpaOoKaiThccrQ8Pluh2CjwAeHF+9ltU6LXMN9EuuxMQYFpdjaqn?= =?us-ascii?Q?WnucX+tODWhEvKdAerqg/uzVxdulYUQyqHLCERj6uwVycTrz14I5/2MHrDep?= =?us-ascii?Q?4xPg0CVpEyio2oU6wBGVzMq5w3R47WcyGSQPW1/zwFkkDKc4GUdWMuTCn4WX?= =?us-ascii?Q?YuA+Chbn/74+o1p90msRvIDYJfQVyaFg9tmOA3PdoPQ3VDHYlBbyKTRzqtvN?= =?us-ascii?Q?mefXIfA9SZ46mc8VDvsaMEFEWqE2a94DYpaKMjx/WMl2yDHo9tsLElSbP//I?= =?us-ascii?Q?QClfi1JFOFSLk9sCcYGqQr8Paeqb0HkqoO9xVp1/FZfDJ5vqdQhOAdLV/lCO?= =?us-ascii?Q?epd1KwASNeAkkHD4bfoeVU5c101oLQHHK/rA/9zZ99RsAPRMjnzB3xRNh1S9?= =?us-ascii?Q?mnDjS2UC3G5sj1ko5Rne0l6QKJWdy2X5g6c/BHJIH8xiVK2/yO5KZGjIYNvd?= =?us-ascii?Q?kiCDXzSkVV4YGjCU0be3+gWn/pEP/ZJS5zkm2+LvQ3CgjDl4PFv70mm+40Yz?= =?us-ascii?Q?XfavbUlzPQu+3IDdbM0jitxGdkB1I3XTU4TrcXXoUwhlbAoJVua1Smrrxw36?= =?us-ascii?Q?/ynkGkNTfaRV/MVBnsIK7vCm2GtF9ra+/l8BX4YKyODRQEVMXdD7nBFu+f2P?= =?us-ascii?Q?rWIRjXm5Qdl5s8ejyUTRdTiVN50ZuX1/7x5IyTI834BTqLGosfRzPHJqBb1p?= =?us-ascii?Q?SExRt1E0OUmmPOA+oQl7c9xX2hwA7GAmzFlMINndRBhNOFMhfvnn8pDdJjOW?= =?us-ascii?Q?A7OvZxe1wv0MVdkbBB2svZK6Oyd33Qs8PMUiQZB+oWrF6xIEWTkb6r54KA33?= =?us-ascii?Q?R1ww/92PGJNr8+hZ6eyhRxZKPEICvOul8Ns89cUkxIAwDOHUoLmb5BdPRlOF?= =?us-ascii?Q?dYnBxKSxn/hlS6IRwaQL2WylHQvBuO+QuTbGVihEES1z5JToviXblk2Vrd0n?= =?us-ascii?Q?LC22ADN8I8N0vAV3TOlzp5zLLXRfHCL3Gh4KEGAMymiLSkzS1N3ZX3WOZHrs?= =?us-ascii?Q?Fav5zskMkD3RbCLE1ovfBu214mg9ZDpmiuctTRFE0qRgfj5193kxVr8kJS7g?= =?us-ascii?Q?lDi/naNSGrTGqewJZ4fLbQmEponVA0WLEQ7MKFFENdszY60TqwbpadbgaA4H?= =?us-ascii?Q?jxBlXqzpsOIjTIGN1AOyRZDOO9x+yP+XAcoE697MjC4/ddwpu3CjYe6+e+9U?= =?us-ascii?Q?6H4AjCaCLIZf4dpudWQs28215jaCHuS9MiD+H2JH5E7Rm2xVHAoWUQ0ue7Di?= =?us-ascii?Q?a2/dIFhYOSdsloKj2OBvnRGl/eu/KrRJgcwR+W8e+f25T4TsWWkJMBqX2zS1?= =?us-ascii?Q?y6hExFcz5SJLw7N6zRGQSXOjhFp5YHPTcedokGeWZzI5hmqtjt7wL1Yl3HxX?= =?us-ascii?Q?YUhdHpU9nYpYYZIgXIrv6gzSA2jWR0kZFRtfWCgn?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: df595a50-80ef-4482-2dec-08dbbf564e0a X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2023 12:36:00.0308 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WQdIiCkVuZm/iPsCEzM73AubVah+7aRcxR4Gbunkj4FRXWVkEfcE+JUIWUC5PA0hePlRpkiMChEZJTkqSyWfTA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7858 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: David Marchand > Sent: Wednesday, September 27, 2023 5:42 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Yang, Qiming ; Zhang, Qi Z > ; Kevin Liu > Subject: [PATCH v2 4/4] net/ice: fix TSO with big segments >=20 > Packets to be segmented with TSO are usually larger than MTU. > Plus, a single segment for the whole packet may be used: in OVS case, an > external rte_malloc'd buffer is used for packets received from vhost-user > ports. >=20 > Before this fix, TSO packets were dropped by net/ice with the following > message: > 2023-09-18T13:34:31.064Z|00020|dpdk(pmd- > c31/id:22)|ERR|ice_prep_pkts(): > INVALID mbuf: bad data_len=3D[2962] >=20 > Remove the check on data_len. >=20 > Fixes: ccf33dccf7aa ("net/ice: check illegal packet sizes") > Cc: stable@dpdk.org >=20 > Signed-off-by: David Marchand > --- > Note: I am still waiting for feedback and there may be some followup patc= h > later wrt ice_prep_pkts. > For context, see: > http://inbox.dpdk.org/dev/CAJFAV8yOa3ShkVdEXHfnmOEmUTwV3e75Bu9U3 > OqpNc5usTt3Rw@mail.gmail.com/T/#u >=20 > Changes since v1: > - moved log removal in a separate patch, >=20 > --- > drivers/net/ice/ice_rxtx.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) >=20 > diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c inde= x > d5513e9e93..ee9cb7b955 100644 > --- a/drivers/net/ice/ice_rxtx.c > +++ b/drivers/net/ice/ice_rxtx.c > @@ -3685,9 +3685,6 @@ ice_prep_pkts(__rte_unused void *tx_queue, > struct rte_mbuf **tx_pkts, > int i, ret; > uint64_t ol_flags; > struct rte_mbuf *m; > - struct ice_tx_queue *txq =3D tx_queue; > - struct rte_eth_dev *dev =3D &rte_eth_devices[txq->port_id]; > - uint16_t max_frame_size =3D dev->data->mtu + ICE_ETH_OVERHEAD; >=20 > for (i =3D 0; i < nb_pkts; i++) { > m =3D tx_pkts[i]; > @@ -3704,9 +3701,7 @@ ice_prep_pkts(__rte_unused void *tx_queue, > struct rte_mbuf **tx_pkts, > return i; > } >=20 > - /* check the data_len in mbuf */ > - if (m->data_len < ICE_TX_MIN_PKT_LEN || > - m->data_len > max_frame_size) { > + if (m->pkt_len < ICE_TX_MIN_PKT_LEN) { > rte_errno =3D EINVAL; > return i; > } > -- > 2.41.0 Series Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi