From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A9C7343336; Wed, 15 Nov 2023 09:24:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 66165402ED; Wed, 15 Nov 2023 09:24:37 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 7F2F2400EF for ; Wed, 15 Nov 2023 09:24:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700036675; x=1731572675; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=EqJXvdGzWYbTL9Gn7i8lpqGjfrRjj3wYcTfjneMV8bU=; b=fQJZm+KERr5rvZUuv2BEPtd6mBBdehecTAREDZoU3Vti1Zfow5fu51nt pFNGnelhP4JpqxSr6cVVoz0q37Pfsyk6qU1EIjPqyg8fAFPrHpIcVdI2b QNB7uD2MTnNrkt3oBVqWgkXxQvlCN5RRBapxY3ULzggcNTvohyJruCZr5 iH7cYm8VxrGgje3JB60JcSL/oaO+5I/jLJE8xBRa1+wkny9L7+8qPsOeJ dx3PEAesNYfE5NfzXM55+nmHqm1XmXd5s4NguvC/OjjOcIPeE6zOZP06/ 6BenMffurmfGJWg/Svct7J+wLQRapS81jZNzdUzBfNoeMW9rtGJNhFLPp g==; X-IronPort-AV: E=McAfee;i="6600,9927,10894"; a="381229875" X-IronPort-AV: E=Sophos;i="6.03,304,1694761200"; d="scan'208";a="381229875" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2023 00:24:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10894"; a="938407765" X-IronPort-AV: E=Sophos;i="6.03,304,1694761200"; d="scan'208";a="938407765" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 15 Nov 2023 00:24:34 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 15 Nov 2023 00:24:34 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Wed, 15 Nov 2023 00:24:34 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Wed, 15 Nov 2023 00:24:33 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kGZ6mydRsLGS9lL9mxADNTM2XbVaz3sflhfqN1pG1kobgi8WP10/GmXkDZjfImyyuvqUk37IJ5oqGU6dgJdbAcMQ9+H5VZuVGBb+RyMzwrsI1dikI3A6NUhI/UeSlxGCaF6SXCyF607pbQ1AKe1KxhglQAdCrMaJK7eAZiGhMJ7XTdnH9s4vT8cEE+V7nWOL/TyObee7v22G7LzxLNGEVa5AuvxpL1HOFgkF14S1Bt4SpwQzxF38+Jt2+YbNc73e8yvEFLf0S0ZAPP/2u9MPeIt94voOyEcfqwlNpYL+yZnLCP9bS4/u5dpAXlOquqJHQXy9Ia/Q5/yepHHG7telwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MKR0Jn6YnfoM8eb/U4roLNAvJ3WyxkDgJLqYrnP28bU=; b=Pu0c5ABpUbwjWjr90H06uQaCuD+2amIG2RAjdcRLN1xXdUdKLzZ8rhrf681vEstccwuhlbvWu3el/V1UIekC3Gstb7N+wtY5Qq6/I1pSB+xtPPh3mApX8Gxg1DzKeBPUkfuSE+Ar9OX+WSGYxsODjJe6D77sLRqoiPLjtoafAtbKNfk+Pe9XMnpi05lUsDBAb6oqOVP1quPOWk02F19YKoNSXN1s7WQ4qS9IoV85iLlqlmXgEh2zdd3dTgjfgRrRu4d0nJM/Y52bXBlJO6ZIgJgQzSmj6Y3oBMEe/K0ta9E/i2i1E2g4TO02L/vuvPxRl5T8B29xv3S00n175KEVzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by BL3PR11MB6483.namprd11.prod.outlook.com (2603:10b6:208:3be::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.31; Wed, 15 Nov 2023 08:24:22 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::62e2:b53a:6a07:f136]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::62e2:b53a:6a07:f136%7]) with mapi id 15.20.6977.029; Wed, 15 Nov 2023 08:24:22 +0000 From: "Zhang, Qi Z" To: "Ye, MingjinX" , "dev@dpdk.org" CC: "Yang, Qiming" , "Ye, MingjinX" , "stable@dpdk.org" , "Wu, Jingjing" , "Xing, Beilei" Subject: RE: [PATCH] net/iavf: fix error devargs parsing Thread-Topic: [PATCH] net/iavf: fix error devargs parsing Thread-Index: AQHaFiB9+67voDbm7E+52af3anAEq7B7DShw Date: Wed, 15 Nov 2023 08:24:22 +0000 Message-ID: References: <20231113104436.86555-1-mingjinx.ye@intel.com> In-Reply-To: <20231113104436.86555-1-mingjinx.ye@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|BL3PR11MB6483:EE_ x-ms-office365-filtering-correlation-id: 30e587c8-62ae-41ed-5b80-08dbe5b44575 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: P2TVt9NjgsE+AYxtXIDjj+VzWrO5vMPMwskdQ9W4ElnbPjO3oRZetPSGf9nwD8WtsFWg66tnrhIU27WqvIJJ60111A4Ctw0T4rDYRUl81Wsv5rp4BWNTqYdatI6EePRX7R2cvWdXPAstl9nKTHjv69VZxCubacAlpGR7NOcOPAm+QoQjPrxriADSELrvAC6fk75IzVIb+pmLPMqlmgq5NVjNLmrJ87fCULqwbQwwGivGxYKxsQ7qHafMp3rvBdQi4PRLlWjYsn28HlrFiXuD1eNT/iB+NKCvIdtdVg2ZFPY140+cgDou8fcKmILs7cZemGx/ZmsBGUZ2nUeWhMbLxsJVb0NNRsjLlkw0MGVjd+/9v1knbzL/A/yUf8L6MPtrwjQrs7qol7PwK3SrI8tJNOxB4ED5XGgCkWzsP9hPG4KGG/LxJFmi3FFsbtg2SoQX8NFYVfi+qL/tq/m1cltXF3G05M9auxs8CRgQVfgFsMsKJh3u2KRFy4RzQf8lzZ2GHFEJISlRyxnm2+mrgAZMUg+SY+4XFgdHhbFIiVPWgFlITsHEv12BdyJyg9Ow3t8bh7QocN37FAeBSFqbtUkakFd1C6PDPYFnRKDd7gW9LnPekoeEu7CEkIcuyVgiOur1 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(136003)(376002)(39860400002)(396003)(366004)(230922051799003)(451199024)(1800799009)(186009)(64100799003)(66556008)(66446008)(76116006)(38070700009)(66946007)(110136005)(64756008)(316002)(66476007)(26005)(107886003)(478600001)(122000001)(53546011)(5660300002)(9686003)(86362001)(54906003)(52536014)(7696005)(6506007)(71200400001)(82960400001)(55016003)(41300700001)(38100700002)(8676002)(450100002)(8936002)(33656002)(4326008)(2906002)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?JHwd/w83A4bPCJppbwq2Rf5KvaS3Gpmr2JGkk66ksOV/yJd0LdoxUy9IkjXf?= =?us-ascii?Q?5rkemv+jGJf0m1KssM6WfGteH/Fq5tV+T0XaeOAw8bBqSow/IgzxVVaoI/nx?= =?us-ascii?Q?56x1/9qYgIdNPvl1Apc8OYgPgr0LVDhYeDt0u5i7RQhszvytVzuswVd2XG9s?= =?us-ascii?Q?zSRiCclXLaAi0bfFfdey9KcO7GyDOsanPpQ6qu3rkKC/1VaJNAuxvF0v3k0t?= =?us-ascii?Q?MuCQw9UrOMAKa43+Cgo+aM+5FUojAdKRy3zsgot9Dphy+5b0piKqPpmPPDq+?= =?us-ascii?Q?GudK9+GM0O0jDp/fth0Y73tRwxU5dYyKlgwcYyWn1LNaC9h+R80CkXoV4xen?= =?us-ascii?Q?xhE5gN1KFe/IsNQq7P2b32Paobk+wvCUymWFWdgwBt3BRIYIUX+NEJ3H1so5?= =?us-ascii?Q?znV5VaL2MslYHx6lCKhUFXdIsyflvR+mgNq0c4KOH5gWlFZO9Zjtj3z/hLjH?= =?us-ascii?Q?f9kFpmCgnhtxVVYyCmIoZHKsSUnV3tMNTNGWVr8wibDe+iM1SxtTtmdlzTSt?= =?us-ascii?Q?1J4w1UlWN1iOPsdl7uWl13j8fEoabvM/FWlCbcvNmy6n+DY2BaI8k22TCu/E?= =?us-ascii?Q?wz2pjWC0MxcoyQ3o1hVN4gW2WDMPLTGrgCQIO/r6IkbrSDd1LibULFQTOk52?= =?us-ascii?Q?d4ZFGiu5gYMwzcy7+zIk9UVxU/yhgwfe4LJwmZ3yQdzifBUoLEToJ1cMUmSi?= =?us-ascii?Q?pxTmJLqRZu+0nREvyjutliQ7bkpGx0RibN5juSjIObvNZ++H/z4yqT+3vBk5?= =?us-ascii?Q?bIraSmP/RMRuCLJZMQpjtMh0fhs5kl+u/z2GyiVxTAZ71L/6qiLYqYFupO78?= =?us-ascii?Q?p4eGIrf2rDSRkzOM9SYPnaqRPzG861yirVdMvK6FqgDocO7eSHYNNOPpo2n7?= =?us-ascii?Q?4k0ny5jFvr9l4stiYlS+Mj2SJgbtBX7wrgPCLnOjMp6ja/POYBeC0kUnVx0r?= =?us-ascii?Q?kdwE7P9+KQ+vwL7SxxjjVI1IwHrLie1HOe4Vfy32KjaxYYNAQcWWb89aCcW1?= =?us-ascii?Q?F2ePQZ10vONKsM/dynBunvrsW97fzUEgddywY/07zeoODwIdC8ueVJBlRk9v?= =?us-ascii?Q?ieO6FPvTxwpEmvOBn+rKFVS45kDWIa5ypvoDcDb9r8DLKBflLuKCQM9g0+aq?= =?us-ascii?Q?yZbwZa5AqhbA9JXsT3GDMHyMPhPgW55rCh4BZ8XROK6YrQQ6g1Nt7oIisnVH?= =?us-ascii?Q?29ulsczkZKKCHYhPpacGCvG5y7n/bQej7cRSUEOy8oJX+yeILpKYy+R5OBPR?= =?us-ascii?Q?Z7FnG0E/sjwdRT7ZDc4miWb+LCTHEx9xOXzm7Lm3MemhCQjZQlSAR+hC4xmL?= =?us-ascii?Q?mj6IPYsPeVONMARuV08kYEtyeYb8DsQHLBN07Zlq2UGnvfo5bpE++ReULANJ?= =?us-ascii?Q?6PphqB0/Am5QPlrtQrxbFonRVv2RsMya/Yy4B4L/RyrZHPw0bjyjw8elhkd1?= =?us-ascii?Q?rHXzw1psTSKv1Fbf+seCwjqhuAslAPUyUFgJ9+Pxacyf0wO0WGaewtSKfZQE?= =?us-ascii?Q?D2UMRhBW1E4THWN1S9LkSO01zAYo3lT6XyoARQK7rgqPc6qXcoKPXUckrllA?= =?us-ascii?Q?GCi2BrPwKTchzvdldZarU5THTmVS7SixK3JBvddK?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 30e587c8-62ae-41ed-5b80-08dbe5b44575 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Nov 2023 08:24:22.5012 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XLv21X/kDe2SiX48+rwL5n5K4HgSi39f8jRFkrX2exzlaYpSdgGInxqYERI9w0K7h9RWjIfcop5WStM5406MFw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6483 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Mingjin Ye > Sent: Monday, November 13, 2023 6:45 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Ye, MingjinX > ; stable@dpdk.org; Wu, Jingjing > ; Xing, Beilei > Subject: [PATCH] net/iavf: fix error devargs parsing >=20 > This patch fixes an unknown parsing result without devarg "no-poll-on-lin= k- > down". >=20 > Fixes: 5b3124a0a6ef ("net/iavf: support no polling when link down") > Cc: stable@dpdk.org >=20 > Signed-off-by: Mingjin Ye > --- > drivers/net/iavf/iavf_ethdev.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) >=20 > diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethde= v.c > index 0c6ab4ac5a..d1edb0dd5c 100644 > --- a/drivers/net/iavf/iavf_ethdev.c > +++ b/drivers/net/iavf/iavf_ethdev.c > @@ -2294,7 +2294,6 @@ static int iavf_parse_devargs(struct rte_eth_dev > *dev) > struct rte_kvargs *kvlist; > int ret; > int watchdog_period =3D -1; > - uint16_t no_poll_on_link_down; >=20 > if (!devargs) > return 0; > @@ -2329,13 +2328,9 @@ static int iavf_parse_devargs(struct rte_eth_dev > *dev) > ad->devargs.watchdog_period =3D watchdog_period; >=20 > ret =3D rte_kvargs_process(kvlist, > IAVF_NO_POLL_ON_LINK_DOWN_ARG, > - &parse_u16, &no_poll_on_link_down); > + &parse_bool, &ad- > >devargs.no_poll_on_link_down); This will be a problem, the parse_bool accept an argument as size of int , = but no_poll_on_link_down is a uint16_t Please also fix the issue for auto_reset .... =20