DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: Kevin Traynor <ktraynor@redhat.com>,
	"Yang, Qiming" <qiming.yang@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Xing, Beilei" <beilei.xing@intel.com>,
	"Xueming(Steven) Li" <xuemingl@nvidia.com>,
	"Luca Boccassi" <bluca@debian.org>
Subject: RE: [PATCH] net/i40e: reduce the ITR interval of multi-driver mode
Date: Thu, 23 Feb 2023 04:34:17 +0000	[thread overview]
Message-ID: <DM4PR11MB59943654F0F788AE2F7ADE45D7AB9@DM4PR11MB5994.namprd11.prod.outlook.com> (raw)
In-Reply-To: <2639662b-6992-93cf-74a9-ae164ba48c0a@redhat.com>



> -----Original Message-----
> From: Kevin Traynor <ktraynor@redhat.com>
> Sent: Thursday, February 23, 2023 12:49 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>; dev@dpdk.org; Xing, Beilei
> <beilei.xing@intel.com>; Xueming(Steven) Li <xuemingl@nvidia.com>; Luca
> Boccassi <bluca@debian.org>
> Subject: Re: [PATCH] net/i40e: reduce the ITR interval of multi-driver mode
> 
> On 26/12/2022 05:50, Zhang, Qi Z wrote:
> >
> >
> >> -----Original Message-----
> >> From: Qiming Yang <qiming.yang@intel.com>
> >> Sent: Friday, December 16, 2022 11:12 AM
> >> To: dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com>
> >> Cc: Yang, Qiming <qiming.yang@intel.com>
> >> Subject: [PATCH] net/i40e: reduce the ITR interval of multi-driver
> >> mode
> >>
> >> This patch change the interrupt interval from 8160us to 32us to
> >> improve the performance of multi-driver mode.
> >>
> >> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> >
> > Acked-by: Qi Zhang <qi.z.zhang@intel.com>
> >
> > Applied to dpdk-next-net-intel.
> >
> > The patch also looks good for backporting, so added Cc stable tag.
> >
> 
> Hi. This looks like it is not fixing anything and it is changing a behaviour, so I
> won't take for 21.11.4.

This comes from customer issue, it does fix for the usage when latency is critical, will be nice if it can be applied, thanks.

> 
> thanks,
> Kevin.
> 
> > Thanks
> > Qi
> >
> >
> >> ---
> >>   drivers/net/i40e/i40e_ethdev.h | 2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/net/i40e/i40e_ethdev.h
> >> b/drivers/net/i40e/i40e_ethdev.h index fe943a45ff..7c4cc44a27 100644
> >> --- a/drivers/net/i40e/i40e_ethdev.h
> >> +++ b/drivers/net/i40e/i40e_ethdev.h
> >> @@ -1497,7 +1497,7 @@ i40e_calc_itr_interval(bool is_pf, bool
> is_multi_drv)
> >>   	uint16_t interval = 0;
> >>
> >>   	if (is_multi_drv) {
> >> -		interval = I40E_QUEUE_ITR_INTERVAL_MAX;
> >> +		interval = I40E_QUEUE_ITR_INTERVAL_DEFAULT;
> >>   	} else {
> >>   		if (is_pf)
> >>   			interval = I40E_QUEUE_ITR_INTERVAL_DEFAULT;
> >> --
> >> 2.25.1
> >


      reply	other threads:[~2023-02-23  4:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-16  3:11 Qiming Yang
2022-12-26  5:50 ` Zhang, Qi Z
2023-02-22 16:49   ` Kevin Traynor
2023-02-23  4:34     ` Zhang, Qi Z [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM4PR11MB59943654F0F788AE2F7ADE45D7AB9@DM4PR11MB5994.namprd11.prod.outlook.com \
    --to=qi.z.zhang@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=bluca@debian.org \
    --cc=dev@dpdk.org \
    --cc=ktraynor@redhat.com \
    --cc=qiming.yang@intel.com \
    --cc=xuemingl@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).