From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: Martin Weiser <martin.weiser@allegro-packets.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Yang, Qiming" <qiming.yang@intel.com>
Subject: RE: [PATCH v2] net/ice: write rx timestamp to the first mbuf segment in scattered rx
Date: Tue, 15 Aug 2023 22:43:08 +0000 [thread overview]
Message-ID: <DM4PR11MB59943A76F2279BCDD370B086D714A@DM4PR11MB5994.namprd11.prod.outlook.com> (raw)
In-Reply-To: <FR2P281MB1701DFD739CBEE8C5DBFFF6BA10DA@FR2P281MB1701.DEUP281.PROD.OUTLOOK.COM>
> -----Original Message-----
> From: Martin Weiser <martin.weiser@allegro-packets.com>
> Sent: Tuesday, August 8, 2023 7:40 PM
> To: dev@dpdk.org
> Cc: Martin Weiser <martin.weiser@allegro-packets.com>; Yang, Qiming
> <qiming.yang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: [PATCH v2] net/ice: write rx timestamp to the first mbuf segment in
> scattered rx
>
> Previously, the rx timestamp was written to the last segment of the mbuf chain,
> which was unexpected.
Added:
Fixes: 5543827fc6df ("net/ice: improve performance of Rx timestamp offload")
Cc: stable@dpdk.org>
> Signed-off-by: Martin Weiser <martin.weiser@allegro-packets.com>
> ---
> drivers/net/ice/ice_rxtx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c index
> 64c4486b4b..e07c6d1f15 100644
> --- a/drivers/net/ice/ice_rxtx.c
> +++ b/drivers/net/ice/ice_rxtx.c
> @@ -2150,7 +2150,7 @@ ice_recv_scattered_pkts(void *rx_queue,
> }
> rxq->hw_time_update = rte_get_timer_cycles() /
> (rte_get_timer_hz() / 1000);
> - *RTE_MBUF_DYNFIELD(rxm,
> + *RTE_MBUF_DYNFIELD(first_seg,
> (ice_timestamp_dynfield_offset),
> rte_mbuf_timestamp_t *) = ts_ns;
> pkt_flags |= ice_timestamp_dynflag;
> --
> 2.34.1
Thanks for capture this.
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
prev parent reply other threads:[~2023-08-15 22:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 11:39 Martin Weiser
2023-08-08 12:06 ` Martin Weiser
2023-08-15 22:43 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR11MB59943A76F2279BCDD370B086D714A@DM4PR11MB5994.namprd11.prod.outlook.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=martin.weiser@allegro-packets.com \
--cc=qiming.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).