From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7089B41DB5; Thu, 2 Mar 2023 14:52:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0892F40E09; Thu, 2 Mar 2023 14:52:30 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 80745400D6; Thu, 2 Mar 2023 14:52:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677765147; x=1709301147; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=U1RAainX1OimxczKP7NnhKjvWSWyjr+wpBWFPri6Gm0=; b=DdwvilqIcbUmLB+lSAwuDPHOervNB8HVKd+8XaZlYyXe1A/EiShHpUhZ IORTy/YDQUpxw7UdFlvfdJ/G2oqqwbL0yIWZASpMNV8fMgh+Nhz0C6OcK rAQBqIn8ExkPEt17Cu0jxZG14Yd5QNSTf9BgFynwtl4OKg5LCuvIerUUf QDHi9eSQSXM63m4KI6jRPfiUT5dqtv2fdcbqt+BUM/7+Pz+BJppxgP7P4 PrP87cxdOk6iTyi7qU4kHB+OjMcvdPM+fV2qrYzVY9R5H1p3IrfRvVotY AV6o3MFBmYjLoyb3XAqxABh/YtRV+oiBMCmqV6wZaqW3gDynPtUbemF8R Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10636"; a="399511378" X-IronPort-AV: E=Sophos;i="5.98,227,1673942400"; d="scan'208";a="399511378" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2023 05:52:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10636"; a="920691761" X-IronPort-AV: E=Sophos;i="5.98,227,1673942400"; d="scan'208";a="920691761" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga006.fm.intel.com with ESMTP; 02 Mar 2023 05:52:26 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 2 Mar 2023 05:52:25 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 2 Mar 2023 05:52:25 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Thu, 2 Mar 2023 05:52:25 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.107) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 2 Mar 2023 05:52:24 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PWEJuAo4X8BnANX2qqj08vPrFqp4W1nzJ+5rBuPgx//K4k0jCwJk5Zu6392cX8AXZPENqYvGgQO7hk2Fw8kxBQifrk8YIbfpSmc/jvgjSFrTAnItz+QqS/FhRgHcwhtt7Hr/UNAmnaFNjOlrtnmPt5hSLnrpn2nKlL8oWL89U35Bya4Iy7SJ7AGeMiQtzdDlmE//lwjRYW1GaUfZS+x0JUMFsyxXsgJhhDF1hytkKvVJYhPt2+vZDHgqYCMB33sM0VOsLGIgSS0yDcahW6zNyXwF4Qyjiv6c1hhoHRqdo+wxwda42sZKYFcXJDQRNFOpjVmDD19AJH0+q/qM7W7M7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XQ2qF5oNZ/gMYATVNCWbG2HvRGwE3xmc1aQaKNU3b34=; b=Ni2zUOYsXBSX3+C4a5/qL7BwaPkTjs1pmhlcrn73jDmmqNOrX8167oN8ATokf+xGLRCcuP2aZ3fdAHVQky4eWOb8obZl4UHCqLALl/qA3reLzGZBR3RFZ/BhIQh91napsIHAivsgzbp78ThtTuipW0pmeW+qEXEkQcFXwywU9hxHisaPmtJikDUDLMCkOZGNjt8PDWNbEUpuRO8NeuJPtPwfd++MhF7499ltfI6m4ISMYEmLVpdWwvTQIYPzyIIGQFKomiNYNRj7+V4Wic6FqaCJ5UjqWI+FH8DUD1rbqP7XM6m0Si86ymuDoC4JlP4aUgdZwHXs4Ut0+73wnrOQlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by DS7PR11MB6176.namprd11.prod.outlook.com (2603:10b6:8:98::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.19; Thu, 2 Mar 2023 13:52:23 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::2c5d:49cd:a9b4:f764]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::2c5d:49cd:a9b4:f764%8]) with mapi id 15.20.6134.030; Thu, 2 Mar 2023 13:52:23 +0000 From: "Zhang, Qi Z" To: Thomas Monjalon , "dev@dpdk.org" CC: David Marchand , "Richardson, Bruce" , "stable@dpdk.org" , "Wu, Jingjing" , "Xing, Beilei" , "McDaniel, Timothy" , Ajit Khaparde , Somnath Kotur , "Daley, John" , Hyong Youb Kim , Dongdong Liu , Yisen Zhuang , "Zhang, Yuying" , "Maxime Coquelin" , "Xia, Chenbo" , Shijith Thotton , "Matz, Olivier" Subject: RE: [PATCH] drivers: skip build of sub-libs not supporting IOVA mode Thread-Topic: [PATCH] drivers: skip build of sub-libs not supporting IOVA mode Thread-Index: AQHZRFkrt467MfPRY0eyt/O0vb/Qjq7nkr6Q Date: Thu, 2 Mar 2023 13:52:22 +0000 Message-ID: References: <20230219115529.3260580-1-thomas@monjalon.net> In-Reply-To: <20230219115529.3260580-1-thomas@monjalon.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|DS7PR11MB6176:EE_ x-ms-office365-filtering-correlation-id: 654ce20a-0787-44b1-ca7c-08db1b25594c x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xAXM+4gl99BasVvYc9NqEynRn/njTOS6PDKVUpKMTio3XT7aD4kZdfkWfzap5coqy3pu2tKi3t2cjpp2UiOnVBts0KvnbDBkVKLkBY5v3v+eLXztdCtqwNPDCK2SwcPGioi6deLjHVYPsjqZVJHAVW1igwBLOCuNkOzwhvZb5gcwfHy+9doQE6KVY9CAhHjXEOJbPXS3OvhCvLqGVoiOmK+wp9MroCP0XKMQD21FSydorld114atBw/bOXkSpepvNyfdz/zNKgltlHm61dxgTFsI/H9jf02pvzY/z6M4jD6H1sghnOYVWutz8IAyHt2FJGX1RR5E2oJ4GZPd+aClTeMPgg/IMW++z0F2HOZzijvcVsfDUYAwZcaMYvPInm3IlnwNruPVyEQ4Yu0lTeKh2LnDPaGDdUYtpThyGT3EAjl+U9nQLLn2C3VjA1fmE4ovpXyvf8JQ5TO6hVBj8hvKJ2KAQYNvDNvU801OWD5O9oaXqVe35hU+aV+v+ONZPiVlL4SNjYoABXbkZdpddcpQtK2bL17HlejvjlmyHEzyszmPmtEvVDffdwZxnspLy1YzjrBClPkcx/gL4XILGyrAKXSOCBaaZh5r1OgOC/yiPZVJsoEjl+T2Mphxmliqv5nSOeUtZb/ttkVo7+hbGwTR0KB5OlPu8A6XlFwdwR+WTkIbmdNh1j+wk3gphzLiz/UcgcJrWc/iJJFu+Q9b0gMkaA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(39860400002)(366004)(136003)(376002)(346002)(396003)(451199018)(83380400001)(38100700002)(122000001)(5660300002)(478600001)(52536014)(82960400001)(7416002)(66556008)(33656002)(86362001)(38070700005)(55016003)(8936002)(26005)(186003)(9686003)(53546011)(71200400001)(6506007)(66476007)(8676002)(64756008)(2906002)(7696005)(66946007)(66446008)(76116006)(4326008)(41300700001)(316002)(110136005)(54906003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2hT5WQ7CzsecG6O3FFKGqrfEs91Dv3MPl3eGsKioc0DGkq1XLTc0/rYfqnlZ?= =?us-ascii?Q?mvWvQ8ePsKUFe24ZTXxnGwlSDsVlGwmGszNN918YDDd3IQydX4gciQmOaCd+?= =?us-ascii?Q?A18HTX+Wm2E9AgWw8yelbZGxNmLDrfXzaaNBQUshidJq+zkINhL9sJMXXvsu?= =?us-ascii?Q?PBtseuPghkD8LJFhkzZHlkXluLtL6AxHgtt1LauTgFJPi0XozH/oHCy65S5j?= =?us-ascii?Q?B9ImOxTbdSlfpW5PbHgioounEFxbzO1hX0Gk96w4obU9TmHcCOK8p9SNuXOi?= =?us-ascii?Q?Fn54O4j48oE5PbgQ2yQg7ms/yfmKD+hqu5f2OUhhsHl782FewAlnkQ3Rzvat?= =?us-ascii?Q?bnsoXLfTyR3i+HaMpk0iqdg7zxtYw3WWGEBqJ8si4MomJ3ZQm+APLtBUn+1i?= =?us-ascii?Q?VCl/vMG/VKDSs/yxmLQMakg/gDod6lxsqHbc4q2zKkkAIX7N1UQRorece7IM?= =?us-ascii?Q?dAg+1vVHkxbu7euWMV+HBjKjt6OtmnvJObXKribtIKN8sCGo4NZsexgj95rX?= =?us-ascii?Q?vYbnmOkef1InUsNNvIbPSCnTEpVJjRWi3jjFJYUWL2sQZsxnvT9W19pq5mP+?= =?us-ascii?Q?ErH1YW5VGPJojfRT4AfRHogoT/yoRGRq6ifzJKc5H4nslMyOhXe53UMJ9X5v?= =?us-ascii?Q?9c+lZLIhOIGVoi+8XJTIVCqWwykjxSvrn3bfC6xsE10plQ/68KEFv9ubIigG?= =?us-ascii?Q?jKjeKjKx2kTn6rd4SBK4gTswk//SMXhRIf0N0mRn1uoPVxRTA0Zvb3U3sgWg?= =?us-ascii?Q?R5hfCAsktpgHsTtfp4GmFHSXybqU94OYRPWuasgudjNOcjvXl6mUfOttkosR?= =?us-ascii?Q?8iPrlEz45TtSCKDSV1aBQp4uRWg+zhtUu6nTC3vU+ULDQjduSfhAgaxm0/Oy?= =?us-ascii?Q?A48cY/kG0rFncLOYgziuxvDc2b/eeKscEPYc7IYRVh03VrDVz9GjZxs2fm2G?= =?us-ascii?Q?Tx3DWNcoY0IUdwOs03HGR7wUFiQGIwaYwDk+yXfGADhlgylcWisWCJiAj4lw?= =?us-ascii?Q?x9VA/ma2LJmVHChhbnOPpqbGkSW57fUuCPN3rATEggdF6MiAXA11xpvEzAS2?= =?us-ascii?Q?WHg4Q7+IFnokklhK/TVUk6xkzmvr/Q+8QQ4Mutp7rYHRwC6dfCm89duwPHrJ?= =?us-ascii?Q?2nFAnM1eMeMy06h4uRc3LVbjcC2nGMtxiS1EEmWIh4Yizi8H14DgXKBDklgw?= =?us-ascii?Q?bosAsgsf50pJR6mhN8Rj4pCzQ1uMVRQl3bRqnlnICR+R41ZJbyic1q8GKj6e?= =?us-ascii?Q?WGpSHESnAuB2SMpzrrFQBWTF3WhX/exZRXu+dgqGQtACsrKhcpt8LfP5a0r8?= =?us-ascii?Q?DmZcLQBB4LacfpoVfcrYQIvFbl+EThBMFMyO2anM4vvfd/emzeYnt0yTGmBe?= =?us-ascii?Q?Nzrei7JS/kJRIL+OgWx2xfls7W3rVRppdNs4ST11MAUlXWKo9f8iebsBDMxF?= =?us-ascii?Q?FrYKJDJkU4uMThpQeKd17Yt/f+eRlJKRyBo2UP5UDnQ9Skdju3awrt+EwLGO?= =?us-ascii?Q?bGQ6esT2/rxujmO/SzpagvN4MVUOeAErr+NnLoi80/Zj2pVTLy2XhxUu2oaF?= =?us-ascii?Q?CPZzEWJRfjUABPQMCLs967oLu6jtzDpBYX4vmhtG?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 654ce20a-0787-44b1-ca7c-08db1b25594c X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2023 13:52:22.8689 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: b9zP3tm0FTzexm9aiHbSvWEAH6klnzgocSs4oDnUc710PZNi4+TWubr3LxIQL7nla+NbbP+T1DdJX0BZkOENZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6176 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Sunday, February 19, 2023 7:55 PM > To: dev@dpdk.org > Cc: David Marchand ; Richardson, Bruce > ; Zhang, Qi Z ; > stable@dpdk.org; Wu, Jingjing ; Xing, Beilei > ; McDaniel, Timothy ; > Ajit Khaparde ; Somnath Kotur > ; Daley, John ; > Hyong Youb Kim ; Dongdong Liu > ; Yisen Zhuang ; > Zhang, Yuying ; Maxime Coquelin > ; Xia, Chenbo ; > Shijith Thotton ; Matz, Olivier > > Subject: [PATCH] drivers: skip build of sub-libs not supporting IOVA mode >=20 > If IOVA as PA is disabled and the driver does not support IOVA as VA, the > build of the driver was disabled. > Unfortunately some drivers were building some sub-libraries (with specifi= c > options for vector paths) which were not disabled. >=20 > The build parsing of those drivers need to be skipped earlier to avoid > defining the sub-libraries. >=20 > Fixes: a986c2b7973d ("build: add option to configure IOVA mode as PA") > Cc: stable@dpdk.org >=20 > Signed-off-by: Thomas Monjalon > --- > drivers/common/idpf/meson.build | 4 ++++ > drivers/event/dlb2/meson.build | 5 ++++- > drivers/meson.build | 4 ++-- > drivers/net/bnxt/meson.build | 4 ++++ > drivers/net/enic/meson.build | 4 ++++ > drivers/net/hns3/meson.build | 4 +--- > drivers/net/i40e/meson.build | 4 ++++ > drivers/net/iavf/meson.build | 3 +++ > drivers/net/virtio/meson.build | 4 ++++ > 9 files changed, 30 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/common/idpf/meson.build > b/drivers/common/idpf/meson.build index 58059ef443..74c0e92cac 100644 > --- a/drivers/common/idpf/meson.build > +++ b/drivers/common/idpf/meson.build > @@ -1,6 +1,10 @@ > # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2022 Intel > Corporation >=20 > +if not get_option('enable_iova_as_pa') > + subdir_done() > +endif > + > deps +=3D ['mbuf'] >=20 > sources =3D files( > diff --git a/drivers/event/dlb2/meson.build > b/drivers/event/dlb2/meson.build index a2e60273c5..8ae7db0011 100644 > --- a/drivers/event/dlb2/meson.build > +++ b/drivers/event/dlb2/meson.build > @@ -1,4 +1,3 @@ > - > # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2019-2020 Intel > Corporation >=20 > @@ -8,6 +7,10 @@ if not is_linux or not dpdk_conf.has('RTE_ARCH_X86_64') > subdir_done() > endif >=20 > +if not get_option('enable_iova_as_pa') > + subdir_done() > +endif > + > sources =3D files( > 'dlb2.c', > 'dlb2_iface.c', > diff --git a/drivers/meson.build b/drivers/meson.build index > 0618c31a69..9c10e2633d 100644 > --- a/drivers/meson.build > +++ b/drivers/meson.build > @@ -127,9 +127,9 @@ foreach subpath:subdirs > # pull in driver directory which should update all the local= variables > subdir(drv_path) >=20 > - if dpdk_conf.get('RTE_IOVA_AS_PA') =3D=3D 0 and not > pmd_supports_disable_iova_as_pa and not > always_enable.contains(drv_path) > + if not get_option('enable_iova_as_pa') and not > + pmd_supports_disable_iova_as_pa and not > + always_enable.contains(drv_path) > build =3D false > - reason =3D 'driver does not support disabling IOVA as PA= mode' > + reason =3D 'IOVA as VA not supported' > endif If we check enable_iova_as_pa for each unsupported driver , do we still nee= d "pmd_supports_disable_iova_as_pa"?