From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB31443177; Mon, 16 Oct 2023 05:57:48 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 72CCC402BE; Mon, 16 Oct 2023 05:57:48 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 83A3040299 for ; Mon, 16 Oct 2023 05:57:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697428666; x=1728964666; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=252nxKsvsfrocdfqq+b6NANjp3NZrYaoIQ+6NCJxB9o=; b=jpzdS7cPqJ3HJ/0e7N0KprSz3P/foNZUpZ+t1o5Ret85/BcBluoT2L0u 4DLNVXWh6Z0daTuyouD518WuyyUMVrIOr95UGNNMXVNKmykhL7d4WK2Sq aXMeyxcg60EOgA1o6XhEDQY7MopjybQ/yagb90YOsqFMuPTfD7yNxYqKs 7F05asnvXjST9aLfHyqgqWzFwtX0t+WPntGjZ1Qypdx3i92k9CG/9MVPS csQUyE13zNhUNnzTdCAT8qIsunsHS9DtgEQdov+FCpZxHC/M32CpAOonv Qj0OdkV2VmO3BbqkKEz3O93T4+px219pW5Oo8he9BrgAeIPzsrhkxU0xL Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10863"; a="389301412" X-IronPort-AV: E=Sophos;i="6.03,228,1694761200"; d="scan'208";a="389301412" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2023 20:57:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,228,1694761200"; d="scan'208";a="3473855" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 15 Oct 2023 20:57:49 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Sun, 15 Oct 2023 20:57:42 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Sun, 15 Oct 2023 20:57:42 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.41) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Sun, 15 Oct 2023 20:57:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mTd3+GGyLTnY8WKbvI/hIz6aJKbTfXkX4FK1r3aAQsGcOQnRZTC/ZlezzWgaJfaI5q2zZblDUyRqGpDI/kndjJBTxHcK7Dtcbtu2mfFY1NlSZCRXWo5KZWTcJpsoZgmpVI85tjwgfURkNxRFmy8E5tSLSw8FSJCj1mzV1QOLPezIiZnXnvGckvHR6mY6kHOBUXzzj8r2MrGomMfMPI2PLnOckRKVEtuGpFeMZhQaflhqI370M3CxekerDRytZpRD60tOJk81CsVQX59ZkzmIrhF8bp4Fjazjf0edotXEjF+KCdlwVu3pojOK1OQ4jflZVNTTYoTz4NLjBiLVNjoSRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2Yd69WGKTLSJTYt/oJUP5LC9Ho7M9jcljjT741l+R7w=; b=n1iihwVCr6UozmAl/BZYQPn1xCnVN0gmhXKkrGKZbg4KxVInzFinyPU1yNRdsTijNIRWsPHP/IylUg9QIHokTh69pdPW7oPd6kR8sXEYxEQrwsrBsi9XfXsKO0Sx/GFljxmao4atXIxPa7v5aU8FDGRus28BztkJpXJLRFrLLAQF3leokG/K+YCwbSuvKi6tsQmRc4jiaaUp3lH5Edr5Q8j6krYAYrpRKV6aU8ixc+CDORjb9+EGZySWuSzc+V2JXTqKTEsW5AtWO+Bn327H9V8PagauzaUG2r4PmFxpqfzpFKLeUcEe7LX+1x9VTDwAL0u8otZyvlOAy9z6YwFsig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by CO6PR11MB5652.namprd11.prod.outlook.com (2603:10b6:5:35e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.34; Mon, 16 Oct 2023 03:57:38 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::27ea:67e:2966:23e3]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::27ea:67e:2966:23e3%3]) with mapi id 15.20.6886.034; Mon, 16 Oct 2023 03:57:38 +0000 From: "Zhang, Qi Z" To: "Xing, Beilei" , "Wu, Jingjing" CC: "dev@dpdk.org" Subject: RE: [PATCH] net/cpfl: reset devargs during the first probe Thread-Topic: [PATCH] net/cpfl: reset devargs during the first probe Thread-Index: AQHZ/BzLbCwa+tU5HkmgTcHXKHqWuLBFuY8AgAANb4CABgoIwA== Date: Mon, 16 Oct 2023 03:57:37 +0000 Message-ID: References: <20231011164720.418246-1-beilei.xing@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|CO6PR11MB5652:EE_ x-ms-office365-filtering-correlation-id: 0fae9fa6-ebc7-4acb-6222-08dbcdfc09a5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5ZvXzKFy2qpw14+VNSF5DMqemVc5agCPTT8RBhIW5/2QU0L4Yo9xFf4G0f1oMwzudh6VwWxOOVdWleucFDvmm1ZuHmcZ/65CJ2ydUCBciisftATn3SKRxKCKYRchNrl5PKtM0Pw12e788PMwjOxVBegdycSD4prDf53xCM4puErG2bi2sM8PrC77DlxBp9KcgGT0d8zFgCmhrlX/JzNcSAeb8DyKdNl9jOSuehUquevg9sf2mXtSTQuHzfMGGn4wOMygL5dPLvfAKetuat6AZDtVPs8NWNsqbI9poOyw8hdSXA2jMcSM8aJYZprCq3RQJdKWgLszJi8g2n1tXtTDIpa5sV8qgvgi1TaMYbmPXhT5xsvV+24xiIPVIXBQvUjsZboTgSFR9ncdmdRuCoatkgU5DVD/0IH2cFISfX0XzC+EYu0G98XJkQfnzBaVrnGX6rmxYfQWlCLHj8YPunFuLi0bZLQ9jUfnea8oeYPLKv38hYoOxvh8hOwYh3MnZMaaqipDil0/5oJYYm2W4ZqZpxHKgT2EOT/a58PcWQY7e7qUsO0emUDyp8d2I+nR7nehPUtdwKCgVt6FUcrvI8y3qiCx2qfyELQ61oyzSZR4ueCNpmUvIzPZooB2K3ttGlWQ x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(346002)(39860400002)(366004)(376002)(136003)(230922051799003)(1800799009)(64100799003)(186009)(451199024)(478600001)(66446008)(6636002)(66946007)(76116006)(66476007)(64756008)(316002)(66556008)(110136005)(26005)(7696005)(71200400001)(9686003)(6506007)(53546011)(8676002)(8936002)(5660300002)(52536014)(4326008)(41300700001)(2906002)(86362001)(33656002)(82960400001)(122000001)(83380400001)(38070700005)(38100700002)(55016003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YROAkuYS/xTC+YgovqN+jBnljM0AebWc9v0HRaChl4LVIS9LPYXY3bNgiJ9h?= =?us-ascii?Q?XJYOsrBDMkreusboN2CAQSNF1ekyLQlpKpL4srGZENMaAp5wMq9zeYh3lkIW?= =?us-ascii?Q?T3WlYzdeyKz/hX532FKod//vj08HMBb5e+sEWJxzf7e9FREngC2VPltThOBX?= =?us-ascii?Q?dLeijA0kH+oGVq4EAzc942kxYnNA6IrPuaYyBTYHNqByj7c2D267/O55dH0m?= =?us-ascii?Q?muNyn0KaFvq/sJPBjzxgUe7UFB5Iuc4/BtwNp7rz9OhelFc8gaf/cB+kqA81?= =?us-ascii?Q?wk2kOO3wS8eDTLWNzdOZbFWLpiuPLQX4OceBTxz+Q3OzCa+P9M9aryczQ0+G?= =?us-ascii?Q?Ju37DWUZ6W1fVE3ro9ZToVZKnD1G1EbpN0GabTzzZpAbR33ouvJcjyAkDYYZ?= =?us-ascii?Q?JFfUoMb4uGMufC4oHcJsxHSypATORk9XIyrjqwy1ZbCSyhFvysE8AcrmRi7s?= =?us-ascii?Q?wY+HoYnwXOqBhg176i5ZTKyXBJNZsX89qWjLmBsDnJvmyRsSVYUWxMc6ZJNJ?= =?us-ascii?Q?bKANX12rDdxz1l/kX9Ph3OlgFo7g66vcJz9+ujR8pAWPQ1Snr53S4ct3zI4R?= =?us-ascii?Q?X8qto2+wGpQUCS1+u8Y2/o/aXZdtKy2h9ooWHRsGGvgERXMr4iblj2OmpxIJ?= =?us-ascii?Q?sGyd5lxf3QLeMcNdfxs3NhTyoAfRCWHuwkZOiTyGFkAEr8/Bqa4oWDdnR0dH?= =?us-ascii?Q?YxzmNwifac0exdFC1eCsPmB/EWHXRICzRCDfZZSzbYvf+60iSFPD37EV7h7q?= =?us-ascii?Q?PyixuyiGO82h4ln3/CUsGqYnriQzedUMYM8CMoZ0CuzI4TZy8kyfxkLuMOwP?= =?us-ascii?Q?RuJUdMDxTSKsLH56zFYH1T2pp3jFMbO78vgjYnVVcSQIFwivLBu/Aejnw8ph?= =?us-ascii?Q?qB7CbVdEqXzg7mj5bTZOm6fmTfhqBRARs5KsrzCJ9+5J6tJ93LAWEDMUHC7P?= =?us-ascii?Q?mfSaHumnzkWcINAY+hZrMwu0z2tokXMc5TCvEa8TjcRpuq7XoSn76q+IQFWp?= =?us-ascii?Q?t9kLXHtGJVhr2Dq32HSLtRliyUXBt3wKu0dE399yWMAz16Vjdkv3PQg+v0pV?= =?us-ascii?Q?HdrhLDLXKg5xRx8jpIsC6ysKUaPs9V4Pc+0TBzPlZgZeX9S5GyhWoSuuA89x?= =?us-ascii?Q?J3j3sY1kH36d9zjlLAaHYqmzIBQVJuCavyRupyOqJFPwtnnCfS21Wzu6MeBw?= =?us-ascii?Q?n6eP6lRubTHPy6pf7UMMI3rCtKaISGM7xggjPIY7LgnGFoycH38JGV5Olo6T?= =?us-ascii?Q?WmS9zIRwTJ+Cx2Ke/R3ZWd+6qMKLsCekK4dq5ht6vYP7rSX3zCafWAcQagUQ?= =?us-ascii?Q?MiGNl2WMa8mDIAbNq1SGdZINF7z2UjOn5xyYiCed7ll+5Yoh/hSZaxsFxnnb?= =?us-ascii?Q?4PXHn8t4n/SlIZDupzCBS57xOTJWS7dQ04F0wYZWtaUohs41h+rJC14G3SFh?= =?us-ascii?Q?2ahRyh1u12ej7v13BPDYAFs6aiiFxKTO0onUxOit1h6v9woKYhnBrGodqk7H?= =?us-ascii?Q?2ehHJooYVHDKLfo0SowFI+HjqyK/y5jaLrpqGHYdHtOmHeNA1snLZYXQS5Q4?= =?us-ascii?Q?bZSe+BmExr7P3lP8plhRp2x8VS426VaZc12mdyp3?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0fae9fa6-ebc7-4acb-6222-08dbcdfc09a5 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Oct 2023 03:57:37.9740 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: l2yB4nEPD6TS4tqgCXTP0ZS66W4xMiqYB/lrlJtQoMTocHjt9196UblVItIDcvOKOZ0+YFDf1vICA7kCl+7mgg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR11MB5652 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Xing, Beilei > Sent: Thursday, October 12, 2023 3:42 PM > To: Wu, Jingjing > Cc: dev@dpdk.org > Subject: RE: [PATCH] net/cpfl: reset devargs during the first probe >=20 >=20 >=20 > > -----Original Message----- > > From: Wu, Jingjing > > Sent: Thursday, October 12, 2023 2:54 PM > > To: Xing, Beilei > > Cc: dev@dpdk.org > > Subject: RE: [PATCH] net/cpfl: reset devargs during the first probe > > > > > > > > > -----Original Message----- > > > From: Xing, Beilei > > > Sent: Thursday, October 12, 2023 12:47 AM > > > To: Wu, Jingjing > > > Cc: dev@dpdk.org; Xing, Beilei > > > Subject: [PATCH] net/cpfl: reset devargs during the first probe > > > > > > From: Beilei Xing > > > > > Reset devargs during the first probe. Otherwise, probe again will be > > > affected. > > > > > > Fixes: a607312291b3 ("net/cpfl: support probe again") > > > > > > Signed-off-by: Beilei Xing > > > --- > > > drivers/net/cpfl/cpfl_ethdev.c | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > diff --git a/drivers/net/cpfl/cpfl_ethdev.c > > > b/drivers/net/cpfl/cpfl_ethdev.c index 762fbddfe6..890a027a1d 100644 > > > --- a/drivers/net/cpfl/cpfl_ethdev.c > > > +++ b/drivers/net/cpfl/cpfl_ethdev.c > > > @@ -1611,11 +1611,12 @@ cpfl_parse_devargs(struct rte_pci_device > > > *pci_dev, struct cpfl_adapter_ext *adap > > > struct rte_kvargs *kvlist; > > > int ret; > > > > > > - cpfl_args->req_vport_nb =3D 0; > > > - > > > if (devargs =3D=3D NULL) > > > return 0; > > > > > > + if (first) > > > + memset(cpfl_args, 0, sizeof(struct cpfl_devargs)); > > > + > > adapter is allocated by rte_zmalloc. It should be zero already. > > If I understand correctly, memset to 0 should be happened when first > > probe is done or before probe again but not at the beginning when first= probe. >=20 > But 'struct cpfl_devargs devargs' is the member of adapter, if 'memset to= 0' > happens before probe again, adapter->devargs will only save the last deva= rgs. Reverted from dpdk-next-net-intel.