From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D7C16A034C; Mon, 30 May 2022 00:49:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6BE0540A89; Mon, 30 May 2022 00:49:42 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id BBEDE40A82 for ; Mon, 30 May 2022 00:49:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653864580; x=1685400580; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=o3X7qau42e93M7HcySXjAxjx4UepipVdV8jXenj8HQU=; b=Jqp/WUbvM5IiYXGDxVy9D/Wbuev0XyLuAoiJo9Ef8nrixDsGr5LEruHW 7/x7hH2w0y5bYXurPLULZK3Ag2H4xtMTABo/wJP14XA/l7ErMA7ryLxyQ oUEXtff4N22LPy8sF+tPAkYBci5S/uJ2C2zJeCZZ68OSZ0rXY0QNYB2zv LSUMaMkkwLirUU8pV7R4PbjCY2iuaSZNApctCTlUFBZCAyt65f+VBMDyU SYdZ7Cfw5bfEZoE7BVX9yD6Ns9WV+cB0DB0uQuxNfG+JXLrnHjJrXYjz9 swh2epguM+Agssu18yVd+VLuxWTkNm5XHeRlRtc35nYcUlOO3ajjVUEdQ g==; X-IronPort-AV: E=McAfee;i="6400,9594,10362"; a="274569097" X-IronPort-AV: E=Sophos;i="5.91,261,1647327600"; d="scan'208";a="274569097" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 May 2022 15:49:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,261,1647327600"; d="scan'208";a="575676438" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga007.jf.intel.com with ESMTP; 29 May 2022 15:49:37 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sun, 29 May 2022 15:49:37 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sun, 29 May 2022 15:49:36 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Sun, 29 May 2022 15:49:36 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.108) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Sun, 29 May 2022 15:49:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Oflj28AAimF4pfn+ZWt8ChI5ud4PitYah2skyPsSJPPc84OHi9d9a/riOb7ivM3uc80C2KOLfPvDqKKI8ho1JEBRujjxZNbVK0WnT9dtdqw3r6GBQa71hfJnwqztLnPB/BKQA9qgyV3giIct0oRjqk7yw8MWHDw/q2kCDPa/MTXF1+MQsdAx8QpiFnhbdcX2sinTudIJ7CqE+s+VwhO/xWBCfn2+SqMjJ6L6cYrOvKTmn/skhln3R6SkQPREwPz8JVjNSPaKDf5CTt0EtgqtXxMIaXKIbTEiCYbSq7cTyJskcTOLIRMN902CIk8QSNhJtckqWf/athZ3zZVy05N4jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XtAK3+9UYYInZ3HV5LGbBDT5qRVoySugr2ETs7rMabs=; b=MBU6rBw515KDVcdlxayZ/WTrIOC+xoBWFBwkL1wYslS4SL9/FSKOSLGLO76pVBhwJU/PKHzNImRZh2j/h0WtZoTItSyVxpljtwZC1DqogOd8gN7m/lAYSfjoCFE5kklaXOrovYMX5FgBxrbNGyRnF/TiFthElRMRjnNqy39B5zoC9NQW+UO2tcSHsUT96XqVUiMrbYEdRJdeU1zmSvS7BFwQcsOyX7LbbOp2FhWn91np6KdPVfoMPEoYxUPejUua/IsHcu4/eIXPz/Gf5uWDTH5TYkqRCRbw6sHVQtespKK+h1w0GLfztRoe/qWTL9OvGuolskul01zSfiGJOr0Z2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by BYAPR11MB2903.namprd11.prod.outlook.com (2603:10b6:a03:89::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Sun, 29 May 2022 22:49:29 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::b4f6:f68:2e31:ddf7]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::b4f6:f68:2e31:ddf7%8]) with mapi id 15.20.5293.013; Sun, 29 May 2022 22:49:29 +0000 From: "Zhang, Qi Z" To: "Daly, Jeff" , "dev@dpdk.org" CC: Stephen Douthit , "Yang, Qiming" , "Wu, Wenjun1" Subject: RE: [PATCH v2] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices Thread-Topic: [PATCH v2] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices Thread-Index: AQHYcUFoO8MkE5VIzU+yZcfMDBVgXK02eCQQ Date: Sun, 29 May 2022 22:49:28 +0000 Message-ID: References: <20220307223442.28012-1-jeffd@silicom-usa.com> <20220526204355.5014-1-jeffd@silicom-usa.com> In-Reply-To: <20220526204355.5014-1-jeffd@silicom-usa.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ee139682-424b-41a5-eace-08da41c57d1a x-ms-traffictypediagnostic: BYAPR11MB2903:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9MGL+W3T4FuMhlmL3PP315qJOYAbuuVISf6sEedk7edJ61xI5osHv38nH8GmUNNsXOrI9yQgHlm3TBsLNhV/5I0dOM63rh1NU1Nt9c3bdFYigNPn3poHbh9K2kmK+AE9pmLOcDMOwmNHoXJkJ4ctpoCbs0gt8kB8sXNnrAo6o6BO7qTCwgJI1ghBpW3I3kVpmaHemVMhvgKjHTS61ffTYJ+o9t4j8F6jizKc4TY90ocIJzoYkijrxZv+W0BveHUuhzu9Ji/b2gLNrvX8+O+EKqQ56B/Vfdz1lIgJ1R2CEuI/gv/v3og4o4y802oCftZK7qpq7AdXEI/byaN7CyNJJwbT//p3pvzk6MhwRaIZsjNHyCtGnOaqiYprsvr63C7d+K74Kg+/9U2pZVTPraD56AHIHKVt5voUvVWmxLCQrDfyrg4Yo0xAtDxpAPU4JOpY4avZvfczNwFoPEpUB2GwSnNdke5hlnRX+WHtl5TMfUjeJPRcjw8M6H5YttZFHIGaMo1RVUotzK4MMD/uUMXbMldVAYDpj7ZUJMoc+aORt/EvQBdP0FN3gxNVXs98UmezDnWNOCD78BNXmWau4W/4bkxGfkKpioxoBdMl2iVo6orgV7zXheYYIZSrdAozIwXVp2tYdAaVlyop+i/Xp4JuJLVLuXHnHUzFcNwNNY93+NAsE4elj5ubxaViriJY0uay+0OrYFVA6EzysispQ7OMkQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(316002)(107886003)(38100700002)(122000001)(2906002)(54906003)(53546011)(186003)(110136005)(38070700005)(6506007)(66556008)(66446008)(83380400001)(8936002)(8676002)(66476007)(55016003)(7696005)(64756008)(66946007)(508600001)(9686003)(26005)(86362001)(5660300002)(71200400001)(33656002)(82960400001)(76116006)(52536014)(4326008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?h0l8VS5gfwMQIxsPpCtDhEpxowmCtlrdD+TGxVfZkvcC000Fs1c0gKXqI/cm?= =?us-ascii?Q?5DnGaA7NAfj88YYZPu9adQ0kueHTCf6cervXCWEkXzZ7dwu9bc445sdgqV+L?= =?us-ascii?Q?f/JFs11aHhHA1F4eNCad//uLTnDLLrcZ+TfteI8VmqRtiYpAAKkzv35aKvDz?= =?us-ascii?Q?5vOMMPddkD7+Lpq9UX54ONPvlEMW+GUkzPgzd7IbLpalAyG7oJhgka1cfKxo?= =?us-ascii?Q?LHCLij8GoLEoWxc4LmW8oh4SBWXeQPnRDRUKNOdHVf+HrY9IUzrgVZyUHYx3?= =?us-ascii?Q?a85vOIL9aGDQ8BhPL1WZQhTVbFldjlJR8RLRLF1MYc8CKtvObcAaBWztbHcn?= =?us-ascii?Q?OKm1nPDVj+0qq5iawIZ/mXBsdcroKVyRH4jc0Epx6Ugg1bV1lM9/lkoBiDG8?= =?us-ascii?Q?4iBp4KittHa5KlOn/XxeQ+jY1S1VGGPOW1WQsv1Y80yL51oroypzpJMRWD/p?= =?us-ascii?Q?uraq6rCXfElxo2JL6nGKdE4ImbRu2ZeUSi8+DD7UmKGFSSnSVbHj3Vmn7phe?= =?us-ascii?Q?7U0eFihsykjmLu7J7lFo3RXuvIIhFc0YcWQj9+WuGO5QP7jF9PcYJ2oJd/9X?= =?us-ascii?Q?heCNzpzb/PM1000WlO/OVCeDvb/p+XLBVDrKRpfW5CEOVtJ9SiTTGcAVsGgn?= =?us-ascii?Q?IL8cC+ha0nkODHpt0QjLXq+wHbaV1BrJigcBeFxqw1k7PEuUE1h0HSXPG31F?= =?us-ascii?Q?dOAqyebDuqJPaplOlSiW1nVoKiniAEirbk3SCHr+V/yiqZ7q4ANb5Ay4yHxm?= =?us-ascii?Q?7qSpzkhuiiLzxyYcCgCBVqiyhB8ORzvzPraY/CJSoRK5DgdKRRBeqTFTIHUZ?= =?us-ascii?Q?6sn4LM0YWe0Y8HTmX8Ysjgq1q6H3BM0gkvEErnGuC59VEL/8NyBdYGX/WCH/?= =?us-ascii?Q?segqr1Vmm4Al7NlaR+Q5ImGQFrT+20v6bEDVdAvqdjox5t4dQ7EwvvtQG2JL?= =?us-ascii?Q?U5jzElHX1UDhP2Cu3JT6ryT4/cYRQVatfkh+I1eWxbO8LcTUx+gRLDDwKWa+?= =?us-ascii?Q?IFKpEaPRsZD1RwtJ3wVZXdbXR6fHBc+GDCyogYJTobRf+OUPpE3wW7ll6Avg?= =?us-ascii?Q?6o9402W3z+V7AJjBZYxb35nL3l3XzeuL190TEFiyOIk3tKTsYjRbwvxMWc4r?= =?us-ascii?Q?bloz157CjFCVaKpDccYuKy7jLm33mUkKOAY7HNqWVmqTMEx9vvp8zLgll1KU?= =?us-ascii?Q?+NZtBxl/GIRNYlrdBXpO3yOqxPrhEoa15scmDpsVkYTojOjIyiFqalEYr0hO?= =?us-ascii?Q?bIY34a07cJUrQw1aUGIb5E+aqYQnAzQFKMKB2RHCBbJTdXTBibCSZWYX0Iy2?= =?us-ascii?Q?SQXHNVckpDJGocWnoZPMF6qM1785G0VdP6cOypilvJNvi3usaU019R4/0Gzn?= =?us-ascii?Q?1orpxcv5Otz2e8Gg0sz4EkMNtHjatIPaUzgDSoaakhS+0pShMmW+z5z4ThPw?= =?us-ascii?Q?LKQnF4JUmIYRWkyMlJPX7wbniQ7qr6w9txEe0RW8bcMjjZ3gt42Vwnn3Q0Hg?= =?us-ascii?Q?IsmCxzyAhufU20NATslo5g6j3TBHSl8Bju79OsJmXfaKeFi95v3yimRhmduV?= =?us-ascii?Q?7J8g/oOktyAOlQqVCmTmhCI8smLfGOt8jRRjwykJ/0BYQXgXEWDsBe+5cdAf?= =?us-ascii?Q?DXwUBxNT41dqY0Sg39lDVE1z5kGMrZrzvlAt+ClLietG+pGEkrYFfOSO5L+1?= =?us-ascii?Q?VL91hD1zqLDrUp12uNXbcf12M5WshovTCvHFe6+0zfwTGTQnLKGx6nwBvn+U?= =?us-ascii?Q?4dXQRk0Z9w=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ee139682-424b-41a5-eace-08da41c57d1a X-MS-Exchange-CrossTenant-originalarrivaltime: 29 May 2022 22:49:28.8999 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DDQp4QDVcSGwsN1K03SOvnt6ECrQHwLyPHpTVMxyys8k2f9DrffthN/IT4Lc0n2GZdc+MJ3ygYS9AnX9CiAuwg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2903 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Jeff Daly > Sent: Friday, May 27, 2022 4:44 AM > To: dev@dpdk.org > Cc: Stephen Douthit ; Yang, Qiming > ; Wu, Wenjun1 > Subject: [PATCH v2] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devi= ces >=20 > 1G Cu SFPs are not officially supported on the X552/X553 family of device= s > but create an option cu_sfp_as_sx to treat them as 1G SX modules since th= ey > usually work. Print a warning though since support isn't validated, simi= lar to > what already happens for other unofficially supported SFPs enabled via th= e > allow_unsupported_sfps parameter inherited from the mainline Linux driver= . >=20 > Signed-off-by: Jeff Daly > Suggested-by: Stephen Douthit > --- > v2: > * Introduced cu_sfp_as_sx option, default off. > --- > doc/guides/nics/ixgbe.rst | 16 ++++++++++++++ > drivers/net/ixgbe/base/ixgbe_type.h | 1 + > drivers/net/ixgbe/base/ixgbe_x550.c | 12 ++++++++++- > drivers/net/ixgbe/ixgbe_ethdev.c | 33 +++++++++++++++++++++++++++++ > drivers/net/ixgbe/ixgbe_ethdev.h | 3 +++ > 5 files changed, 64 insertions(+), 1 deletion(-) >=20 > diff --git a/doc/guides/nics/ixgbe.rst b/doc/guides/nics/ixgbe.rst index > 82fa453fa28e..5db63083eef8 100644 > --- a/doc/guides/nics/ixgbe.rst > +++ b/doc/guides/nics/ixgbe.rst > @@ -101,6 +101,22 @@ To guarantee the constraint, capabilities in > dev_conf.rxmode.offloads will be ch >=20 > fdir_conf->mode will also be checked. >=20 > +Runtime Options > +^^^^^^^^^^^^^^^^^^ > + > +The following ``devargs`` options can be enabled at runtime. They must > +be passed as part of EAL arguments. For example, > + > +.. code-block:: console > + > + dpdk-testpmd -a af:10.0,cu_sfp_as_sx=3D1 -- -i > + > +- ``cu_sfp_as_sx`` (default **0**) Can we make this devargs more generic e.g.: "allow_unsupported_phy" So we don't need to add a devarg for similar requirement case by case in fu= ture, of cause we still need to well explain all the unsupported cases in t= he document.=20