From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44B03A0032; Mon, 30 May 2022 15:50:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F2D7040694; Mon, 30 May 2022 15:50:40 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 5F090400D6 for ; Mon, 30 May 2022 15:50:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653918639; x=1685454639; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=4C1Ah3q8Z6ge15mJZuo/AMh84RCoGz21RQ790P93AA0=; b=dCjC8L4RLJwZZU8BJ7VrxuJgRlr4oFOd3V3I2BWed7UchTSC6x3TnLVz WhrLkFgS89E4vnSA7RdJB6Vwb/66Z9T93zJC7cBNOpr6hkxMm7UkLZM6P zauEFGuCNg9t+C/pZOQ5vyGe7rIhdjnoPEcNKYrWhVARv4fX3Fo7fFcZL CmQvFPvfMAYD/wNtZ0ICyHiMHj0OZWWapNnJfNHH6LGwLtpc3dH10kTc1 evqjMulLtLBwkG6x1LjWlL4Iu9C1ypmTgfdnnV9Se4omWrjQg8bN+PiL/ ByNzlULkBCyxwLqgOAAidnYU0YEMmLTIxO294fVaa95gRkDhoJ5L5rI3s A==; X-IronPort-AV: E=McAfee;i="6400,9594,10362"; a="273817787" X-IronPort-AV: E=Sophos;i="5.91,263,1647327600"; d="scan'208";a="273817787" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 May 2022 06:50:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,263,1647327600"; d="scan'208";a="751297751" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga005.jf.intel.com with ESMTP; 30 May 2022 06:50:37 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 30 May 2022 06:50:37 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 30 May 2022 06:50:36 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 30 May 2022 06:50:36 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.174) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 30 May 2022 06:50:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Dy32A139XFiFKapeS3Rk5MKeUi7CQizETenDmii7O7rzHd59f1/FmQAMiqeGW1Dn5pE1/WrHhaNzCo5RBUy3+979oZ4atUfNE/WRxph2NI5voMIqdzt/SHgiEd0nsF1T9tC+SKeJHK+wBGfaM8jRy8q9BxXyNockcaUSGuh66JC1f8S2Oba6irn0zH5wk2l+x0J1auS5yJrFdnjUxoibdv5wDQhj2ej7UG8H0ocX2WID208YgGflhNEq4T6Y1vKoDWtWhDqZ0Xn+mxhZ0w7iMvAfC2ohb3CJE4KmQ7dd04/9OAD74hN45mfNArC9zqtaGe8NvOvHvVuEeoa8M/iQig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wUMZYo4sien7t3hnR5gYp17bgvMF6ikkWUstQdUAglE=; b=LP1vtfUcP7dM4JGFfIcUgdg82TAl7uMzFtuPpVYAUG9orNBKZw5x6vBGisI/M2HqIXEtJhRv4+9KQlK3zOxa9YI3TxgFUwlroSMCWoHYrRr3T3KX/IZ8aEVmLWO9x4DnIAEjITmRWLwwMMey5bbX7QdUm6Sa2ARsompzTa+btR3Y7zzBxtGyaMmggXg6PE2aeGHkIAXMvLHl//xXav6T+iN6MYp8KkenSEoSGFUsFhtb3/FOXHy35c4hHaYvj7ahppmHYCr9NuPQ7MBn/bCp12VkDE65YdIknt8bDnTYuoyupTWx1NNmh4V9wbyvE5L4ik5CF5+1iKVjzZarFfyv3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by BN8PR11MB3668.namprd11.prod.outlook.com (2603:10b6:408:81::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Mon, 30 May 2022 13:50:33 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::b4f6:f68:2e31:ddf7]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::b4f6:f68:2e31:ddf7%6]) with mapi id 15.20.5293.019; Mon, 30 May 2022 13:50:33 +0000 From: "Zhang, Qi Z" To: "Daly, Jeff" , "dev@dpdk.org" CC: Stephen Douthit , "Yang, Qiming" , "Wu, Wenjun1" Subject: RE: [PATCH v2] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices Thread-Topic: [PATCH v2] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices Thread-Index: AQHYcUFoO8MkE5VIzU+yZcfMDBVgXK02eCQQgAD40ACAAADScA== Date: Mon, 30 May 2022 13:50:33 +0000 Message-ID: References: <20220307223442.28012-1-jeffd@silicom-usa.com> <20220526204355.5014-1-jeffd@silicom-usa.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a6338681-e6c5-4248-08f0-08da42435e26 x-ms-traffictypediagnostic: BN8PR11MB3668:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: O2YzIZIQ1H5pbbMbE//8UfwSn+t9pYK1KfSf4k6HeVuvyOa5RdX+bmpMr7cBmIcrZwrITk3Eoc6+njeyQCoVH1xuDZ/Y2Fg6ukfssIoV4LDvwjmFMwAYOZr8aNihCEJ5Ydqqp0OQueGRPPT3rzTauzAIeGEA6uOqYvFlkhHEIxECtX62t/B8NIGGKq1Yf21Ks52vM87d2NjpMBGxd91ADyPuIMpOTi4MvrhyeWn+kY5VluGcyj7C6Zu6dwjo5DkKvRAJ7BvbgDiwC2SGBabe2DGjJsnPdjPmfQ+SQeJyAFdm+K/iP7VYoFQ47XHekK8sd20JO12gmjldR8H6pj3T6cd5V2xqJb37wy5S++oGcSc8bUwIPc5Ki8ItXyIIda/E7HbPIowygS1TwlSeyoAVyo0fBs/yUETsxrdChu0XM7Hbfsa/6I0rg1d0i3x8T2CHxW8nd1m4wKftv26HNysaNyNXkoXoXfBTX/FrSkip+LKsclcaYZMUFt1psY8R9o/XgTYMmkVrftXNXSx1Ioqr7U1Cs+yRqOZ731P9x/SqCvW1Dy96skQQVzre6f4lyX+nC38e9cPTtaqNzdXar4BSCYO1RxyThCn6u2D2M7HroxJWLkOMDLWSPOIPvyFjruS91TYVJ8BhJL7zcQ++dXgHd3eqJNc5hn3wSqzHo9+zT6l+NOJxKQ1177Lj0EywzhRO+ETd3snoEHcBA1dHYuoGJQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(508600001)(110136005)(54906003)(52536014)(83380400001)(6506007)(7696005)(8936002)(33656002)(5660300002)(38100700002)(86362001)(26005)(66476007)(66946007)(66556008)(186003)(55016003)(53546011)(64756008)(107886003)(8676002)(66446008)(76116006)(9686003)(38070700005)(4326008)(71200400001)(2906002)(82960400001)(316002)(122000001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MX3cdbxFsTk+wzw0FMEkyfE8rs30igMosDaNg9ELr6KOby7yRBV4O0mMNlxf?= =?us-ascii?Q?o8YUFJeccPw1xB/M7sSbEphHUg2PnTrVJJkclCf2vZytI0bp7Ag9OH2798Qb?= =?us-ascii?Q?QSpvNJPtlf1d08hd94DFyB/zjSlri6EQdCdh1Rx6r9XXAVRuRdyxUo315IoZ?= =?us-ascii?Q?qUJnHzSY4lvB43oKVtIGkA8KXdJCf+KCA/1+XY1WIxh5Ve065cfzbFDjwVDs?= =?us-ascii?Q?mtLG8fy19kqukof7QxqWRHP++uQKPHTjK6+iPrY9rZ0tUX4jDDANsvZ57Fwu?= =?us-ascii?Q?W9q6MbYuSaukhTff2z8pmPWWpqgvf5P9QoW+tP9dmr+RWzi5phNHG45IjBT5?= =?us-ascii?Q?BNXnu05gBbNFtnR96ddYdFVA2qjmbVy5+FR1GUy0D7fb92SEBt6uAUO+xw9f?= =?us-ascii?Q?S6IoadqhxS3k/H8mHJ/q0vZtT+gvhcebqqpkKzeqQ9pvMdJMl7c7l1kpylJr?= =?us-ascii?Q?Jy9480LGLYhndIom8s9p3c/jc1sVW2DrKuNshp/cDmRZlTaP+rTernwhz+8Q?= =?us-ascii?Q?39xSK3IPHJbYL1ox2J0zil+jxT2fxSuc6ue/7OMgT1flefDUF+7daVR9o+W8?= =?us-ascii?Q?Uk0N9qzwv58sGKnk+Jr1DfOd+udF0I5oIgRz5Ytn/eYJdv9SNacyTesaUV6F?= =?us-ascii?Q?Ei9J/vo49jSVvbYhDvMrDsjejvht9YO3oHLc4Cmdpl7VsncbirsIqaoCWROk?= =?us-ascii?Q?soDSJtXhu1iPQMiDmPyBF5RLv+KTHU3c42okpbbq4lCEZ1JYAhh5V/qV9fUF?= =?us-ascii?Q?8tTJFXB6i4OTPjRZA+mTSQyExboN7krpN44yc3tr/2phrP797q2Ii8O8lPXL?= =?us-ascii?Q?AhqASU58BVIVXYUFIlTm82jwoV3WRwiFSrZG0kJxkyi3+kHlVJe7YVrA6wdD?= =?us-ascii?Q?PSIwT8Y7/0MElpb2yVUsOBsHn3EvIDrKhj3cu87xzpErUpJFq/fl6tbwq1S5?= =?us-ascii?Q?pc1zGmDHpdIwmEHigcfnqacdHTMMROh2sqOb1OYgnXyTz+rIa/pjQoxR+5cZ?= =?us-ascii?Q?w+nxyx3x3/nOIfRkzE2JeCkI0g+/rFqC/a/7ZI6SGslDq8BMPCoi0U4F+icb?= =?us-ascii?Q?33JqPBMIkZlfWigyTTK6gAWs6ucT6eHyHtYAGCg1gFjGlM8aJKk2Bk05BWVR?= =?us-ascii?Q?ij7f+ppy2ty9/bzeGm+3o18PBVRs4vcjQ7f6iAsKykERJiDoRrND2HQQ/UDI?= =?us-ascii?Q?xbgVgmq5uzdaS9NwEmF6jkVIQagNetdDf9pd0dCJ5TjeqpbyYoLht/liwIGX?= =?us-ascii?Q?8V5JiflXbBQkrXB9dC8VxEzWX2wUnTaeYlKiXM+z966lyZXBp06U10W80Q5q?= =?us-ascii?Q?qzczf1Xmla2vTVp1RNMKQoSBsuH1N5vFJrc1606kohlKAnUkdpfNBUdv9xsK?= =?us-ascii?Q?zti8yVCp0q44LXsKsNaCaVzE43H56vmwqmSpzx7ct6M3fZratCem1EG9C1Ha?= =?us-ascii?Q?PZNODbfr63Ya+a1K+/I76Suyg/dmMnJsoU13Rlh+IZzOdZuCKQu+/E9tVaV8?= =?us-ascii?Q?niQsdx2hb2O8zZrkSCmHnXEERd46ALf+Q+sA4YJulUHXj6xC4HabCMmO5RdK?= =?us-ascii?Q?5FxDxOWqSSadNzb/QvZXY/+dJr+S8jnoNzarTt1kzMv5ozPGjy0R6xoXuURZ?= =?us-ascii?Q?ITrU50BZ7hyZE9IcshveYgl0AzrbP+UTEUfQkVOrP2/KTt2AGbVMhXFL/Ajd?= =?us-ascii?Q?s/QCq0oFaVQzf+TuUFH0MqM7MQth/r8mEAToyMj2TLDLL8JRPtpUweTMU1lZ?= =?us-ascii?Q?ykdnfFgx/Q=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a6338681-e6c5-4248-08f0-08da42435e26 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2022 13:50:33.5514 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lYSARtMMC6qefRUU6h2dxdDFJAwRusNVanLBJd11dnJTAN733x9hiLBgpCHabQa3LIIzkxDpYkZ8dzDB3UdyOg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3668 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Jeff Daly > Sent: Monday, May 30, 2022 9:33 PM > To: Zhang, Qi Z ; dev@dpdk.org > Cc: Stephen Douthit ; Yang, Qiming > ; Wu, Wenjun1 > Subject: RE: [PATCH v2] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 > devices >=20 >=20 >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Sunday, May 29, 2022 6:49 PM > > To: Jeff Daly ; dev@dpdk.org > > Cc: Stephen Douthit ; Yang, Qiming > > ; Wu, Wenjun1 > > Subject: RE: [PATCH v2] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the > > X550 devices > > > > Caution: This is an external email. Please take care when clicking > > links or opening attachments. > > > > > > > -----Original Message----- > > > From: Jeff Daly > > > Sent: Friday, May 27, 2022 4:44 AM > > > To: dev@dpdk.org > > > Cc: Stephen Douthit ; Yang, Qiming > > > ; Wu, Wenjun1 > > > Subject: [PATCH v2] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 > > > devices > > > > > > 1G Cu SFPs are not officially supported on the X552/X553 family of > > > devices but create an option cu_sfp_as_sx to treat them as 1G SX > > > modules since they usually work. Print a warning though since > > > support isn't validated, similar to what already happens for other > > > unofficially supported SFPs enabled via the allow_unsupported_sfps > > parameter inherited from the mainline Linux driver. > > > > > > Signed-off-by: Jeff Daly > > > Suggested-by: Stephen Douthit > > > --- > > > v2: > > > * Introduced cu_sfp_as_sx option, default off. > > > --- > > > doc/guides/nics/ixgbe.rst | 16 ++++++++++++++ > > > drivers/net/ixgbe/base/ixgbe_type.h | 1 + > > > drivers/net/ixgbe/base/ixgbe_x550.c | 12 ++++++++++- > > > drivers/net/ixgbe/ixgbe_ethdev.c | 33 > > +++++++++++++++++++++++++++++ > > > drivers/net/ixgbe/ixgbe_ethdev.h | 3 +++ > > > 5 files changed, 64 insertions(+), 1 deletion(-) > > > > > > diff --git a/doc/guides/nics/ixgbe.rst b/doc/guides/nics/ixgbe.rst > > > index > > > 82fa453fa28e..5db63083eef8 100644 > > > --- a/doc/guides/nics/ixgbe.rst > > > +++ b/doc/guides/nics/ixgbe.rst > > > @@ -101,6 +101,22 @@ To guarantee the constraint, capabilities in > > > dev_conf.rxmode.offloads will be ch > > > > > > fdir_conf->mode will also be checked. > > > > > > +Runtime Options > > > +^^^^^^^^^^^^^^^^^^ > > > + > > > +The following ``devargs`` options can be enabled at runtime. They > > > +must be passed as part of EAL arguments. For example, > > > + > > > +.. code-block:: console > > > + > > > + dpdk-testpmd -a af:10.0,cu_sfp_as_sx=3D1 -- -i > > > + > > > +- ``cu_sfp_as_sx`` (default **0**) > > > > Can we make this devargs more generic e.g.: "allow_unsupported_phy" > > So we don't need to add a devarg for similar requirement case by case > > in future, of cause we still need to well explain all the unsupported > > cases in the document. > > > > >=20 > this patch is specifically to change the driver's recognition of Cu trans= ceivers > and treat them as optical transceivers. so should we consider this an > unsupported phy and use that same switch 'allow_unsupported_phy' or are > you looking for a more generic name than 'cu_sfp_as_sx'? if you are look= ing > for a more generic name vs just reusing allow_unsupported_phy, then pleas= e > pick something and I'll submit a new patch, but I don't want to guess wha= t > would be ok by submitting patches. >=20 I'm not sure if there will be a situation we need to enable a unsupported p= hys in a different way, But as kernel driver take allow_unsupported_spf as module_param, so I will = prefer we keep the same in DPDK.