From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A9AE4A04FD; Thu, 10 Nov 2022 10:57:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 634E240150; Thu, 10 Nov 2022 10:57:20 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 9E5AE400EF for ; Thu, 10 Nov 2022 10:57:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668074238; x=1699610238; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=qbCax6Wr4ByUwfyKpqD9HKbkp0F+djYYpvIr9sHGVF0=; b=Q25JMbSJgUK8Ed2anXcsC0rf1Lfr9UNaU7EqbHPf92rBEvzUJCu+n1H6 m39UQT3gOmzRgXD7FOvmOPTxdjLECiw1gaQq4icphy37jMbahOKl/HeaI b8H3psrM49iAy8Y2kNOzTc1RVMnt5x+9Vi/RpDaAINn9lp9oBjBhe/YIj MLl4QcZsO+5rokZjZLxxvuo4Sf0QHN1GjH8WG6zFA1yS/Uq9A7r1sF7Tg 2Tsqz9FQuw6TUXT6ByNcFuzCvgUeDoT60Q6jAeLzAUn8w/qPoIczGnqLL ajfA9p80SVpvBAXW9TCeRR8kr4tI46Sz1zpMDWBNmk4WPQngHEXDXfwE2 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10526"; a="290989145" X-IronPort-AV: E=Sophos;i="5.96,153,1665471600"; d="scan'208";a="290989145" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2022 01:57:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10526"; a="726330809" X-IronPort-AV: E=Sophos;i="5.96,153,1665471600"; d="scan'208";a="726330809" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by FMSMGA003.fm.intel.com with ESMTP; 10 Nov 2022 01:57:17 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 10 Nov 2022 01:57:17 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 10 Nov 2022 01:57:16 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 10 Nov 2022 01:57:16 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.177) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 10 Nov 2022 01:57:16 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cIvWiHBDA3huPfHr7qZqWynLx9Z5Scgnf7Tfaf5mtsrh/5h2v1VehU1bzAN0LZONp69EQCwJMr07Gq1jS9C77fAUk4OioTx/055B3YcbOQHX5Hco2ZhyVel7Cfdg2N/ETS+6J6KJ08s0EnUsDhsZ5/DRy2F4RceY+yFieFfqAgSyBC2jXjeQqzfk6tsFIOs5YRlm0RR6m82jDaLYoth3GtGUf294omVv/rbjKH220fvjrZwHmMPiJxd8qNUXQ4M0ewTi3qZYxMFySJQ26eVuxAbMckmgr6ym4oej+yqsoa11Cxyd43+j/1sFSpbZAHqKSsAXENzPMYIPRzIUjvEHfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1gqGN8ZKUN7wHi+fwx3EaD80AWMPadXNY0SEeNqVj3I=; b=cjkSLSgVL7LsWjMBhEG7DmmvzP72448tPJ90kFXFjAwvqKXS/5c4cGpVcg56dh0Jz7LEkzVO5hfW8ujfGZhks/wFMV6H7YJN29QVjmyh9NGFR2OjFV+Mx8D0z57ERQ5MwPAzPBPX666lb8PrDmoMKJ9/nM0IzVTaECnsO7cPyA6/tSX/rVpLi/emCSJ9qONtkhrQkuqp9ngPHqGGP28n7ae6GvobrDjyEuj+In5Ibu32NoKHm/MmTZiChUx0am+rbpZ8nVO5RjqkEUN+53Aqjnv/bZg99SMYMFFP1bJ0Y1BWt+PyoTQ9kXxlLc9ZJTi4c+tEB0JXFVK2POM1LTbf2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by MW4PR11MB7031.namprd11.prod.outlook.com (2603:10b6:303:22c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26; Thu, 10 Nov 2022 09:57:14 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e2ac:cde3:4d74:3fa7]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e2ac:cde3:4d74:3fa7%3]) with mapi id 15.20.5791.025; Thu, 10 Nov 2022 09:57:14 +0000 From: "Zhang, Qi Z" To: "Zhou, YidingX" , "dev@dpdk.org" CC: "ktraynor@redhat.com" , "Yang, Qiming" Subject: RE: [PATCH v3] net/iavf: revert fix VLAN insertion Thread-Topic: [PATCH v3] net/iavf: revert fix VLAN insertion Thread-Index: AQHY8BOv/ekGxRx3fku15b76gQrira41yL/AgAGqNgCAAICPMA== Date: Thu, 10 Nov 2022 09:57:14 +0000 Message-ID: References: <20221018102602.217673-1-yidingx.zhou@intel.com> <20221104061000.1868113-1-yidingx.zhou@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|MW4PR11MB7031:EE_ x-ms-office365-filtering-correlation-id: 4bce3a95-ba4f-436c-2868-08dac301f1c0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bB94b/QgK3n2POsVpjnqlUWzM98SdrOlgRjnLeFsU/0qxP5v6H5gRcSxSVraGnlsN4+e+dz5jIUJdD1BAdFWutt7tYyJY3nRtwJ98c1OUkijjIEse823Uigd+wS5j48GMu1rgR8rmcs051gddyJPkeWPAigJRSUyDBLf83+6lQmu0tw0VM5rjBq7YVZ9QBKF52jq6hg/Rv8dK+ZCBQNUZfVaizreAKRO1AQrw+CAVoOcfp6AJUb6WaMDlC/21paRjU7EySxrkDiJwNVypK1cQWv314BCvWqEr9t9fdQc8WaESTdyCME21wdneRohib+bmiJmahHq6fN0HmbGi2v6MjI21nHOQx+qmJk65ue368CJtGK9asYodSLe0acK+QZ6VufYhxrWOBfC4KNKso1/8wiE97c294qxEqHUHoZS5d5Ca1/LwppAnwZx21giuea/1JUCIL58CPfEnCgvoJ+/xoc6s+Sr5bBb3QeNlSk5nTJSW3OsI6oXXiM8EMj2EO7yze5SY35hTSDZuOQlwFR1rK/GVNlM7ar6/beu2RQQc7U1bm7ce9ltRJ91546oQ/Hh4XAV2TCPTmUJAxNTIH+yOpzMABcl5xIfW25Hp3eWz1OMCkDmhHEKEb9yL0rk2WakboSBjRl8bGgZrjh2PhFCDL2G+evBA++g1zaRoezGBYtY+WDfZ7oCXnF1B0LCpmGz42zC94WMoLAXV8w62z0A/miZCK0LpxD4pThqMu6e1Gnd7QJtiDd/8U+R3ISpmS+fiO7s/y6Y/qRhKIGqSyUllg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(39860400002)(376002)(136003)(346002)(396003)(366004)(451199015)(83380400001)(55016003)(38070700005)(2906002)(86362001)(52536014)(82960400001)(7696005)(186003)(8676002)(41300700001)(38100700002)(76116006)(8936002)(107886003)(478600001)(122000001)(9686003)(4326008)(64756008)(26005)(66556008)(316002)(66446008)(66946007)(110136005)(53546011)(66476007)(5660300002)(71200400001)(54906003)(6506007)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KTGkSIV2RrJtooB+CDpNYozX3a1CR7kM6Y4eRZLwLOEkLcGr9jWMOTyJi+gf?= =?us-ascii?Q?1SVE7o7Sj31UNtDJ3wFL8ZFi8obhH9fpu4718shsN/oY6cJEc3fdYY+FyMUa?= =?us-ascii?Q?VJ+ic4+8rXC1tSO1vSuL2Jy12AKm2Srcj/hCfDItXIrFNZJYnTTfUdkCIJhR?= =?us-ascii?Q?fUtc/rj/AZh7w3MheYljcZNJkZR+25t3Qvviu/G70n+p0turzONk8BcZ08r8?= =?us-ascii?Q?f/99CcFk9n9iYdViFEJuPe29AN3HOsRmO7sbtfooAGKKlIGYuha0ppFETrGy?= =?us-ascii?Q?p/5DUNK2678gFytonI2Z301vfzbUxmBvNIQcj/fRHUI7CeLY51QmbrjQzWqD?= =?us-ascii?Q?WpdKN2bNZko0yM4Wie9sILLosfqg9lRPEk76+zxqiUdxFBIdYPRkv3fhdxni?= =?us-ascii?Q?LQwCEpkvJAVIh58jfhMkdccUMekSvSbpF2JrKi1r/9Wyh5kocMIk7mH1dg2r?= =?us-ascii?Q?PVNsO9QwiSMLmAUMu6cZB1pHDKtYQo4P3cpRyJI+9rVF9XI57hRs1QWSapsK?= =?us-ascii?Q?u4UMX3cN+YgOkE0s7nmZ4n8hIq6eLi7MIPaQZLgg4O1l0uUu8McUVFfErYxX?= =?us-ascii?Q?nPuolQlBXlMv4gLhc+1QIMugLsevWMWdP5sReJes/59qelN+7EURGbXrGccd?= =?us-ascii?Q?s5S7tZX5l4EXc19rqTHL4Zjq+soaRNZM05FPLVLMYwlPy3o53NYVmCHpdLIr?= =?us-ascii?Q?K/n1nPtziXGSy7SIGd0KnS7Fg79jj17aGFAFbysRX0lLO3Qu6ukYE3NWwHNX?= =?us-ascii?Q?mgRM1GF0tbplSQ4iPft37TQqrPC0KydrrJbxW7L2UqMe0I+CepptnvczCSsy?= =?us-ascii?Q?XW9qcxPBMRm1ePxGaz/hmfmWeYZIjBOog9O5TC9JXNYksUpTGhRU4tovA60D?= =?us-ascii?Q?RSDqVWD/KKws0+cUI5B5JQp+GtHqKdoLAJM1nHHycK6KVw14kRdQwIjKGMox?= =?us-ascii?Q?JSTAfVtM7SUFAAz/u5OQ9sAz0emWSkyBZ1djZPpexOFjvv5HazRneXHJxrK0?= =?us-ascii?Q?2YBZ4GHHKeSlSlC7jrdtIcYefLxZRB7ojqaw3dgb0TLHz4m3YkZiFBgVBXO0?= =?us-ascii?Q?3IUW5uXo94w+RxJ10dQfTBjdGfHO4La7RJcfrZQ1PyuwIuW4rkjVQ+FQWojj?= =?us-ascii?Q?9NOlKGCpMTUDl7hWOlQgM2uILJXHfU1ZzdOvYdhYsG1o0m5MnyKyKwT2oRnH?= =?us-ascii?Q?KkXl8ciyBW7vfiERsBFP2lQVcPUsE+UBG17C3SBO0SlE7soZyz0GOvWzSZJe?= =?us-ascii?Q?NonjLqbWFqltFUeCF49y2cTDCVJQEONT2235Nrcqcwn578NMLVkjcZOPKGI4?= =?us-ascii?Q?R3yADDTbYzwdsUyXAcJfXie4T5rAFEO34Ib7otPYFw4ce/8n3GhpadW+2tqd?= =?us-ascii?Q?Oi2a74ZzT4STNF7gA1RxxMbSNJxYjKuZZZfWJTWmfUToVrtYdo5pwV+FZSNw?= =?us-ascii?Q?Dh4gitNwy5SAB84eeN3RS5fzUthlpYe7sQs5+lZI24mY5cmpOKYJ9wm5yzSU?= =?us-ascii?Q?5zdUikKuHW5Sf1sGi27qNn+GUbmDUekiGbXDVUCQXf+PLTg7wFBetmeYc3Qw?= =?us-ascii?Q?Jxzl16xijPM4m3gWz1ZeJ9t7wChbOAEj5hIpjWnp?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4bce3a95-ba4f-436c-2868-08dac301f1c0 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2022 09:57:14.4319 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fJBOBHJ8faT7DYdL7eoAAX5pPWSmVb2NVQMXhGVh1dL2FmWGa1ZMAICa1ih9Z1U3M2/khvTy2wf0GkI/qN5Edg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB7031 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Zhou, YidingX > Sent: Thursday, November 10, 2022 10:10 AM > To: Zhang, Qi Z ; dev@dpdk.org > Cc: ktraynor@redhat.com; Yang, Qiming > Subject: RE: [PATCH v3] net/iavf: revert fix VLAN insertion >=20 > > > Subject: [PATCH v3] net/iavf: revert fix VLAN insertion > > > > > > The vector Tx path does not support VLAN insertion via the L2TAG2 > > > field, but the scalar path supports. The previous commit was to > > > force to select scalar path as soon as kernel driver requests to use = L2TAG2. > > > > In which situation, that kernel driver will request to use L2TAG2? >=20 > According to my tests, this happens when the kernel driver version is new= er > than 1.8.9 >=20 > > > > > > That logic is incorrect. Because other case like VLAN offloading not > > > required but scalar path selected would have a significant performanc= e > drop . > > > Therefore the following commit needs to revert. > > > > What will happen, if kernel driver request to use L2TAG2, but still > > vector path is selected? > > > The VLAN tag will be inserted to wrong location (inner of QinQ), and thi= s > behavior is inconsistent with PF (outer). Ok, I assume we will have above limitation after applying this patch, right= ? If that's true we'd better claim this in the commit log as well as document= it as a knowing issue.