From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 49458A00C2; Tue, 27 Sep 2022 04:07:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E089940F19; Tue, 27 Sep 2022 04:07:29 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 3033640A8A for ; Tue, 27 Sep 2022 04:07:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664244447; x=1695780447; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=sL16nYwsvWncmSZq5Ep5gktIYYfP1suE7dIpnA0nl4g=; b=dsTJMEjt8kFAxUpgBcVIJGVufTxbOYUDpRB7V4k61CAkJix52slGszHT 3TQNY6jjtV2xHgMMN0olMoKcWz2bHmKk4XyInnCItv98sig/WecIDYEmp Swl2/lYLV5YimbRefAXOZysbEK7ypllWhoPIcMF9mYUeTSlNF20zWse6p dS96eRxt/tc/5G2Qx+XnyTPMiw/3zSx/bDnuWEcbFvXeYVqz90ltsjNxU hAMAJlKY40DK/TYzpW55gaCTOnaz94jRXeqVCKmZMP1u6rIfuXSSecIWv kcA4jrkaUT3AbfxsvDOXxU0dg5c6IDK3Qe461HEH8Qg9x2iSmHgcj5GOR Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10482"; a="280914511" X-IronPort-AV: E=Sophos;i="5.93,347,1654585200"; d="scan'208";a="280914511" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2022 19:07:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10482"; a="763691696" X-IronPort-AV: E=Sophos;i="5.93,347,1654585200"; d="scan'208";a="763691696" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP; 26 Sep 2022 19:07:18 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 26 Sep 2022 19:07:17 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 26 Sep 2022 19:07:17 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.46) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 26 Sep 2022 19:07:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HMYHqjOp08fUX5FB6US8OXHHwUemf57BYf2Ou0cDYgSuYcCDc61UJ73oZRhHBhAVA76E43TLdFdmwTer2u5n7Sp4MHi44WiMX61zpyWVMEdWuT63ipoZ64vDdSgYtyisECbWfLk+6YJIhYQRlP0DOp+aQdz8fVogKuR54/WvEskQhb8J5Ep21fUJRmYY1CJqaJO3hQ8y9cOZsj4h5FUaanBGVFgnY+vpa334/dz1s19ycCuFih/f/XCO1r73Bn/2+xStghnuEL20hCEZmV7SaTkFxQdkc2w8OEsIa9t+yK7K9bEIen5J3Fx4aW+TkynNGH2D4W82o6BLddGU3y9NTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TRBXe/rmvj+X2q2tIFDz2rx97ZJuEhY3f/rta4EXoUY=; b=kvs7W8HGja2vbdjnufAUSeTeek3Cqdbe7oa3NoWcDtTWxyM3En9HFPIDIjlTLBWe0IYzB2ToK2GimcXToMKUhOmiFfGN6H33iHzjx5rwrisq3EYwn4YK2WVgcwQK6IlZauEs03K61yAxVaMcD1CH8bVTZPoAeQJgDMNme8mmIXUCkmzJ3tG7xZWyCtH3Hx7+EIyOQMSh3cATJtKZ4FGyfZmpr7X1zIaMDA1Ct7bvOT+MV0jjLDfA31lMP7zqJnogpZndZQ07hD87bSpv7IHyFhKk0ky58+/jY3660x43vhSuF9vHYtg/VW62utSfz1wku8pQo8I+6OIk7hAvcatIxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by SJ0PR11MB5072.namprd11.prod.outlook.com (2603:10b6:a03:2db::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Tue, 27 Sep 2022 02:07:10 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::16d:109c:ee90:fc9d]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::16d:109c:ee90:fc9d%2]) with mapi id 15.20.5654.022; Tue, 27 Sep 2022 02:07:10 +0000 From: "Zhang, Qi Z" To: "Yang, Qiming" , "dev@dpdk.org" Subject: RE: [PATCH] net/ice: check process type in reset operation Thread-Topic: [PATCH] net/ice: check process type in reset operation Thread-Index: AQHY0a+K6WoxBnidUkKSoxZKEATFQa3yhyKw Date: Tue, 27 Sep 2022 02:07:10 +0000 Message-ID: References: <20220926134405.304919-1-qiming.yang@intel.com> In-Reply-To: <20220926134405.304919-1-qiming.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|SJ0PR11MB5072:EE_ x-ms-office365-filtering-correlation-id: 165928f6-0149-4899-f8ad-08daa02cfc8d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 80v1h/RHNy/EclKTEScBVN+cdYtE4/CDBcFIrd7bKK5bE5yphcuG6JLu7YlwsdD4oUE7s2wdzauj8HLvvvCB7XgeFyNnua9c1Sa7pik6Lif7RlOZr+jymCzfousth0Me1ZEOJ85GtHNoltHsrV1AhqcQga5j1x3/iRkQfe+N8aAADSvqX1pVdqBmuMbvVa3nZe/JzIUZX2bsKM8SaVFng1ifXWiyZN1Rn5te/PBWCgkUhlRp+LH0i6yb7z6M1/BKJ5w7QqLc8Y6Y2EtxRpDa0cGV1m3UmQTJiF8ypwAyr/nU7Cyfy4gIKL7g7rsmugjZyGkH06l/KRl+wW3dRH0Huz69/F8tBvP1dAUJtdyu5tpzbznw6Yg6K4u9MbC8+1dY0+P2tmNTgZ1ETFcM3NwIKIQGT08yS9lKWcQCfLsRniytrHUXb/3StKLNnLc/9qNUGLnaCOcxuzoRIeT4Vp6By5kJ1N2vvkYnySZh9kiFx5g7FgDUYdYcG/PW3xfFt4UyVl2Wd+wDXKTIFJSDsM4ok4VUxBiAlSL/HYxHxogQ/WSvZ6nhdeyfQEiYDekIAlv/XJdfBclye3doM2PTBpKiaQ5SH1QMFla1Y2/gPivM9c8SPrzdL9/C7y+6RqkMmbA18uiGYyE2RJQ6CIUlrVtC0ObEzPKkMYU+Ej4nGdKXDLxmsVfYEYiMwD0sNviH6CQPT4K4ezzWE3rIF039de0K3FNRAPppeJBWTtEaygFhjZQVXg9TIRzu+hdZgGh1NEn/bnIzaMFYtfKymeu2axhEtA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(376002)(396003)(136003)(366004)(39860400002)(346002)(451199015)(41300700001)(55016003)(478600001)(66446008)(7696005)(66556008)(76116006)(66946007)(66476007)(64756008)(8936002)(71200400001)(33656002)(110136005)(8676002)(316002)(82960400001)(38070700005)(122000001)(38100700002)(186003)(9686003)(26005)(53546011)(6506007)(86362001)(83380400001)(2906002)(52536014)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?B2Ve2l4IE4AY7Hq5F3YRhrJQuycvEqt/uXClDCF2jXJ/dM8yxCcUDU5aatWI?= =?us-ascii?Q?XIMWBAptZdvxsLlAcolF1wRD4u0zx5ot4NPK9W01xYkjwlUt+39ZbfqlOwnD?= =?us-ascii?Q?uzql19JwupvvB1irboytbZ2RrVLkBSbiqOn/yLLMszgNDqydVxsK+PZfpacT?= =?us-ascii?Q?8GFvpyhYRFyg+cn6YCQ8b7obfP5rOzy0bNgSmX1XiEli8NvsmPVJIFpi2fm6?= =?us-ascii?Q?S+/4AKwm7BnyBUWcHBhRueKWb3H5Y11g/PonRdK/TBCZYsANo+bfjp2xgtDO?= =?us-ascii?Q?VtsyeD/PdHWCfySkZx6cQQi5a2xPdxccKeSaPVQrKdyQ/IBxB4iJEE6m/OVX?= =?us-ascii?Q?vGKRSm5mF6v0eOxp1r2izX+mgY2MRFSc363Zz02aDrHcE5VQgJ0pmNJt+0BU?= =?us-ascii?Q?bICGKIweRTBhf9MNDoC/rt0uRItTaRKz6/LLj3l4DK/Uhh6VXE9nTRJoAXE3?= =?us-ascii?Q?zM5+oTUv8n+lAsaNg+/MbyAJtxNR68kwX/QK31EBUMAS6HcDiFxVKKsf6kUM?= =?us-ascii?Q?3OHEQPrN7r5kyJrcuTtnhiOZrl100ujMMupe42c5DqgKNvuRsNM7hdFkJDFj?= =?us-ascii?Q?5ibny8mFF1mzrrl4UJ/MR7e/xNREvguvkoow12QuUavqnOpDprvbzwUltEXr?= =?us-ascii?Q?idANnjPk66Z1GmX6pfbe01wOAFQT0kRD9hQxwlSK7pPrvYhwVhr4HOPL8F8X?= =?us-ascii?Q?zNN0hqF6paXU6j5mAunI565OcUFLAEBl/LalS5iCHS9iDKqMtm2CsgXeGsg3?= =?us-ascii?Q?n2IkAHYhySldxHoWa9QKKqOFWRpN30hUn5FL1nWjD3NHE/4PWqXoi6mLE0yW?= =?us-ascii?Q?tLgU679R7Pbqej9tAaFbK0DnmdoecvjfMnTKWhh0TLP/gpj2petzoIi3s3Pb?= =?us-ascii?Q?bh/BEb5+j2iDiRwF33SP+TVvYG+MRMskncEamGTYd6roEjlJBKxfieETJxGP?= =?us-ascii?Q?Bbwnfa8EqXCCqbU3vcEl2eFF6dFwF3nXHmHm319ZmpvqdPgQVNyYFQws6GZI?= =?us-ascii?Q?9Iafo6AwzwOh0mvi3GlUDp0FdCZxnv737moN2YXKOXP/nlOChudxH6N8mKmy?= =?us-ascii?Q?c4gEohlc9PLXQXjUEn69GNIUbHy2DNTPYP6qXZili2zGDw+rZFtAgzTfU5yl?= =?us-ascii?Q?OEHdZs57sh71AJFLxirKx3jKkeEngv7EkzJaV+RSVbYObkjkUHGvoJ2CCLMP?= =?us-ascii?Q?x/qnKF+/dtYutdYj+FkrkjafW82m/Ltw/icjozXdXqxD9sd40AxDfDvDgR1P?= =?us-ascii?Q?RlABQb4umRe5uRBKbI1xsf9J9c+PefWJCaM0WjvdlQPIxTeb6sEh+I5NXky6?= =?us-ascii?Q?Jerzdi6dbxQsoFvzUktTIFsJhzndOO9KJiGuDauSWkvxDVUjm9L8iF8v+x+g?= =?us-ascii?Q?sxQwK2ofH3IfFszwr32CxpZgL0/ZXe0UKa6NKcT/oKuW8mMJVpsz2lVXCxIa?= =?us-ascii?Q?7zjpcJ4I8hkrhW4siNIBr4fOjzWYsW0iKmZLgL0uBi+kAhatzUEZ3+MQsTJN?= =?us-ascii?Q?aicXDfbWPPTQkDj3eb5wv5faPx+yD1zavsuudohpdeg+iBVfTSypPKCLWhZj?= =?us-ascii?Q?/FuraGAfKn8/xxB/RvRhImzwkeNF6av4GeqHu/UP?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 165928f6-0149-4899-f8ad-08daa02cfc8d X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2022 02:07:10.1889 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jsSrfKnQgvX2AGHd6wqhjwaH3KyrxbSXmLHrgyFqSsHijIM4IVzt6PQgFa1YsbJdekSOkXbz2+69zdg3alpUTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5072 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Yang, Qiming > Sent: Monday, September 26, 2022 9:44 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > > Subject: [PATCH] net/ice: check process type in reset operation >=20 > The secondary processes are not allowed to release shared resources. > so the stop and reset operation are forbidden in a secondary process. >=20 > Signed-off-by: Qiming Yang > --- > drivers/net/ice/ice_ethdev.c | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c = index > cf63ce1f32..d855e9ebe1 100644 > --- a/drivers/net/ice/ice_ethdev.c > +++ b/drivers/net/ice/ice_ethdev.c > @@ -2504,6 +2504,9 @@ ice_dev_stop(struct rte_eth_dev *dev) > struct rte_intr_handle *intr_handle =3D pci_dev->intr_handle; > uint16_t i; >=20 > + if (rte_eal_process_type() !=3D RTE_PROC_PRIMARY) > + return 0; > + If we didn't explicitly deny dev_start from secondary process, then we'd be= tter keep same for dev_stop Any conflict should be handled inside the PMD. > /* avoid stopping again */ > if (pf->adapter_stopped) > return 0; > @@ -3742,6 +3745,9 @@ ice_dev_reset(struct rte_eth_dev *dev) { > int ret; >=20 > + if (rte_eal_process_type() !=3D RTE_PROC_PRIMARY) > + return -ENOTSUP; > + > if (dev->data->sriov.active) > return -ENOTSUP; >=20 > -- > 2.25.1