From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 34693A034C; Tue, 30 Aug 2022 03:46:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 094CB40F18; Tue, 30 Aug 2022 03:46:13 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 0DED540F17; Tue, 30 Aug 2022 03:46:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661823971; x=1693359971; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=CbB5T5OEPQtPyPGIxYqkFvNKimhkx+ZR9QcprwGu/6M=; b=noZxvj2k2ACkXhlItllcRZyPvOcTAlCxs6tqbcaKx9uiWLid7DaP6bjD xUVAoUnTHtqukevQwwms2A4JaUFO6IGlhak5sZKYY1idixNSBiJwJ1Jx1 +PwvQ6boV2f+KpIr0MAAwjfOcBUyQLnLP2r4B2n4KXwWSi+JlgxK+h0O4 M5Zdi73WME3Kc6MG3gfizYkB4Z4L7R/mhvcQptBulQ/KmRIC1BJCPP2Tz W20Nb7RSyTCHmBeqg4uvIHvGXjAg0ab6vMKHkxlCZZD59+V0R4Oz128eJ vVD7iwhhwqb1dsZuAcLI+VCmRAOIb4V/IvlBaEieOaTbKAopjTXeNPLO7 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10454"; a="275452361" X-IronPort-AV: E=Sophos;i="5.93,274,1654585200"; d="scan'208";a="275452361" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Aug 2022 18:45:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,274,1654585200"; d="scan'208";a="607655393" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga007.jf.intel.com with ESMTP; 29 Aug 2022 18:45:42 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 29 Aug 2022 18:45:42 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 29 Aug 2022 18:45:41 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 29 Aug 2022 18:45:41 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 29 Aug 2022 18:45:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jy00XgWycvM2OiBgI9QFcvCrz52qL7/1bEUsVS2cR3ouY9K1bY7Zf5W//o24pd+3EDQ5939Z6S4mPsqd5iAVX53E1iLPQR+cOv4L32tFGmhK92nU0kGWy2YGTZ03bn8Dazg0jCp4wTtFVj5mxMp+b8yrP9J7aNCTLMymsXXwSbhXhyLcEAf3WPcijIhu9TrYQO0lJ8LKxkvkkKVGB00t709uM2ahHmZ4Siubc+SKYEkViDwocKH8nE359kDtFSJREfUkWDZPPcnF0PBgIrH+VZa8bDmgC3ew0ux+qPl6+HQA5t46J111IBAvIXKZL1i9wdiLDnWDB/FL+kFVGawo8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CbB5T5OEPQtPyPGIxYqkFvNKimhkx+ZR9QcprwGu/6M=; b=Eulvokh1U8NKBgnufKFSViA+iB5Zkay4s/nd8QKvDZt0SHnzwlRwkoZIBQfbardTuNxxefdKqTsnY1yqrTahQobQcoFSSSc/+LyywOrUYmNAcN56jabs39WkWzQs7r+Rr+PKDE6mIlz0CmoBAOafDIEi3/+wGn58bpsPtPhOW7homVUHlFBApytDvOHwrNax+58Ko7LT/iqA384eqhdaWa2HbA0rLdmDnxxS8Z+KIGX3ryjINFjFRYz/sFuQtJDd+f0YTfCfNASSiQpJIiRmVYAVMD6heSqRXSkD61pWOa8UlWe7nbmxtaZqJokG45Al8WXqGLxIsaUs1hSX4UlzXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by CY4PR1101MB2071.namprd11.prod.outlook.com (2603:10b6:910:1a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Tue, 30 Aug 2022 01:45:34 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::d94c:1798:9e3b:804e]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::d94c:1798:9e3b:804e%7]) with mapi id 15.20.5566.021; Tue, 30 Aug 2022 01:45:34 +0000 From: "Zhang, Qi Z" To: Aleksandr Miloshenko , "Wu, Jingjing" , "Xing, Beilei" CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH v2] net/iavf: do Tx done cleanup starting from Tx tail Thread-Topic: [PATCH v2] net/iavf: do Tx done cleanup starting from Tx tail Thread-Index: AQHYvA3sbberpWuAOU2XtB7iKPwnIa3GrCOA Date: Tue, 30 Aug 2022 01:45:34 +0000 Message-ID: References: <20220707001414.25105-1-a.miloshenko@f5.com> <20220830011346.24657-1-a.miloshenko@f5.com> In-Reply-To: <20220830011346.24657-1-a.miloshenko@f5.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b5ee2636-709a-4316-ba88-08da8a2954c7 x-ms-traffictypediagnostic: CY4PR1101MB2071:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IkgfeA3TxdrA9mymTl179RRP75pYhfkREriL3kFX9DRWxSCeCR07QKFQQf3CpB4sy9Ej9G61X3ASwa2i8rDar7/xLxCdsmIv4/F7OUfqUWFhelYi3OtG9EpUkpJin9Qwtm0+NU0DlQYcHDXstMeaSKNG3XppIzme7BuVp2loOVM8xuy/uINLr84fd68ptGBxWg0+CDj1Xd//LZmR3J59Wi9pF51H90nucoYNjshz5QCJ8wxPMdhhqYf+LszkVD8CpMWj5xEXinSokFCCNRE0x49TNRFlTdBAT6uI+8uNk42v/D5wfASYDeu/Xpg54C2Mx52peIpNagRqhdF85rwrZtB0zWFscTneda1QMlKtxkWyZwcHy1zdBBXEguRB1wN35hTjfOHCkOwn4M7oO9S/zTZxjYeKUuIdxNpQ8ndfbjuEtYwne+/ISk9kKatJhcGodyiWIxy4G1PwkrT4DmYGO2ycCYkDIfm2462Gho7Cy1J/EGyJlz4HbeJ/wjSJTkNjEmW8deDK8ryrgCxvtI5gO9vr0wMCdMylx+rki2Q57LEilQ7Q5rZs5fRV80UXww0gS9+qScuG8VJjI7cqg4mGS6ml+hDK/cl4rAEtrsZQiA4/eOpM0ZGCa7TVnitXRL6uqoIQ7+3JI3PmqZNe5xqVHV3kFQd+zxRWG/yM5VZp/HgP1ba8T+OhSSCwegCr5fdaCdmbE7HSr3zwW9YcbPvR5JVfHdnVbu+LdjXuSxL8c7GAkl2VmqbPb1QqPIAUyZXMzOr0ka0JfMcmkgUa3SogcA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(136003)(396003)(346002)(366004)(376002)(39860400002)(186003)(2906002)(83380400001)(122000001)(110136005)(52536014)(64756008)(316002)(54906003)(6636002)(4326008)(76116006)(66556008)(66446008)(5660300002)(66476007)(66946007)(8676002)(53546011)(9686003)(7696005)(26005)(6506007)(41300700001)(478600001)(71200400001)(8936002)(4744005)(33656002)(82960400001)(38070700005)(38100700002)(86362001)(55016003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5d25Zvq9BpvB0Q3JDD76YVnnmi+ZTvC2ac7cbhL+ZBwtFpd9vnPwRRLfLvd2?= =?us-ascii?Q?LUy3u6fY3kZhDBXWuDsUvWeelI+R8pKT1nbbK8tD6I5NRfPTFgAltVx3JyfR?= =?us-ascii?Q?JN/UKcO0dUR05SbGelfB2r7cZ7O2i2EC94rPhy3XLsfRn7Rwm4QtW9pk789F?= =?us-ascii?Q?revgptH18RROe1F7fqUvfkP3lAbqOSQo59KwP2I7MSLpKvQCriGPyA942V9R?= =?us-ascii?Q?iGGkCOW1fHbbsBs3q8IZ2jc4dFjZ4Crsf9qonv3oATl7N27QqDFcI1Sv3qGI?= =?us-ascii?Q?tdr4L5il+RWl5ePsZ6LY8KeYD/4s3shVRx6ThI3YjraQZN/mamnqXRvLusSI?= =?us-ascii?Q?c9qaFdgWipCvbEpK7UhxF0uhUvLV/9WZ77DaVPK5MAQI3R11lm8EChGojeXl?= =?us-ascii?Q?OOrve11f0Nk6I2rVReIDsz9R+cFfBSmwX2+xaWKSfbLre/F4St10i044rz38?= =?us-ascii?Q?EzwcT4e/t0CzYgfOPYEM9pzfjnJSQImvHBbBZ59NuO3wYtoNhG68BTF4sWyv?= =?us-ascii?Q?M10ZP+e6ReJ4B+xvd/Jxt8FkZCzzHZEMjfY/RoRn9t1MZEGoupSE6vrkOlt+?= =?us-ascii?Q?wc69jLczgsr/AgPeKh5KtZ2vsLsaVdiV3PvbgmxEMaJ85hjQQPqxJ32uBwPA?= =?us-ascii?Q?2xN4hlPFdzSXxHhhy2a+QaDTmCFOX51GN9M2RgzARC6DpSUm/eBmAQ5uQVo7?= =?us-ascii?Q?FskyIxrOHWoHy2thqJmgkxr/RjhVShoz/fXXEHg/VoyB6rr7nbKDkfmwzsEW?= =?us-ascii?Q?X682brfr3A0FuYgpEgx3lXjyKMlnlvFuA7iSRiYNVX/XoB1I/2cuxhrIp2Mu?= =?us-ascii?Q?QB08tg92TvFlyI8+Nyw2/2EuAGpsC6haT5GJpwoIzkzP/mJP8vnPyh8jSbBP?= =?us-ascii?Q?yZo8Z4GmsD0EYWEloSQPIWZ8oEOhyetMW+Hg1IaK83TiEFb6vPMqBm+2Si19?= =?us-ascii?Q?s5AT8DeKbubhZ77SGrpiiMBGX4twuHHBdGfBxDq4qw71OXhIaejY/jQMnRnz?= =?us-ascii?Q?LNnwxj2I9XKecV1YUBGWeWfLI0kvRrQxwyimJWfeWjeaFRh221eMbhdwDjar?= =?us-ascii?Q?q2nZMCEgG+n1uIIO0fNdw8pegtxiv7iVTOfYW0tTEyp7hS5qpIOpiND+A9Fv?= =?us-ascii?Q?iTR2I9BhMujLCat1c4mTSKFH1KwXkhZP/w2POrX5j9Y+wuv9x6tWJPr9WtBa?= =?us-ascii?Q?ZjkX2TzZGI0fNeaSF5awr3nRJGQOn6AWTIlvgOsD3NTZic/5syhDkGDdYFZy?= =?us-ascii?Q?SXhFCzwVWNt7/247EUSDI9+u1lEDeTtI/KhXmJnq3V+allyQ4Up6yY9JUs0E?= =?us-ascii?Q?X0efgPvzjsdIe8vjJiFjmjiL7df0OnQZ2Dt2rtaqvdsavqi7msqtgFaB3TyI?= =?us-ascii?Q?OZ0pbVfgD066ViljdzSLibB0tCFOhI0RkST40sv7YE2HZY2T0t0WmcsSNNmD?= =?us-ascii?Q?m4Q0v8H/KvKX4+2USw3YftmK+h0dgzsIFPmaaSv3Otprvh9h3s9XnvZ8P6qL?= =?us-ascii?Q?o49nZ+Jis2KQAFy2XjDbcBnxaSeGBX3wp9Y17u/IxkDIT8LUhXUHuube64H5?= =?us-ascii?Q?FqQk6Kr+d7CDMNSjvU9ClxBvPrrTBGhH+C9VEoxq?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5ee2636-709a-4316-ba88-08da8a2954c7 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2022 01:45:34.6545 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3Lj5JPoVaFHJyxXwp4vv7/wl4l8z0c8AsxefW/MGg0FPeeSt/4NBfQhGU+/CejiwTaAlzMpKDVA9CEYhv142+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2071 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Aleksandr Miloshenko > Sent: Tuesday, August 30, 2022 9:14 AM > To: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei > Cc: dev@dpdk.org; Aleksandr Miloshenko ; > stable@dpdk.org > Subject: [PATCH v2] net/iavf: do Tx done cleanup starting from Tx tail >=20 > iavf_xmit_pkts() sets tx_tail to the next of last transmitted Tx descript= or. So the > cleanup of Tx done descriptors must be started from tx_tail, not from the= next > of tx_tail. > Otherwise rte_eth_tx_done_cleanup() doesn't free the first Tx done mbuf w= hen > tx queue is full. >=20 > Fixes: 86e44244f95c ("net/iavf: cleanup Tx buffers") > Cc: stable@dpdk.org >=20 > Signed-off-by: Aleksandr Miloshenko Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi