From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4768B42D94; Fri, 30 Jun 2023 10:27:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C457E406B5; Fri, 30 Jun 2023 10:27:44 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 417864021F for ; Fri, 30 Jun 2023 10:27:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688113662; x=1719649662; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Qf3/lqatFUkier+JGZLl9Ava9I1nRgWhbUeN7nc7Ds4=; b=emI9e4elCbUTFIfzTCGTMw8/6z6zRFM9TMOlK302HLpjVeoypsNx+Zqp kZGWNKAegKb5pCzkcrD8KESE6vwaKo0ejU2p76m2DTJ/DhYDm87tNlL9s PMotp0A3NNqpLdJPSgJqxV1QG+tCPhQACa2QImt7zDSG/UseLW/F0X2bn cBJ2K5hLoFZy4ws6llHu+F9OQqnpYVOFkQ/dCKtulQKIeuuAMrPVWr98i 36Rz7yxgOCy176GRdV6AtxNfynrxOQ5uXUqS9qnvIyjD/v5g2Q+P4z8TP zZAwySu4JTZD+5SfAnSEe0YHEEvtxsXlh/wCBVVuw7euPhUtcA8Uu87Yy A==; X-IronPort-AV: E=McAfee;i="6600,9927,10756"; a="347127766" X-IronPort-AV: E=Sophos;i="6.01,170,1684825200"; d="scan'208";a="347127766" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2023 01:27:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10756"; a="862222729" X-IronPort-AV: E=Sophos;i="6.01,170,1684825200"; d="scan'208";a="862222729" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP; 30 Jun 2023 01:27:35 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 30 Jun 2023 01:27:35 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 30 Jun 2023 01:27:35 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Fri, 30 Jun 2023 01:27:35 -0700 Received: from outbound.mail.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Fri, 30 Jun 2023 01:27:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LNeMDmeOM7xr/z1459YM4W3LAuk9n5w4G3Is/gL5VBZzs6iPpHri/FslNwF4nKnbMvGUtIFEtPvnoxB7OQU+x4tfiTAx9wFDptquL1kAdwRGTaAsmd1IKjIWTh1fXBnGdbQL43yCOpnMRY/82xwXQYBjkKpbvUtL5P69txQhBdCXAWy/smtSwARdr9uUPHiqGHAp45m+fxzfxw5XxgU/q9ysrXgHRJVLTz/V7/ifFUxu2c9HoTWkEwpSJBXq8sRr5ykhgQealM8xzfgaLkHlvyDOyusROSJoMnJGZ0ehmk5bRGa9ZNssw9EahvH8sAwS+3rLKBLYp7Bqii4LY3Zy0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4y0fd3X63VvOxiZq0G97NhNuR7JOJ64nLWyQKRTNO0E=; b=Ca2XtmDT/e44FnoqYoDw801nQG8HiByltZGfzZ7b6EuQNfzyRxF2nU/ZcNDkzNQPQLI/S3JpUQ9Ja76jcUTul8f/AF/nORKbi4Ki4xG/X/GxKOKv+iiDhtAK9jqqeI4aANDAp/8rEbj+y97L2PPI4nWx2LfLLj4dcVYVBD/7xXL+Lqcx7VxVLhesv9nm74x+V+jHpRMC6/PomEr1+JlGhkv0QaGWc5q3jqxepfttb7VF/ijpMuSq9a5qszwl5u5fRYyjwWQ80dUR8No6Afn6QaF7fkIykJbBoA1nuDUggtJqwHaZvVUkea6vPNXXjWzkTc/LVNH+RC8Y7ZaOX5fuQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by PH7PR11MB6835.namprd11.prod.outlook.com (2603:10b6:510:1ee::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.26; Fri, 30 Jun 2023 08:27:26 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e570:d9a7:df1b:1589]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e570:d9a7:df1b:1589%6]) with mapi id 15.20.6521.024; Fri, 30 Jun 2023 08:27:26 +0000 From: "Zhang, Qi Z" To: "Liu, Mingxia" , "dev@dpdk.org" CC: "Wu, Jingjing" , "Xing, Beilei" , "Liu, Mingxia" Subject: RE: [PATCH] net/idpf: refine dev_link_update function Thread-Topic: [PATCH] net/idpf: refine dev_link_update function Thread-Index: AQHZp9oA/7J7gmc02UO3GMwV/Is05K+jCNRQ Date: Fri, 30 Jun 2023 08:27:26 +0000 Message-ID: References: <20230626111454.489844-1-mingxia.liu@intel.com> In-Reply-To: <20230626111454.489844-1-mingxia.liu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|PH7PR11MB6835:EE_ x-ms-office365-filtering-correlation-id: 68f1e8f1-5fff-4c49-3fb0-08db7943d60a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sTJ14lAxrlk/D+mftNtQNY8Zi5Ec6Ng6n9yf3a6bi0bKtN503qDlsaA9f7WnotsLUBOu4UgSBtJyUouav5kuRjWY04yxVNsPLmdvmr1iqeh5YUH8/LaKxghz7JkFsW8WqDE/rt2KtqugHRUAyoq4VNPCznNhSehQFVuYZVlv9neRtxTewQvW6yo0nxdkdP+c/igkcrE9Livb3yRW7rutt6IJa1J8I65LuiHMEW85PKZ9fb1fFiQWtESkkIYH9YbaSHEDByhywhYv2NCUeD9Mb3ex9AWxax2//cTsv8GYsCDXlEpjuwyvNDvQAC+RL2Ftrqn9T1zwIR/4fGAtcdnfP/7UTu5E83w6JjFaP6/ucOnxDVgKZJibNkO4zYylB83avCO54qjrCzUU+qLEaWIiInn5E3HBr0zzNFuBymZ2HCKpQ3c0Npcac0qrDTjhPi46efJIvHWlwt8eJcTwxv43W9ZPwDbJzuWpgpMKSOgfl/hVyYfU4b6+QIZtd2arK8MGGQyXsh39gmEJ8tro2a3QL2b/ZYDe9zHosi37TVk4Ol+breBUxZ7LcY1FPeqS9m7cs0/rojvTT4BDF/O1doi9RY5PzkuoaxQi2JjeWLaW6OnMq/KYcM4krgrA8TxPrbd3 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(376002)(366004)(136003)(396003)(346002)(39860400002)(451199021)(52536014)(110136005)(107886003)(478600001)(7696005)(54906003)(83380400001)(26005)(186003)(2906002)(9686003)(71200400001)(6506007)(86362001)(41300700001)(33656002)(5660300002)(122000001)(66946007)(4326008)(66556008)(55016003)(38070700005)(316002)(76116006)(82960400001)(66476007)(8936002)(64756008)(38100700002)(66446008)(8676002)(53546011); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7nNClDcKOVhlxDI29onnXYmVoMZnHARfPEbg67R01m+DME3sTlqB3HlHp/ob?= =?us-ascii?Q?X7s2hO8KJ/BP45QlAmadlddF7MerL8Hi6L7uwI2t3V9oxOvpIv3kiBpw5Qij?= =?us-ascii?Q?Jr2UZHXIyuEpzYfyvO3GrBtA5hyAPzozItBk+jvNPcxakuQR033MQv+ASQAB?= =?us-ascii?Q?5UFm/arno7SENIetoTdjS2ICat4qPJnhXcYIN2BQlHuaHiGuG/quXR6ltRPd?= =?us-ascii?Q?I+13CnTVWcFAIieZKwQYWKkHAa5yGbVaNmG2xkwpcyvX3XUk9HQguHHHSG0Q?= =?us-ascii?Q?DQGguGXCcXoLVzB1CKKjeNLwM8X0gCkTVndj/HaNEF92LqQiHLnZKqczi7/l?= =?us-ascii?Q?IK7UyK7Fucw+y9LDimZ50JkPpKgFT9uZ8MpFqWFHV82Ss5mRwUerGJZJFxsX?= =?us-ascii?Q?TktKgb985AJNrzSIAERVr7+Ywk9pW33qQOf//a4bPZ7OPmLqS5EylxKe401s?= =?us-ascii?Q?dZvY/ljZxN/tgdoufHtPsvBugvjt4vejZqE+cxcR3XH2P9gj3PBuVwseIc3Z?= =?us-ascii?Q?JZwQxkhrFpCHPV9E4577uLCGu3Fg8iuBhCmVZfedxv7DDm4N4nT2Hfvt7dVH?= =?us-ascii?Q?o7K5LBqwbl3NFQ7Y3ji1Ma0goMlgeKBhpBJD6qUWsn4ML86FJCM4eR91XbcA?= =?us-ascii?Q?k034bZwfc1ikrca4mJCt7cJKDowPJ7TQIrcF5KYJf7kWLlbl9vjYLxa6Meuz?= =?us-ascii?Q?kDITrZRzhS+eV3tvM8/qX5ccjiREMxUgmcTnn9FTZxjKLsPHKoIYlarqk1rk?= =?us-ascii?Q?s6HE5fjCgnTqpu6mZ6Xv+DwwjCbB6oJreCBwBxooQRJw2eb9Her7Fl0Rp6dx?= =?us-ascii?Q?lrukzyofmtXHaI2rvGQDG09gfZrei/hSqtuuCdaOtZmFDqFbYzXcNDvk2PmL?= =?us-ascii?Q?EV1bECrkvs51dPrSZx7cZsocSA1dskpLG77Nvru6fhkXBydgzcit2RLnNaOa?= =?us-ascii?Q?OacL9eiwIBP6i4K7PLgrp/ce4T194IS8M6oNbMiwRMs4e+024HUWsIj2wxwW?= =?us-ascii?Q?qfur8O0t1t7hVmM+Fjg7fHXxs8/zLGsa5opLspZNLSbLf8HPDQj99KQksrgO?= =?us-ascii?Q?o8T5QgAqWVxAPS1HMTOVnUCr8FbU59i9oYWyN7AeP0sCBAUz0qAcRfjdGbpO?= =?us-ascii?Q?WvPs3N0lsvTVmgsdCEZFFBJFzQu7pDh/M2wtTv0RL09XryZNRMt6tEWKEo4J?= =?us-ascii?Q?VNIYflW0XKK9+WX1i0rYDRUTuK0Ctjtx8nI/i+vEXHto5z1eT+eMkjuKcc6V?= =?us-ascii?Q?/F4DrQgRc4cPVhk3XifZWhCfUgw48jFcBmieHLiGxUsU9xtlMf6nWiPfinUX?= =?us-ascii?Q?CUDor56vF7PEWJoYsSArI8CphlH3vq0ravgdJdcUXQZC+OXgNerpz36ZM/Vw?= =?us-ascii?Q?sN0rdIica4co4swnPIbG5A9ZVJnR86OJYraK2rj2sygizGlfjM1DU9W6AgpC?= =?us-ascii?Q?wXuJ3h8JSptifQuQWcuyt1Tru8faabY/nDkwt/BMcvVcRDUPkjH8egjpa/OB?= =?us-ascii?Q?xOgzJahDLZA6nQrXJ0bM3YhclIqvVDp2k6bFBxSFhzVyEiFDULy7Eh9hZZAD?= =?us-ascii?Q?u6yFn9WoLERNNAD+azKPCC5GJbGzvuCfZiyY9QW+?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 68f1e8f1-5fff-4c49-3fb0-08db7943d60a X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jun 2023 08:27:26.3207 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xKvV2eytfqHDqIhjHKQAE5Mg8lVxMZduGmT5LUGuDuys3FNQkggk6M+yHcQ5lTY5oMQ34FGMlotjrogmZFQ13g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6835 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Mingxia Liu > Sent: Monday, June 26, 2023 7:15 PM > To: dev@dpdk.org > Cc: Wu, Jingjing ; Xing, Beilei ; > Liu, Mingxia > Subject: [PATCH] net/idpf: refine dev_link_update function >=20 > This patch refines idpf_dev_link_update callback function according to CP= FL > PMD basic code. >=20 > Signed-off-by: Mingxia Liu > --- > drivers/net/idpf/idpf_ethdev.c | 63 ++++++++++++++++------------------ > 1 file changed, 30 insertions(+), 33 deletions(-) >=20 > diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethde= v.c > index fb59655555..bfdac92b95 100644 > --- a/drivers/net/idpf/idpf_ethdev.c > +++ b/drivers/net/idpf/idpf_ethdev.c > @@ -30,6 +30,23 @@ static const char * const idpf_valid_args[] =3D { > NULL > }; >=20 > +uint32_t idpf_supported_speeds[] =3D { > + RTE_ETH_SPEED_NUM_NONE, > + RTE_ETH_SPEED_NUM_10M, > + RTE_ETH_SPEED_NUM_100M, > + RTE_ETH_SPEED_NUM_1G, > + RTE_ETH_SPEED_NUM_2_5G, > + RTE_ETH_SPEED_NUM_5G, > + RTE_ETH_SPEED_NUM_10G, > + RTE_ETH_SPEED_NUM_20G, > + RTE_ETH_SPEED_NUM_25G, > + RTE_ETH_SPEED_NUM_40G, > + RTE_ETH_SPEED_NUM_50G, > + RTE_ETH_SPEED_NUM_56G, > + RTE_ETH_SPEED_NUM_100G, > + RTE_ETH_SPEED_NUM_200G > +}; > + > static const uint64_t idpf_map_hena_rss[] =3D { > [IDPF_HASH_NONF_UNICAST_IPV4_UDP] =3D > RTE_ETH_RSS_NONFRAG_IPV4_UDP, > @@ -110,42 +127,22 @@ idpf_dev_link_update(struct rte_eth_dev *dev, { > struct idpf_vport *vport =3D dev->data->dev_private; > struct rte_eth_link new_link; > + unsigned int i; >=20 > memset(&new_link, 0, sizeof(new_link)); >=20 > - switch (vport->link_speed) { > - case RTE_ETH_SPEED_NUM_10M: > - new_link.link_speed =3D RTE_ETH_SPEED_NUM_10M; > - break; > - case RTE_ETH_SPEED_NUM_100M: > - new_link.link_speed =3D RTE_ETH_SPEED_NUM_100M; > - break; > - case RTE_ETH_SPEED_NUM_1G: > - new_link.link_speed =3D RTE_ETH_SPEED_NUM_1G; > - break; > - case RTE_ETH_SPEED_NUM_10G: > - new_link.link_speed =3D RTE_ETH_SPEED_NUM_10G; > - break; > - case RTE_ETH_SPEED_NUM_20G: > - new_link.link_speed =3D RTE_ETH_SPEED_NUM_20G; > - break; > - case RTE_ETH_SPEED_NUM_25G: > - new_link.link_speed =3D RTE_ETH_SPEED_NUM_25G; > - break; > - case RTE_ETH_SPEED_NUM_40G: > - new_link.link_speed =3D RTE_ETH_SPEED_NUM_40G; > - break; > - case RTE_ETH_SPEED_NUM_50G: > - new_link.link_speed =3D RTE_ETH_SPEED_NUM_50G; > - break; > - case RTE_ETH_SPEED_NUM_100G: > - new_link.link_speed =3D RTE_ETH_SPEED_NUM_100G; > - break; > - case RTE_ETH_SPEED_NUM_200G: > - new_link.link_speed =3D RTE_ETH_SPEED_NUM_200G; > - break; > - default: > - new_link.link_speed =3D RTE_ETH_SPEED_NUM_NONE; > + for (i =3D 0; i < RTE_DIM(idpf_supported_speeds); i++) { > + if (vport->link_speed =3D=3D idpf_supported_speeds[i]) { > + new_link.link_speed =3D vport->link_speed; > + break; > + } > + } > + > + if (i =3D=3D RTE_DIM(idpf_supported_speeds)) { > + if (vport->link_up) > + new_link.link_speed =3D > RTE_ETH_SPEED_NUM_UNKNOWN; > + else > + new_link.link_speed =3D RTE_ETH_SPEED_NUM_NONE; > } What about /* initialize with default value */ new_link.link_speed =3D vport->link_up ? RTE_ETH_SPEED_NUM_UNKNOWN : RTE_E= TH_SPEED_NUM_NONE / * update in case a match */ for (i =3D 0; i < RTE_DIM(idpf_supported_speeds); i++) { .... } >=20 > new_link.link_duplex =3D RTE_ETH_LINK_FULL_DUPLEX; > -- > 2.34.1