From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C2B4A0566; Tue, 18 Oct 2022 06:20:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 739DA4021D; Tue, 18 Oct 2022 06:20:09 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id D7E3940143 for ; Tue, 18 Oct 2022 06:20:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666066808; x=1697602808; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=pP5Wsxsweo7xf8I8uHZ3LFsoXRN7BCU2BtrO1JBRlEs=; b=Xt9V+BAb55tvZOHcms9TM4OOqK960rkHvL2T9ZsgpDALgLs1QFA6FfmW LSbM8VqwqHPC63tGFyO15u5Znsx4bN7Hdl00l9yd0m/pVjdlyAZpFerxF nGHvROd9pSYi7TR0TV01xsPEDIqNAvmitlfl/heSHEjjZ17SCQNn1RA2G Ac83qav0nuzUTUJ5BAZRG4VGASlOdAY2+cwpA9WWTIot+N3C84i1NYlef 0FQtJDMAfVYWKuCtzHXFp+vUf2tImVMB2E31wgZnXyJHG2gsNIIZ3rjQ5 st1C0sFnTvYWBWtbBoA6Y55jqz6xGNvPmOW8yGsJpwMAIvrSV9Jj2pvp/ w==; X-IronPort-AV: E=McAfee;i="6500,9779,10503"; a="307077190" X-IronPort-AV: E=Sophos;i="5.95,193,1661842800"; d="scan'208";a="307077190" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2022 21:20:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10503"; a="661736963" X-IronPort-AV: E=Sophos;i="5.95,193,1661842800"; d="scan'208";a="661736963" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga001.jf.intel.com with ESMTP; 17 Oct 2022 21:20:06 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 17 Oct 2022 21:20:06 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 17 Oct 2022 21:20:06 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 17 Oct 2022 21:20:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BEX4RCL+8vq39cd70X9qL632UHl+jbexQr8Nmb+2Ozwgrt5mHO8pLMvtpPmcTbu9zqjTJOxQ/Xqjmn2qbXmtLq2S3cH2oSPEMuCeqCZ1fO4yCHQhnmkgE392ZTLMD5YKjS8gRplQr+jOdvITxmq6/h443lJW0om/7Pr6rM3fBM38nvmKjctZSfZXZEiH+PN9/xbZvf9yx0o9Uo7Pjr/uMo9rBGzceccqxfM24xZ53POiJURh95V+y479y0cdxEoKKuVs/Fa7qqzuvSP64RyybNCvcaXzuP+Vk2fW1s0lHKyxp5q1Gh56TBpng3vm/jbKYaXLi1EDqU8KnK/X41UjDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pgFcCoWcAuNoHiOJ/GSJEvpXFf5N9p3yKDbq/HU9N/M=; b=g8QV8rK6lgkJIZGD2oEpVa730VJ+yAkejgejDMS5y9TWfIF/zKDpDBImMyKfgN8GIXiNrlYQqrTaJKkXTxgY8Km7yquLIHuSV4JvHAO3zNxvtH3aonsH/4wOFPNLy/rnQUUhQMHL+s4COAef7YppyoK+5G7fwf+MhUGK/tsc579rQvkboY+lm/kPAY8e500TPy+hVMcQ3e9ruP6+jBbR/KteVQ7KlABBXGMPdkLDgWGL+SSrVW26L1L7qo7O0MAuidciw/PYPmTO0RfcBdHQl7jgX5KumLpQTTl6RWhreYSJyeJO5RKnKG9pTeO3Jaq6z75B6doCpxJLYAMRS1PkpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by SA2PR11MB5097.namprd11.prod.outlook.com (2603:10b6:806:11a::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Tue, 18 Oct 2022 04:19:59 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::6fc4:1ff0:a5db:6546]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::6fc4:1ff0:a5db:6546%3]) with mapi id 15.20.5723.033; Tue, 18 Oct 2022 04:19:59 +0000 From: "Zhang, Qi Z" To: Jiawen Wu , "Nicolau, Radu" , 'Jian Wang' CC: "dev@dpdk.org" , "gakhil@marvell.com" Subject: RE: [PATCH 3/3] net/txgbe: fix security session destroy Thread-Topic: [PATCH 3/3] net/txgbe: fix security session destroy Thread-Index: AQHY3v4w3e0kI9VE+kSE5HgyM8WbK64NqRMAgAXqouA= Date: Tue, 18 Oct 2022 04:19:59 +0000 Message-ID: References: <20221013121913.3543260-1-radu.nicolau@intel.com> <20221013121913.3543260-3-radu.nicolau@intel.com> <002a01d8dfb3$880b6da0$982248e0$@trustnetic.com> In-Reply-To: <002a01d8dfb3$880b6da0$982248e0$@trustnetic.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|SA2PR11MB5097:EE_ x-ms-office365-filtering-correlation-id: 88290db8-f788-4330-f428-08dab0c00537 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iPWegFuCOZ5hgEBEqvGb/vwr10zb+YW+rkBIfDuHeOJffUk5iHu8cbE92NrfnlYLLW1afn0Ubh400S66vK6G3dZhy6TCDFYVp5NxR3oS82ffe9a4T6uZ8Tq3BS9FUu026nCReBL6tcR07R+FnSwJ/h/rNogoKD8y4jJZJOJUqjFQAa52AEI2R0AX6ZzcW/cDi+m1793hSa5N3KgvNDhJIh/nPLi8Y+xA4fMG8SomwIjAf0AztuY/YY4ngPEYwMj98SynDsh3VDV98gMhRK8dkfGSy2AQhWAqyb0SRFkF8kAEH8R68ezocmmpgCAyAYWG3k2tuP6Edq2/npNUOObvLHdQrwIw5t93GZqJkYQ9oP8ANck1Ot2s23fgT6X3JuHGZfsHLVhlqGLcwiuRG+OykPUomlBhQuU2FDIpm/PWpxY+BPGzsTue1clwPMHBnhZuz20UIhZ+zEdMIWs2d3nFsOBva3EPAx5FUwslKzlnRnlXHNuc/Xhp7K49m7oSYS4mKyqvSiJq7OMIbHTvN8xKDuWe1PJhQ5NAij/TqNDrZ0bLKcSZlzOEUAMm1whjJPn8QgEe+k+7t09tbAImCUM2nW0jRnmmul91aTLQtTF2Rw5oFrHstUNXMBKkpr+PR2DMbjFRYsrAEG5EGUWcCn5VUFUS45ZpifZf1MqXHchxxw3JRRwR9lA5w6R97YHQWkHAvYBgnTAp6b40HQs64oS1GKcz9u8dLwxndFarfk1a5xC2uNVA0DFYJXLKmrglBxnv7kDF7zcHGox2hxG/jeNq5Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(39860400002)(366004)(136003)(376002)(346002)(396003)(451199015)(316002)(110136005)(83380400001)(9686003)(54906003)(8936002)(52536014)(2906002)(33656002)(5660300002)(15650500001)(26005)(66946007)(66556008)(66476007)(64756008)(66446008)(86362001)(8676002)(76116006)(38070700005)(41300700001)(53546011)(122000001)(4326008)(55016003)(7696005)(186003)(6506007)(82960400001)(71200400001)(38100700002)(478600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+fbQQblJ7JkjAdxCY64MAdXq556DeIWhJBIULf6jac6jsT1s/kD1ncz3jo6i?= =?us-ascii?Q?k6PbFihoG1hOkcsJy67TC6dd8H86x04R/Dbl9lT6Hm16YbEryqkOLi9jug0u?= =?us-ascii?Q?hjDreo/jaX+/Zn0je75L02ZxHDCMey0M4U5CPNdOH6E1zGJYdCgSOIoeA1Wy?= =?us-ascii?Q?yi6RL4n2wuJyK5BVMFQG6bpp0atrz05GWlDAYATHAgBF9VgwFRbAVW1kOI9F?= =?us-ascii?Q?znxbFT2TQG4eBlE7l4zKnrBrtfivmfpn5IwE/SAQuyVG+HAvr/Q812aavzO4?= =?us-ascii?Q?TP/L4dRJLcse0eJKiLKEAjGfqyyk6o8PCSQGLjLhoJ9sqxgyqucPR3fYXSIZ?= =?us-ascii?Q?aEXumm4EMXrAdqC4xgfjKtULeC4bJgTL6GhuHG4oV3MgmY7V8ANJs67tejkx?= =?us-ascii?Q?ofT6ojYglumQIVVEC9BYjsw4iLhBtdUeO9JYzbXkeqQTg4mecs6xB2e0pB47?= =?us-ascii?Q?nl1CNK7LxkOl8B9OJNHg1TYWxAQnDiBLzL6SZeLc5vhjqTPQNuSW5vXPEUD/?= =?us-ascii?Q?y68nZ6/tZZ8anv32BT0bChbYzHSytWCsXVNXUD/Ke75/3A2OEvjb8ZxSCTz7?= =?us-ascii?Q?vyutgKpBkbz9bkoyHwiZQUWpNMhxBNxGGoNEIiA1u0Yu1oKe2dgKYwa7JEVN?= =?us-ascii?Q?MdiDfa0Ugzd89R8BYGhwnUuhpa0lqD63rZL99L932CiT8afoNWxC1Sz8SH/A?= =?us-ascii?Q?xMe7KnS7+khzlkMP1sc7TFoAGzsnUuikmlK8hFotCnas0ORz/vuUm95mpO0C?= =?us-ascii?Q?Pe6U7fMrfAfAV8pmZFMEoUAa2FBF7RCVHDF5T+jcZeMnbI8hDPF2lSYibQ92?= =?us-ascii?Q?I8pSvY7U8wFg/2h5FaqRozCqJUtwxZWpQD09KeK5hEpETr7G3J9ouiCX2O20?= =?us-ascii?Q?zsIYWSj3hDHfJRlz6DxfUABEPiY8vTDg1IaXuX6ReHZGEWoJxO8kb7rQNqYh?= =?us-ascii?Q?6lwBRxUXOYY++Dk3NukH4enwoDyfB+B/QTGtBn0bz/nOPMMy+6i8kOastbfx?= =?us-ascii?Q?5vNvqkE0YFR2G4caEtrfoL7dOPuKYvJOGDnCwgABI5RcTs634ticXneOB/n1?= =?us-ascii?Q?Ae5K5cTrXgeqSOIckVdA/7W5OyxFuUjaWg1bSUsPBJVLyCVestf43ZSfEkF8?= =?us-ascii?Q?JIhkCmocgzhDYFdU5AH7xsqq1Yed/5JAIsOlwK9cSsWf+vBQJZkl59TsxKB/?= =?us-ascii?Q?X7+H96NzIg7HRYQ38tD9oleYhjYf3EooPIFFnG6Q70G80GX+P92KZ6nk801w?= =?us-ascii?Q?BoE+VKDjtEg3WCd5Ug8LZmAGUIlihNO37Q5ipW0NFSzB7UEHVORyNkHxoEzz?= =?us-ascii?Q?0qNuWB5xShy5pjA1VrVNrsuBFPyd2jBxpyqkBc2Gqgpjv0W6rX3GIsA9EPKn?= =?us-ascii?Q?0xuIMrU1NviEWY92fds+L7oYeMkBMdS10FGaSGriG1h5HKSiiCPf/34FkvxW?= =?us-ascii?Q?dgOYKIeYuTK0HKVsclHSR7z8gDO7BSLsmdndddy0pXuYLhUVx8m21p24fpbM?= =?us-ascii?Q?FzsWHDHoh9/wieQ+7TXMqMQJnJ4WsDf8seNye6QyU08s8Oa6OkzlIFch94+O?= =?us-ascii?Q?yyxVcFOPq12LZovKewaqBDWkckRESa6VY3HuAHXq?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88290db8-f788-4330-f428-08dab0c00537 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Oct 2022 04:19:59.3953 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: D0Qgcin/Gj1YhxSuiFBAmrRHBoxSio9b1hkP28LwQCHV8tDvnhx5mSBdzicpF5JFmL1hc92eJTr0D66jvtN6Fw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5097 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Jiawen Wu > Sent: Friday, October 14, 2022 5:59 PM > To: Nicolau, Radu ; 'Jian Wang' > > Cc: dev@dpdk.org; gakhil@marvell.com > Subject: RE: [PATCH 3/3] net/txgbe: fix security session destroy >=20 > On Thursday, October 13, 2022 8:19 PM, Radu Nicolau wrote: > > Replace mempool_put with memset 0, the internal session memory block > > is no longer allocated from a mempool > > > > Fixes: 3f3fc3308bd0 ("security: remove private mempool usage") > > Cc: gakhil@marvell.com > > > > Signed-off-by: Radu Nicolau > > --- > > drivers/net/txgbe/txgbe_ipsec.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/net/txgbe/txgbe_ipsec.c > > b/drivers/net/txgbe/txgbe_ipsec.c index > > b458b3a922..f9f8108fb8 100644 > > --- a/drivers/net/txgbe/txgbe_ipsec.c > > +++ b/drivers/net/txgbe/txgbe_ipsec.c > > @@ -409,7 +409,6 @@ txgbe_crypto_remove_session(void *device, { > > struct rte_eth_dev *eth_dev =3D device; > > struct txgbe_crypto_session *ic_session =3D > SECURITY_GET_SESS_PRIV(session); > > - struct rte_mempool *mempool =3D > rte_mempool_from_obj(ic_session); > > > > if (eth_dev !=3D ic_session->dev) { > > PMD_DRV_LOG(ERR, "Session not bound to this device\n"); > @@ -421,7 > > +420,7 @@ txgbe_crypto_remove_session(void *device, > > return -EFAULT; > > } > > > > - rte_mempool_put(mempool, (void *)ic_session); > > + memset(ic_session, 0, sizeof(struct txgbe_crypto_session)); > > > > return 0; > > } > > -- > > 2.25.1 > > > > >=20 > Reviewed-by: Jiawen Wu Applied to dpdk-next-net-intel. Thanks Qi