From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0CECC428B3; Mon, 3 Apr 2023 07:39:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 941F140A7E; Mon, 3 Apr 2023 07:39:45 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id AF8B64014F; Mon, 3 Apr 2023 07:39:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680500383; x=1712036383; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=BjRZdBfwzOkeJLPGu82vRNVxmbGsaMIhDQ4nnBV+/A0=; b=bMtAQVSVWwM5pzxujtNibZwRp59gJLQrF2a1MwbAAgztsjxdYYHuQe2I FLAt25PhlfojhQ2VKQLf1C8qB7eJlRAIT5gFZLcHWgttBbwRrXpQ3ELNc xyRqTlSMbmXSo/EcnhwnaaH9+H8nX9ISoLssj2hmdehcFJmQR7nV7tYfe CrK7EsXE5gr/LFaB8ucvJgYaUPUtBApEo2atJvb6Q1uYlTVlYpBYAFEI8 GZrDPPjDcQjDnIx7wjXR05tTJwMoumrnd5wUGzKB5YduTvXjILIvw9HUA zuwPpXir1U46qKw6Y4eIKVnfRB3gLo5YePpoPDRVOrdn/mo7+oZJhFN+3 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10668"; a="369621084" X-IronPort-AV: E=Sophos;i="5.98,314,1673942400"; d="scan'208";a="369621084" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Apr 2023 22:39:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10668"; a="663084038" X-IronPort-AV: E=Sophos;i="5.98,314,1673942400"; d="scan'208";a="663084038" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga006.jf.intel.com with ESMTP; 02 Apr 2023 22:39:40 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Sun, 2 Apr 2023 22:39:40 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Sun, 2 Apr 2023 22:39:40 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Sun, 2 Apr 2023 22:39:40 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Sun, 2 Apr 2023 22:39:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c5Ia6BLjwH3W84WfPJrKDYPLJmLP+uxrCvtUTuU6vcxfPbNMUFmcM1e/+yxqk6D6nq8jnhERW+wxq84GX7vBpKNbrEeqdBdj1XWsd9CflIDyX/57T/lJgysp1Pb01wnwq5yy+ugqXvqdjPkjDzTj598vmTZLRjYlHw2Ft0cMVWgy+uKG3Jp6lBBQPUrcFU0KdyGaWJnFdr6i9aYACC97CCcEPrfWfUQAAnDiecACncCvwOVc+l/RMuOYtyAZQBmBHyuHbIMW75y/J+oZD1Q7SQqepkCdCBhXRWKV51PNQxT+01T1f+Wu2FJ6GSwfTcz36E2orKq/2HL9uzGyDXlN+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BjRZdBfwzOkeJLPGu82vRNVxmbGsaMIhDQ4nnBV+/A0=; b=nR51IkoHWxdn2I/KDaPpmUpyyEIixQ/VHoDfMoLzF5nXMKpsKlv25IRsnGlqshaGpUDnwqPpeuDZKDabpARUffNkioeECCCiRf025LUWfSMV4ztYsDm64Q9RRVwPyfGgaYU66GSB57p2WQHQRKKIt8OtjUX2bsbg/Gdg/IqEHpdLEAsKA4O7pPKy4KhCWZtzv4q97OA/s8EOXwSm3J/dn4BdUPr8K3BzUz4bz7xTVvVU2cktXiv6jUiT2tzfagv5UedDpgK1rMnOyFaOs/B6FLcTUWUL4FoSGN+tvw75VbJRAYHT3ruMRQU7DYLbEtDLnYxMdIM+9Wpow803P+k4nA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by PH7PR11MB7569.namprd11.prod.outlook.com (2603:10b6:510:273::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.28; Mon, 3 Apr 2023 05:39:31 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::c03b:8d85:1c75:7046]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::c03b:8d85:1c75:7046%3]) with mapi id 15.20.6254.030; Mon, 3 Apr 2023 05:39:31 +0000 From: "Zhang, Qi Z" To: "Lu, Wenzhuo" , mschmidt , "dev@dpdk.org" CC: "Richardson, Bruce" , Konstantin Ananyev , "Wu, Jingjing" , "Xing, Beilei" , "Rong, Leyi" , "stable@dpdk.org" Subject: RE: [PATCH] net/iavf: fix VLAN offload with AVX512 Thread-Topic: [PATCH] net/iavf: fix VLAN offload with AVX512 Thread-Index: AQHZYJQgWcZBnlocsUuoK5858o0Ts68Q9AOAgAgoE+A= Date: Mon, 3 Apr 2023 05:39:31 +0000 Message-ID: References: <20230327100750.448859-1-mschmidt@redhat.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|PH7PR11MB7569:EE_ x-ms-office365-filtering-correlation-id: 8f2db295-d0c6-4c02-98a4-08db3405cc97 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fIP2qXAZB6/WI8j0uuj2FkkihWfQI0AmlSKi/j429EaMXyBMIy8umMvmP6M2l//YCEeIpuQ4KBeQR+WWOcBwwA9z89eCQMbQn0ZyTyB8XnZeMIK40Eb36KD79IeFj2aiPx2nMK+E/pUBLRoHxhBjjYtbdpH/YxSGwvqdCN5MiwNn01ksedZdGIa6bcwiaNY0JW585DtfMpeR0tIcLW3K24G5q/9bQ2G29FdISNtj1vGE78EDBw1DYF0k7ayrKnZqHvPcWeGHkFB0QAJwAIz2/jWuM3JnQROkp7BTjzcrzzSoak7jWvTDJ1kArIAWd4Q5/9rraOecU2k8/xZlSbCFx2Ag8X5Gud77tAQ9M2aR1NUtqNTJWCXekP6j34e5+A8lSl6QhBrXyX0swT8yVBEFiKQR3zPPHmAMwiig8F/Mirhhf4t3tjp1BNnR/M84O14QHGYhGoASci7PoNjeIpF+C4a0TNW59tEc2jsiN9QZ5cdNDClAudHUHcaKtHSTjwbOxoEr+RiPW9/wE+pBGdnCw6/qKqb74cc/KeKoDN1ykfvTc+bKXqZ/joxMQii3yhYVlsOKG9HafQH0mmzyKoa0c1/75RPinF1SMWotR2pqQAF4bv02MuGIRa0jX8nCqB3T x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(366004)(396003)(136003)(39860400002)(346002)(376002)(451199021)(86362001)(186003)(66446008)(64756008)(66556008)(66476007)(122000001)(41300700001)(2906002)(82960400001)(33656002)(4326008)(53546011)(8676002)(55016003)(6506007)(26005)(9686003)(71200400001)(7696005)(83380400001)(478600001)(110136005)(54906003)(316002)(38070700005)(8936002)(52536014)(66946007)(76116006)(5660300002)(38100700002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Rj+7n1BvClN2uaqhYokCaelwsdOFvhu6i/EdqUlOplqJejEZ/dV8RA+p/cXk?= =?us-ascii?Q?rInoJhWiNcwrINk1ScgyljwGpk4zryzFwKdgI6JIzuN4K7Ln5mqpsgvvMJpf?= =?us-ascii?Q?ywRuzn4SqcIoSMJRa4AxWDFZ9WapFAD3MWfa9HX7naISg53ubA2t9XYHjAM/?= =?us-ascii?Q?tMada/dhvzVmViiAFYwnronfQriZ7fDvBnAH09U6ph+NynvZsyA6zn8uO3x9?= =?us-ascii?Q?IZHL+/4osneoYgZWn1L2ldtd17eGoigEReceOQ9DIEg6ulc9UAAoXq5FY6g3?= =?us-ascii?Q?kBTdUrtU1T73U2u7J/zwtUleOF9DUtITsCIVSrXbWJdAc+8iQ5UKRn1X0/jN?= =?us-ascii?Q?Tl2d2CcwRbHVnYHyLEUkYqAsJM3cXAamQrWmDbwii9YQ/f1RAy6qf2cl0mfK?= =?us-ascii?Q?4KqaBZD/7QVrf5haqt3FNEHiOgpzufcAdbCLgrRCWcSe1wPxYqOtIpyUawVL?= =?us-ascii?Q?vk3CKol7QmSSOVhmsRqCA339NsDXXPQd6WqSVI1nOOw8NZ4isTxa7mAyAlEb?= =?us-ascii?Q?gSK0hxwRUH5fa61hn+E4TSEfehe1+1GMn9LDL44nEJuk6Uw82eQlaPzzWWr3?= =?us-ascii?Q?krwa36bc5jhK3JS5ZFtnU7cmxY6HpCHkoUWputj9hNqQFBeapzfk+IeDody3?= =?us-ascii?Q?nQmwx/gGGKVTf3DD1pZuxU8/KLA9KjhbibTm4HIOCAsnkKw+HNDzTPFd1eLs?= =?us-ascii?Q?Y4vmIRCf0EkS7WpeTP5ne3tVWlm6kgMdmiUWAq3934of+KYR+/YnWytg8BFz?= =?us-ascii?Q?h8Dh+Mbh/x2basvMk57nYvkGXawXN2SdkzAKW9BdRe6662bPnAkRyOoOenRh?= =?us-ascii?Q?p7WigdRcfPS0bDZJLchDervzu6Niwx0H8mLMhg5sfwkPTBupO9r3nzYy8ZNs?= =?us-ascii?Q?uKkBtpVrv7JGhPI0wLdrUkCPVPp6pCJ6EtyW3QnlM1nCiou3zNRecVH77+qz?= =?us-ascii?Q?hoedzDn2YLJqO1UiCXb1DhUQSHBy3NuMIfDFcgmNmVh89JGuBhM2ebKTRLty?= =?us-ascii?Q?7aLyb1vmY2Fj4FMPZvPFEIrM93/jlfDsQZWENTntXBJHlcbzWWc05S0OO5Zq?= =?us-ascii?Q?ZsnUHj5qY1Eqo3NDA1+hOBr1MKf5/SPaT8AQ13QfRrZsdiY2zz1nbm1ezmQl?= =?us-ascii?Q?sTr0lU/tP6ED+fbkvIiaSVkGzye0eQewVe1uyUE5zia6gWQKI/wg3r9L7l5u?= =?us-ascii?Q?+XlXRHQgOSTKORAuROE7NvRx1Rw0Bzs9ejEjP13Pu7tvq+KU9UL828vqDmAI?= =?us-ascii?Q?jwWUtVWk6RqsOhu/Bm4w0KEM/2seLLmVGO0Xf3/whK2FwWlnwruLogxsPwCE?= =?us-ascii?Q?1rv03zwUjQ+FahZk9/gdfBAGILZdyKd6Fra8kkpp+e0A0zD83GKf4mze33We?= =?us-ascii?Q?Mi8+HYtWhLgZxU1dzvk1KWWUF6ePHgyeiPm7YAnzW4rSlAoIk38oMuysCt14?= =?us-ascii?Q?WB8/mHRuf67Px+Uzhddu1xOOW4irUQ1XTXgq8hQvbWGoZ8gg7PJ2rW00X8Tv?= =?us-ascii?Q?lhsbQYhe4e+a+MPMU2YgOGejAzGj+AZLs7VQDskS4k05DF+mv9WSwpTqK4Hk?= =?us-ascii?Q?v6jxqtv84WZ6Y8f+bPrZnPYDwqKKMwegNQ1280ka?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f2db295-d0c6-4c02-98a4-08db3405cc97 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Apr 2023 05:39:31.4449 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OXanMoaTmCfhQmNsR/HiFySTyuIRRCPVhqvXWLkdCc8HNhfm9DjifIFVXfo5/W7wkuiKtCqdU1TJl1yteLJeEw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7569 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Lu, Wenzhuo > Sent: Wednesday, March 29, 2023 9:06 AM > To: mschmidt ; dev@dpdk.org > Cc: Richardson, Bruce ; Konstantin Ananyev > ; Wu, Jingjing ; > Xing, Beilei ; Rong, Leyi ; > stable@dpdk.org > Subject: RE: [PATCH] net/iavf: fix VLAN offload with AVX512 >=20 >=20 >=20 > > -----Original Message----- > > From: Michal Schmidt > > Sent: Monday, March 27, 2023 6:08 PM > > To: dev@dpdk.org > > Cc: Richardson, Bruce ; Konstantin Ananyev > > ; Wu, Jingjing > > ; Xing, Beilei ; Rong, > > Leyi ; Lu, Wenzhuo ; > > stable@dpdk.org > > Subject: [PATCH] net/iavf: fix VLAN offload with AVX512 > > > > It has been observed that mbufs of some received VLAN packets had the > > VLAN tag correctly set in vlan_tci, but ol_flags were missing the > > VLAN-indicating flags. > > > > _mm256_shuffle_epi8 operates as two independent 128-bit operations, > > not as a single 256-bit operation. To have the RTE_MBUF_F_RX_VLAN* > > flags reflected in the resulting vlan_flags for all 8 rx descriptors, > > the input l2tag2_flags_shuf must contain the required pattern in both 1= 28- > bit halves. > > > > This fix is for the AVX512 Rx path. The same bug in AVX2 was fixed by > > commit > > eb24917428a1 ("net/iavf: fix VLAN offload with AVX2"). > > > > Fixes: 4b64ccb328c9 ("net/iavf: fix VLAN extraction in AVX512 path") > > Cc: stable@dpdk.org > > > > Signed-off-by: Michal Schmidt > Acked-by: Wenzhuo Lu Applied to dpdk-next-net-intel. Thanks Qi