From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Deng, KaiwenX" <kaiwenx.deng@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Zhou, YidingX" <yidingx.zhou@intel.com>,
"Deng, KaiwenX" <kaiwenx.deng@intel.com>,
"Yang, Qiming" <qiming.yang@intel.com>,
"Wu, Wenjun1" <wenjun1.wu@intel.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Dongdong Liu <liudongdong3@huawei.com>
Subject: RE: [PATCH] net/ixgbe: fix error of drop queue index
Date: Tue, 8 Nov 2022 01:07:27 +0000 [thread overview]
Message-ID: <DM4PR11MB59945C4465230872590D051BD73F9@DM4PR11MB5994.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20221107084840.89186-1-kaiwenx.deng@intel.com>
> -----Original Message-----
> From: kevin-intel <kaiwenx.deng@intel.com>
> Sent: Monday, November 7, 2022 4:49 PM
> To: dev@dpdk.org
> Cc: Zhou, YidingX <yidingx.zhou@intel.com>; Deng, KaiwenX
> <kaiwenx.deng@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Wu,
> Wenjun1 <wenjun1.wu@intel.com>; Andrew Rybchenko
> <andrew.rybchenko@oktetlabs.ru>; Dongdong Liu
> <liudongdong3@huawei.com>
> Subject: [PATCH] net/ixgbe: fix error of drop queue index
>
> The drop queue index was not set when adding internal Flow Director
> Configuration copy in ixgbe device private data.
> Therefore dropped packets would be received by queue 0 which is set to
> drop queue.
>
> This commit sets drop queue index as IXGBE_FDIR_DROP_QUEUE to fix this
> issue.
>
> Fixes: 5007ac13189d ("ethdev: remove deprecated Flow Director
> configuration")
>
> Signed-off-by: kevin-intel <kaiwenx.deng@intel.com>
No need to add company name in your signed-off name.
I assume it should be
Kaiwen Deng <kaiwenx.deng@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_flow.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
> index 1250c2dc12..110ff34fcc 100644
> --- a/drivers/net/ixgbe/ixgbe_flow.c
> +++ b/drivers/net/ixgbe/ixgbe_flow.c
> @@ -2759,6 +2759,7 @@ ixgbe_parse_fdir_filter(struct rte_eth_dev *dev,
> int ret;
> struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data-
> >dev_private);
> struct rte_eth_fdir_conf *fdir_conf = IXGBE_DEV_FDIR_CONF(dev);
> + fdir_conf->drop_queue = IXGBE_FDIR_DROP_QUEUE;
The expected drop action is to drop packet, there is NO "drop queue" in the generic flow APIs
if you want to steer packet to queue 0, just use rte_flow_action_queue with queue 0
What's the gap?
>
> if (hw->mac.type != ixgbe_mac_82599EB &&
> hw->mac.type != ixgbe_mac_X540 &&
> --
> 2.34.1
next prev parent reply other threads:[~2022-11-08 1:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 8:48 kevin-intel
2022-11-08 1:07 ` Zhang, Qi Z [this message]
2022-11-11 6:39 ` [PATCH v2] " Kaiwen Deng
2022-11-11 8:56 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR11MB59945C4465230872590D051BD73F9@DM4PR11MB5994.namprd11.prod.outlook.com \
--to=qi.z.zhang@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=kaiwenx.deng@intel.com \
--cc=liudongdong3@huawei.com \
--cc=qiming.yang@intel.com \
--cc=wenjun1.wu@intel.com \
--cc=yidingx.zhou@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).