From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 314C5A00C4; Tue, 8 Nov 2022 02:07:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C89A4400D7; Tue, 8 Nov 2022 02:07:34 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id AAA464003C for ; Tue, 8 Nov 2022 02:07:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667869652; x=1699405652; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=BX6WlnyDksTAGIKRD6ARfOfkwSw/+i4f+yw9groIIFI=; b=FhAqYTnvntUTKy21/PsprEWqqUIml8fFRJ5Sm5yNz+xBYO/dJQH/XcVT yDVvnE15iEAzt+vX1bF+rgxAeFs+90czFfaNPvkH7qQJxbvxjpxMfE779 OVxC3J6sN9SCt4mCO34QbpdjbBbklxQ3yyygzYKDONPg9VwA2c7XR2Krg COhhlmWbwwnDprA97zmc4ZOvNgTsWeJSuKpSWtZX0XsSHddXu/cuqNL9m QrZbEZEsa0HNxQjwl9qsBiknOSSLslSsss1dhrJsNXKhMuos0pUeNeRp0 ZbOJAmmn65mCT+2zgLZRsGKeC6ZBvQGj8ms/e3EMo0kpTBXQE+rxQMX5J A==; X-IronPort-AV: E=McAfee;i="6500,9779,10524"; a="311720441" X-IronPort-AV: E=Sophos;i="5.96,145,1665471600"; d="scan'208";a="311720441" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Nov 2022 17:07:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10524"; a="667391935" X-IronPort-AV: E=Sophos;i="5.96,145,1665471600"; d="scan'208";a="667391935" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga008.jf.intel.com with ESMTP; 07 Nov 2022 17:07:31 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 7 Nov 2022 17:07:31 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 7 Nov 2022 17:07:31 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 7 Nov 2022 17:07:30 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ady135Sf7ROX5TsCbldShhUGEsVQYXIgl89ZMt3MK5mOU0LdsJN+XkqynAlwsn+bvHrJIszikofFPZQruzPNtlfLFtJZE+lbbSgbnS+RB+JBRF7YeM35nLkRU6JwvQIfIIURA6InFH2ZCh0aYzYnFEmd5z2tKVmSnZT+GxdoZ2Tu11zwhBFkd5lH/51KiWdU1dtzmkpImrpDENEdHY7RjnH/YoTz+aDxysE1E7ReTnwHqRTRCBzSIPjdJsrQYdJO+TnKYb+Ynxc2hu1ktm+WhBHh0HrnZAz2XbkxJ0Ctd1609P4hzvsYdDSPsD8gCETkeOCzYt407wcBsm1WQcj67A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x+elWzda0hIgZmzIjP8ZcQel7qTUN+7c0+/WPeEkirc=; b=i47L7PhSJQR6LHSAmwWlhCxuIxiwXSix+jlPwUt+Qdaf2YcSfmNRRfBsGmkUwDlbah5cT/hcy/pFzhSMYeI1CmgqTLZJMR6Bd4pPp/5Qxldni5a5AHfz7R1jXjZ4ekqnOANy7Ofoo0UtDLQNxc029m78Zg14EhIF7waTpbqdtDbo8by2Vuod/x2iTBwjCSVVkK3ItFPD6p10ylZ563mmCxNJp/dTrjBnA7jRkMq44jM5Dmf9RQbaFciQDd1OPQjZDB6p/fR3SYpELBu2DpjC5KvCakktUDDvOBNnwhivW9l7cRAHbQcDXcDUIGDHV9IIiDmsCiRImbfuBO1DcS9eCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by DS0PR11MB7408.namprd11.prod.outlook.com (2603:10b6:8:136::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26; Tue, 8 Nov 2022 01:07:27 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e2ac:cde3:4d74:3fa7]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e2ac:cde3:4d74:3fa7%3]) with mapi id 15.20.5791.025; Tue, 8 Nov 2022 01:07:27 +0000 From: "Zhang, Qi Z" To: "Deng, KaiwenX" , "dev@dpdk.org" CC: "Zhou, YidingX" , "Deng, KaiwenX" , "Yang, Qiming" , "Wu, Wenjun1" , Andrew Rybchenko , Dongdong Liu Subject: RE: [PATCH] net/ixgbe: fix error of drop queue index Thread-Topic: [PATCH] net/ixgbe: fix error of drop queue index Thread-Index: AQHY8onVWQ1PdiBY3U6FKkmOGQq4Hq40Nd5Q Date: Tue, 8 Nov 2022 01:07:27 +0000 Message-ID: References: <20221107084840.89186-1-kaiwenx.deng@intel.com> In-Reply-To: <20221107084840.89186-1-kaiwenx.deng@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|DS0PR11MB7408:EE_ x-ms-office365-filtering-correlation-id: dc858037-f9d6-484d-481d-08dac1259a81 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rbOZsgvZQ9cgCQxnRO1aP14ZGzJ3Mcw5WmedEAFn7BopAnDUdfuG0F7v+Ok1GERXXMTsb59xOZJI7+IVmFcJhxm+xRteHPvHRYk9EcRvWXmHVZTWXh3GOmRLMi//Qr3CaTG0OAP8Fb3LUbIIj6y2Zvp7RMkU1lZP34Z+mWojp2nYnci/b72ovIm//zY1xgyDgqmikpqSytpcxN8/k7MxnJYO3bNRkQukkNo0RP6Lh21UyZmSyJCC8zaqqPAVNCrfUb6jJ3YJQ7RDWNcGSPp7wRd3x1Sq0svJ2zlzzHCAROmkmWRcnT5qt+EMnBwcbLscy5UYlfxEhQ6frr+U1LxhwJ3UnMzX9HiI6HL7XZnYnpqPUUxco5eNc9Nkby5yn7JuXO7ZasELDwPZM9TR+AsiY7zPQM36pMDRIO96ZQXR+vuAZaBHAZXFg97Mha96hZATSy+to2vb+dQClXSbhTXbYcrmLJMCQHuH+L0w9BlSfsTZ/rHNtQT0MrG1HxZMmQl1c0iqhk3iHRPU40kg1DFHV+GlkE7k3cGiNsCFqun5SerMv0GjwAGtFCVC+PFdGU+FGEMudVMZu3JBs7olUPV/YAtQ3/rVBE82VSRoVsIwE4gg3axhRt3DZSdDWtgQP8nbqK4U0EjuY3A5TtaU449h5kLANLV/CY7DnWNHqHvb/eeuWaNdJS40GG9y26Mku6K/plYDL0D6tzH9pZsPmn9XOptV4Uxs/6/96OHftLGi3YbdTp0BBycevYbifzVpXv2bBbihq/A3ncNWsqGv1A6ojBgKJitV4ptaOS9Rcz7lnGU= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(376002)(366004)(136003)(346002)(39860400002)(451199015)(33656002)(66476007)(38070700005)(86362001)(82960400001)(2906002)(52536014)(5660300002)(26005)(9686003)(83380400001)(6506007)(53546011)(38100700002)(7696005)(122000001)(186003)(8676002)(8936002)(66556008)(76116006)(41300700001)(66446008)(316002)(66946007)(4326008)(64756008)(71200400001)(55016003)(54906003)(110136005)(478600001)(290074003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bLdajdjsR3whMyMZEP4ITMkfuqjHa6pdFUo2CZbuigsUULt9l4Vfgm6ggWt3?= =?us-ascii?Q?LL9WadKholfVhbJKXeDvuAVhjPxklzw5PnKP54Hunc8ttmLbib4WsKTbLY0Y?= =?us-ascii?Q?WqDlAoPLDPvnjywDqWFId9DZ810Jg4O3XfpkIdyyXH+stuH8nryiF28xpHmI?= =?us-ascii?Q?KgH2VpM3+zGI7197Imf8SbozZVF+CLNYzEfnthmkGKOvyS49m9Mz1nyIWDtq?= =?us-ascii?Q?xTZw0p7s7mJi7gfUE0F9lozKttoxtPwkE+ZYyJwIMDiHMTaIbULmyZE7nEFq?= =?us-ascii?Q?Ye2INJMJdbpOJc9kv9RiuU10pOR6J63MMGj4KYuqIigrA7GXIR86ZCNVRFDa?= =?us-ascii?Q?m6lGB0KwHxBYWTxEB5/kaNBExr+cvl+FBPXw7hnDEEDJM29Kcc/Ks716Hk+x?= =?us-ascii?Q?g05B/KgrrSeQCIxQxhlZ7STvfTc5miPJLkX2yUQ+a9XaOLKD/bkny0e1EfZC?= =?us-ascii?Q?Bh6BU3RYDIN33y2LKNsW9kEW2Z5pAsAR+Dyr8VScYMLQrZO0rqfTaVZDKKl6?= =?us-ascii?Q?pXDWbmlb2xef1S2EtunayMjl+BCHHOttaRGgz0grKW1kByPHJTf0+dBNHWXY?= =?us-ascii?Q?nmIUXFwsJyWVsJfB+MdqVbYbkXNwM1oJz9bnh1A3t57XRTHq3lEh8dbhH2Ok?= =?us-ascii?Q?bZtg+Ys0Z8MB6oSDNXY6Y0ogBQaePVX/uX4tXmYFniow42uBAJPlnSOs3sq6?= =?us-ascii?Q?Q9t5IdeR8+7w3IiaSKbShzo5l9/4RcMr/RAswOOKEC9WjY8gQafFNMKI9Cen?= =?us-ascii?Q?ggDRYb9rjmE7eNIEjIzSVJ8Ijq7GyK4V1ENbyG0uts6pPetdCvsWhmV3OkY2?= =?us-ascii?Q?sjwQgCON2flOOj5D20qNcGu5ylpXcl4f7UjaVSKHKL9XZBCYdObMZ3KTtJ+w?= =?us-ascii?Q?Ly9nA5gZpgdrHrFwBv5yxa5xwmRsYiHcHyXU3vYkkTM3H2Y0y7s1MhqzNnWS?= =?us-ascii?Q?VAKQuAO+6xDL4J5XuyBNwExKkcCw0cgXfcZTGUCkr5E7Url1F9nSxTlFjAM3?= =?us-ascii?Q?zmczKWU1MvG7k3zHLy0gy7rhkCusQXUBwK0wvRdoNmOyJsWEAw2SoDLyGWSN?= =?us-ascii?Q?b4mgBFqMDsakzu2kwEDccAmeqXS/GYfaFZJfVTzz4JgrKzgwDhuxtn5HW/7T?= =?us-ascii?Q?BhZNU04nn3VDCAK9JNYTv1szGAJhWpqonKCJFI4cjws62yOvScjy+u/kUaSs?= =?us-ascii?Q?vi9A92N8cAqInZ8aM5A90KueDrg0cTlffSjPybzGPHfXcmY3IjxEqad+f146?= =?us-ascii?Q?wVKLfN160a3UlceS7+m8kSYZ4zGd4O6qbAIQiYYNFbzGMiZMRhslgpiId1WA?= =?us-ascii?Q?gF/UeX95GGDcL4YjtZ4Dke8JbrhJgXdryz02vbDhRLuFvsnoPCJmq3eapxcX?= =?us-ascii?Q?c/z2lypQhgj+oXtKJQ81sMVol3nOMvvVCEnx5MXifRm8+KALGQd28M7gK4+8?= =?us-ascii?Q?fuDwznK3mOtBMqwJCSKhiLpFsYECD8Qxxda/863gzqydvg2Z/h22mM5ZfTrG?= =?us-ascii?Q?8uqFAMbQRoqd08NUy5yBeYq6TT2BeK6B9syrEdepVkPx54AqSYdRnnev4aNO?= =?us-ascii?Q?LZqxeRVX3JrB260Dw7tUtQh0Zfq3CdQRJUJZBcAt?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dc858037-f9d6-484d-481d-08dac1259a81 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2022 01:07:27.5992 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZAPR7GNZ+zgvy0cNiaH6I+NrkeSqbtv3gMArWrjkbrkLnv2jH1Rkt+K3NBCgfankrwDrdxNsW1UrWmkZp3Zm5Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7408 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: kevin-intel > Sent: Monday, November 7, 2022 4:49 PM > To: dev@dpdk.org > Cc: Zhou, YidingX ; Deng, KaiwenX > ; Yang, Qiming ; Wu, > Wenjun1 ; Andrew Rybchenko > ; Dongdong Liu > > Subject: [PATCH] net/ixgbe: fix error of drop queue index >=20 > The drop queue index was not set when adding internal Flow Director > Configuration copy in ixgbe device private data. > Therefore dropped packets would be received by queue 0 which is set to > drop queue. >=20 > This commit sets drop queue index as IXGBE_FDIR_DROP_QUEUE to fix this > issue. >=20 > Fixes: 5007ac13189d ("ethdev: remove deprecated Flow Director > configuration") >=20 > Signed-off-by: kevin-intel No need to add company name in your signed-off name. I assume it should be=20 Kaiwen Deng > --- > drivers/net/ixgbe/ixgbe_flow.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flo= w.c > index 1250c2dc12..110ff34fcc 100644 > --- a/drivers/net/ixgbe/ixgbe_flow.c > +++ b/drivers/net/ixgbe/ixgbe_flow.c > @@ -2759,6 +2759,7 @@ ixgbe_parse_fdir_filter(struct rte_eth_dev *dev, > int ret; > struct ixgbe_hw *hw =3D IXGBE_DEV_PRIVATE_TO_HW(dev->data- > >dev_private); > struct rte_eth_fdir_conf *fdir_conf =3D IXGBE_DEV_FDIR_CONF(dev); > + fdir_conf->drop_queue =3D IXGBE_FDIR_DROP_QUEUE; The expected drop action is to drop packet, there is NO "drop queue" in the= generic flow APIs if you want to steer packet to queue 0, just use rte_flow_action_queue with= queue 0 What's the gap? >=20 > if (hw->mac.type !=3D ixgbe_mac_82599EB && > hw->mac.type !=3D ixgbe_mac_X540 && > -- > 2.34.1