From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3F0A4A04FF; Tue, 24 May 2022 15:42:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2607040140; Tue, 24 May 2022 15:42:19 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 9479D400D6 for ; Tue, 24 May 2022 15:42:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653399737; x=1684935737; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=UarQr2SQr5oS8Zr9tyzdkQ45e6qzyGdyql0Q5fL5cHI=; b=mqMClBbPaQ8y6MBtXLSfP0GowXXbugWZroOB00CYwuBAbJXnqsneIi9K vsWocluQIAKIQQTFQL9cvinFFKnGCSPsqwn4VczbkVpR/rnOWM30xv1QL HhG5YB+yZnJ8DgHDQIbgBGkA/nybzaW6r96mr2yJMOQZnym96ByIehwaC lhAfIMDh20uueFe1i9wPhJ+Zy4OLU4B2CkNC3VN3SGzDB/oiu34ZCBaNF ya5SsDigYMGm6/047dhU6mnIaDU2S59uql4g9lXo9w3/ncR6TAqq0SeI5 PuC0AdTdyHMGYTsdV+kGIl+xXz749G2H3w8dw+ch47Oz2TQIXr9t4JpdC A==; X-IronPort-AV: E=McAfee;i="6400,9594,10356"; a="254032206" X-IronPort-AV: E=Sophos;i="5.91,248,1647327600"; d="scan'208";a="254032206" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2022 06:42:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,248,1647327600"; d="scan'208";a="577891816" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga007.fm.intel.com with ESMTP; 24 May 2022 06:42:16 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 24 May 2022 06:42:16 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 24 May 2022 06:42:16 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 24 May 2022 06:42:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bMRwDbwWy55ZQ+6g6Vlo6V+25kAHH8jkCplkk6jekjvy5Uz0PwegnTOadcuw7z46I4v7A8tCCPVTnH/J781vHJtjOeIVJyXg9wC2CYGi5T0a6FTgnP37Ldieke4QgxiF7V/5gkGN1R/8SxHtWNtOEF65mVDHmNpfqmh782NWsxfWH+A12vZeuLKwJPg5EW47T6qPxff5dZs2EZIcIdcGvpHSd2cdZDjUgwPteyu1goCDciH5IBsoKfzrlKDY1UUG5fCVSDmR7uZQud5nmzQ57GOHwBe3DpHAYmruz0RJIfPdG5fstSULgxrpxANLstTH0CDvYSUT49gm8cGdUhliMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f+Gp7GM8YHX5PVBKQwqH9lAxPL5TGAJ2sPzqpeQUlFY=; b=Ci4m0ha60xDBTLgdZI+XoXc4Z6itRhhicnHnz+UqOG+IvMIkBFrjQVbBBFBqxGaGaaPIYXNW+RMCAcTkbYVmWV9JsGpXwclUogbfTN3jbfdOdIPRoDgcZvAK2asdY2U+vKwUCdwjT1l6W9wrfJg2DJutiRoYNkeJFuWBAIITnJBQymEDAuNcXcYdYJIJzj/nL7JdG5vxHXCwR9JHD0B1X25xIAfjZhTMM3Ys4TDrdObcOTO0MFDNV5crOgLcpN1cNKLvRFHJNiy+Dp34D5GYSE321/PpjjZkvK/Nbd8fpbg/B8AXEPj3DLkwde0VsIC4Jv1P4bgZH+NzA83c4EjPwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by DM6PR11MB3785.namprd11.prod.outlook.com (2603:10b6:5:13f::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Tue, 24 May 2022 13:42:13 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::b4f6:f68:2e31:ddf7]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::b4f6:f68:2e31:ddf7%8]) with mapi id 15.20.5293.013; Tue, 24 May 2022 13:42:13 +0000 From: "Zhang, Qi Z" To: Thomas Monjalon CC: "Daly, Jeff" , "dev@dpdk.org" , "Wang, Haiyue" , "ferruh.yigit@amd.com" , "andrew.rybchenko@oktetlabs.ru" , "Richardson, Bruce" Subject: RE: [PATCH v2] ixgbe/base: Manual AN-37 for troublesome link partners for X550 SFI Thread-Topic: [PATCH v2] ixgbe/base: Manual AN-37 for troublesome link partners for X550 SFI Thread-Index: AQHYOWgI/FvuTNVQ3E+3m88sjeNJdq0kIZXQgAohkwCAAAM7wA== Date: Tue, 24 May 2022 13:42:13 +0000 Message-ID: References: <20220316181544.7251-1-jeffd@silicom-usa.com> <20220316185917.4448-1-jeffd@silicom-usa.com> <11811318.eQLIkvUDd3@thomas> In-Reply-To: <11811318.eQLIkvUDd3@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3098e642-4dbd-47e4-01c0-08da3d8b3590 x-ms-traffictypediagnostic: DM6PR11MB3785:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: I+XFyRyzbNuqOJtAAAO+M4/IW3W1bT/ysGUnccGq1vihG+7jxvqiL0nPJ+1TX4/Y7XKR2j8uxA+K684uz8+EC+vTskV+xqYAWv0P1tcx267L6Opn1GVHcS1DOlbw69VHD1LuE1uyBkfOOnjAn85LgHxTHyKrnqgyYjXrp6lOJ158fdXOWjjiC0K0nJdQQBhwQzwYafQFDCUk4GeESOzV3nvwJW8eMT7ZMPiaur4Q935A/nUkWpiu18Bf4OzjRp5cJWUEK3D0p+UsJWzzB/IuVbxVzXGO40ZPFQJ78oeNbo/QwVb769eX3s87bENbvHlQ1TgvbZ5eP8uCDUV3KCOdDKFW3k9Y77tGiTKHGiAUM9YxZ6a2kIKBwdrgZ5uLeUxoZhHOeHgJrbqxZCoMOIfiHLfIR2Htb0xGCoo1J2O7/8/Rqc7BJJObrlV8E38nX7PDFh390t2+u3V4IkWpU5RSXhOf+eIJrAQBMCaB3/vs6niRYtmTWrdaqh2+5JCZOArwzeA0RQn0OALpXh/73pO0TyJdZY673bjOXK2nxmESLFNDRvANxAycF02i/FxgOvfoPWZLI50yoxSmlfRQdYWUGaMi44LfNbel4Do5YozwP4L1v6/coQW7xPLWX4OsBZv5RdPt0r/NEAMzdLiP9z8InFxRNFsyCiDmzCGFcjkAfnWzEPGRdiCEJLKNkDY6ZlZKwRJZW7lFEb4yKu4C99v4lwCZf43APEgh9SDxSfX8+Bd3HKpsxw+ZgqbZlUfFjKB2 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6506007)(7696005)(66476007)(55016003)(9686003)(26005)(4326008)(66556008)(66946007)(64756008)(66446008)(8676002)(76116006)(52536014)(508600001)(86362001)(82960400001)(71200400001)(5660300002)(33656002)(83380400001)(122000001)(2906002)(8936002)(316002)(38100700002)(107886003)(38070700005)(186003)(53546011)(6916009)(54906003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lpgHDMee2uPJ9u0N6S13hBWv81nppBWMcRGXaFp1uXPMV3Usig60IK6YbWMe?= =?us-ascii?Q?kDvyGR1nbP45T13eUIPMDSuRNR+z18tNfTFEWhLAHCaeZhlvgb5QUyGXyVfb?= =?us-ascii?Q?O9cRS4DBVaaTCU//gnIEwS6Lj0PO1SeE4qYQO3ZqXreXp13vQvwpC7GBl80R?= =?us-ascii?Q?xte8QPJ3tuWHNoBcKc9NQ6N9WSwwBlTAiIub7yuxeq4ew9vE3iiYYzBWiK9I?= =?us-ascii?Q?FuaKb+ByK6ulXtbuYVFYi+QS5k+GqH8R0eskQtZUincyZmQWA6AA3oZeqM/A?= =?us-ascii?Q?HvOGzoyIVAbcn64rGzgDUmqjUzJLP8UqYdXDGuF4hbzDZrjlN77QO0xF1U5i?= =?us-ascii?Q?tiD8BqqD+zSazyWg2t3IP5GRMMF4bC7qNSrY67pVsBDovTdhlHpb0RyS0dyW?= =?us-ascii?Q?p4TOMNqlwv5+MN4MeofyzMCEyD3+GFh1WSVohcw8k62fJQWt1d8Ss+efZ80u?= =?us-ascii?Q?KbENwvASRtZ1C3iFJk8r5GVGnRICuE3oRbSXr69wjSWqgOpkNf2mu/ku3WXV?= =?us-ascii?Q?vS+Jwbhnp8tDTC/gb68g0yAHelbnArpyVn2GD1ZBqENODgUMPxszQrUNuGIn?= =?us-ascii?Q?3nh1B5bvxyYVmtIFCItiV1sCgUwzE50ZmSEPROSdPCg2FvmfMfdsvwpOe12R?= =?us-ascii?Q?wSuHg0VoGn39A24cnt6VG0qWwauyF9owIYVrScyUvpdnoOsVpJiMQHkQz8VZ?= =?us-ascii?Q?c5vztM2iQIiozKG3wHxbC6HL3uzIsDbCKetz8aYz4Jc7dkbF7AAf9SQtbERF?= =?us-ascii?Q?x2ZipTZaCKhvE6R9yuMduIr+ZJLn3tU4+AY/JFsjZHGluGdrfIMCF/Sy6lcB?= =?us-ascii?Q?zlTwNqPhAi6ZSehpZGWelAhRZXHNBXfHM9fAbr+N6na1LBMo4r2FfrxzVvsG?= =?us-ascii?Q?tfIyeRPedpUD3bIQ1PYH2Sfp27C4Zb43HMHXRk/pEl9lxq6Yc8o8II+MZCvW?= =?us-ascii?Q?9j+/A9aPIMLcaPLPIgYnfq1Byw2dYjHzz9eyCgr670njnb3gizPQPAeepZFP?= =?us-ascii?Q?IsO932Y6qEOvwGGDc+34a6gKSZbVB93zn2KLJu9+lBFa+ShcUdxlQtn3H/CD?= =?us-ascii?Q?TLXDKjS39IdMS+2IT6QrhjE92IGQGmtKljizviDFDIrKAiX5n18k+1li4kNR?= =?us-ascii?Q?dhOadXWQ5YbbvSyA5VP2/9H4iVuLqULMutmHWQLnDEWWRG9mpSg4r/y5aqwW?= =?us-ascii?Q?e1HVfLJovTbxQ1ObXM7cqOhBJeLW5wdvEhw4CbreiVYe7vlI1RegG2EwAQKS?= =?us-ascii?Q?koJTBJgkYmHWd5DjPQXv76fR8kpamfxI+eiLFTQF/CxfAiZf0qhiWFkfvWOh?= =?us-ascii?Q?wLXoQBbOHbVJjqPpOmipyvKrN4NdTn8ijeSfONRrIQzDx3041N27hf6rAygj?= =?us-ascii?Q?NLayX6nL1tnDm8Xgb4c64DsqtrZ/xbul2BimbwPp63bSJyuThcq6Iv07e59F?= =?us-ascii?Q?Xs6Fd3RCJir1Yd6sZg99/sb2fMhjjifqplsg61JNIAvq+QU2PWOUIR/k7AXO?= =?us-ascii?Q?/oOFMNJn2vlAxnx8YwhSo63dzjt/CwHAsVLcVjt82LRi21Jp3DqPvwq9MmfQ?= =?us-ascii?Q?Up7ZEpDh2ksiUrabPVubMtUzn6PFnitZHzI0s0YjTbT7JfGBi6mxuLTHHAcX?= =?us-ascii?Q?vCI5klwkAgd627iUztdLpCrHWuEYdtDjUWt8da9imy5RdsnaDn8TerTQU6nf?= =?us-ascii?Q?wU3A9ueOuQgi9CWhF6A2NJgrI5RSx7jBNvnuPiFxu+fIzQVI86ETMIE3KxkP?= =?us-ascii?Q?efG0eAAJ0A=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3098e642-4dbd-47e4-01c0-08da3d8b3590 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2022 13:42:13.4666 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aRRhwZrw0z2AM6p0R0IveZw8JRWtSUJAqa1kNON9aGgGT3JUNYnogA183cTUj8rk3WBiuJJ7oVXYjvYedn09dw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3785 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Tuesday, May 24, 2022 6:43 PM > To: Zhang, Qi Z > Cc: Daly, Jeff ; dev@dpdk.org; Wang, Haiyue > ; ferruh.yigit@amd.com; > andrew.rybchenko@oktetlabs.ru; Richardson, Bruce > > Subject: Re: [PATCH v2] ixgbe/base: Manual AN-37 for troublesome link > partners for X550 SFI >=20 > 18/05/2022 02:03, Zhang, Qi Z: > > From: Jeff Daly > > > > > > Some SFP link partners exhibit a disinclination to autonegotiate > > > with X550 configured in SFI mode. This patch enables a manual AN-37 > > > restart to work around the problem. > > > > This fix for some specific hardware in base code, unfortunately Intel > > DPDK team don't have the device and the knowledge to approve this, >=20 > That's why the work is collaborative. > You should get and trust knowledge from partners. > The only concerns of a maintainer should be: > - good feature design > - good code quality These are the questions we can't answer, we don't understand the design, w= hat is " change mode enforcement rules to hybrid " means, what is manual A= N-37 here and what those numbers in the patch means. Of cause we trust knowledge from our partners, but anyway this is an Intel = product, only Intel have the right to authenticate this. unfortunately none= of the active ixgbe DPDK maintainers and I have the knowledge Meanwhile if this is an issue on DPDK, it could also be an issue on kernel = driver that's why we suggest to submit to Linux community first where will = be right people to answer above questions. > - no regression in known cases >=20 > > the base code is delivered by our kernel software team, I will suggest > > you can send this to the kernel community to get the right expert to > > review. >=20 > Which kind of expert do you imagine to review? > Intel team or Silicom people who are pushing these improvements? >=20 > There is another problem with asking Linux kernel change first: > the patch will land in GPL code, bringing difficulties to move in BSD-lic= ensed > base code. Only if the author agree to share the copy right to Intel, so Intel is able= to re-license it to BSD as same as other base code. >=20 > I suggest we make this process more flexible: > 1/ a contributor sends a patch for DPDK base code > with an explicit grant for backporting in any license. > 2/ Intel checks that there is no DPDK regression > 3/ patch is merged in DPDK > 4/ Intel merges it in the internal base code > 5/ Linux kernel team can backport the fix to Linux > 6/ Any other OS can backport the fix in its driver Right now, our base code in kernel is GPL license only, code with BSD-3-cl= ause can't be distrusted without change our license strategy,=20 so it's the same effort if someone want to backport DPDK changes to kernel = ( shared the copy right to Intel) but I like your suggestion (if I understand correctly), have a dual license= s in kernel base code make things smoothly to backport from DPDK to kernel,= I will feedback this. >=20 > Let's make the DPDK process open for everybody. For sure, we should. >=20