From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 800D54236A; Thu, 12 Oct 2023 03:24:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0ECF2402BA; Thu, 12 Oct 2023 03:24:37 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id A8A1B40279 for ; Thu, 12 Oct 2023 03:24:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697073874; x=1728609874; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Iwlh/fmiMTacAURViHf8h5MEGWA/P+RsuCKDpnTDgVw=; b=DthfyVZ+xx1BzNJM2JvDv7wS3Fn22ibvycth/cJqIC5otDrrFlB2aFBv 29V81PXcMJgRjQpL4NbzSgmx2bg+IiKjN1TYoffvGDHdP9BWRHhUCPdZ8 +mAdL9DrCf3gxKYr6ZJfkwsIuOWcRXF+fWhbUmljOXUA4N57hmqLU5peH fx8rbuTnmjZEhmk6pS9Wc0f7J9hOmG4tBK2cMRZBOM2UFzonhwSj5uM/Z hwQYVEEH511JTioruEZA8rFAafGGmFGjmOG7bq3qyki5MjQsG4vwTwnHk rgQMIRKx20cnnY3/JBwYPgFsFznZ1nn3o7xHV6tROXJLArpTA8GCD1EGz w==; X-IronPort-AV: E=McAfee;i="6600,9927,10860"; a="449000698" X-IronPort-AV: E=Sophos;i="6.03,217,1694761200"; d="scan'208";a="449000698" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2023 18:24:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10860"; a="703962738" X-IronPort-AV: E=Sophos;i="6.03,217,1694761200"; d="scan'208";a="703962738" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 11 Oct 2023 18:24:32 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Wed, 11 Oct 2023 18:24:32 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Wed, 11 Oct 2023 18:24:31 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Wed, 11 Oct 2023 18:24:31 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Wed, 11 Oct 2023 18:24:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mIe6su/Q7OeSKQVoL74YruQV8PmNMSLZMr0Xs26wXyr+8ZovcdW44oQBhbwVu8Wh3uoh13zIi0RF7YpExu5g0Ks2xPTo+MsqJLDJKyTQBnO0qwOv2wlDBDBcrHmsu0GnkrXJ4HxVc8Fxx2vD/b9oEcvxG8/+XCHySsmW/N3iAguiJ9D4Utlk65vMLlmDoHAbMT0nk9Cq079IfSZvEKuby39GSu4V/wQIttOsLHR6ybw8RYExOsQbftguFvpasew7f1WoQzbJLu5SaUTO3Y6NsCaJ6AlTkNmrZdjejosdBL88gr06AwhKVhEReVwSLSAK6Ypr/b67ynNyZW8+RquPsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LfmRsk2Bnph+BQizSqWPi0n065TXT5A4SNiEdzWcZrs=; b=hNYWDKlQ88idMEsAbmLO3o2VnjvjiI3lyKX8GeGeF6Dx6zNVGFaLR0LKRbXFW7FkOC/xJ194+OiLMD54T9axJ5RP5vK+XgU8Tn5Kqm/RncLzozpjvmnNPinhMtnR+CsPp3SPawKifLZZ81XIpOE7Ej8spdQUmOnfRH9TFUTf57No4tLonMMaXMsXMcASUes0vqlfQ+NHYqI2cHULe6IZm6R514fmKtFpMUS2WKCRtwdAOkleQ5xPo5tz2QXLn5Yat8mzdCbeajEtNl3UhhWaOvNEiOP5qwZi/xsSBCRbWZAxLjK7GaaZ5GfbG6I0yu43hI1VZWvsnZj1eQMvsJuhDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by CH3PR11MB8494.namprd11.prod.outlook.com (2603:10b6:610:1ae::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.43; Thu, 12 Oct 2023 01:24:24 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::27ea:67e:2966:23e3]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::27ea:67e:2966:23e3%3]) with mapi id 15.20.6863.032; Thu, 12 Oct 2023 01:24:24 +0000 From: "Zhang, Qi Z" To: "Xing, Beilei" , "Wu, Jingjing" CC: "dev@dpdk.org" , "Xing, Beilei" Subject: RE: [PATCH] net/cpfl: reset devargs during the first probe Thread-Topic: [PATCH] net/cpfl: reset devargs during the first probe Thread-Index: AQHZ/BzLbCwa+tU5HkmgTcHXKHqWuLBFXRtA Date: Thu, 12 Oct 2023 01:24:24 +0000 Message-ID: References: <20231011164720.418246-1-beilei.xing@intel.com> In-Reply-To: <20231011164720.418246-1-beilei.xing@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|CH3PR11MB8494:EE_ x-ms-office365-filtering-correlation-id: 58ddc548-94c1-46da-aa81-08dbcac1f805 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KNhfmaC5Xy46+AgBqJtuHZ9ok6QPz+K6Owf1UIXaURkQPrszs94hPOIddWGuwXxJczITm4/W94JdEjhAOH9GtEmImxWscXBzPn1ngImx2FypboOO++4amd39+uBNXNCe38oy7ULHwc+yYiaxSyVZMYFP+xUmS8YafHaYxiHRCRij3Idr+gUghGbU3o0NtJaa8H9+LLpgJRTimwne9a+imOCrwpfjqSeEsg+7XwqXPNPBcoXRaiabeM7Uq4je1yREsZGCn2E3APSz73D96WZOIug3CMPi/psPp3zWdeZDR+m5sef3Mjzke3BVD7W6iHpZ5BG8HjPWTqdfGkSYtybYw32rQmXdxnQ0bbOdD7rAsOrPn1ShpUHtbtli28yZunJtbI9hMa1/7nNFrqQw34JSZ5kWDLhuhCrWU7lr3GHyWbiQeq2MsECQ9sVauEF2zA+gJr0WsonPsISh3BLbYQev5hycG6aKq1IB+Rg5zkU1BXFqw9+/VKWTqq/4XN8OeQ6Z5FF1qX6BE0dlp+Ptr3K1PIMtKOCyXQ1KcMqc1VVKxpdXMV81fB6HV+gFRgS0uq457VkriZv1c+LKudr+CDy+FnmshC1E8MHjKfbpF6zdGCFK3Pigot91/uN/FY6MQa9i x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(39860400002)(396003)(136003)(366004)(376002)(230922051799003)(64100799003)(1800799009)(186009)(451199024)(6636002)(38100700002)(38070700005)(110136005)(86362001)(66476007)(316002)(66446008)(41300700001)(66556008)(54906003)(64756008)(33656002)(55016003)(26005)(8676002)(8936002)(4326008)(52536014)(5660300002)(71200400001)(82960400001)(122000001)(478600001)(76116006)(66946007)(6506007)(7696005)(53546011)(2906002)(9686003)(107886003)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?U+K42tMxOIVJNwASaGwx4HvRVieuSU0omHhlfsgJ0ML0IavvOe/z9W3VgThB?= =?us-ascii?Q?MlphVnfzi3ze9QJ40RblAcVRIESUTdY4HbHi62mywfLnj7hBDD6lbO9eoruR?= =?us-ascii?Q?/o1hgH3RgI++vNjpgDxWGySvhTpPXCQEBuIP5CvKUetHLU2faMulTE6QFHz/?= =?us-ascii?Q?Ckr7Bn61fIfH9IZcN1/gjV/MoYotrCI5ZKlULh9h8SsMexf+DmSApWRln5XV?= =?us-ascii?Q?JigAJiTImHqCqFXPyby+VaLv10AIhmuw/89KSbyXWCL/5aL9NfukS4BfJWfs?= =?us-ascii?Q?moBrvDA/aegPYEAgCddSnectuSqHjWSMFjzVkzTdWooNtexR65hDueYart8W?= =?us-ascii?Q?5oBFM+HFwBOGzhEH9iaDuNYvQvgO8o/MNRP09o41BydevNftnNpuDLvN1qTl?= =?us-ascii?Q?aoWtD1/ICa0NLsmBd9ij0SGI2JqA54SkBQSycVPleCxUIr6lNsnsP7N/rBXu?= =?us-ascii?Q?d6luWIrAXXsV8PGSFzHSiGfRxSGQXMsHtaCzy6SnAPwhCLs62mTqtcSz2Q4l?= =?us-ascii?Q?zSfjf9WD7bfdVPoQ7Q3vlQDD+6ZnmVwn6UvtRGYh4RujBLKu/Xt802ueOeMq?= =?us-ascii?Q?pU08IMW3BDCR2F466amvl0xbLo0dgDiLBuHZnJHz+Vv+rwHnYhw/EHzvoMwz?= =?us-ascii?Q?ll/VlQYeMsFCBoPu9XRgzKLubiVGihnfyg5FKlX+agtCKeyIkaDoYXg8tHPk?= =?us-ascii?Q?CkT4U3Q8Hsx4JAnyqaIUvxC/JYDIFtLWTw+FRBbHsFTkZyrIo3VpOSGwv0na?= =?us-ascii?Q?wivASTV0yuwQx7KPkTjxIVL+4tLglITyYizXwzq9JOIJsZjJ9HSFuk4+90jd?= =?us-ascii?Q?/ogQ6uVtGePefIz/KbAaFAehhkFXK7yJqTT9XplV/mkM8U+BXvRGljJiPEeb?= =?us-ascii?Q?2rPUYhK1PXoeJlnZjIVenr8t2ITMt+w5ncRT0OROCVzF+kKPO+CM37ozn4Gw?= =?us-ascii?Q?4pMxFw2ODDPpcCtDC2QPLQjy2j3AAh1ssQ9qkF364d439/oGWaDBvNdJAKT7?= =?us-ascii?Q?tepZfmQEAT3FJLsiXVx/eG7wQHX+Y2EXas0tS41OZ/H7t6e2PWfXvwaqri25?= =?us-ascii?Q?dpyHykAMXSWog6cudNJ0PkCnlKq9F2P689GVho5tdzJkarZSbEQWRAo6nCqb?= =?us-ascii?Q?wSTBd2xVhFjQVUTAOxfx/agPqVxEf5EufLesMVWjnlMvmELaABRAWFjd5qZy?= =?us-ascii?Q?xCG/oZ3TK5eMP51LPgjUi7qiq+JlWocZzGMoRbK8rDG/AbLnaXDI+YSUesHY?= =?us-ascii?Q?b2XcYfHn3TAnIOcY3KSvcXWvDZcwPQsQIQzhxluDjMkKUBTPx6og5/GU3C1X?= =?us-ascii?Q?P1QTQ5b8ZtIf6FmwIH4tBj0shUNzVcPSpa3PBk2dObeWUEzwTO6v/qExRiKX?= =?us-ascii?Q?Ht8qnmcN0tFsm7zKJkOQv/3UzkeM4fbIHPrVvv6UueLBAW9Zhg24SG0MP3Xm?= =?us-ascii?Q?rq7nlFbRbCte3Wzz+QrgGGAZWinr81AsqpOGaXTrdDHnyAhC9aM1bcV9pTMH?= =?us-ascii?Q?W9eCo9xKBWDdeJ3JnTs9cmPJoMvvsm0ZEIvzXcvUbfWtyiyiHI6gVEU9WbzV?= =?us-ascii?Q?+us+GAAwrmZ7/SAKW6lQdRI6EB0aTm7Wpe1gVrSA?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 58ddc548-94c1-46da-aa81-08dbcac1f805 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2023 01:24:24.1496 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wcNCEPhABFMLWpnmNCV/gNnd8L32jcT98eIDr/13hs+mquOH6zY4XpSHldY4xvG11+lFQQfLZuhvM0SDs5DXBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8494 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: beilei.xing@intel.com > Sent: Thursday, October 12, 2023 12:47 AM > To: Wu, Jingjing > Cc: dev@dpdk.org; Xing, Beilei > Subject: [PATCH] net/cpfl: reset devargs during the first probe >=20 > From: Beilei Xing >=20 > Reset devargs during the first probe. Otherwise, probe again will be affe= cted. >=20 > Fixes: a607312291b3 ("net/cpfl: support probe again") >=20 > Signed-off-by: Beilei Xing > --- > drivers/net/cpfl/cpfl_ethdev.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethde= v.c > index 762fbddfe6..890a027a1d 100644 > --- a/drivers/net/cpfl/cpfl_ethdev.c > +++ b/drivers/net/cpfl/cpfl_ethdev.c > @@ -1611,11 +1611,12 @@ cpfl_parse_devargs(struct rte_pci_device > *pci_dev, struct cpfl_adapter_ext *adap > struct rte_kvargs *kvlist; > int ret; >=20 > - cpfl_args->req_vport_nb =3D 0; > - > if (devargs =3D=3D NULL) > return 0; >=20 > + if (first) > + memset(cpfl_args, 0, sizeof(struct cpfl_devargs)); > + > kvlist =3D rte_kvargs_parse(devargs->args, > first ? cpfl_valid_args_first : cpfl_valid_args_again); > if (kvlist =3D=3D NULL) { > @@ -1628,7 +1629,6 @@ cpfl_parse_devargs(struct rte_pci_device *pci_dev, > struct cpfl_adapter_ext *adap > return -EINVAL; > } >=20 > - cpfl_args->repr_args_num =3D 0; > ret =3D rte_kvargs_process(kvlist, CPFL_REPRESENTOR, &parse_repr, > cpfl_args); >=20 > if (ret !=3D 0) > -- > 2.34.1 Acked-by: Qi Zhang As the target patch has not been merged into main stream, squashed this pat= ch in dpdk-next-net-intel. Thanks Qi