* [PATCH] net/iavf: eth pattern support smac and dmac match @ 2022-07-24 15:07 Dexia Li 2022-07-24 23:37 ` Zhang, Qi Z 0 siblings, 1 reply; 4+ messages in thread From: Dexia Li @ 2022-07-24 15:07 UTC (permalink / raw) To: dev; +Cc: Dexia Li Position src and dst mac bit in iavf fdir eth inset, thus eth pattern can support src and dst mac match. Signed-off-by: Dexia Li <dexia.li@jaguarmicro.com> --- drivers/net/iavf/iavf_fdir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/iavf/iavf_fdir.c b/drivers/net/iavf/iavf_fdir.c index 4789d46ab2..2e6b3a9097 100644 --- a/drivers/net/iavf/iavf_fdir.c +++ b/drivers/net/iavf/iavf_fdir.c @@ -29,7 +29,7 @@ #define IAVF_GTPU_EH_UPLINK 1 #define IAVF_FDIR_INSET_ETH (\ - IAVF_INSET_ETHERTYPE) + IAVF_INSET_DMAC | IAVF_INSET_SMAC | IAVF_INSET_ETHERTYPE) #define IAVF_FDIR_INSET_ETH_IPV4 (\ IAVF_INSET_IPV4_SRC | IAVF_INSET_IPV4_DST | \ -- 2.33.0.windows.2 ^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] net/iavf: eth pattern support smac and dmac match 2022-07-24 15:07 [PATCH] net/iavf: eth pattern support smac and dmac match Dexia Li @ 2022-07-24 23:37 ` Zhang, Qi Z 2022-07-25 3:11 ` 答复: " Dexia Li 0 siblings, 1 reply; 4+ messages in thread From: Zhang, Qi Z @ 2022-07-24 23:37 UTC (permalink / raw) To: Dexia Li, dev > -----Original Message----- > From: Dexia Li <dexia.li@jaguarmicro.com> > Sent: Sunday, July 24, 2022 11:08 PM > To: dev@dpdk.org > Cc: Dexia Li <dexia.li@jaguarmicro.com> > Subject: [PATCH] net/iavf: eth pattern support smac and dmac match > > Position src and dst mac bit in iavf fdir eth inset, thus eth pattern can support > src and dst mac match. Hi Dexia, As this rely on kernel PF support. May I know how you prove this feature, which kernel pf driver version you used. Thanks Qi > > Signed-off-by: Dexia Li <dexia.li@jaguarmicro.com> > --- > drivers/net/iavf/iavf_fdir.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/iavf/iavf_fdir.c b/drivers/net/iavf/iavf_fdir.c index > 4789d46ab2..2e6b3a9097 100644 > --- a/drivers/net/iavf/iavf_fdir.c > +++ b/drivers/net/iavf/iavf_fdir.c > @@ -29,7 +29,7 @@ > #define IAVF_GTPU_EH_UPLINK 1 > > #define IAVF_FDIR_INSET_ETH (\ > - IAVF_INSET_ETHERTYPE) > + IAVF_INSET_DMAC | IAVF_INSET_SMAC | IAVF_INSET_ETHERTYPE) > > #define IAVF_FDIR_INSET_ETH_IPV4 (\ > IAVF_INSET_IPV4_SRC | IAVF_INSET_IPV4_DST | \ > -- > 2.33.0.windows.2 ^ permalink raw reply [flat|nested] 4+ messages in thread
* 答复: [PATCH] net/iavf: eth pattern support smac and dmac match 2022-07-24 23:37 ` Zhang, Qi Z @ 2022-07-25 3:11 ` Dexia Li 2022-08-08 1:03 ` Zhang, Qi Z 0 siblings, 1 reply; 4+ messages in thread From: Dexia Li @ 2022-07-25 3:11 UTC (permalink / raw) To: Zhang, Qi Z, dev Hi Zhang Qi， When I test ovs parial offload using iavf, then found it can not offloaded. Ovs flow like this: ovs-ofctl add-flow br-int in_port=1,dl_type=0x0800,dl_dst=52:51:00:00:00:21,action=output:2 I use ice 1.6.7 Pf driver. After modified this code, this flow can be offloaded. Thanks Dexia -----邮件原件----- 发件人: Zhang, Qi Z <qi.z.zhang@intel.com> 发送时间: 2022年7月25日 7:37 收件人: Dexia Li <dexia.li@jaguarmicro.com>; dev@dpdk.org 主题: RE: [PATCH] net/iavf: eth pattern support smac and dmac match > -----Original Message----- > From: Dexia Li <dexia.li@jaguarmicro.com> > Sent: Sunday, July 24, 2022 11:08 PM > To: dev@dpdk.org > Cc: Dexia Li <dexia.li@jaguarmicro.com> > Subject: [PATCH] net/iavf: eth pattern support smac and dmac match > > Position src and dst mac bit in iavf fdir eth inset, thus eth pattern > can support src and dst mac match. Hi Dexia, As this rely on kernel PF support. May I know how you prove this feature, which kernel pf driver version you used. Thanks Qi > > Signed-off-by: Dexia Li <dexia.li@jaguarmicro.com> > --- > drivers/net/iavf/iavf_fdir.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/iavf/iavf_fdir.c > b/drivers/net/iavf/iavf_fdir.c index > 4789d46ab2..2e6b3a9097 100644 > --- a/drivers/net/iavf/iavf_fdir.c > +++ b/drivers/net/iavf/iavf_fdir.c > @@ -29,7 +29,7 @@ > #define IAVF_GTPU_EH_UPLINK 1 > > #define IAVF_FDIR_INSET_ETH (\ > - IAVF_INSET_ETHERTYPE) > + IAVF_INSET_DMAC | IAVF_INSET_SMAC | IAVF_INSET_ETHERTYPE) > > #define IAVF_FDIR_INSET_ETH_IPV4 (\ > IAVF_INSET_IPV4_SRC | IAVF_INSET_IPV4_DST | \ > -- > 2.33.0.windows.2 ^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] net/iavf: eth pattern support smac and dmac match 2022-07-25 3:11 ` 答复: " Dexia Li @ 2022-08-08 1:03 ` Zhang, Qi Z 0 siblings, 0 replies; 4+ messages in thread From: Zhang, Qi Z @ 2022-08-08 1:03 UTC (permalink / raw) To: Dexia Li, dev > -----Original Message----- > From: Dexia Li <dexia.li@jaguarmicro.com> > Sent: Monday, July 25, 2022 11:12 AM > To: Zhang, Qi Z <qi.z.zhang@intel.com>; dev@dpdk.org > Subject: 答复: [PATCH] net/iavf: eth pattern support smac and dmac match > > Hi Zhang Qi， > When I test ovs parial offload using iavf, then found it can not > offloaded. > Ovs flow like this: ovs-ofctl add-flow br-int > in_port=1,dl_type=0x0800,dl_dst=52:51:00:00:00:21,action=output:2 > I use ice 1.6.7 Pf driver. > After modified this code, this flow can be offloaded. OK, as this is already proved, I don't see any issue for this change. Acked-by: Qi Zhang <qi.z.zhang@intel.com> Applied to dpdk-next-net-intel. Thanks Qi > > Thanks > Dexia > > -----邮件原件----- > 发件人: Zhang, Qi Z <qi.z.zhang@intel.com> > 发送时间: 2022年7月25日 7:37 > 收件人: Dexia Li <dexia.li@jaguarmicro.com>; dev@dpdk.org > 主题: RE: [PATCH] net/iavf: eth pattern support smac and dmac match > > > > -----Original Message----- > > From: Dexia Li <dexia.li@jaguarmicro.com> > > Sent: Sunday, July 24, 2022 11:08 PM > > To: dev@dpdk.org > > Cc: Dexia Li <dexia.li@jaguarmicro.com> > > Subject: [PATCH] net/iavf: eth pattern support smac and dmac match > > > > Position src and dst mac bit in iavf fdir eth inset, thus eth pattern > > can support src and dst mac match. > > Hi Dexia, > As this rely on kernel PF support. > May I know how you prove this feature, which kernel pf driver > version you used. > Thanks > Qi > > > > > Signed-off-by: Dexia Li <dexia.li@jaguarmicro.com> > > --- > > drivers/net/iavf/iavf_fdir.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/iavf/iavf_fdir.c > > b/drivers/net/iavf/iavf_fdir.c index > > 4789d46ab2..2e6b3a9097 100644 > > --- a/drivers/net/iavf/iavf_fdir.c > > +++ b/drivers/net/iavf/iavf_fdir.c > > @@ -29,7 +29,7 @@ > > #define IAVF_GTPU_EH_UPLINK 1 > > > > #define IAVF_FDIR_INSET_ETH (\ > > - IAVF_INSET_ETHERTYPE) > > + IAVF_INSET_DMAC | IAVF_INSET_SMAC | IAVF_INSET_ETHERTYPE) > > > > #define IAVF_FDIR_INSET_ETH_IPV4 (\ > > IAVF_INSET_IPV4_SRC | IAVF_INSET_IPV4_DST | \ > > -- > > 2.33.0.windows.2 ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-08 1:03 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-07-24 15:07 [PATCH] net/iavf: eth pattern support smac and dmac match Dexia Li 2022-07-24 23:37 ` Zhang, Qi Z 2022-07-25 3:11 ` 答复: " Dexia Li 2022-08-08 1:03 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).