From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E66E441C37; Wed, 8 Feb 2023 04:23:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D257340DFD; Wed, 8 Feb 2023 04:23:20 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 5C55940DDB; Wed, 8 Feb 2023 04:23:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675826598; x=1707362598; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=i55AgThtYYHd6etWZC6SwQjoFHeMTG/Md23jZW5ENyg=; b=NDM29W135gePhsbw4mmVy5mbR5YVA+tBUB3f6p59QDjQLWpqqNMOS19n LewqD0HNOBw8YJ41lKUA7iUDAhV/sirG/VsvWAg5TMkNH7syUStLDQ+YN ixxVh2IGQuIW/xqLeHMU1qLfd8WxXpjsccsK/ALGqMtlCjMF8qgrZuPuW zCLs6VrYTOohN/PWmLUxD9ODu6AjiYfzg5BMls5tTUZPqeCxPB70E48GB IOXhZL9Kka76O5sqz4ZVdcJjoolf/CyFIZ70bvO2pucM1+YgYvlRQwukJ aP21oWnlDFwnS932PbDb09O3SJSeOnqN/AWKGThqpCmfM3nwEuuGY7zZN g==; X-IronPort-AV: E=McAfee;i="6500,9779,10614"; a="328351005" X-IronPort-AV: E=Sophos;i="5.97,279,1669104000"; d="scan'208";a="328351005" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2023 19:23:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10614"; a="755873184" X-IronPort-AV: E=Sophos;i="5.97,279,1669104000"; d="scan'208";a="755873184" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by FMSMGA003.fm.intel.com with ESMTP; 07 Feb 2023 19:23:16 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 7 Feb 2023 19:23:15 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 7 Feb 2023 19:23:15 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 7 Feb 2023 19:23:15 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 7 Feb 2023 19:23:15 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PfH+jZoFodB0vVFiwGOEo8NF04nDMax094h+UqLoE25dH+CsxAZgB6KuQpYXlzFngMtNEdL33SiPjvPeGn1UqJ9kwgXr7bstBBg4InETgVol+d2L9qzdLMgDMjXhTzM8NuTEpqLiLzTyX9ptVt+E1bFyV0MPScFSFltSfRXZdmSm9qyYqKUtXuk7fj1Spw0oZJEW9SoAnZojahPCaAwzxn8mu0JWYF5WvJCoDMl99nlLRg9/mZP9F+iy+kyIad3k/qrWxZqCAroR66w2COPV+jUD+8eLN19iYK3OHoMyyp7a5NYBh+NZq8n5ihYGq14BRzfc08ZYg9ShDGych2IXEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MCNKt3QvlzfkajolzmHNwaRMNS8GeVWHbM1OVvI6t8M=; b=eUQVVrFPD9eHotSnl7J5g7zm7aCe3pN6LQXJ/APMAcQ/67MKrrJCblm0kg3faW53RifSBLo/+3b6t0cX+kplzatgV0wpBsxC1YJzbmVTj7T8rhDyBY3T84eoxvqREYh6gDTIizV4rVPJ6kVQoK57JQ+IP8efdGEnfruUXK9L9pQxD5OjLKl8KX7qPvqPjDiQ1yIT4YhCbQCIXa187EEzY8fMa6smYQHe4Zdnndr1iI9Y4mbhUvv4yRFJZs0i6K9LM7QTlDXfvWelDZU04LGBUEyOcguumSGCQnf1KU8MsfUKHMuj4UYYDg4xZSk9meBSjctpa2xRkZ0S3nMrh2BR6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by DM4PR11MB5374.namprd11.prod.outlook.com (2603:10b6:5:395::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.17; Wed, 8 Feb 2023 03:23:12 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::eb70:80e0:1b88:3ca5]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::eb70:80e0:1b88:3ca5%9]) with mapi id 15.20.6064.034; Wed, 8 Feb 2023 03:23:11 +0000 From: "Zhang, Qi Z" To: "Yang, Qiming" , "Deng, KaiwenX" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Zhou, YidingX" , "Wu, Wenjun1" , "Zhao1, Wei" , "Xing, Beilei" , "Lu, Wenzhuo" , "Dai, Wei" Subject: RE: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API Thread-Topic: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API Thread-Index: AQHZMuyFZDAPhP/ncEu5KFyV9ivMnq67NAGAgAAMDACAB9iAAIABWtiA Date: Wed, 8 Feb 2023 03:23:11 +0000 Message-ID: References: <20230128071519.42946-1-kaiwenx.deng@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|DM4PR11MB5374:EE_ x-ms-office365-filtering-correlation-id: f9a23c91-d5b8-4672-c32d-08db0983ce99 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sVl6W79i1uNHKi74OacgUCVPU6YC1MoF3LNvK+i5t6w6CO02N47QrNvQ7GtlONQ+NC9HF6IA1vqOnqBcfjvSVt/Mm85cul07pYkjLMQBmzYn5+Hzj4F2ASz/wmWS9EBSzFqBdBuYj7+++DSDI829WdDbKmoT1wmRZSqucGr1pBXVCxMtvdKL0npYvI9Wc0YFiCR5FbfuNccmwOI+ZOE29b1METPGOqt1AMj1RPqMHLnMVZB/GDeunp6Bd4FnOwHkejKu3anKeLcQI5bg50v3WbeunGEYi/s0MUr4fJQxADKxnA9PQ037W5aO1z3H3bTCrWW/s+fTMNxBttyfm21AXe7dpwjFyOwcAjxmDIrFcfar/GTlb9tHcEVStCHMJW2eQ88pjvrAgvCn75e8vPT56lGVF5M0hybZDVsHW/0pA4399G4PkM6qwP5Mr6CG63GSv1LteFlTDzfC+kPDkUdGAXNHbcx6i7uy+4UBPR/b2la3Yo5H+ersWvUQx4PqJDaQv6A0DXAx1QuvCQlkO71rAySGgS0jgby5wmsIA5lqY0g+AqLn/SW6VO8yfOEE/4ij2LVwezpKePKDu8AkLm4chTG0cpbcrIB1NkIBZM4TdJEbsH/2TBWxl0zeVzrAUAMwZ3Z7kO1AutylA7JksI+j3MIx62QaLtEEjNTNu9NqyZMZsbl2/ynsfNFdb4bqncceD7jFTyDemowgvnz8YkR9JXUfnJx6Hs0VjCNQAah1acY= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(346002)(396003)(376002)(366004)(136003)(39860400002)(451199018)(9686003)(26005)(41300700001)(186003)(478600001)(38100700002)(54906003)(52536014)(122000001)(64756008)(110136005)(66446008)(66476007)(66556008)(66946007)(76116006)(4326008)(8676002)(450100002)(82960400001)(38070700005)(33656002)(71200400001)(7696005)(55016003)(8936002)(107886003)(53546011)(86362001)(6506007)(5660300002)(316002)(83380400001)(2906002)(41533002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qpCwz/kLjeylTCXCfGneR4rYEAZpoS2caz2oiWgWhFKjxVrZJgVE57AlErOB?= =?us-ascii?Q?Zhhigb4yipknnXxCdeIt7xrY3a9kKmvKLtX8h3KBc1xaC5j4+/R/M7tqfvmX?= =?us-ascii?Q?eYGScnKJi26rVYY6KxRYp2JUoJzHGN4m55YeEViwAcY2C8THmvLASQGsRS2E?= =?us-ascii?Q?KucRYghwVeyvy08xZXPEObqZMakj0OA9s2l2OInBxixF0/AaiH1ZlAsAD7fG?= =?us-ascii?Q?9TNisBPfCfXh4+sJJiLH+dGkKl+KkRS/4+9yCEqVJAbOwbDcmnzYxGgIfW4e?= =?us-ascii?Q?Oq7C0f69ISlro1fW3xi6kB/gUQmhlJrWCoTLN+v8u0r0knDoKoS8o4/cOeRL?= =?us-ascii?Q?+7xegYZOAwWy4z2PmZruqTVe+tv2EkyUgfTAEOV9774/imeIZBJkMK0+IJ49?= =?us-ascii?Q?D4aHNDHEtNRC8jsn/LyhRFzOM5K9Zmzc+56IKTagadbr1IXeCGWbA9oD+CK2?= =?us-ascii?Q?O9Oxw1hA2/hke2T0x0zRDbwMQIZy6UVpP+65KGOMlF7raP13SRkqqaiOlgnQ?= =?us-ascii?Q?QLlVkFQ59SwO588b00YNIIfcUPGjM3xos6rdGi0MlRmA0hsJgtb41VWJbCiU?= =?us-ascii?Q?YHjOwKBXs3JdggN/lEVWNzvkAu4UeGlNqv9WR13J0KtJSwUOjRKL+g1tFenN?= =?us-ascii?Q?q57RQ8jprY5zI6okICOVXAwSBy0FWg/JUG7gG4gtnFFnc1P1KJ+6Y/PVK1mZ?= =?us-ascii?Q?8u8vbTewSPNsIle0wIU/n6ZpPW9LXVMT9a/OV3J0wkX6kUXD42J0yljp42he?= =?us-ascii?Q?0gbGQDeNlx/m35jkTPOxO1leV/5mz09q/HZtyQAWEAHMWxA7hEddY0EIm8h7?= =?us-ascii?Q?jEIv7wR1d1i4e6c4P8F5dQw4Ob+kvrX1yEjYnIgqD60Uc0+1dcC3dNBWV6mi?= =?us-ascii?Q?buzpHbc4Bs8gz0GqECa7Z71coWTorECkQQGzmoHbgHN64GW7ysLo8gXVHtbn?= =?us-ascii?Q?lVYO7OJMM6PvSDjw9jqbNRUpokSlUGPKVfMvmKWkFbFG7m50t6FX1VoDWAUO?= =?us-ascii?Q?OOlPEtI9/nDDcdhZ2qMgEkNnnBuBX7R0sK1aR+zonaMDRac8uEmxjecnHz+Z?= =?us-ascii?Q?ur5HRcgFH2e4axMv4UROd3dsGqPewpWDGkDHGao/1r/fS4xwVES2H644920D?= =?us-ascii?Q?Tv7YWc+k4yM/M2CKPKnqAwuS+jwjvHhap1F5JoknYeIxYSC5MQ/ZOiWhzJ4q?= =?us-ascii?Q?zp5+qppWboRWRIMViASkRY+WN1V+f7X6bSt7D2aH+KAt3AyD6g/pfn/kpadu?= =?us-ascii?Q?+BaGw6YYiUC/upbJcG+EUfCDlJpfB4/10FLKDr7RHjdrTIcWddDTb66l4wGk?= =?us-ascii?Q?Z9srclF/jwrStbj9vMdnLOqkpYaFiwRWVsixMugoUHOl3mgXBXhG+Q3UcMhk?= =?us-ascii?Q?n3nOZoPBDZloGY5ZZ/GEW4LJfO/8Onyt0gOMqV1gRznO78YkLLkRt7BKIssl?= =?us-ascii?Q?tPNRY6ZzN1W8PETjSiTadDcQNPaGaNHXEupbkwBwHfhyeJYgMwBL2ccjwZjL?= =?us-ascii?Q?/DLKgJdTYtfKYXTYySmFtyOBBCIVTv+QgqlU4ERywIdqsFr8VpZ+tLC3KBmT?= =?us-ascii?Q?P+WitPXf+Qkusmm7ebTGaiufO7czjLLRX1xhY6IC?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f9a23c91-d5b8-4672-c32d-08db0983ce99 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2023 03:23:11.4450 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hKmjZ030CM7GmqxunkrNqnIcUxOuHKdU1+2HjJScd/2A2OM9DNM0OSIY8aywajEqpCqRtsKnsJB8Hyi/KHHYHg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5374 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Yang, Qiming > Sent: Tuesday, February 7, 2023 2:41 PM > To: Deng, KaiwenX ; dev@dpdk.org > Cc: stable@dpdk.org; Zhou, YidingX ; Wu, > Wenjun1 ; Zhao1, Wei ; > Xing, Beilei ; Lu, Wenzhuo ; > Dai, Wei > Subject: RE: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API >=20 > Hi, >=20 > > -----Original Message----- > > From: Deng, KaiwenX > > Sent: Thursday, February 2, 2023 2:53 PM > > To: Yang, Qiming ; dev@dpdk.org > > Cc: stable@dpdk.org; Zhou, YidingX ; Wu, > > Wenjun1 ; Zhao1, Wei ; > > Xing, Beilei ; Lu, Wenzhuo > > ; Dai, Wei > > Subject: RE: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API > > > > > > > > > -----Original Message----- > > > From: Yang, Qiming > > > Sent: Thursday, February 2, 2023 2:10 PM > > > To: Deng, KaiwenX ; dev@dpdk.org > > > Cc: stable@dpdk.org; Zhou, YidingX ; Wu, > > > Wenjun1 ; Zhao1, Wei ; > > > Xing, Beilei ; Lu, Wenzhuo > > > ; Dai, Wei > > > Subject: RE: [PATCH] net/ixgbe: enable IPv6 mask for generic flow > > > API > > > > > > Hi, Kaiwen > > > > > > The code looks good to me. > > > Can you ask someone to test this behavior and add a tested-by? > > > > > > Qiming > > > > > Hi,Qiming > > > > Peng Yuan just added tested-by. > > > > Kaiwen > > > > -----Original Message----- > > > > From: Deng, KaiwenX > > > > Sent: Saturday, January 28, 2023 3:15 PM > > > > To: dev@dpdk.org > > > > Cc: stable@dpdk.org; Zhou, YidingX ; Deng, > > > > KaiwenX ; Yang, Qiming > > > > ; Wu, Wenjun1 ; > > > Zhao1, > > > > Wei ; Xing, Beilei ; > > > > Lu, Wenzhuo ; Dai, Wei > > > > Subject: [PATCH] net/ixgbe: enable IPv6 mask for generic flow API > > > > > > > > Add IPv6 addr mask and L4 mask support for rte_flow APIs. > > > > > > > > IPv6 flow rules do not take effect in ixgbe when set > > > > IPv6 addr mask and L4 mask to default value as 0xFF. > > > > > > > > Set IPv6 addr mask and L4 mask as 0 to enable fields can fix this i= ssue. > > > > > > > > Fixes: 11777435c727 ("net/ixgbe: parse flow director filter") > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Kaiwen Deng > > > > --- > > > > drivers/net/ixgbe/ixgbe_flow.c | 4 ++++ > > > > 1 file changed, 4 insertions(+) > > > > > > > > diff --git a/drivers/net/ixgbe/ixgbe_flow.c > > > > b/drivers/net/ixgbe/ixgbe_flow.c index 110ff34fcc..d2ba87df27 > > > > 100644 > > > > --- a/drivers/net/ixgbe/ixgbe_flow.c > > > > +++ b/drivers/net/ixgbe/ixgbe_flow.c > > > > @@ -1645,6 +1645,10 @@ ixgbe_parse_fdir_filter_normal(struct > > > > rte_eth_dev *dev, > > > > memset(&rule->mask, 0xFF, sizeof(struct ixgbe_hw_fdir_mask)); > > > > rule->mask.vlan_tci_mask =3D 0; > > > > rule->mask.flex_bytes_mask =3D 0; > > > > + rule->mask.dst_port_mask =3D 0; > > > > + rule->mask.src_port_mask =3D 0; > > > > + rule->mask.src_ipv6_mask =3D 0; > > > > + rule->mask.dst_ipv6_mask =3D 0; > > > > > > > > /** > > > > * The first not void item should be > > > > -- > > > > 2.34.1 >=20 > Acked-by: Qiming Yang Applied to dpdk-next-net-intel. Thanks Qi