From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C3FC423F5; Tue, 17 Jan 2023 02:54:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D881640151; Tue, 17 Jan 2023 02:54:15 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id C8893400D4; Tue, 17 Jan 2023 02:54:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673920454; x=1705456454; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=V1B/bCH6z9uTooTTH+8oUBvIfcZ9kBzzX0V3FWMoejA=; b=NubOxzQhUKN/JyM1ehG3yvk6lnh6WBvw/3gychI3/s8TJyPlrJsYu3Mi /Lxc7CJW6NS+b4cz/g6hsfRS7w+jzn64WkNdic74038SFijeT0YJggo4A tm602Iyehku/i8vYKR2qcO9LdzvQcK8KZNl+UttRHOcDAheC+7UDtssJR 2csS4blwKedMXX1WghTscq0Wk/B8t06j03YHx4vBnHvlRxXfJg0e/iRHh nGlDH98jPZ7MHrvr+RmkiHIR5DGMJuSW7H+FSqxRlB74SmJvdxLlULmzq mtu9MPGkpENHvqcLzHUoH4HR+6bm12I8PUko5JelwqpKNxNqwhG++xqJ0 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="323284126" X-IronPort-AV: E=Sophos;i="5.97,222,1669104000"; d="scan'208";a="323284126" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jan 2023 17:54:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="636701076" X-IronPort-AV: E=Sophos;i="5.97,222,1669104000"; d="scan'208";a="636701076" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga006.jf.intel.com with ESMTP; 16 Jan 2023 17:54:11 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 16 Jan 2023 17:54:12 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 16 Jan 2023 17:54:12 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 16 Jan 2023 17:54:11 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d03+6RHZ0U4/Tx2N45eTBFpjPp/YgvBzMNGmDe77J3J41DSvN6IKWK5uK0dMp2KrtruJHIi9/QaaDf768bMeQq6PP6l2fB3s+rDeIKme+c6FbSgIFxZpO8LD1bpAS1v46QDB0L3zNKIwAA+4/6lzkmtnqEAaqlvNU7ePKw2K54rYIadH+Nn9s3qi4nEtLN7CVoNEPoEnHfTAMr6NYNdiYcEP9tmfd+L7j5XzrcBNAYgxqi9IbkEj/zUEIHVnDfuXuIG8SHPX+wFTYUcEV/5GCe0Q4lyZcqgy4mte2vaAHS30U6x0iN7/5GyawZtxuISQhaXUqa2gn2o6lFJNKfuOBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WmSgGwZH7eMVcMp/wCA5VRStFrwv7/1yOkRTJPDtRkI=; b=l71MCzzjPV4rI84OlyUfHymmpTy4G69vrSnUZeM1bjIPxUB0dyWYRjkbSCrMSke0R/UiwqiLvRaO+eCSPTyr/9AD4FxNlMZJYk37t24g9+GB95jEnsKyZeS3llKA+J2Ey1ZxSIagwwZ5ySY/JWyWR7Z5Z5r9GxKpLV68UdjKTrZExwMf2+jPW2KOdixPfihjYFXQj61QR0moTqQy/R2XwuKdvWvO19dMtAgamD6tEKP3U2NDdazq1WOZ0psVuAGmeT5CfYO2t0kNnZUy4Nqf1VCtP0jXYuEX3oHxVAHucSvxvldaEsrXpobcZHgZFlnrN/RUh9WVMlB32OpHXajoLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by IA0PR11MB7695.namprd11.prod.outlook.com (2603:10b6:208:400::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.23; Tue, 17 Jan 2023 01:54:10 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::eb70:80e0:1b88:3ca5]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::eb70:80e0:1b88:3ca5%9]) with mapi id 15.20.5986.023; Tue, 17 Jan 2023 01:54:09 +0000 From: "Zhang, Qi Z" To: Vipin P R , "Wu, Jingjing" , "Xing, Beilei" CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH] Intel iavf: Return in the case of ADD/DEL ETH address Thread-Topic: [PATCH] Intel iavf: Return in the case of ADD/DEL ETH address Thread-Index: AQHZKR3BexqaAWwVdUy+DfGRRDUDEa6h16LA Date: Tue, 17 Jan 2023 01:54:09 +0000 Message-ID: References: <1673615963-21216-1-git-send-email-vipinp@vmware.com> <1673615963-21216-2-git-send-email-vipinp@vmware.com> In-Reply-To: <1673615963-21216-2-git-send-email-vipinp@vmware.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|IA0PR11MB7695:EE_ x-ms-office365-filtering-correlation-id: beae057a-4a68-4a27-bc53-08daf82db997 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xvGoBU8Rrfj1nf2ypn+y8PHm1mulcYE4KWtdxXicdpyDOVeAcgo6oYZbVexqEh2cDP81Uqonf6MZKfbvyAuRGTfyHG8Mt6RBI/FljpvHi2mFCPasf+NwPFrOw6mYS4V7oAHAcmcnK1yh0w0lFeawKTppYk5FqTVE2o6ZVpIoksw3JaTMpLXvplbwDU7oWu2ohxZkT/YOK/AttENAfAFTVnSSYrN0pCvMEO0oLpZngJ3IaCQV+gFMahDsgTY5uXx2uisqUm8ywG45mkLjmvLa6NidlvGXL1cdqkDpiiiSnOWsN/Tog5JBTCLX5zWqU5e7uuFwMIoZroUpYdA2aPqNcniFqgeSpl064rQRoPAemOhIkLAs4WoAm5sszag6NxR3pghak53jgw11jYKxI5Bo5F2j2Q7dB/Cr9B55B/DeRER4ncjvfpW3HRaMuxY6sFQi63QjwXl8yZDKOyZUPAk90XhMDr1CIBimAxW1ImLjHTvZIo6+22wCze9P/b7UEECqCrTKONz2Uv71rXhanp6V6MVEVl3dtNQFACNH6ZjfW3PUnS8PeYfaPAD8+7pkXLv6H9rLZGAESFMT7g4BfLpcaoo40GQngOZ6nYN3T6Fj9Yr/Y+pZch4nPqdBNY7HXaFo0hYPe6seYUKDrnzJt0CGaDCtaVdkVcrk3HOpq5EKdryOCWNJ0qydiHykSUphBnbDtkHh0aP53J+fciBOMBCkdw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(396003)(346002)(136003)(376002)(39860400002)(451199015)(86362001)(33656002)(64756008)(53546011)(186003)(4326008)(8676002)(66556008)(76116006)(66946007)(66446008)(26005)(41300700001)(9686003)(66476007)(316002)(6506007)(7696005)(83380400001)(71200400001)(54906003)(6636002)(110136005)(478600001)(122000001)(2906002)(38100700002)(38070700005)(52536014)(82960400001)(5660300002)(8936002)(55016003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?A/H61Jh6PoRJqYhilADxPWJNozdpvqIXrBwX58HIb/Vs4n5cC++/pvvazJnU?= =?us-ascii?Q?WHkPRDcTB369LWiuqDcEg+MAJ00h7As4BGn9M6aDO1zYn5VNQw8/wAFWBg3Z?= =?us-ascii?Q?737xurZgzX6bCaKYRZhK8ZwcOU72RwKFljrWLEW4FHEyNzkjdAF9gZTfmLGm?= =?us-ascii?Q?GOhIhT4DnSD9crv3R9P6jd71/Mg8FZxsp227K5d1onelXdGRV4YreoQmF4Do?= =?us-ascii?Q?9MYm/nDVgQTzgpkkejj7cQrINfczWeeKmvHA3VJoqsPIiyPS/Jnh3zrr5NhK?= =?us-ascii?Q?ysNzcZW1ImlLnUuHH1VVJp3xpQC4v9IhQp8EHlsHrBmytl0YuQYoGeaTcyVI?= =?us-ascii?Q?es2CElKoaz7hLsaZdl5t13lonn6oOj5P1KnhhkmgbxUioBMOphbl1SSI10gB?= =?us-ascii?Q?az39plXmjuqGKYekiX0gJvqPtR2+u+YUwVoPJXT5e8cO0HlY1al2Ou9n86z/?= =?us-ascii?Q?0sAd3LGbUDeI4V5SxiO0NYdNd00udeDECNCzF1KRjotASsH5ZqxArj43ctIP?= =?us-ascii?Q?BWZY9mkLLZKIUMsi2shGwYPiotg4mSZ7ZKyDeXzGh8lmEkmWblqZBzbXcHwZ?= =?us-ascii?Q?qinX8eMDqABM2y/BpLSuu4CeSSEMgVMyvNa3EiKZak3pn2xWo3rA+3f37/tM?= =?us-ascii?Q?dml7kA//mAfFus/q+zNxH3k1QkyGFLPehvZCBC3A2NkEouszjYvujHMrO6aI?= =?us-ascii?Q?0xJQVth9zasnUbhzaaY0QRV5tdPcXDuoIstjXXqymklK62z/dDD1sdcLczNE?= =?us-ascii?Q?oM5O/9/3CScLNa/+FzbMHkMTj3Uz2zinyKcfolv9KQCKvvI6l4mud+PhqlYY?= =?us-ascii?Q?n0Ia3rER/ZWD77G8bdjKORYUQzG8W91ZTlaYgFcUm2NXSlalzQBbYvaXsTcE?= =?us-ascii?Q?LTLGH7YvN9iez0JD/DdT4cDHKgFEeWicuN+I7+wAKK6HkmqVdDxCjUbRyQgr?= =?us-ascii?Q?mduYCP1TacbjhCxZrjhsaQkBmCCV8MJNs5/T00W6YdoTrdVUjz2c9qk7f4gv?= =?us-ascii?Q?b3UxJw0mVl9ynHzyP0Ze/USfug3x9+gpWfQ9FFamQD6WCVA2zOVMrEqRrY5n?= =?us-ascii?Q?x1+DcKKghau+qgXVpTyi3NLmQKWAjyXeAI7bUnI7IyM+vIBLOXOw7Lge2pZ2?= =?us-ascii?Q?iIVeiTavfgf59WTmayavO+8Cs2EWrNCloHW6WCtyG39grLwzNfQVt0SWxETw?= =?us-ascii?Q?je0zdJ3HhMavJmqmulYd/5guZF4+2aubOxx1lzxL39Cj5GTwxIlAY8AEC7iI?= =?us-ascii?Q?fz5O4aWETphbsz0qeA6ubhariVzV+bHwtkmLRkJ1kgeQG52pUUaRJ/cBTXyZ?= =?us-ascii?Q?VMQVrT6SUo4sesM3NFkO8/2Rb1nqGYM8SEzz6wFzlPsF0p0BCus2ppOJ9SwB?= =?us-ascii?Q?Zlooy1ZEGW02Dlhq/aHpgEdbH6M4TaQ5A0TfD1VzY6kBJHtjWcAw9d2946jw?= =?us-ascii?Q?0gEubhpKLGF0oYg7Jhx90/8Z4RGUZyxntEAv8zZN1RseHR87Jxbn64gG4VVk?= =?us-ascii?Q?idY2O7uGUwA4S6plHaujm2eHCjIQjKnJVvI2O4YhekW1LgUqAS1mEb+JNBRD?= =?us-ascii?Q?abCuxsqGS0tVYcv6YTqUPb/VzCFOuCCvSAC7OhKR?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: beae057a-4a68-4a27-bc53-08daf82db997 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jan 2023 01:54:09.7136 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mYV5EX2vAHzXBvijYi+/4sn6hBaKE6B3glala45dj5BtIUwSyd6WaE4MYJ2jkcU/7E5894JGPgtMTjI3fyR7WQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7695 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Vipin P R > Sent: Friday, January 13, 2023 9:19 PM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; Vipin P R ; stable@dpdk.org > Subject: [PATCH] Intel iavf: Return in the case of ADD/DEL ETH address >=20 > In case of i40vf, VIRTCHNL_OP_DEL_ETH_ADDR and > VIRTCHNL_OP_ADD_ETH_ADDR are unsupported. > i40evf_execute_vf_cmd is invoked with these operations as part of > i40evf_set_mc_addr_list() >=20 > The cases are not handled in i40evf_execute_vf_cmd() thus hitting the > default case. > There is a retry logic of upto 200 times (2000 in iavf) with a delay of 1= 0ms (1ms > in iavf). > This results in a needless delay of 2s in the init phase for each VNIC. >=20 Sorry I didn't get this, why this is related with i40evf? I40evf PMD has be= en replaced by iavf PMD. The iavf PMD works with both i40e and ice, does this will break ice's usage= ? > The patch aims to rectify that delay. > In fe2a571c70cc397f2ad4e280f8d084148fea5d62, i40e_ethdev_vf.c was > deleted. Hence adding this in iavf_vchnl.c. >=20 > Cc: stable@dpdk.org >=20 > Signed-off-by: Vipin P R > --- > drivers/net/iavf/iavf_vchnl.c | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.= c index > f92daf9..e2f65f5 100644 > --- a/drivers/net/iavf/iavf_vchnl.c > +++ b/drivers/net/iavf/iavf_vchnl.c > @@ -367,6 +367,14 @@ iavf_execute_vf_cmd(struct iavf_adapter *adapter, > struct iavf_cmd_info *args, > } > _clear_cmd(vf); > break; > + > + case VIRTCHNL_OP_ADD_ETH_ADDR: > + case VIRTCHNL_OP_DEL_ETH_ADDR: > + PMD_DRV_LOG(WARNING, "OP_{ADD/DEL}_ETH_ADDR > unsupported"); > + err =3D 0; > + _clear_cmd(vf); > + break; > + > default: > /* For other virtchnl ops in running time, > * wait for the cmd done flag. > -- > 2.7.4