From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C3EBCA0503; Wed, 18 May 2022 06:11:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 708A74068B; Wed, 18 May 2022 06:11:00 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 4594E40041; Wed, 18 May 2022 06:10:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652847059; x=1684383059; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=PnqxqrKAzXh/XAbNhxthGNXD0haHYsO8e1RGrVOiZD4=; b=KZrDiQ83hyaI3qRDs4ziZMSyPsyxY0MKdViIgQ7zMvdJdbqPPEK4DS6l RoAGy0GUg3tqfX/fsegoFREmlQhsZD3r6c3pZrzs5rYQNxunOEYygxFAL NdNOy3zKvKgpeVsJiJkYN94hU8B5r9zae3vQzYGzvRokPdGHAKke0mIMl yS9KCdtV/A1Cdp7L+x7eDadCX3NhbzPfCs2Et3e03ngR5R3IfqBFjnwLc Oi/2JVywzGCwi8QulibrorhQjSTAMnPUWmcAkjMGtXUKSa3ydUrsHoHdE ejTAkD/cAjG+A8GWI09BTBy5CSytZ+pjY1R8h72Vk2COUBt8M1sQBKQJS g==; X-IronPort-AV: E=McAfee;i="6400,9594,10350"; a="269051364" X-IronPort-AV: E=Sophos;i="5.91,234,1647327600"; d="scan'208";a="269051364" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2022 21:10:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,234,1647327600"; d="scan'208";a="605674742" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga001.jf.intel.com with ESMTP; 17 May 2022 21:10:56 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 17 May 2022 21:10:56 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 17 May 2022 21:10:55 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 17 May 2022 21:10:55 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 17 May 2022 21:10:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iUEfxz7IpFoEhxf570mUe8/Ywjdq0BacQQuN4OcyF6bS2JHKd49gQxFFpyCovgy1kiKy1jOv34LO4blULrswevk4DM2eD9rgJpFha5XeNsjlp3IalueoaidP3t/Eu0amdY4/l8zIhEKfpCogACb9i8kWtpFMsTwo0zhGpsLbAvpXpA23wJys7EDls6RYrVRMzJUQtb3hGQVl7nsfSewSgqX/nqvCrCRYy8QMXPhwrE6F5RzXyk0UEUFFS1lzEQJNxFCO+F2WEXRNak4yYekgTY7HbStfKZ5baJGYNslX/sk2FmumjPM2Xn0NkyqmZ/Yewj4wLc2LsvYcWyvcyt/MtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PnqxqrKAzXh/XAbNhxthGNXD0haHYsO8e1RGrVOiZD4=; b=egzgF0tZhVa1+UTWIH3O1JidC2Y4wjO/M7YRUqTSLZ0GE/8rA9x/e8ZCfx0TuHKlArHvSM1sFLA2FKfxnqFTDMJwuX+gpPjxGxliYEfIQLIce4U2Faoeu4VY04zb2YdDD3/v5TcFA4lcYJ2RkBHpqo/O2DqrrSniJu6i+ixcxSsLLJenFd/ZmyFCDp6VWFW95MJbpREqoOV2Vd5BBRTWTX7rhd7L12gqjsKdTYVfUic7iLJgs9e6aVSWWPcc/m+fBj0/xeA929CsvztbfKW8AJ/4EnHAlAY7HhBlfbSqbvzsbLEaEtWu8Xa4RQtgFJHcQgwl2SWQpa3D65EkUQZqiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by DM5PR11MB1913.namprd11.prod.outlook.com (2603:10b6:3:10b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Wed, 18 May 2022 04:10:53 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::b4f6:f68:2e31:ddf7]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::b4f6:f68:2e31:ddf7%6]) with mapi id 15.20.5250.014; Wed, 18 May 2022 04:10:53 +0000 From: "Zhang, Qi Z" To: "Zhou, YidingX" , "dev@dpdk.org" , "Wu, Jingjing" , "Xing, Beilei" CC: "stable@dpdk.org" Subject: RE: [PATCH v3] net/iavf: fix segfaults when calling API after VF reset failed Thread-Topic: [PATCH v3] net/iavf: fix segfaults when calling API after VF reset failed Thread-Index: AQHYZatDznVnZssTU029d5PJJaz/s60kDrmA Date: Wed, 18 May 2022 04:10:53 +0000 Message-ID: References: <20220421170827.2753175-1-yidingx.zhou@intel.com> <20220512104851.21966-1-yidingx.zhou@intel.com> In-Reply-To: <20220512104851.21966-1-yidingx.zhou@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.401.20 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2de96d4a-f63c-49de-ccb6-08da388466bd x-ms-traffictypediagnostic: DM5PR11MB1913:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uHY5qp+e4kO2TkoCcHEqPkO+E25MTZIBDBXrocW493p4h+HDKapqsrAPcz9B5iQ36VLPPkmhKzZCcfjPDsD+q/6kGWgvNbTfezRKWdkvgfXgUL05vg8QFktWVE5rPIieRWwxgd8LPu8fPypqhou0XoXhUp8p0oIMdKOUnrHWTljuMj2ecxcEwbl9SdeLWh+sZgwKvysu505w2eqzuqPNJ0b4TWQvmClwHlawgd36aWfRW7QrNBVJ9ylTH+TQMg/8wE0zFOH8pJkwn8WRzA3ozoFxo7me0NSDTrQaKqXZocF4NYlltoCYMcHc5S1BMKaVAQiBwb+7i5ZwZcw8xtrcZ0BOA5au89S2NWRPcVO1eIzQR2LRWi5dgy+G9uN1a4o+bEBuMOfaiL/n9FhMy/vPG+V3wMcdcBJh7SkakdxwlwjnPyapoptkj7UHWjrhV/Sbj1tsXd2mBLNFzwxzpwVn2UvjIEqqT7xM3P3GylD1XG+AYhKYc2Xgz96J7bCj5A0UIpTk8snxuhSskIUYFQD07tMBEo4myGwT/uxmTnJdSEVZYb/4RywqzubHTZIC3n/3nXefGa56NmrEBqZinJq0VdpZRHis6cozK2CM18337uSwwiOvldrQx9qmlSlqgSEQNDaoP8/pCfFOMldVLEqzBYRL/xWi5RxKIzBgRNFE0cs7gXQip8FCO1mVeg7T5c9fKlCiAoot7a7m0uoIk+GOUA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(33656002)(4326008)(66946007)(82960400001)(316002)(66476007)(8676002)(122000001)(66556008)(5660300002)(66446008)(8936002)(450100002)(76116006)(7696005)(38100700002)(83380400001)(55016003)(38070700005)(6506007)(52536014)(508600001)(6636002)(2906002)(110136005)(186003)(4744005)(71200400001)(53546011)(86362001)(64756008)(9686003)(26005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OhgVCbeMm3/wzvw6yECTA4v62QAeWLXZe3fOiLcFZqDdC5oMJnSal1VIVY8o?= =?us-ascii?Q?tcT2MpkTrxl3GZBM2GL8ysGh6r57sQcq94SugXzW9RCmgjFMc74jzis11nOo?= =?us-ascii?Q?4uc+tS5Jp1FyidAMK5+6nAjfpBo7qVtQDghCH+JGTSo/Yrbdm3lHoGZpzMup?= =?us-ascii?Q?DRs9ak+iMxHHoyNkP3SfXEgacaWvvW6rXr7geUWAnodp3uWZ69Db3M3HAc4N?= =?us-ascii?Q?kGJPK9a9NKGTGy1PvNHctKc0pnUwt5kW09b8xVY3kFiMA3AdtyfPW1XEElB4?= =?us-ascii?Q?aT3bU1nhNXxi7we8heFpDx/abHKpYnRmfnxsqtD2hMYJWsvNqSuCcwprgwJn?= =?us-ascii?Q?/NMbp+s2hI7ANDFxR8SVndg5hrJmp5LNc5x8vgEDvhL4vMprFUz65lp85Nqw?= =?us-ascii?Q?jugCDTW3MHIitnI/ceR8WRyqfBwWcGx5OG4O+W7g5FZsQCRyT3ZAXU7odxkl?= =?us-ascii?Q?eu/oa6CfkYANALI0u6AQnO2UrBhoE8E1NehUgChTAEbNuMHsgDP04n/ZkuAD?= =?us-ascii?Q?waPQi/lC6UDbWB3ls6uPvf1Vvjg7YybY+iiWgLPatj2HLofU3gmsFGOk8dfX?= =?us-ascii?Q?vNsyaADuXdPXXsawWNq0wmc0py2LFj2TYyAgfhEGImTGFDu4d4kPKO0S1fmy?= =?us-ascii?Q?lix52YsgnXFsrE/TKnHXCFWWNNkoibEVffDz6Y1yVoFpF2NJxd0oPqjTSxeK?= =?us-ascii?Q?PqPeixNfnWMbLU6qvj329rMzlL/CLDQhkGLn8u7mSzJHQ7aYkkj+SZbaLeG8?= =?us-ascii?Q?DuLnEjvetBO+oBBwRE4Z0m9HeH0WJ81hRpgX8+kIQOc/co3kUGx6XjbUFOxM?= =?us-ascii?Q?/yDfLSsCO4KM5KBx4fD9dJjrbDXqAZIlaMLf2iXVX7LHNYZVhN8c4BLqdFh+?= =?us-ascii?Q?H+swnoGmjdfv4M5j3BG3xHSz3nYHjoPCi30gZ5NkE6rWB8Z14Kx3HBHewPMY?= =?us-ascii?Q?299IFCtwUuVhIz6emIQ+Rf9wCEJpDXKbwrADFyEyW02UyG/OXNhQfgRj0xJb?= =?us-ascii?Q?SYyWQQOPNqmZOyQP42GJSfZT1GJocjlinuPw6QdiVwI2qrMGefxdkxLvxnnr?= =?us-ascii?Q?IvqIc2xMKPYrUADwXo8ktRXo8w2S3aDzyJW3NavuJcjMpV29wlwDjxQYdsWo?= =?us-ascii?Q?FkNa8SClCdGiBvje3JkhBjZKI58Na+oXTct5n/V+Khi5IiVfPprcuhhPtvav?= =?us-ascii?Q?9+CPRe73r5vwV/gRukYQC/XzC4IiqL9ZkiW2NUe02Is8J/DRgjJWyB+cUguj?= =?us-ascii?Q?Dj++qMgMvKCgW9GMEZKHYAJalsZMhCo2aahryvHgX87/O91QKps+3igbHJnY?= =?us-ascii?Q?RRauMkxAbM+YaPn9z9o1qttmUfV/LMxX35/r4yY9eAxmFG2jUyf8z/bofA0i?= =?us-ascii?Q?2OLqM3W6QNTDpXjrbXBdgTIIVe1XhEQjxbYChhldNaEjTPwGbA86jagYMsqw?= =?us-ascii?Q?OFUi4hXPqVKkBchj3LkcUNQww9BOIkDY4pxTxYQlERmQgW7a9Li7BqLWubTI?= =?us-ascii?Q?KvcRGyeQ2llnd64bmoTpPgUh4JcQN5jH+7OcSEKh/Ku2Hi+aId/ZejAarUh/?= =?us-ascii?Q?6HMV+UBJWP0JXp941WqUU0YWO19jjN7DTUtM7G7j/UUZ57CXn+LlTdfEQv92?= =?us-ascii?Q?DqpRYhy6hGJKwvbWdPZl7W6D0+EUBIfSbM9hMdQI1is4fGT2+daOacTmbdMc?= =?us-ascii?Q?zOmBM5AtsID3HQjnuaXk0mW+L6me9ApZaiAYng269V9Smie9HUeTV2KA1yLX?= =?us-ascii?Q?IrZjyb/pNA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2de96d4a-f63c-49de-ccb6-08da388466bd X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2022 04:10:53.6743 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: v8wRBeqPWceZIyzZc9AsbszsOsuzqQqtqDnxGwh7eSjp/oGBdbrDFPdxy4q6T32byphaTtG9v6EfXEpfRd7Xow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1913 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Zhou, YidingX > Sent: Thursday, May 12, 2022 6:49 PM > To: dev@dpdk.org; Wu, Jingjing ; Xing, Beilei > > Cc: Zhang, Qi Z ; stable@dpdk.org > Subject: [PATCH v3] net/iavf: fix segfaults when calling API after VF res= et failed >=20 > Some pointers will be set to NULL when iavf_dev_reset() failed, for examp= le vf- > >vf_res, vf->vsi_res vf->rss_key and etc. > APIs access these NULL pointers will trigger segfault. >=20 > This patch adds closed flag to indicate that the VF is closed, and reject= s API calls > in this state to avoid coredump. >=20 > Fixes: e74e1bb6280d ("net/iavf: enable port reset") > Cc: stable@dpdk.org >=20 > Signed-off-by: Yiding Zhou Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi