From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B9C794221C; Fri, 1 Sep 2023 09:12:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 068214029C; Fri, 1 Sep 2023 09:12:22 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 267A34014F; Fri, 1 Sep 2023 09:12:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693552339; x=1725088339; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=PdO6u1+YTGZnKJaCxcSxx1tOv4kMuffiBSW/NDjku4o=; b=IOF2dqfuSxzmryTCJUqQz0v2N9bF8l+BgFLR35/74DwW9Z96W1Wjy2zS u7n15kpkCOFjhoKqHgAOqLyrijK5Z/SB01G54rBSOMbP4QW7wAjYcUE75 XDPsLQ8hSdGn+aie0OYe19CMhq5zSfMtIjsgtor1GxVjeaNDJQNjv6n58 GGRrMJwUEQdkszpR7IJ2kMWcN6nBi/eILUCeInL05u0Q6koWCrjdyO+cF WLSV17N7NK9kxx3P31ej71Gp68kuD6csjihh3RNakGK5zGEX/QIiptUQb qzN6rRsvEU9ID0M/p6XaGZ/0PtqYiTXox5DLR2VUc5zIoWAGqOp4hTNxf w==; X-IronPort-AV: E=McAfee;i="6600,9927,10819"; a="355648561" X-IronPort-AV: E=Sophos;i="6.02,219,1688454000"; d="scan'208";a="355648561" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Sep 2023 00:12:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10819"; a="689651729" X-IronPort-AV: E=Sophos;i="6.02,219,1688454000"; d="scan'208";a="689651729" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 01 Sep 2023 00:12:17 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 1 Sep 2023 00:12:16 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Fri, 1 Sep 2023 00:12:16 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Fri, 1 Sep 2023 00:12:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fZtByKKwDfznLkvYPF2VDpbvY8zn9u2EdWNXUvD4B8u5MWsPF6xYYsDvwA/eq2kepLUPm1HsuUBWf0A6qw0U2CTMG5pcLDFG/cqV3YyVZ4+1tYFu6SH1y7iNDyUi8T12ZS0LhnFqMlsWtLurJsswbS3J03Kn8CtkfC+aMlLoU076KR9W8Ws8O32XGvVCxzaVCIqIgNL86wrDEkidJ2PkdqiINpK3xMsJzmY5MqTDdekcNSRCosWmAHLSVwn6wbGl9WLc1mH43kEnWIeCjjiXoIrdOD1BQi2U2w1wpNPOihRb9OF/xZCTZLpf7UmvSLvRxeKoZZOpHFnx6ISphF4cMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pnbdxy1QU7R6h8C1eqw1fE6ECtUptO8JU2/6rk5/pFw=; b=W9+k7h67E5ruxCstZdFScCZNK7X2KlK5y1HDqO1pEJ167UKfQ2l0ep15+pzy1yZNIGdeReXMMHITKMQH/OVKi/34jgp+Ek3XCR9QOYEHXSo9PpqOTOgp9DZ0107S/3IhVkv+tghvBLdwgaq/oy8Ana2cNKQ7GYbOwpacYURUn0e7y2gpKH4vNr3R3eoDQRKcDATWz32PipUg3F2SaMKdy783wSm9SVSicsIqJMv/i7AGBpXdh2ZXWcDmgsRTtinNdAph4pbb/O1lK1zcTPtRZ00AWFRjeViAWPWf5HFj/vSfnYU4CO4I7Ci9fMoCDDxzaiBCMua+Ks+TMAlIiHNpow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by MN2PR11MB4597.namprd11.prod.outlook.com (2603:10b6:208:268::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.23; Fri, 1 Sep 2023 07:12:14 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::8a49:15a2:ab69:91c3]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::8a49:15a2:ab69:91c3%4]) with mapi id 15.20.6745.023; Fri, 1 Sep 2023 07:12:14 +0000 From: "Zhang, Qi Z" To: "Richardson, Bruce" , "dev@dpdk.org" CC: "stable@dpdk.org" Subject: RE: [PATCH v2 1/4] net/i40e: fix buffer leak on Rx reconfiguration Thread-Topic: [PATCH v2 1/4] net/i40e: fix buffer leak on Rx reconfiguration Thread-Index: AQHZ3AdxjtaibwYSY0qw5Q6x4BfP0rAFjboQ Date: Fri, 1 Sep 2023 07:12:14 +0000 Message-ID: References: <20230830155919.592390-1-bruce.richardson@intel.com> <20230831123337.871496-1-bruce.richardson@intel.com> <20230831123337.871496-2-bruce.richardson@intel.com> In-Reply-To: <20230831123337.871496-2-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|MN2PR11MB4597:EE_ x-ms-office365-filtering-correlation-id: ca9b9521-cabf-45b1-77c4-08dbaabac48f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Mum4mCjtIVGNeJ6vDb/Mhdcn7bpsEslqtwB8RklCtGfP/8cDXooYiuzI0jescxhU6y9KFeODJhbANDPcGXTxQud80S8OWOoz0e829xbR6wrt57Pvk6pvXbOw7oPTNPJjuzdYWRnc7R/KhL/zZNp86CUNLedH4p55EACL9eV2XMD+24bnxR2GkFVvte7nNxFZEO0hVIdVoeKiAnrPGDovijFI5Pq05T11y1ZL9xY8lII2AI1jUtEi4w4ovo5f2XKFmgsD8geNUjUk5+sIMwCgfQINUUP4sXcWWTuOx2Gfm4hl+CGYvHWcFkTh9bL6Rs6It3mJyuzI3nMX8fCaDWcUcjhDy20efj2GvBCdiLgaWmfoc7WKWKsRHlRo2D71IdEcXJ+BUH7iTOU1JO1mvIlZOW1KioCqaimLxTR+qDm+DkSL0Ima58v4n+HUuuuj25js5S355hq/T/EjsE0dgvmRstKUqwVazSCRYv6TYg1/YxsNbAjX9LqoQ8JHHxjWGyvPio55c5gEZ0MiSodckiNb0ZLmzgy8j/1EKpGiwhuSAw0VhNNGjgW7l065aAmXjTQVrVrus6XfjTwJ2c5JLx8ZHafze4dIGNJkph3wQB42kCpSGB6HmawwS2GhlXoPy+8P x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(366004)(136003)(346002)(376002)(39860400002)(451199024)(186009)(1800799009)(71200400001)(7696005)(6506007)(9686003)(53546011)(478600001)(83380400001)(26005)(2906002)(64756008)(66556008)(66446008)(66476007)(316002)(41300700001)(66946007)(76116006)(110136005)(52536014)(5660300002)(450100002)(8936002)(8676002)(4326008)(55016003)(33656002)(82960400001)(86362001)(38100700002)(38070700005)(122000001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?PdJUUw9paRUozwgIj9cWLkOu0FWiZOO+wDTiOwkGWH8Md2OZ753PEdZRV+uD?= =?us-ascii?Q?BEVx2bxQUFxIGybYBoJrHuL24kyHs2g3DQob2u7C7LdBhJPrRF0CGZQbmt7U?= =?us-ascii?Q?FxmAy6g/I3GAoBeQsv8U+W00gTyFGYUMAzpaEZZC6vsFZevFshVqA6rbXq2x?= =?us-ascii?Q?d0G5xx7gNCcro2o/2QQyCZqIrzcXQKpDFDy1pvAehJw5pNwsPYLTESVGxLsU?= =?us-ascii?Q?9tyytMjFMYTfkCzBxN1x2fI7EKHnBbwDSmgfDRGxDK1/nDfloS75Mi9PR3Zl?= =?us-ascii?Q?9eJ7mLYzgynAa5vxzRitavkQtqTqZ56hMPd5ki7xQ1jDAX0eHVZ5cZTFbjgz?= =?us-ascii?Q?cXJZHUXBVrdaSHY9X1VSI2Fkxel0MVLxj54DqIhzm3Befb30VK52iWeAqENq?= =?us-ascii?Q?9HzUh5ta/uPRKrPx0vp+VyvKJLzNMFcAzQXbXkNWYm/qzoS5UcOH4SCFE52H?= =?us-ascii?Q?CtgVS1zT4ioJeSIazsr1ZeNf4VEcJpqAR6Nq1X9mH5O98D85oYWbpM/gu9nB?= =?us-ascii?Q?QvL7uqWF+ZcTknnssU+ozUN1hKKIXAdg+MUm/nsGfBx4cERj7DdauLjFsF+D?= =?us-ascii?Q?AhzUy7fW+uvhlFh3lfVqzvyTgX50w2ekTFY+1tdewVUMviZLrHEhNJuEjo1k?= =?us-ascii?Q?orB57e/MMQ3p1LvVkRGGOMH7263cOrhHsQCkxkT3hbbM6qovICoHa1c+jmNf?= =?us-ascii?Q?zUk6CnP1sXALnorL/2zEhm6ZCVxJIy4IDCxd8mZF2hBTCezIKvh1ksH0Jh1I?= =?us-ascii?Q?buiPaKP/cIQ3gOidFJM/UpXqeqgtbgk1aJPqo1XEMG/CvCcnhlYfHxr/BaEv?= =?us-ascii?Q?ylSulR0sFx2fGObURhMTHzeqYAKCRU5Bpi/iiWbj0Z5vBEKTEENWK+nr6gCy?= =?us-ascii?Q?PoU/5vSA/wzednrCIDmzdqIJV6Uya+JJKy4jSXfRMjArXgUzercU7xnaOWZw?= =?us-ascii?Q?hqSGpMuGsdm9RerjXojllAKSxPEIg8UNi3amtDwbgSdfmCkHH2fwpANbpWCZ?= =?us-ascii?Q?4ZuHZOv5UrN+hUnDEOZZtFxyvSOCepclChxR1h+GHqgg8s23HJBYz93YFQ8J?= =?us-ascii?Q?LyO4jVE0tMcUNN7lMKjqYre5CZ77I+q+AgBYSU6xntHlJlE5kgbYsqJTBl4k?= =?us-ascii?Q?H7fp1pBKp8Js3hu/Z+97aU0SJ1xw/E5/3w4ZEh+7LOkmH/61ni4CS+Zlj5dH?= =?us-ascii?Q?Nm6bKgxy3pfSRReci4mHGmBOJO6o5/BD/4MsDB+lR6PJ6c6lujTf4OrxZ+NN?= =?us-ascii?Q?qSsjWN+JF2Qd1Xtgz8nz+ulM5DeXxD1IgyCftN7G+LWbitr1NnjUMLytWUNh?= =?us-ascii?Q?bLCSM+dL0e3n6KvCmu690YYFMDzSH4KO7B+fzjEZDdQWJFLRbsCztfsQn/Di?= =?us-ascii?Q?Di+jG73MeUFKsjPbhsWcLvMPjmCg3eq6lxi24XdMV50CsyqNZXnxu4blkrAu?= =?us-ascii?Q?jFoOrVEj8RyZcQZPOxgZ5VxGXmjep/3/+xvfWhGCw135419m9UgjpmC94mHb?= =?us-ascii?Q?fH5I19JWyawWO5z7CqJJ40nx/Nho64W8b1qU3P+uNUxszTxtIbWH1mGx3MVQ?= =?us-ascii?Q?Gacdo0NCjDCigSt1AlKjidnwpXt4ehQkrVTDptVM?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ca9b9521-cabf-45b1-77c4-08dbaabac48f X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2023 07:12:14.0953 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zl3PaJ2qMF5LZ1jv51tL+C4+6k+lNYsJt0iHAUXzObtJy7cQGWZeJ5cUoInnWF1bvc/7nSeQx3wT1Qy5XVWKKg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4597 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Richardson, Bruce > Sent: Thursday, August 31, 2023 8:34 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Zhang, Qi Z > ; stable@dpdk.org > Subject: [PATCH v2 1/4] net/i40e: fix buffer leak on Rx reconfiguration >=20 > When reconfiguring a single queue on a device, the mbuf initializer value= was > not getting set, and remained at zero. This lead to mbuf leaks as the ref= count > was incorrect (0), so on free it wrapped around to UINT16_MAX. When > setting up the mbuf initializer, also ensure that the queue is explicitly= marked > as using a vector function by setting the "rx_using_sse" flag. >=20 > Fixes: a3c83a2527e1 ("net/i40e: enable runtime queue setup") > Cc: qi.z.zhang@intel.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Bruce Richardson > --- > drivers/net/i40e/i40e_rxtx.c | 6 ++++++ > drivers/net/i40e/i40e_rxtx_vec_common.h | 1 + > 2 files changed, 7 insertions(+) >=20 > diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c = index > b4f65b58fa..d96bbbb677 100644 > --- a/drivers/net/i40e/i40e_rxtx.c > +++ b/drivers/net/i40e/i40e_rxtx.c > @@ -1918,6 +1918,12 @@ i40e_dev_rx_queue_setup_runtime(struct > rte_eth_dev *dev, > if (use_def_burst_func) > ad->rx_bulk_alloc_allowed =3D false; > i40e_set_rx_function(dev); > + > + if (ad->rx_vec_allowed && i40e_rxq_vec_setup(rxq)) { > + PMD_DRV_LOG(ERR, "Failed vector rx setup."); > + return -EINVAL; > + } > + > return 0; > } else if (ad->rx_vec_allowed && !rte_is_power_of_2(rxq- > >nb_rx_desc)) { > PMD_DRV_LOG(ERR, "Vector mode is allowed, but > descriptor" > diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h > b/drivers/net/i40e/i40e_rxtx_vec_common.h > index fe1a6ec75e..8b745630e4 100644 > --- a/drivers/net/i40e/i40e_rxtx_vec_common.h > +++ b/drivers/net/i40e/i40e_rxtx_vec_common.h > @@ -201,6 +201,7 @@ i40e_rxq_vec_setup_default(struct i40e_rx_queue > *rxq) > rte_compiler_barrier(); > p =3D (uintptr_t)&mb_def.rearm_data; > rxq->mbuf_initializer =3D *(uint64_t *)p; > + rxq->rx_using_sse =3D 1; I saw some further code clean can be done by leveraging this change. > return 0; > } >=20 > -- > 2.39.2 Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi