From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
mschmidt <mschmidt@redhat.com>, "dev@dpdk.org" <dev@dpdk.org>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Rong, Leyi" <leyi.rong@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
"Zhang, Helin" <helin.zhang@intel.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>
Subject: RE: [PATCH] net/iavf: fix VLAN offload with AVX512
Date: Tue, 13 Jun 2023 00:38:13 +0000 [thread overview]
Message-ID: <DM4PR11MB599477EB065E4A20B3A87A5AD755A@DM4PR11MB5994.namprd11.prod.outlook.com> (raw)
In-Reply-To: <4584961.CvnuH1ECHv@thomas>
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Tuesday, June 13, 2023 2:02 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; mschmidt
> <mschmidt@redhat.com>; dev@dpdk.org; Richardson, Bruce
> <bruce.richardson@intel.com>; Konstantin Ananyev
> <konstantin.v.ananyev@yandex.ru>; Wu, Jingjing <jingjing.wu@intel.com>;
> Xing, Beilei <beilei.xing@intel.com>; Rong, Leyi <leyi.rong@intel.com>;
> stable@dpdk.org; Zhang, Helin <helin.zhang@intel.com>;
> david.marchand@redhat.com
> Subject: Re: [PATCH] net/iavf: fix VLAN offload with AVX512
>
> 03/04/2023 07:39, Zhang, Qi Z:
> > > > It has been observed that mbufs of some received VLAN packets had
> > > > the VLAN tag correctly set in vlan_tci, but ol_flags were missing
> > > > the VLAN-indicating flags.
> > > >
> > > > _mm256_shuffle_epi8 operates as two independent 128-bit
> > > > operations, not as a single 256-bit operation. To have the
> > > > RTE_MBUF_F_RX_VLAN* flags reflected in the resulting vlan_flags
> > > > for all 8 rx descriptors, the input l2tag2_flags_shuf must contain
> > > > the required pattern in both 128-
> > > bit halves.
> > > >
> > > > This fix is for the AVX512 Rx path. The same bug in AVX2 was fixed
> > > > by commit
> > > > eb24917428a1 ("net/iavf: fix VLAN offload with AVX2").
> > > >
> > > > Fixes: 4b64ccb328c9 ("net/iavf: fix VLAN extraction in AVX512
> > > > path")
> > > > Cc: stable@dpdk.org
> > > >
> > > > Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
> > > Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> >
> > Applied to dpdk-next-net-intel.
>
> I don't find this patch in your tree.
> Is it lost somewhere?
Sorry, it is merged now.
>
>
prev parent reply other threads:[~2023-06-13 0:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 10:07 Michal Schmidt
2023-03-29 1:05 ` Lu, Wenzhuo
2023-04-03 5:39 ` Zhang, Qi Z
2023-06-12 18:02 ` Thomas Monjalon
2023-06-13 0:38 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR11MB599477EB065E4A20B3A87A5AD755A@DM4PR11MB5994.namprd11.prod.outlook.com \
--to=qi.z.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=jingjing.wu@intel.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=leyi.rong@intel.com \
--cc=mschmidt@redhat.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).