From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
"Yang, Qiming" <qiming.yang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Liu, KevinX" <kevinx.liu@intel.com>,
"Mcnamara, John" <john.mcnamara@intel.com>
Subject: RE: [PATCH v2] net/igc: add I226 support
Date: Mon, 6 Jun 2022 12:06:38 +0000 [thread overview]
Message-ID: <DM4PR11MB5994781CF8EEB8C89933391AD7A29@DM4PR11MB5994.namprd11.prod.outlook.com> (raw)
In-Reply-To: <8688555.GXAFRqVoOG@thomas>
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Monday, June 6, 2022 7:46 PM
> To: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; Liu, KevinX <kevinx.liu@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>
> Subject: Re: [PATCH v2] net/igc: add I226 support
>
> 06/06/2022 12:54, Zhang, Qi Z:
> >
> > > -----Original Message-----
> > > From: Thomas Monjalon <thomas@monjalon.net>
> > > Sent: Monday, June 6, 2022 6:49 PM
> > > To: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> > > <qi.z.zhang@intel.com>
> > > Cc: dev@dpdk.org; Liu, KevinX <kevinx.liu@intel.com>
> > > Subject: Re: [PATCH v2] net/igc: add I226 support
> > >
> > > 06/06/2022 01:12, Zhang, Qi Z:
> > > >
> > > > > -----Original Message-----
> > > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > Sent: Monday, June 6, 2022 12:42 AM
> > > > > To: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> > > > > <qiming.yang@intel.com>
> > > > > Cc: dev@dpdk.org; Liu, KevinX <kevinx.liu@intel.com>
> > > > > Subject: Re: [PATCH v2] net/igc: add I226 support
> > > > >
> > > > > 25/05/2022 07:57, Qiming Yang:
> > > > > > Added I226 Series device ID in igc driver and updated igc
> > > > > > guide document for new devices.
> > > > > >
> > > > > > Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> > > > > > Signed-off-by: Kevin Liu <kevinx.liu@intel.com>
> > > > > > ---
> > > > > > v2:
> > > > > > * rebased
> > > > > > ---
> > > > > > doc/guides/nics/igc.rst | 14 +++++++-------
> > > > > > doc/guides/rel_notes/release_22_03.rst | 5 +++++
> > > > >
> > > > > You are sending a patch after 22.03 is closed, so it should be
> > > > > listed in
> > > 22.07!
> > > > >
> > > > > I will fix while pulling the tree prepared by Qi.
> > > > > Please be more careful with the basic checks.
> > > >
> > > > Thanks for capture this, have dropped this patch in dpdk-next-net-intel.
> > > > A new version is required.
> > >
> > > Too late, it is in the main tree with release notes fixed.
> > > Do you need more fix?
> >
> > OK, I guess we need to revert it with a new fix.
> > Sorry for the chaos...
>
> Why revert? If there is a bug, just fix it.
No a revert patch, I mean a fix patch with revert change on release_22_03.rst
>
>
next prev parent reply other threads:[~2022-06-06 12:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 6:04 [PATCH] " Qiming Yang
2022-05-25 5:57 ` [PATCH v2] " Qiming Yang
2022-05-25 8:55 ` Zhang, Qi Z
2022-06-05 16:42 ` Thomas Monjalon
2022-06-05 23:12 ` Zhang, Qi Z
2022-06-06 10:49 ` Thomas Monjalon
2022-06-06 10:54 ` Zhang, Qi Z
2022-06-06 11:45 ` Thomas Monjalon
2022-06-06 12:06 ` Zhang, Qi Z [this message]
2022-06-06 14:20 ` Thomas Monjalon
2022-06-06 22:53 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR11MB5994781CF8EEB8C89933391AD7A29@DM4PR11MB5994.namprd11.prod.outlook.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=kevinx.liu@intel.com \
--cc=qiming.yang@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).