From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D244A0542; Sat, 8 Oct 2022 07:46:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 159B840146; Sat, 8 Oct 2022 07:46:26 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 4ED5740042 for ; Sat, 8 Oct 2022 07:46:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665207984; x=1696743984; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=7Dy4iM3qykNW2O7roqUZgaZhQp9Y/VVr/Flbgks85Is=; b=h13UQiOF8Un+YIY46Vm6ulxnUKBBdLPXILy+NcDw1c08RvqzmPZfHx2c tRnbR+nlAiIrFJopPmOySkVIMaVKmYTOBPXsaG0FJ2AuyNZ6hipYsIods 9A3k2C+vYwXqzgxcqtgP5PJI/Lm/mhkhiL270RkCun/dFVChguo16ni94 nlWqFKiehfdioVNsiTE2ZNcb/n2f39Z+xUtxS0HRn2FNTVTKrMO+Sp1jW vyFFXrSNT+DulvZla5jZZ5CJ5jge61gq5IKCyknBYFL7v9qo8tz/erf+m x0MYQr9j8nBJ7TcKv4052o5rpm80PR2wNbHl06cfjAW1Y3RV162+oY724 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10493"; a="301501545" X-IronPort-AV: E=Sophos;i="5.95,168,1661842800"; d="scan'208";a="301501545" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2022 22:46:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10493"; a="729882697" X-IronPort-AV: E=Sophos;i="5.95,168,1661842800"; d="scan'208";a="729882697" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga002.fm.intel.com with ESMTP; 07 Oct 2022 22:46:23 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 7 Oct 2022 22:46:23 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Fri, 7 Oct 2022 22:46:23 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.106) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Fri, 7 Oct 2022 22:46:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W8Q8RyPgg8/Zl4LG3U4bnLi7+IvBCpQuaCRLpTi1rNJurwUA0iP4CZtkYR2OV+Vr66QCyVUGwlb82WuBBebBIpBYj7/U+SYqyoBdi8YwCWB5Vu+nyzkpxvV0fQPni3uhqGBZWi4tnyk87w++xPP5xYJcrzkPI4CWH82OVP7Sa+QnHMYFAsFDbenNZFRS7SQ4U1XgA8PHISeZOQQC01SOSkoClbSbF/QZi6yvZDY2NVYzfk+e7KbRiwfgTdFkxKueV00TT24xTd8eeOeIlq0DFazhc7FmK2gx643n8j4wdGwWTqKtYWvFoxTLaUxiLcRodmR0ynJz10Pwc4IZg9TlEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W3RK1S+TVA1vx0AO+HBxM9yKSd/BKlGL/L2YNAG1VRg=; b=aPRz4WSlnsSpvFEbZGwcCG9QFnJ9BiY+2c5nMR7Imfucp7DZZ0kOb7MQPYFYd8iVFY2pbyQi0SjIkAR2WPtTXMHxUvVM9jL+JAq1Q8V+/D4GYlct05DPH6A4w6JHP/bfk4NI3/MRQh2t97rOthSphI81fEHzV+q6e9VEV9DE7lXhm1CeDWGAGIr/PcfHgTGjpK/yXvkEqgfSYDOSWAsshPQWhD4KHw54V4i5uiz9r6+bTG1gpb/9nU9WZl3tOXinJYxnD9hfWYYZvsEE/O4GMzMhqKmP7vZjEVEjNu7E4UNDGqIFpZCk9bXBZVDASyxnk3F69HsghwkA6nHvjjkCJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by DM4PR11MB7373.namprd11.prod.outlook.com (2603:10b6:8:103::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.15; Sat, 8 Oct 2022 05:46:20 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::6fc4:1ff0:a5db:6546]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::6fc4:1ff0:a5db:6546%3]) with mapi id 15.20.5676.028; Sat, 8 Oct 2022 05:46:20 +0000 From: "Zhang, Qi Z" To: "Yang, Qiming" CC: "dev@dpdk.org" , "Yang, SteveX" Subject: RE: [PATCH] net/ice: fix DDP package init Thread-Topic: [PATCH] net/ice: fix DDP package init Thread-Index: AQHYwrGgVegsQ33f00OQaSMHfOhcIq3T3ngggDBMMbA= Date: Sat, 8 Oct 2022 05:46:20 +0000 Message-ID: References: <20220907120603.169681-1-qi.z.zhang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|DM4PR11MB7373:EE_ x-ms-office365-filtering-correlation-id: e4cda574-31e0-4923-9b09-08daa8f06d3a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZpcknV2Lo85EGbP3WCCVQRUgXjgL6oebINg2klY/myNRpiF0jz0hCXpjoVtthBPS7cvYD3qNhaDzu6fbq10H3z0IPFx8QDSysqYRm5EnBpEMjbD71jsDhEj1ODlenXG9MYHINXjgo0GSqfQJMaqLgTJ5Hu/yLLKl3RX3iRv16ul6tBlTghFG84i032kqDjMpNBUDlTjeye5zglqk5NDEd0b6/8fyjErh5MH3FdM9/f1qpdK3LQbULfy/cp7fqcq/fObpgO7w2Prr2KGaptlp/oisC7Sc0IOZjN39me+j8V2Xg671ifa2h6voSS1JHoLBPPz9NO3VT43UKJ6pjHQc/1+TYcReApqR7Us8I4UA+DvUHfAd+XQNqAvq3+OcwEHEOoqFKLAmpXOriG1xdW+Pvtx7slQVRHDSv+tOw+qNqWFwZ2iR2VAH5r90cmnrwSr06EY03eFjQjlVx3GB6DXpi9GcKn1xbvFnz0bdTrd9mw2YURdC2TcFVd+WdCaGC3Dd/bnYj21aPxDVHuVsGEW06S6XTUnKzdpwup2sLtNSl9G+iAAifuyN+x07GlUUQMVlL0F3yDIkVH4OgwmdngN54F6KTR1nPesR/BpgPp29pBTna3Yd8y0uF9W+MMHmaow2qXvpwTHXHTBr2p8vpxxB+nJwMY/+/HpRQDKbvfSBR7qNhtM+EXDtC3uGj1Sftg9jLPAp0U7O31KxnbYUY6lvM/ta03k52jAqXcYcr4u9L+8008kPpbFHZDXD+7NfdksJlCcuZX/JqrVFSqV0IhBxzt/PGD5FgOwgc/Pf3lgA2cU= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(39860400002)(376002)(396003)(366004)(136003)(451199015)(8936002)(6862004)(966005)(71200400001)(5660300002)(8676002)(64756008)(38070700005)(4326008)(66446008)(41300700001)(66476007)(186003)(66946007)(66556008)(76116006)(52536014)(83380400001)(107886003)(33656002)(53546011)(7696005)(6506007)(38100700002)(86362001)(478600001)(82960400001)(9686003)(122000001)(26005)(316002)(54906003)(6636002)(2906002)(55016003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7jcvK4E3ZCL4YRaNm4jIbXceZ1ySvkYk7PtK7ZIGjb4W7vGI9dOSjFaCaKaK?= =?us-ascii?Q?fP/QYVJlef6UWG5zFgQHrhRdtBtbpt324FTtc0DggroyKcYMSu9XGsmiotKn?= =?us-ascii?Q?/ln8UERIfx0BeSfRx0ZST/iaa3m2ECCkWcO8BtUO18t/TE/zaPmE0Mu0Wdk3?= =?us-ascii?Q?tmDJA0h7T8cVGbYFR4x3CMZCm2AOxP43pKybGGQohB2aRHCEKjv0PvUjWJ+r?= =?us-ascii?Q?O8Nqw11uC4M0Yv7JwIEftfSbdzyygWRTiHC87NbWc/K8aKe/hZLuqM/0zgAf?= =?us-ascii?Q?M2xJjKU5Hpqq5CtS2BRsHE9l8JPeqcHVdNaW19OOifI0EKwBp3v1pvvfIAVW?= =?us-ascii?Q?63Rk837xnWFkx6ofhg83FFv63gmBdpEi2qJmXy74bP+KF7mK7oIGs7jUIUzL?= =?us-ascii?Q?qFeJoh0yAF5PJs7Rarjr87fCmsdQlwMGIpkwzDDZevj/SskMQ65MBKpjU+0h?= =?us-ascii?Q?75U9HrMHRJub/5sPUSlxsjzwFZyNI8o1j72Ev9vKB7A+A9+f9cF6mbPD6Rzt?= =?us-ascii?Q?51zOpdV2n+v/z1p9KGadLLVvXfAqgo9SEpX1ubxtA5a6GiZOfk3tFN+Ktoj6?= =?us-ascii?Q?LSmjpn7LqNYcn3TOmPkQhlzLq8k70LRGiPy/HxhwhqwWgXU3MWj+29u20y4u?= =?us-ascii?Q?rL4khIIXaiEDbEWjqBRvEELTcO5lo67xoB8D4kK95EbExk+omOg7g+4jcbRk?= =?us-ascii?Q?nfHpcPSH52YCoPyXSCa7zooAIsqsaZSjt8Cx7HBr5gVr3hLuELubW3K/C87O?= =?us-ascii?Q?CILYKBuCh6eB7mkS7lMRjnvPm2ZjpuZ8xCLrvjJr4+dUaqCsVyOXXb8ooi1x?= =?us-ascii?Q?YpCr1yCPhVc1nr2D4mS3wjuK0hsQTmlz4pT5hvQY2z0wcCiVC1aXWBZWrSZr?= =?us-ascii?Q?RMgfPJcuTPtCSNjOM8IQQ1GZHYUXeGcP5JCYiRBzHrW+LPKSqvca+40z8VDR?= =?us-ascii?Q?74PeQA1S4lp1qNMGe8gxEYFGpepT/t9KD3+nLlYrXOmpFcx1PSSWfclaCOgh?= =?us-ascii?Q?nGoZ8msyjNGWvMXesDpj739roXi35UC2jcZcHpLMjoH+vdVJQ4Suk/DmXCWN?= =?us-ascii?Q?s5fx5TV/DPuqCRi1RT95q5R7x2Cg0bC58KCXYp1IPXrXEmjEOisSuytKy7JA?= =?us-ascii?Q?q4YxHLQGXgmMJbgyhKP4DtBS0BgsVqgNNfLPjPqedJCyUgXzioRDQF9iDtK2?= =?us-ascii?Q?BzLHy5gqpcpzdtn0t4izPVkejkIz6uSeYFfz0qRZ+2AdIMmIkEm/Lg1ElcjR?= =?us-ascii?Q?oATdHtn+K5b3MgO8azJ79n5mOGaEDwxDVdD47p4ZvXzkYZ22ZT3tp2idkUDx?= =?us-ascii?Q?YY+13tyE/gq1beSHW3nvhIvxqgx9cPGVllPCf3ZmCxpPtB4NQyt6FefmuWDT?= =?us-ascii?Q?Uu0FPBxZiiK5WrAk/S917Z9ZL733PdGDbLTK1MqT1sbJUtsg0XHVlAvzJ2AR?= =?us-ascii?Q?PTEr+EoVDrfllPEQMuiNMFvUxlduw/X9zghZdjB3XIgNoqX5qOWJEn1U8DRw?= =?us-ascii?Q?1oKWXQ/OXy6GkR6PmCJxx157xkhXf1bzRB5UWaPLxYnRoPREKHpXZ75itWcl?= =?us-ascii?Q?SN9ljmYSJDIX18CTxyjPlAyHzneEGVKtX0zlVTh5?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e4cda574-31e0-4923-9b09-08daa8f06d3a X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2022 05:46:20.4364 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: t8ZHcWvllHQ22DYTljrm5ONJ7COH+hKxLz1CZw3Xzu/KWcBB/0JHU0z78CqHjuuxVTYo1d1hdXty0OMufhS1SA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7373 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Zhang, Qi Z > Sent: Wednesday, September 7, 2022 8:05 PM > To: Yang, Qiming > Cc: dev@dpdk.org; Yang, SteveX > Subject: RE: [PATCH] net/ice: fix DDP package init >=20 >=20 >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Wednesday, September 7, 2022 8:06 PM > > To: Yang, Qiming > > Cc: dev@dpdk.org; Yang, SteveX ; Zhang, Qi Z > > > > Subject: [PATCH] net/ice: fix DDP package init > > > > ICE_DDP_PKG_SAME_VERSION_ALREADY_LOADED and > > ICE_DDP_PKG_COMPATIBLE_ALREADY_LOADED should not be treated as a > DDP > > package init failure. Use ice_is_init_pkg_successful to check return > > value of ice_copy_and_init_pkg. > > > > Signed-off-by: Qi Zhang >=20 > The patch has been squashed into below patch which has not been merged. > https://patchwork.dpdk.org/project/dpdk/patch/20220815073206.2917968- > 21-qi.z.zhang@intel.com/ There is a miss-operation in dpdk-next-net-intel, the patch actually has no= t been squashed. At this moment, since the target patch already be merged, a separated fix = is required. The good point is the original fix still has defect as a failure of ice_cop= y_and_init_pkg will not be escalated to the caller and V2 will fix this. >=20 > > --- > > drivers/net/ice/ice_ethdev.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/ice/ice_ethdev.c > > b/drivers/net/ice/ice_ethdev.c index > > fc889420c7..50fe23fdc4 100644 > > --- a/drivers/net/ice/ice_ethdev.c > > +++ b/drivers/net/ice/ice_ethdev.c > > @@ -1836,7 +1836,7 @@ int ice_load_pkg(struct ice_adapter *adapter, > > bool use_dsn, uint64_t dsn) > > PMD_INIT_LOG(DEBUG, "DDP package name: %s", pkg_file); > > > > err =3D ice_copy_and_init_pkg(hw, buf, bufsz); > > - if (err) { > > + if (!ice_is_init_pkg_successful(err)) { > > PMD_INIT_LOG(ERR, "ice_copy_and_init_hw failed: %d\n", > err); > > goto out; > > } > > @@ -1846,7 +1846,7 @@ int ice_load_pkg(struct ice_adapter *adapter, > > bool use_dsn, uint64_t dsn) > > > > out: > > free(buf); > > - return err; > > + return 0; > > } > > > > static void > > -- > > 2.26.2