From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B178A0544; Tue, 28 Jun 2022 09:00:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8CA05410EC; Tue, 28 Jun 2022 09:00:34 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id A4E69400D6; Tue, 28 Jun 2022 09:00:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656399633; x=1687935633; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=66ZRwsaSBDhcAgZ1PU7eKfPvKiAUtodgHShaYJTjdcM=; b=eVIm0DkWfnaf0lmTaZjElvPD7ZY81jozHtaSdwgFefEUgApqedIJSZOV +nEqTZmmNOJ70fwhl0pGVufy9prx8IJBrK9RowrBULOFaTCrUGt4Vx9Er dKPuKyiuUNKqmLqTZa8xMxpc6axcfNYZn0hFurOi0X5Z/OEs9KParTUyu 518Ka9N/Q4coI/Hhp+iUkrBV7K1IvCyzLof5q3fP2mn3C12lL73F7zPYy YSs9RaYZdiXsJVsCTSsXCG1WbOGw4OLrSRHksHjzzV9e5gaYtUdihBhZ5 MzqvTndGtSFh3aXZbEkwnr65BBXlOWn0dcNosEv17wxBaRe02hYgIVYFW w==; X-IronPort-AV: E=McAfee;i="6400,9594,10391"; a="280415061" X-IronPort-AV: E=Sophos;i="5.92,227,1650956400"; d="scan'208";a="280415061" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2022 00:00:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,227,1650956400"; d="scan'208";a="540387788" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga003.jf.intel.com with ESMTP; 28 Jun 2022 00:00:31 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 28 Jun 2022 00:00:30 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 28 Jun 2022 00:00:27 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 28 Jun 2022 00:00:27 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.109) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 28 Jun 2022 00:00:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eEf4r/v+X4vjWRaaIUJ3gqu3ifqqcT4H+WwsWjD06kAXoIoAI1K32FYpmHb35ogD99gk/U1FlR7yxL5F3EhJ7XnRgozh5lWJs58pZMpLWS255BFxkyUv3qb/nc6IJEGLLAN5JCHTjfOjTCr4IJlK9mNYh7s9hsOeZ4GE0HZWVKMRti68oPSQFHaBL/A5ozN1oFfQwq+woEVZoUb4/h9eda8SZuV80ZkN91aiyZEOqO0zgaTgD2kfye17MpLvq0UEToqTe14n/e2g5W9i8whvYxiuD0oOVsERsnaOgaZWBkD1ZwASun7roK2JaP/Cq5/2hWJhsSgMmlJsvUwV0wlJ3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=66ZRwsaSBDhcAgZ1PU7eKfPvKiAUtodgHShaYJTjdcM=; b=IxwcUcri8dYTpkNVTgvMbJxHm3bFooXAgVNIYeH8CxmSlnfC46c/qK2senRZbdOlUbfCn5Z+3m5kVP0V3oGuDBmrOtCAX/4rFgXR81H3TT7pCsCVM1OlLX+W/pBF5VsCdkQ8u6SkbWnxahYTCX6GUJeT7OKKzAkiX4O47u3UAkkx+HiGxWEXHW+neiLEoWoLV/WyzxKK+k6ZN3lepkSqqYMG51kZ21OyKZifWGhgXL7mVvqCtLsVyYJHyF6dCXD5GJkc5rvel9I3Sjg6s8zA8Mi7kuKN/Wn/8jRUSoiZzFirDU2n4gXLsHiLAmBjSJxDKn/9Ah1Dk/W28xIokXiyWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by MWHPR11MB1536.namprd11.prod.outlook.com (2603:10b6:301:b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.18; Tue, 28 Jun 2022 07:00:26 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::644f:ecd2:47d0:aa6d]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::644f:ecd2:47d0:aa6d%3]) with mapi id 15.20.5373.018; Tue, 28 Jun 2022 07:00:25 +0000 From: "Zhang, Qi Z" To: "Zeng, ZhichaoX" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Yang, Qiming" , "alvinx.zhang@intel.com" , "Guo, Junfeng" , "Su, Simei" , Ferruh Yigit Subject: RE: [PATCH v3] net/igc: move the initialization of data path into dev_init Thread-Topic: [PATCH v3] net/igc: move the initialization of data path into dev_init Thread-Index: AQHYirdRuxfUarQ9W0S7+lZoqL0W6K1kYm/g Date: Tue, 28 Jun 2022 07:00:25 +0000 Message-ID: References: <20220622104907.862666-1-zhichaox.zeng@intel.com> <20220628062052.5397-1-zhichaox.zeng@intel.com> In-Reply-To: <20220628062052.5397-1-zhichaox.zeng@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c682134b-e169-48e3-0dec-08da58d3e08b x-ms-traffictypediagnostic: MWHPR11MB1536:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4Z+fGgq4W1Y0jq3pNMQrs0svQfYYLNMWFbEgH9k/q+oSnqMKklfaPIrK/9veRff8gDUeIE3zLU2P/Dksf4NEA107RIyclhEtz5oxdmzC/D/SfDWVgf824wJ3qqXhhSVOBlNWidpPHvxVWVh+TdphQh4AxrdV2H416T6TtVyw2eZIQUNWwlUDM9dsMwhBCLjZOpPEQh6BUVn46UHLXOYHC9mBkOwnLJa87CbPMqINTDmGM046Mw8F0syI0wRiBNXP2+ytkFg5Gf3J6QjU6+FGQcBAAGXiVQvVnKpzZ1MAse3Ymr+bpXVBQ5DWyIJ5fqsXB+Hfr7N/kzFZkGaJzyll028SLrDkOFX6d5SS2UEgPi99N5zVRdrWgKYTzHw7YhAf0cSoYViIOFO56z08qplgSDGkPC1lQ07v6mtrzMAwq06R4p5SwqWMDIoEvrJ8/fMByi3kyCl9cx2EC08atIYZMOq5sFRGgRBE1aDBn9AZwZqHgXELfwNk+145FhHq9MmMHLrmkUSjtbNvCuMTObICOhQ8TTiGG24jsEhuw8guXodA4vVJ9R6glX6+T5Bc/d1PXNAq5nn9cKklQ9M7rkKCNF35gs6LCCae/qez+/MkPzF3pAkzkuBOGU0gDNPje6lpX5Kdsj4w98+4aPgm8vjpWdyZnWYTtggVwXEV5i21qzC7ikrxZnDFjqYV43anAiqKmYDkXGTEhbsDm2NYzpAdrcH8lWxU0awo5+7MNHWEpwT+9YsaEPyFApqjxwud0isNnUDb35iPTaNHIJAETW4QYziXEVW5trT9EPaPjwDC/zQ= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(346002)(396003)(376002)(39860400002)(366004)(136003)(2906002)(52536014)(54906003)(122000001)(316002)(82960400001)(53546011)(5660300002)(186003)(38100700002)(86362001)(110136005)(41300700001)(107886003)(76116006)(8936002)(7696005)(66556008)(66476007)(9686003)(8676002)(450100002)(4326008)(66446008)(66946007)(83380400001)(64756008)(33656002)(6506007)(71200400001)(478600001)(26005)(55016003)(38070700005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?q+LpYJEOSPBmrVs/QB7KocyqmW0bDPqrNGM4fxbkraI/QW8k7TNQIFNmZKQE?= =?us-ascii?Q?PH6YOlCObf7hp16mP5db9XtVZWo5aq8rebxNPOYqrMAhBRNdB4ewiR9+zw7W?= =?us-ascii?Q?BBSwSAYk8MYUiq+g5m8fCyUiCBLvyOBbyNP9oAFB/Y3HQa5aNTMxta3pYyPo?= =?us-ascii?Q?3dtu/KD0L6llrwL7+opyAdILQ1RmTbHF90GFvfYDjgj5399l/Qi2/SywB6ND?= =?us-ascii?Q?ywUojEAOUesC82kA70z7Gk7Kf5gCiNfDU2yGnv7oB4PCpnBzWPlTvj5+irjn?= =?us-ascii?Q?aelthsdkdEYj2ZQSqymKy2IVdLbQjPxBLpfwXA41cnYHvEqSAFRXVSDv1S1C?= =?us-ascii?Q?D+7n1K9K42D4SeuIXfaCUlUuM5rVoobHoCK0wLneFEcZsZOivGVXfwJnoOwE?= =?us-ascii?Q?lN6hQJ62/u32RMG8fgy6OMY7rcMys7f5xo9igHq8Ute9R/pkUGx0l5ywZp+O?= =?us-ascii?Q?qixBBMJMKMBgvu841Cxlvugoe2/1uFmKpNngDDfNMopgKXDNVCcDfUavWxHj?= =?us-ascii?Q?UKxY2nJlWq0C8YqEYBFwXMI2lIF/OVBK7+s0qMqjGHRLwNDnTg7QTNJoglEF?= =?us-ascii?Q?2NFeEt3hciVeQAEepTLzT7DuvQnYYdT1Kc10uTGq/c8TtuL+8oxVD7Pt5lvz?= =?us-ascii?Q?3ZyKTWHxbDGNcu99HpSW32/ARPq5SkgecMrx3q0fzNZvkcZf+qLjLQf2hsgW?= =?us-ascii?Q?+rVBZJkdVMz3PuFlwJfhhEazgaS3oiXoNz6CnJTv/wQgcHsgdxG3c53zl2rF?= =?us-ascii?Q?NTzT2i5fbnnSX16uWlPJZmU89XSv+UQQWfqY0re3rpYd8uQiFCfLLRIF8Qj2?= =?us-ascii?Q?zgmBSX1RGGkzT8WFwF03W4l4ALCX4lyUK7+FFFGC/1gzrQtpKsffNBI9l0WF?= =?us-ascii?Q?jUWeJne4OPAUOO/+iYNRUWM816QefkbDFJl02zoWDb2SUq9rUCkcr2Hcu1vn?= =?us-ascii?Q?RgOGn3y5xrc0R+a7zkp4NLEBv0FDfHTB98+iAsji50GS21lk87CuBBri7Oct?= =?us-ascii?Q?8c3VvUuMKgPRasDC7YlnfZSra7wWfJhejY/xWQfKpUUky6UY0wuqVmNJxiMq?= =?us-ascii?Q?Eut1AfIc064hHORS1VVGchZIM7RDLX0d+WsyYAWamGQ4zWl4ElA4AsVWrbrt?= =?us-ascii?Q?3zHTF1jl2ttjzuQFejeQLNYYaVIVNKSsFkx74hcpNM//wXTvaQo8tDb5rCv8?= =?us-ascii?Q?L+96aZQsRlku51g8g5Twia8IjrvugOhNptOVuHkxDPdBJlOGdaMhBfXRzsKm?= =?us-ascii?Q?vfJDVsWI5t6/kEU1bgdrHrEV8tvfji9rB0RTm40suIEq+p6KTRT6eckdPTrQ?= =?us-ascii?Q?U52myT/8hMfyWqz6aDRbX++jxd1DvxH0Tx3f1ajVrSGPPbPx+mCjHcnMNQ/k?= =?us-ascii?Q?3OyUjxjqsQgABDi1EweXvhPuaPHZjU+lmjrVvIMJ6NXV+UyaHHpwF8aU8V89?= =?us-ascii?Q?xiGlLNmX/qYJ3ahELkQJcia71TuSC4GQTLTaynU7znzAvPiqNmvoa8mv0R0/?= =?us-ascii?Q?bS+RxZJ8a6KuVKqQradMv4WQSFip/79rDILagEr5uBKRcYdRN1ZjIUNL0yhl?= =?us-ascii?Q?Mm91oHXm6ULcO0t90qtRuSYYMCG5n6CVGWi+0fG7?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c682134b-e169-48e3-0dec-08da58d3e08b X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2022 07:00:25.4274 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iMFYeMdN6r+iVzjGtduwhleaVSNlQhNjyZY1P34OyF6ceWc11ZWeRam2tuOMR2fCmbXN0uL/6jVuFVr5kJ1TtQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1536 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Zeng, ZhichaoX > Sent: Tuesday, June 28, 2022 2:21 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Yang, Qiming ; Zhang, Qi Z > ; Zeng, ZhichaoX ; > alvinx.zhang@intel.com; Guo, Junfeng ; Su, Simei > ; Ferruh Yigit > Subject: [PATCH v3] net/igc: move the initialization of data path into de= v_init >=20 > From: Zhichao Zeng >=20 > The upper-layer application usually call the common interface "dev_init" > to initialize the data path, but in the igc driver, the initialization of= data path is in > "igc_rx_init" and "eth_igc_tx_queue_setup", while in other drivers it is = in > "dev_init". So when upper-layer application calling these function pointe= rs will > occur segmentation faults. NO, for most intel PMD e.g.: i40e and ice, we don't initialize data path in= dev_init. >=20 > This patch moves the initialization of data path into "eth_igc_dev_init" > to avoid segmentation faults, which is consistent with other drivers. I saw dev->rx_pkt_burst can be overwritten in igc_rx_init, I assume the iss= ue still be exist.