From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0BBA2A034C; Tue, 30 Aug 2022 04:03:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 92E6D40F18; Tue, 30 Aug 2022 04:03:49 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 448EC40F17 for ; Tue, 30 Aug 2022 04:03:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661825028; x=1693361028; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Zn9u8KfN6qOMTCt0fF9LkesX2a+VlJhtSPTFGaURktg=; b=RbC8DMHOGnOOJrLlyOIt+v5CFFr7OJGqEwEX7OgSjGZwty0B3tsi3X5O LtuP7XNSNcj7mKXtzissuzsN+fI4PRhq927432GE05MqnYq+ADKOKfnDz AMiWo/HV9u7MakbPojSm4Up7TTQMnVJEw4vLdMG7uBzTJK7Hro04xQPnA Ifcew60OqbuE0x8DYAFdmZ1x/kvijH8+6gee17SYs7/FCEP00shaw/tJn K1o8+b51HVhdBkV/5lw+ZjsBELEcQ3tREf6cJ76D/xd7B4RSQF6SJOCri U9G4DUFC+S2vNO+1+54RjQdwMKOpJ0TynMO23a3HvD2ieshOpdpHgA9aR w==; X-IronPort-AV: E=McAfee;i="6500,9779,10454"; a="356771267" X-IronPort-AV: E=Sophos;i="5.93,274,1654585200"; d="scan'208";a="356771267" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Aug 2022 19:03:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,274,1654585200"; d="scan'208";a="562461778" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga003.jf.intel.com with ESMTP; 29 Aug 2022 19:03:42 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 29 Aug 2022 19:03:42 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 29 Aug 2022 19:03:42 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.46) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 29 Aug 2022 19:03:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jIBaFxB2kVdYmrqDIk2h+XSIJ2Xz+wjLcCoW4AEUkv6R/JrA8Jlqhzgl1ZSOO8CD6uPM/gTrcKnFdQzYWZaxWTf8YTMPcNi/81GP6oRFm/2Edwq1YzO8OzAimyjcIEZHvi1Jsc6n47Ysa3J86nNLizMmpvfoO3mXRzu8JqbuKbSkpwT0cXpKVgQlwdxmIjJEESlBJbVGB7YMJtXexF98pNRGh5pWTuQJwKvrayIQIq5+b2sph41WvTBCYAoKsd+k1bU9KFtRdujgY9Xu7TO5WA+o3nmsk6ZjKiV7uFJE9QMFRP5v8WdxVpfyjdhmdcWLZwjfWtQdVCLjCr+AqIPUxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zKgRDhMp2RFo9k23+H/D3VNCDbrdHYToAiq3cdQ17YU=; b=LhzQD+WlawK24qVt1GvXRG/vH+DfJOVLQnoN6tHJODgoecqWMckPZWnJQG85qrLntrDuSlWJafw9ekmFoDEUM0QVyE/wxpIhw6O4gXiOgSj5sh+KUteMTIzw8Y3kfKeAAxVpuoc95Gu8Z1ws168U3eKWB96oKpJhL9CIOJfbChSyKHv3AwgLt+cypAz71GFmczqhPgpCu9QsiMSvmECVnEdYShoBrXl9Zybgh/h0tkrRtCBCEqdUrt4TKSMWC0yyiMzyUkX8fgvamNfaWfhxsGoTYk1/VVPuR7EVVods9jgVUcONADMFLo/QPfC45TIvjYGKE9uzJaK8vwKv/spTWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by DM6PR11MB3017.namprd11.prod.outlook.com (2603:10b6:5:6f::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.14; Tue, 30 Aug 2022 02:03:39 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::d94c:1798:9e3b:804e]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::d94c:1798:9e3b:804e%7]) with mapi id 15.20.5566.021; Tue, 30 Aug 2022 02:03:39 +0000 From: "Zhang, Qi Z" To: "Liu, KevinX" , "dev@dpdk.org" CC: "Yang, Qiming" , "Yang, SteveX" Subject: RE: [PATCH v4] net/ice: refactor proto_ext to remove global variable Thread-Topic: [PATCH v4] net/ice: refactor proto_ext to remove global variable Thread-Index: AQHYuPHeKeS43UW16kGe3pYcicBtva3GtcUw Date: Tue, 30 Aug 2022 02:03:39 +0000 Message-ID: References: <20220727165901.457146-1-kevinx.liu@intel.com> <20220826101458.1520919-1-kevinx.liu@intel.com> In-Reply-To: <20220826101458.1520919-1-kevinx.liu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: be39baee-ad81-4a2d-f1d8-08da8a2bdb8c x-ms-traffictypediagnostic: DM6PR11MB3017:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oKLdMLdIHienrJG7o4D1OGXhVV8EmzoLNbxu3VsM8XyHAOF/jAQ4ZPJH1d0ma8k3/MGqrXPtKdfTOOaUJ9esr4+3+CvhMJdFZI/HQRxm1hstuDUMr/JVcEj8cjt4AgDBHxCZmgfb8ZxJ1JMfPFzx0qksRnwdYyuZ4D/G4wLRBw4Fl2PNN3KnbmU46yNpa7gumXrsl4rpUNeUdECEiUTZJx4cYwU4OhV/YRP1rubsgKyj2zo/OZYvc+T9L7Wx+xijNEMDKfBrKvO+uJdMYf5ALh9/okWcfEeXJCKpnudvw4lBijJfqYFaoQzfzddnSEYvsVBbx3iB4KUJCIo8T2v/1GH15b0c6OtqTn2PVuCy06B/rPPUAqOLbEhCw28eo4xHhl5s5Fc6NcKD7KRna9RDwXm2hLYd+jgyXWmWLR0kePYfJp52934fZW8VXZ9rBjf9JUgPuNEYvQMAp8b+98onzRvsJAu1PqWdIwq4YVLhTiTGGGoX255esU5K9mKs2vBO6Iowk9Z2n82lhzuZcI8TNb4qEwE6YmjvB+nxYih43BTs305LnEaL027t2ScczoJnBQM80aBTZ/eijUc1cuEanQ17WyX8zuQ3EYXbBfqAySf9Cd8WzFf41QayT9VDgx2aTTMdl7TswgpbtR5dRS5bwWwQiBSnZL48STX6L7hV93aexYoQ0f5tN4SsyHw6ZbaCIWYl+keueZP9rCK7ufve/JFxVEBaZPl0AEfEkd2cjqPPWgNpKjislVxXEkQu3dMJQQDjrFs6R3TYg/7xqtgAtQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(346002)(366004)(39860400002)(396003)(136003)(376002)(6506007)(53546011)(7696005)(122000001)(38100700002)(83380400001)(2906002)(107886003)(55016003)(33656002)(186003)(9686003)(8676002)(86362001)(66476007)(66556008)(66946007)(71200400001)(64756008)(66446008)(76116006)(110136005)(4326008)(316002)(26005)(54906003)(52536014)(38070700005)(82960400001)(8936002)(41300700001)(478600001)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?it5ctlw4ZFg/aXUOsnlyavTPTVcB3MEliW32qPN4IHE1XByOIEYtXnjVkD4m?= =?us-ascii?Q?NdaZ63ST6v+G6VhYfebUac9/Q6NHOoN8cJwXMwffNCwSxW2Zv++0DGCg92cl?= =?us-ascii?Q?J1r7HXvaUPTiv2/QHqQR5BMuMndrdLJD3kr+DnQhJ6eVCknKOblLYQapollI?= =?us-ascii?Q?/gwyGRqTJajgj+QvQNJKSE1pVFVdrB7pwW3UC4furkqg+fgOrEfejyK8vn0Y?= =?us-ascii?Q?mxXbMVFMDTyg4sokByOOmF5m2/fOr4MYwybtHoVbvFOSh5+lZSTGt8Wi8dtu?= =?us-ascii?Q?g+A9zgD7UHTf71K7hLPVZHoyRY2JxgH5FnWcmklgPFP70lS0LagiI2u4zQ8o?= =?us-ascii?Q?8BHHgRdLwrpQakkfO7xxMTq84iyfZnCfKw/9jL/Dgkjvf2iLNSMAXHBj22vr?= =?us-ascii?Q?ivkqXCSbanIVak3WmrLqi5pGlyrSXN3FcALr8C7O5CPq8mJHdxB+0jIc7o+p?= =?us-ascii?Q?1ZMsZ8UP044ElToDF8oWQGzrJqsTTV3Y6Ot8amdzD1FZS4yJTIL8n8neDUjA?= =?us-ascii?Q?FeyFyUHUv2h17u0hfFtMrqwbsvQfYroPsLxmkeiJnB28Jk4M8iETGMeuQphI?= =?us-ascii?Q?I0EtF628peiyn8XgH0nI4ldM7SUA3hI9uD/vyscUja5hk5IJQ8F1lk98z0QC?= =?us-ascii?Q?doIL+P2m3CzUOfl9EtWpX7TX3PW4q8aZpAMOX9kwQ8f11KyVjz7l1JxIRaci?= =?us-ascii?Q?OXwO7qPEPxsIwl5icTeFn5PcjzqGfrzA+khGsLpgPVHC3xQFlb7Mk+rewpRb?= =?us-ascii?Q?Ej+TFIe2HVUCXU/k7xTETC1oSqycGtEMoA9N+oThzvkSiPWaDM+6tHLK2ne3?= =?us-ascii?Q?IsfYDCna0ssqzdgunNAX4kVv3R4B8XIkBhg3KE3zc0PfuSgmpdB780mQkGVX?= =?us-ascii?Q?gq2fRcmU6la4V+gbd9OXFS0YNzj0RyegIj5w6YTKhBOidV4wCR0v/YNTEVc2?= =?us-ascii?Q?YSt1V4QKXoT4fQh2bsai+ENbcAuLmVqYosaWvchjtfuqqrDfJqpeeoinfA2F?= =?us-ascii?Q?bWlnh3n2e8GlE0b1zsaxoozjQf76ahvnrXPf6RRhn/0KlbB0rz1GeIRFpF12?= =?us-ascii?Q?UB93O1RIFGk/rJpfF2XiKO2ITvhqjVg3nuNSuOPVIN4mbw/DLzVzZbDc+rUk?= =?us-ascii?Q?Aq5QFX/bPuKa49PhodDy6iiwkCfYFqqii1GwvQuxoyXawOktlhiO6Pz8YSar?= =?us-ascii?Q?BSXsLCpiDw5N3Q1IZpBDPhU+ZCVKUS4aicdtJfJqJzSLZ4iE9hefK7IzxjLK?= =?us-ascii?Q?ySEBPiph1EFtt1jwGKfN1QR/jJssC8rpLX0Cz0CxHk+es/RuvkyI9XgL4lA3?= =?us-ascii?Q?DQ39RzLtmeJLcDe4Ba6cveg+1tS4uWqC3eMLxAEm+RXlEo5lRs2qLZVqtnyB?= =?us-ascii?Q?LVvlORhzH6JOVQddBb5e/nCMp5s6IV1DUOLMrn/fVrzlZdvHC43c460EFPMe?= =?us-ascii?Q?1TXnZwnv9LpnsBsZ1JkIaFKHmFDSiKVcvvJNBdjs97qFJ6oDRcGDNPGordB5?= =?us-ascii?Q?mR1FRUOiUku+Vvss/eg7YAo7C2fz/KprJofXTJvHdUNHDeDPK3kHsBaIKf2G?= =?us-ascii?Q?mFarGF1XTfDIumIA5Y/JgdisD8gQrvbi6irwekNo?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: be39baee-ad81-4a2d-f1d8-08da8a2bdb8c X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2022 02:03:39.7708 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9mSRP4ehCa/GiYbLds9+EAjw19XmIsl02F2ePQntoWtAbGSeqLrxPN9cPu6tuMQukPsqIPzrlDVQmaEJ8vkDWQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3017 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Liu, KevinX > Sent: Friday, August 26, 2022 6:15 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Yang, SteveX ; Liu, KevinX > > Subject: [PATCH v4] net/ice: refactor proto_ext to remove global variable >=20 > The ice has the feature to extract protocol fields into flex descriptor b= y > programming per queue. However, the dynamic field for proto_ext are > allocated by PMD, it is the responsibility of application to reserved the= field, > before start DPDK. >=20 > Application with parse the offset and proto_ext name to PMD with devargs. > Remove related private API in 'rte_pmd_ice.h' and 'rte_pmd_ice.h' file. >=20 > Signed-off-by: Kevin Liu >=20 > --- > v2: Delete doc content related to 'rte_pmd_ice.h'. > --- > v3: Delete doc content related to 'rte_pmd_ice.h'. > --- > v4: refine code and change the check mode of dynamic field. > --- > doc/api/doxy-api-index.md | 1 - > doc/api/doxy-api.conf.in | 1 - > doc/guides/nics/ice.rst | 33 ++-- > drivers/net/ice/ice_ddp_package.c | 1 - > drivers/net/ice/ice_ethdev.c | 113 ++++++++++---- > drivers/net/ice/ice_ethdev.h | 7 + > drivers/net/ice/ice_rxtx.c | 45 ++---- > drivers/net/ice/ice_rxtx.h | 1 + > drivers/net/ice/ice_testpmd.c | 2 +- > drivers/net/ice/meson.build | 2 - > drivers/net/ice/rte_pmd_ice.h | 247 ------------------------------ > drivers/net/ice/version.map | 7 - > 12 files changed, 122 insertions(+), 338 deletions(-) delete mode 10064= 4 > drivers/net/ice/rte_pmd_ice.h >=20 > diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md index > 186a258be4..e578800cea 100644 > --- a/doc/api/doxy-api-index.md > +++ b/doc/api/doxy-api-index.md > @@ -44,7 +44,6 @@ The public API headers are grouped by topics: > [KNI](@ref rte_kni.h), > [ixgbe](@ref rte_pmd_ixgbe.h), > [i40e](@ref rte_pmd_i40e.h), > - [ice](@ref rte_pmd_ice.h), > [iavf](@ref rte_pmd_iavf.h), > [ioat](@ref rte_ioat_rawdev.h), > [bnxt](@ref rte_pmd_bnxt.h), > diff --git a/doc/api/doxy-api.conf.in b/doc/api/doxy-api.conf.in index > 608494a7c0..6fab7436d7 100644 > --- a/doc/api/doxy-api.conf.in > +++ b/doc/api/doxy-api.conf.in > @@ -18,7 +18,6 @@ INPUT =3D @TOPDIR@/doc/api/doxy-api- > index.md \ > @TOPDIR@/drivers/net/dpaa2 \ > @TOPDIR@/drivers/net/i40e \ > @TOPDIR@/drivers/net/iavf \ > - @TOPDIR@/drivers/net/ice \ > @TOPDIR@/drivers/net/ixgbe \ > @TOPDIR@/drivers/net/mlx5 \ > @TOPDIR@/drivers/net/softnic \ diff --git > a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst index > 6b903b9bbc..432c6fd7ed 100644 > --- a/doc/guides/nics/ice.rst > +++ b/doc/guides/nics/ice.rst > @@ -110,29 +110,43 @@ Runtime Config Options >=20 > The argument format is:: >=20 > - -a 18:00.0,proto_xtr=3D[...] > - -a 18:00.0,proto_xtr=3D > + > 18:00.0,proto_xtr=3D[...],field_offs=3D= , > \ > + field_name=3D > + > + 18:00.0,proto_xtr=3D,field_offs=3D,field_name=3D >=20 > Queues are grouped by ``(`` and ``)`` within the group. The ``-`` char= acter > is used as a range separator and ``,`` is used as a single number sepa= rator. > The grouping ``()`` can be omitted for single element group. If no que= ues are > specified, PMD will use this protocol extraction type for all queues. > + ``field_offs`` is the offset of mbuf dynamic field for protocol extrac= tion data. > + ``field_name`` is the name of mbuf dynamic field for protocol extracti= on > data. > + ``field_offs`` and ``field_name`` will be checked whether it is > + valid. If it is invalid the value needs to be reconfigured. It is not clear here, better just describe when the configure is invalid wh= at kind of failure will happen