RE: [PATCH v2] net/i40e: don't check link status on device start

["Zhang, Qi Z" <qi.z.zhang@intel.com>]

> -----Original Message-----
> From: Su, Simei <simei.su@intel.com>
> Sent: Monday, March 6, 2023 2:54 PM
> To: David Marchand <david.marchand@redhat.com>; dev@dpdk.org
> Cc: stable@dpdk.org; Zhang, Yuying <yuying.zhang@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: RE: [PATCH v2] net/i40e: don't check link status on device start
> 
> 
> 
> > -----Original Message-----
> > From: David Marchand <david.marchand@redhat.com>
> > Sent: Tuesday, December 13, 2022 5:19 PM
> > To: dev@dpdk.org
> > Cc: stable@dpdk.org; Zhang, Yuying <yuying.zhang@intel.com>; Xing,
> > Beilei <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> > Dapeng Yu <dapengx.yu@intel.com>; Wenxuan Wu
> <wenxuanx.wu@intel.com>;
> > Wang, Jie1X <jie1x.wang@intel.com>
> > Subject: [PATCH v2] net/i40e: don't check link status on device start
> >
> > The mentioned changes broke existing applications when the link status
> > of i40e ports is down at the time the port is started.
> > Revert those changes, the original issue will need a different fix.
> >
> > Fixes: a4ba77367923 ("net/i40e: enable maximum frame size at port
> > level")
> > Fixes: 2184f7cdeeaa ("net/i40e: fix max frame size config at port
> > level")
> > Fixes: 719469f13b11 ("net/i40e: fix jumbo frame Rx with X722")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> > Changes since v1:
> > - since the CI reports a failure on v1, simplified the fix by only
> >   reverting commits,
> >
> > ---
> >  drivers/net/i40e/i40e_ethdev.c | 50
> > +++++-----------------------------
> >  1 file changed, 7 insertions(+), 43 deletions(-)
> >
> > diff --git a/drivers/net/i40e/i40e_ethdev.c
> > b/drivers/net/i40e/i40e_ethdev.c index 7726a89d99..a982e42264
> 100644
> > --- a/drivers/net/i40e/i40e_ethdev.c
> > +++ b/drivers/net/i40e/i40e_ethdev.c
> > @@ -387,7 +387,6 @@ static int i40e_set_default_mac_addr(struct
> > rte_eth_dev *dev,
> >  				      struct rte_ether_addr *mac_addr);
> >
> >  static int i40e_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu);
> > -static void i40e_set_mac_max_frame(struct rte_eth_dev *dev, uint16_t
> > size);
> >
> >  static int i40e_ethertype_filter_convert(
> >  	const struct rte_eth_ethertype_filter *input, @@ -1711,6 +1710,11
> @@
> > eth_i40e_dev_init(struct rte_eth_dev *dev, void *init_params
> __rte_unused)
> >  	 */
> >  	i40e_add_tx_flow_control_drop_filter(pf);
> >
> > +	/* Set the max frame size to 0x2600 by default,
> > +	 * in case other drivers changed the default value.
> > +	 */
> > +	i40e_aq_set_mac_config(hw, I40E_FRAME_SIZE_MAX, TRUE, false,
> 0,
> > NULL);
> > +
> >  	/* initialize RSS rule list */
> >  	TAILQ_INIT(&pf->rss_config_list);
> >
> > @@ -2328,7 +2332,6 @@ i40e_dev_start(struct rte_eth_dev *dev)
> >  	uint32_t intr_vector = 0;
> >  	struct i40e_vsi *vsi;
> >  	uint16_t nb_rxq, nb_txq;
> > -	uint16_t max_frame_size;
> >
> >  	hw->adapter_stopped = 0;
> >
> > @@ -2467,9 +2470,6 @@ i40e_dev_start(struct rte_eth_dev *dev)
> >  			    "please call hierarchy_commit() "
> >  			    "before starting the port");
> >
> > -	max_frame_size = dev->data->mtu + I40E_ETH_OVERHEAD;
> > -	i40e_set_mac_max_frame(dev, max_frame_size);
> > -
> >  	return I40E_SUCCESS;
> >
> >  tx_err:
> > @@ -2809,9 +2809,6 @@ i40e_dev_set_link_down(struct rte_eth_dev
> *dev)
> >  	return i40e_phy_conf_link(hw, abilities, speed, false);  }
> >
> > -#define CHECK_INTERVAL             100  /* 100ms */
> > -#define MAX_REPEAT_TIME            10  /* 1s (10 * 100ms) in total */
> > -
> >  static __rte_always_inline void
> >  update_link_reg(struct i40e_hw *hw, struct rte_eth_link *link)  { @@
> > -2878,6 +2875,8 @@ static __rte_always_inline void
> > update_link_aq(struct i40e_hw *hw, struct rte_eth_link *link,
> >  	bool enable_lse, int wait_to_complete)  {
> > +#define CHECK_INTERVAL             100  /* 100ms */
> > +#define MAX_REPEAT_TIME            10  /* 1s (10 * 100ms) in total */
> >  	uint32_t rep_cnt = MAX_REPEAT_TIME;
> >  	struct i40e_link_status link_status;
> >  	int status;
> > @@ -6738,7 +6737,6 @@ i40e_dev_handle_aq_msg(struct rte_eth_dev
> *dev)
> >  			if (!ret)
> >  				rte_eth_dev_callback_process(dev,
> >  					RTE_ETH_EVENT_INTR_LSC, NULL);
> > -
> >  			break;
> >  		default:
> >  			PMD_DRV_LOG(DEBUG, "Request %u is not
> supported yet", @@
> > -12123,40 +12121,6 @@ i40e_cloud_filter_qinq_create(struct i40e_pf
> *pf)
> >  	return ret;
> >  }
> >
> > -static void
> > -i40e_set_mac_max_frame(struct rte_eth_dev *dev, uint16_t size) -{
> > -	struct i40e_hw *hw =
> > I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> > -	uint32_t rep_cnt = MAX_REPEAT_TIME;
> > -	struct rte_eth_link link;
> > -	enum i40e_status_code status;
> > -	bool can_be_set = true;
> > -
> > -	/*
> > -	 * I40E_MEDIA_TYPE_BASET link up can be ignored
> > -	 * I40E_MEDIA_TYPE_BASET link down that hw->phy.media_type
> > -	 * is I40E_MEDIA_TYPE_UNKNOWN
> > -	 */
> > -	if (hw->phy.media_type != I40E_MEDIA_TYPE_BASET &&
> > -	    hw->phy.media_type != I40E_MEDIA_TYPE_UNKNOWN) {
> > -		do {
> > -			update_link_reg(hw, &link);
> > -			if (link.link_status)
> > -				break;
> > -			rte_delay_ms(CHECK_INTERVAL);
> > -		} while (--rep_cnt);
> > -		can_be_set = !!link.link_status;
> > -	}
> > -
> > -	if (can_be_set) {
> > -		status = i40e_aq_set_mac_config(hw, size, TRUE, 0, false,
> NULL);
> > -		if (status != I40E_SUCCESS)
> > -			PMD_DRV_LOG(ERR, "Failed to set max frame size at
> port
> > level");
> > -	} else {
> > -		PMD_DRV_LOG(ERR, "Set max frame size at port level not
> applicable
> > on link down");
> > -	}
> > -}
> > -
> >  RTE_LOG_REGISTER_SUFFIX(i40e_logtype_init, init, NOTICE);
> > RTE_LOG_REGISTER_SUFFIX(i40e_logtype_driver, driver, NOTICE);  #ifdef
> > RTE_ETHDEV_DEBUG_RX
> > --
> > 2.38.1
> 
> Acked-by: Simei Su <simei.su@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi
> 
> Thanks,
> Simei