From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 12203424FB; Tue, 5 Sep 2023 04:25:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E555C40270; Tue, 5 Sep 2023 04:25:17 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 933B64026A for ; Tue, 5 Sep 2023 04:25:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693880715; x=1725416715; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=wFhc2HEAZUP8lMOtn2VhzEmsTaADKq52SZz2ksP5Udc=; b=jbGa2Ow4tNebMUdjllD8zkr9oVNI9kKIVmvu0CK7wA6V68mtpMhbPwh8 WGWE328rvsyh69z+huhEvWinCB4O+/XeRXk1BOJh6yfV9iTgZgSvLBWkm j3ZzFOs4stUCtYlexMtlImif6NkZ2fy4hO54J7NPvtT9eVoerdWz3X79s kbJktOzZTnGSJXB1HYOtw2hp7gLKNLGZ+wasYhVOq2n4+nw5RF8J8umC4 AcgF8YYZgbadeJG8KvrU8OOZa90ZsWsBcbjutJQLlKRmeoAlHRb1Ig8UX NnRO+h4+nAlhgU4DsodzcSHCMVXG6K4zmCCA/YSYZKbVPCp4G/z6wANxc g==; X-IronPort-AV: E=McAfee;i="6600,9927,10823"; a="463054232" X-IronPort-AV: E=Sophos;i="6.02,228,1688454000"; d="scan'208";a="463054232" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2023 19:25:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10823"; a="740946566" X-IronPort-AV: E=Sophos;i="6.02,228,1688454000"; d="scan'208";a="740946566" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 04 Sep 2023 19:25:12 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 4 Sep 2023 19:25:12 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Mon, 4 Sep 2023 19:25:12 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.46) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Mon, 4 Sep 2023 19:25:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CAvItt/rdskVgYu47Kod+tpYwV0Vg4Kt1BOLOY3qHUhKyz6b3deZQ2hLSZcehKNm9xdJnTYkE72uwQ1oyv7NjKKEpj4fO8uDvP98072qDQcnq+5GoAS1xVKE0XpQbvhsd9rsVOTNccuQvrETxZyLfYQ1pWPzIZbHbs6cMbDCkJsHD1uENmpYK9w/F6h1BsHON0lQi6VC+HWwTiopkSGR+DE8miCeNWS2JeZgyO123FD9vpHPL+KK3GQKkJ/HFL6omh7qwFFPpvkDYV4/VbLE0VJwIMavlEIh6/2At5R11bQrrlQDTj7aIMUBihGCP2tytJ/7nQO+ZQofsYhutEU1gQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wn1PrPoX4CbYuDetFd/B8o5V4Vn/yKOVSZvUM3rab54=; b=a8pHbbhVWLCcRMaoVAaJNQdwip2bmBvX0Ia9C4jH0qNDyXtZmE0tfyR3Y7cH8Aq5AgYI5/ffDhH4m7N6s8r8RFM89n+XABt/7Cohj1utkQ9QuEOUFFGQ99yTq7RPiOwpVce4W7PTBt6iqR2m/CwboT4Z3pInfz6lJ2H0kSxY4DWLn2wJX2cOqya6HzvOeQrnYBrhmnkRACGqprfYdaH4wKLBUZKqGwrrZZoBas8lr0AOS2aKCLJ5XnmSij1yh5lqQZu1kg2YfmC1QTpLAPeLrjC0NfibocVgEfyXB9LE/dTiLPAH/9tqodumgM9OFDFd+6MvxsTr1pK+fslkJJSp5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by SA1PR11MB7110.namprd11.prod.outlook.com (2603:10b6:806:2b3::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.33; Tue, 5 Sep 2023 02:25:01 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::8a49:15a2:ab69:91c3]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::8a49:15a2:ab69:91c3%4]) with mapi id 15.20.6745.030; Tue, 5 Sep 2023 02:25:01 +0000 From: "Zhang, Qi Z" To: "Richardson, Bruce" , "dev@dpdk.org" CC: "Richardson, Bruce" Subject: RE: [PATCH v2 4/4] net/iavf: add support for runtime queue reconfiguration Thread-Topic: [PATCH v2 4/4] net/iavf: add support for runtime queue reconfiguration Thread-Index: AQHZ3AeH24Dv6Ol4AEmgQMSFy+sdDbALh9AA Date: Tue, 5 Sep 2023 02:25:01 +0000 Message-ID: References: <20230830155919.592390-1-bruce.richardson@intel.com> <20230831123337.871496-1-bruce.richardson@intel.com> <20230831123337.871496-5-bruce.richardson@intel.com> In-Reply-To: <20230831123337.871496-5-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|SA1PR11MB7110:EE_ x-ms-office365-filtering-correlation-id: b5b1a5c5-d76f-4181-46d1-08dbadb74eb0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HpwC7IpdctyYTwbgIJ7lVISwFj1zMXK+pHyCeBFqnDeZ5xdHrOxFSyrAfCBr5lEWjufuLi4Dk3Ec1Y0MD7Ziba84M8tk66hynqDT5w5NJrqC4OZTtvASSgcD3v4mZ3yoFC07IAR0+FxXnZQYvJCa/vf0kNitIcpIFSX6J+klrTHP5ziB7jhKE1DZkLCYhSGp114EvKVwxnOBD6aK/Au8BpEc2cnIG7YnO0oqAegVmjPQsFDl2FQBdbGi3+fiJCkGdq8LwiQhxxU/elsbWRujIalC2x9OrVouhqklBr4Cxh3iaNj7WpG+yPn22w1pyr3ErFON12GIRadPSuuQRKuIjYena86dtWYB7TiQfjpgz7ghEsayAGbPcQYR799nislH1eMFhQHQwiTZB+OqN1ybYcc9PUJ4ZGh23ZsnW9LrR39qbOi0e2zIkjLgnfsZezS3pe56skalwdSr7Or30V1bNnGgO4K7GGH4qk6qWwnZ2VLhvNv5feqMdBwesEyTciW2wq2trajUfwA8LDczW6Qud4QCWwKZg/23nP2GOFBfoBxL2ZcIHVs9g7AN7XaGRsFi5pEn/fpbMwC3H51aIYo/imkKbSBckpWNIuZmnvZ4o/5l7gJmfPvIR+wvxRachwHE x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(376002)(39860400002)(396003)(366004)(136003)(451199024)(186009)(1800799009)(8676002)(8936002)(4326008)(26005)(55016003)(52536014)(83380400001)(5660300002)(9686003)(107886003)(41300700001)(53546011)(6506007)(7696005)(66556008)(66946007)(64756008)(316002)(66446008)(66476007)(38070700005)(38100700002)(71200400001)(76116006)(82960400001)(122000001)(110136005)(33656002)(478600001)(86362001)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8h+zMqOfoj5i3zTI3GszpVdewCW91LLIiwbsXY6zHP+UVawMchmxNO4DHjN/?= =?us-ascii?Q?FW9uBTrsTMkUAuNLoCDNUzNc1g/HzZlfVpV0FKhxsagdLH0SmCWApUxC9hLM?= =?us-ascii?Q?SY9smD5P/HljJpTuPUD26Gea5mnDQ+qsW1DCrJZ3OppWs7ffvXt9ZdLytEsj?= =?us-ascii?Q?cRgK5nvkY2n9ck0FTu0tXl/pAU7IvRV3EQkRAV9QTb9Lty5r9nW41mJ/zArR?= =?us-ascii?Q?e1uvktOVW/HHFeezQEv11dQdxLPwNcWcghk5VOE4ONrwBZstxM7UDu43Er89?= =?us-ascii?Q?5foNZ8ROyOaenIO7Z6tk+uByuuZGQufkzI8He/jmWpp7OgL+yb0xSok2aOm3?= =?us-ascii?Q?yZ4jWGN+VZN+z+VXh7P2lZlOMLdfi2snxuTx6emwtDgvmsBLgarK6tYfCrQ0?= =?us-ascii?Q?gr/NaCi82H+WdCLl6gZ7QuJLgCDCHsrmQGmxXjKWIao3D7ujfxwuWC+htXbE?= =?us-ascii?Q?GSex7gp5AfXl40uEW8OU1dYCajbDESQOW/YUf0HFdxeFBk7XtDZMtnxKVuQW?= =?us-ascii?Q?lTWiEagyPB4QP0Rvs0aHL8yVdh49eGlCSdcxEU3hDhfXakeSEOHLVR/Gtr7m?= =?us-ascii?Q?lgLmtve9mfBFBjhcJW7blAq2h3n012lsQVF9JxETCkfNHOBHwyea1VIm/Q7b?= =?us-ascii?Q?gxIqb03bsg1bFjIdj8SqP7wg4PN84etb14/yUaoyFKvuE/gy/cXR/hWfdi6A?= =?us-ascii?Q?+Xa9Z7lAWkE7tGx2+TAnjkfrzWNtS2kRbWgdkcLJJDZnADbhwizuyp6Hxv/y?= =?us-ascii?Q?hWHdL5AlbVeAZ/iEgUrv4lOKnPgTiXKnhBIRU7hE+1afLF0o64XGIQ9OrAgZ?= =?us-ascii?Q?QEV8/p7l52ExIK3R/HgyUYkInybCasAytzWa92tn2lj7NwDIAGHbf8yqzYsb?= =?us-ascii?Q?0KTg92kOmD2kYMlk0GqvIGb4azLxDQwr6LaZrWB2uV5J0Liu5I12Oq7mKiQ7?= =?us-ascii?Q?aGirSKSO4oWHyV09Du5KcCxCfPGGfm1JyVpa5Td5tqH5OGfuojQAUXKH8pNV?= =?us-ascii?Q?oUKdmjCdHecjBzxLkXfzLNpC2vHgdfouGp/ULrDfPx1v44Wj3qNAtHxgfXHg?= =?us-ascii?Q?dDDnpt5grj5JtEZH6B+M9/L5PwZfLoR2hWoz4U9cgHd/BeJYBZj9BKmdqN7o?= =?us-ascii?Q?msauziL4aSU7qdYydYr/Z3RiJkOjJWW0sXGNkdNAp4SWa6pQH809dpWBt1Dg?= =?us-ascii?Q?UuUep7PVGPjwDTdA94VJLbte6jpf3VjaTxpsuJSO9tGOVWhbo3xYuygbFA19?= =?us-ascii?Q?Qcr464gtHyJxDTsNNRscMRZ7biTJI2AP0m0wlChMkNDIZbX4U3GiTPUh5ULn?= =?us-ascii?Q?hJcXoVepxGaUdb/QpO4CKo0zEeg05wrdMO5nFs4Ti1nTka93M6ceANu1+TCR?= =?us-ascii?Q?6u94VYSrw7T9q9mOzHM/wpGP1kVrvB6RHExlGZYifCMxK2oLwIq80Uc4OcxD?= =?us-ascii?Q?pHlh3zqPBROzf9Y9rREQsWL6TP8l610oBo1A0lXNvCGGYAbF+tsGJ1JpKaUV?= =?us-ascii?Q?VQqr4XIiOMHEz+khpLuVVKq43d30PdlIDrtk7aeqyP5sQcKgDa57lk/sxNlH?= =?us-ascii?Q?kxjPngwb2nbALWohv18IgBHUghtr14uyfaoW7z+7?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5b1a5c5-d76f-4181-46d1-08dbadb74eb0 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Sep 2023 02:25:01.3466 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: G7S0z/Pdwc08uuwYXyFr2Tqlf6AyvuePpcAjjqE0VQFAntDtJds50dpXw4h0UgSKFIvZ7NFMFT2UEEGcQKu/KQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB7110 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Bruce Richardson > Sent: Thursday, August 31, 2023 8:34 PM > To: dev@dpdk.org > Cc: Richardson, Bruce > Subject: [PATCH v2 4/4] net/iavf: add support for runtime queue > reconfiguration >=20 > Unlike the i40e driver, the iavf driver does not advertise support for ru= ntime > reconfiguration, meaning that application using the same hardware may get > different behaviour when using a PF vs a VF. On testing with a 40G NIC, t= he > only blocker to reconfiguring an RX queue on the fly is the fact that thi= s > support is not advertised by the driver. >=20 > Add support for runtime reconfig by reporting it in the device info flags= . >=20 > Signed-off-by: Bruce Richardson > --- > doc/guides/nics/features/iavf.ini | 2 ++ > drivers/net/iavf/iavf_ethdev.c | 4 +++- > 2 files changed, 5 insertions(+), 1 deletion(-) >=20 > diff --git a/doc/guides/nics/features/iavf.ini > b/doc/guides/nics/features/iavf.ini > index b72cd98484..db4f92ce71 100644 > --- a/doc/guides/nics/features/iavf.ini > +++ b/doc/guides/nics/features/iavf.ini > @@ -11,6 +11,8 @@ Speed capabilities =3D Y > Link status =3D Y > Rx interrupt =3D Y > Queue start/stop =3D Y > +Runtime Rx queue setup =3D Y > +Runtime Tx queue setup =3D Y > Power mgmt address monitor =3D Y > MTU update =3D Y > Scattered Rx =3D Y > diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethde= v.c > index f2fc5a5621..22fbd7d6b2 100644 > --- a/drivers/net/iavf/iavf_ethdev.c > +++ b/drivers/net/iavf/iavf_ethdev.c > @@ -1127,7 +1127,9 @@ iavf_dev_info_get(struct rte_eth_dev *dev, struct > rte_eth_dev_info *dev_info) > dev_info->reta_size =3D vf->vf_res->rss_lut_size; > dev_info->flow_type_rss_offloads =3D IAVF_RSS_OFFLOAD_ALL; > dev_info->max_mac_addrs =3D IAVF_NUM_MACADDR_MAX; > - dev_info->dev_capa &=3D ~RTE_ETH_DEV_CAPA_FLOW_RULE_KEEP; > + dev_info->dev_capa =3D > + RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP | > + RTE_ETH_DEV_CAPA_RUNTIME_TX_QUEUE_SETUP; > dev_info->rx_offload_capa =3D > RTE_ETH_RX_OFFLOAD_VLAN_STRIP | > RTE_ETH_RX_OFFLOAD_QINQ_STRIP | > -- > 2.39.2 Acked-by: Qi Zhang Squashed with Patch 3/4, applied to dpdk-next-net-intel. Thanks Qi