DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Xu, Ke1" <ke1.xu@intel.com>,
	"Zeng, ZhichaoX" <zhichaox.zeng@intel.com>,
	 "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
	"Yang, Qiming" <qiming.yang@intel.com>,
	"Zhou, YidingX" <yidingx.zhou@intel.com>,
	"Zeng, ZhichaoX" <zhichaox.zeng@intel.com>,
	"Wu, Jingjing" <jingjing.wu@intel.com>,
	"Xing, Beilei" <beilei.xing@intel.com>,
	"Richardson, Bruce" <bruce.richardson@intel.com>,
	Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
	"Rong, Leyi" <leyi.rong@intel.com>,
	"Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Subject: RE: [PATCH] net/iavf: fix outer checksum flags
Date: Sun, 25 Sep 2022 05:51:50 +0000	[thread overview]
Message-ID: <DM4PR11MB59948BA19E73AFAA0DBD8D7DD7539@DM4PR11MB5994.namprd11.prod.outlook.com> (raw)
In-Reply-To: <PH7PR11MB6056014A93094F4F5FA3A10AD34E9@PH7PR11MB6056.namprd11.prod.outlook.com>



> -----Original Message-----
> From: Xu, Ke1 <ke1.xu@intel.com>
> Sent: Thursday, September 22, 2022 9:55 AM
> To: Zeng, ZhichaoX <zhichaox.zeng@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org; Yang, Qiming <qiming.yang@intel.com>; Zhou, YidingX
> <yidingx.zhou@intel.com>; Zeng, ZhichaoX <zhichaox.zeng@intel.com>; Wu,
> Jingjing <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> Richardson, Bruce <bruce.richardson@intel.com>; Konstantin Ananyev
> <konstantin.v.ananyev@yandex.ru>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> Rong, Leyi <leyi.rong@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Subject: RE: [PATCH] net/iavf: fix outer checksum flags
> 
> 
> > -----Original Message-----
> > From: Zhichao Zeng <zhichaox.zeng@intel.com>
> > Sent: Tuesday, September 20, 2022 4:37 PM
> > To: dev@dpdk.org
> > Cc: stable@dpdk.org; Yang, Qiming <qiming.yang@intel.com>; Zhou,
> > YidingX <yidingx.zhou@intel.com>; Zeng, ZhichaoX
> > <zhichaox.zeng@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Xing,
> > Beilei <beilei.xing@intel.com>; Richardson, Bruce
> > <bruce.richardson@intel.com>; Konstantin Ananyev
> > <konstantin.v.ananyev@yandex.ru>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> > Rong, Leyi <leyi.rong@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>
> > Subject: [PATCH] net/iavf: fix outer checksum flags
> >
> > When receiving tunneled packets, the testpmd output log shows 'ol_flags'
> > value always as 'RTE_MBUF_F_RX_OUTER_L4_CKSUM_UNKNOWN', but
> expected
> > value should be 'RX_OUTER_L4_CKSUM_GOOD' or
> 'RX_OUTER_L4_CKSUM_BAD'.
> >
> > Adding 'RX_OUTER_L4_CKSUM_GOOD' and 'RX_OUTER_L4_CKSUM_BAD' to
> 'flags'
> > for normal path, 'l3_l4_flags_shuf' for AVX2 and AVX512 vector path
> > and 'cksum_flags' for SSE vector path to ensure that the 'ol_flags'
> > can match correct flags.
> >
> > Fixes: b8b4c54ef9b0 ("net/iavf: support flexible Rx descriptor in
> > normal
> > path")
> > Fixes: 1162f5a0ef31 ("net/iavf: support flexible Rx descriptor in SSE
> > path")
> > Fixes: 5b6e8859081d ("net/iavf: support flexible Rx descriptor in AVX
> > path")
> > Fixes: 9c9aa0040344 ("net/iavf: add offload path for Rx AVX512 flex
> > descriptor")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>
> 
> Tested and passed.
> Tested-by: Ke Xu <ke1.xu@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

> 
> > ---
> >  drivers/net/iavf/iavf_rxtx.c            |   9 +-
> >  drivers/net/iavf/iavf_rxtx_vec_avx2.c   | 118 +++++++++++++++------
> >  drivers/net/iavf/iavf_rxtx_vec_avx512.c | 133 ++++++++++++++++++------
> >  drivers/net/iavf/iavf_rxtx_vec_sse.c    |  77 ++++++++++----
> >  4 files changed, 252 insertions(+), 85 deletions(-)
> >


      reply	other threads:[~2022-09-25  5:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-20  8:37 Zhichao Zeng
2022-09-22  1:55 ` Xu, Ke1
2022-09-25  5:51   ` Zhang, Qi Z [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM4PR11MB59948BA19E73AFAA0DBD8D7DD7539@DM4PR11MB5994.namprd11.prod.outlook.com \
    --to=qi.z.zhang@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=ke1.xu@intel.com \
    --cc=konstantin.v.ananyev@yandex.ru \
    --cc=leyi.rong@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=stable@dpdk.org \
    --cc=wenzhuo.lu@intel.com \
    --cc=yidingx.zhou@intel.com \
    --cc=zhichaox.zeng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).