From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B9A8DA0503; Fri, 20 May 2022 02:15:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5276C40156; Fri, 20 May 2022 02:15:02 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id A96AD40151 for <dev@dpdk.org>; Fri, 20 May 2022 02:15:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653005700; x=1684541700; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=1t25cSg4ON63oRSvqxewSK3R88wGJ31eX0TholzCeg4=; b=LIaaEtdIUjl4Q9eWYavdDZ0vy7M/kD5VLFqYQI4UgovNrdQs7fTRxaBI yc5h6ntkRLdNnk8eSm+mVuLNFw87jidSF8RpbgTnm1r/C+WvG8DZtUfIu 6uZ2ckxOwfihkq1/TufmbwgoExmfp9/rI+lLOdqsJHZLVTJx7N1JCIa+x mb1dARFotnysbMKcvBhfQuX9IvU3K6H8Cg+6nL4ricvLtzviDcHsKah3W 3ihfCgW4qTnx97WDlR62S0cfTDghPzIjPa/dSdwYg6ia3QztjXfyWT63u gIapx6T9WJDA7MYrZk8CNwWUADcvS4sqBRRJ/X/FKLTTATOo+13N/wGyR w==; X-IronPort-AV: E=McAfee;i="6400,9594,10352"; a="272555953" X-IronPort-AV: E=Sophos;i="5.91,238,1647327600"; d="scan'208";a="272555953" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2022 17:14:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,238,1647327600"; d="scan'208";a="606756442" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga001.jf.intel.com with ESMTP; 19 May 2022 17:14:58 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 19 May 2022 17:14:57 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 19 May 2022 17:14:57 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 19 May 2022 17:14:57 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.42) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 19 May 2022 17:14:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E4s+ofANMVoGtuZj7yrNwGHA+WHJir5x5beo/M/NqHLbt/Y32piUVqUss01B7gdX3Z18pzv9ssbA0mbywNTYzASfZ3RyJv0Q+TRaR8vN9D2K0XsKrIoh1L5aavRQxtQP511QdVgKFH4fk/bdmI6JT5RM0EaIs2o9+Skqsg1Av3XTOPjHh5E/sQqVd/ABqldvinPtywefja9a9aaq6UPv5ghueagvoYhBF7Xz8SVH9BGT57RveTDVKbNNbG18v6Wj9feimfJw0AVNXxVprCF2CJH0yG0OY/w7alZ83MPCoRWpbJrhISycOtF2VcT6iLVijPU+1FBms3egwJWp+OWgAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6I2oBwa3d4/wGH03WbbfsHhggcF/q4mXgcvGdaQUt1U=; b=klxDvjLASXFISLhsN2Y8/5V+Kkt0je292mHeCk2CQhfza3hnu2wmZWdpRj8U8J+B2IHDMe/IvB/snk/n+9qUeovNu27gUi/XSACErz4sXwzzAYgi8KoYZ8m2Jrwo3QKWS+oKZiHZl7o/EV/pyRroeDkpGmUdDPBEUa3WJ6KELTFSTVMt6XsdNgTOllyl8XjKJlhwSyzNw6ptDegwaUT+SysIxqSFdAkhkw/1359GCRbD28kqTnUdWVBU/avgG6VO6nEvnzKiIGB3swCpP4So8ZO0QKLEfWWqjKyoHrQSF/RijCV0/p9x4oQ/MRRvoaX7j2pqhJuS7HMdYw+v4OhiUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by DM6PR11MB4363.namprd11.prod.outlook.com (2603:10b6:5:14f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Fri, 20 May 2022 00:14:55 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::b4f6:f68:2e31:ddf7]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::b4f6:f68:2e31:ddf7%7]) with mapi id 15.20.5273.014; Fri, 20 May 2022 00:14:55 +0000 From: "Zhang, Qi Z" <qi.z.zhang@intel.com> To: Thomas Monjalon <thomas@monjalon.net>, "dev@dpdk.org" <dev@dpdk.org> CC: Stephen Douthit <stephend@silicom-usa.com>, "Daly, Jeff" <jeffd@silicom-usa.com>, "Yang, Qiming" <qiming.yang@intel.com>, "Wu, Wenjun1" <wenjun1.wu@intel.com> Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices Thread-Topic: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices Thread-Index: AQHYMnOyeQTUxssyHEy+SSEKCDh1Cqzuk+wAgDi80mA= Date: Fri, 20 May 2022 00:14:55 +0000 Message-ID: <DM4PR11MB59948E4C6A31E444D3C2E5EFD7D39@DM4PR11MB5994.namprd11.prod.outlook.com> References: <20220307223442.28012-1-jeffd@silicom-usa.com> <1681763.yIU609i1g2@thomas> In-Reply-To: <1681763.yIU609i1g2@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.401.20 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 34b20366-9d2d-4b49-d9b1-08da39f5c468 x-ms-traffictypediagnostic: DM6PR11MB4363:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: <DM6PR11MB4363BABFB9FD8591B8652ECFD7D39@DM6PR11MB4363.namprd11.prod.outlook.com> x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Y9ELbGyeMBq3DPeqQYq4OHL17UE4Qinv64Sahub8urteqEE3VYf2mMqQF3K9qMaVwoPMQy0b/FZZ1k1YBmrOUnZjyggn/np6W5IOIDxPVeVHF0UPT2tlGCvEH8WcxLEezjZMv5T7kHQgMAo+G2b0bJIzBASxqAeSeeZUuRpRUtWTR1z1x9DMM4iYTmrXb8gjjjMqN/cGGAdO/VZWfgwQVtKXlW6h70KOkqlQJaiOaOIOCy5gro5wbxbbYaq1ptIOvO2yWQiBLmX2PXgRPTJtsh2QymvQ4m6qhTvw62Jca2NtCD3QskjJtC05wZqzxq1+ZwSw7e7RXRfdUgLoxE+YNB+JRUdi2Y0jlRxlTUDYDJ0b97FtPE1w8dLvygYH1uO6oj0u+iGd8eJZ3WTXgUxwg7x8+05O37sG68Nz5gdYaH8ONJG9xuCmJFEhtAnpN8q0gFipGhPdonF6zLv/zohn2U3BYdA9vBp3eSOZwvrRCISGLM32iEJEfFXlyazN47uxWj5HcpR6cVK3JBLjRrCVg9QQVhfgNxzQfqYQTwXyxblFTRT2UkR9BP2Jfc/jwcTbCN2IMwZeB9kdoet5dxo5uBCa+uFG+xdSnZaPmZ31jby0buX+sMADtRK2yoVuB+KoNkZ2Bed1BfPp4S/UUO/Hd9S6G7YJeXKyMezJw9xyP6gd2Ci5QIw03q99+7ePNhZT9xzDczKRqOXvExc1Xub6uA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(4326008)(8676002)(122000001)(38070700005)(82960400001)(508600001)(8936002)(66946007)(7696005)(2906002)(64756008)(66446008)(76116006)(66556008)(66476007)(55016003)(5660300002)(52536014)(71200400001)(33656002)(38100700002)(83380400001)(53546011)(107886003)(110136005)(186003)(26005)(6506007)(86362001)(54906003)(316002)(9686003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?q2H7neaj5NVIykDWQlnNPxHru4m2BTfng6vacU0yYQB8atp+u4+p/WJGWhcc?= =?us-ascii?Q?3tKZ+chm+6Nt4EtllaqNsOGbnFaWN5N6wLqpHMkMk/KBEDshdque7jzZk4Mz?= =?us-ascii?Q?pHlflCnwzK2hzbowu7nrY+2qjd1h3BnhUUnXlZ9usFc4aeE1svCcreZVXGsu?= =?us-ascii?Q?aWKUD2xmu56HIPTWpe/auFvIsjmrHQwEvYHo+F2t5JLxL1AJTro6a4HgaJja?= =?us-ascii?Q?vjSmV1UIa+G3uUbe7FaoIO2Q0xtKOnGGTBCfitk49NXI5Fad2ei7GjQ/reZ8?= =?us-ascii?Q?TkC10AgLnlJboWKEkK0/A/v2K2f7XrRaYGSD6tz5bzeUjoLoXj1dqCGwQHrb?= =?us-ascii?Q?7cvEL5bpQOmzXIqjXSUM6Z1+XLEMoyDE6dUp4pEFVd/j72E+d6BeCZ1tX8hW?= =?us-ascii?Q?dclgLci6HSk7TxfOfbKDWhjdJYQVqzzWrMGQKpZmo6ERIxVUMZIKHbu1HGll?= =?us-ascii?Q?v/wY2cQacpKdhE3y6Bx4M3KOIXqkW0guhE4QWLAiOK5HpQL/Kk7CUFKFwZOB?= =?us-ascii?Q?Wk6e4yQffhF0nQiuHNg4dYum3kuADR5Dw0ZnIgo/dGhRCpFQlh6xVvW6jRwv?= =?us-ascii?Q?LCD95VenRlvxtkZOkTbIPxWlO4vgQFyJrz2WhKz2cb0DXg6B88i6NePUdGs1?= =?us-ascii?Q?K0itd7T4VoF65dTf5CexgiCG8c/iLAaZ0b749QAPXyu1yCtS4++UpExhflsD?= =?us-ascii?Q?D4whzBpD2+8X1anUkP+ztVQlhG5cND+5EdcWiENMohJQ5fJX17O7p6p0Febq?= =?us-ascii?Q?JKkP85axL3xXMeB1qt+PAyuPERVg/8IPXBDf3ddItH+0iOd2kTuIwBuCkCkK?= =?us-ascii?Q?Kxsg+qM3+xA9W7zO5yAML7FzYZxP3komD+ZfSAUgEzXVxi+Rvcu0oUpxa/B0?= =?us-ascii?Q?yTYDYzGpM1WmmdnucvCndo6VtkN6a8TrAeA6e+ThL8uyIZpcvGIuIxHATQw5?= =?us-ascii?Q?GDW5sV1aXIwQhNyazpxUv9ZnphP2Re22dx1T06IfoYLAdpD2PPRUoCeILaDu?= =?us-ascii?Q?aovJjMB9pdUZoYThWCJxs0ZJovVKVTzHWEKRLLbmpf12l63yMIxDqMPSaLRI?= =?us-ascii?Q?nSbs0Nw3G/fzzTjX3YEMSfQunJfOMBQnDVxGCST5c2S9FCTcHruLiYczXXnc?= =?us-ascii?Q?Hdwb/Y9cEWrhBxII6tPrBxTGYsQYKkUkEmL6kK+Q/sTt6NFFRL4Eu/j+RoG+?= =?us-ascii?Q?i4dQjYEvX9wnEr567raPmJ3AZkCBL3OOBtFeSnNQmyd9VSFCba1eW+e1jpNL?= =?us-ascii?Q?L/kkBSmhm2kzWUOQFsomLi6gigrG8wNN37iH+bm9r4udiMrLldbOMQQvRQGD?= =?us-ascii?Q?Pj3C9m5pX6qsd2QmiN3910xzYQwB7EYPbpb6DyGOOVsTx2wBfLvxriwDQR2O?= =?us-ascii?Q?qFU70ocf4Mk7ADSPzfmz622LCftGWxwNxAbGEpSi7COK7ZWBOcwlW+AAhOax?= =?us-ascii?Q?8f9g5Vjn9PN5PRXA6D8rkGlFdUz1x2ytBqe20W8BDPgdriMH3fQZQOwmLPw/?= =?us-ascii?Q?qGZLHQ0sDAgHmdXa0SHFsWAbFXAYDxnfO8z/JTArbPmbFbgTkC2guTFmBDhb?= =?us-ascii?Q?wWgW6CgltoDh0Mv5J6w3z0a53Hlf35N+q/uPyT2787f3hke4/lO/PSaBFNqN?= =?us-ascii?Q?DoWCl2q9IGKA7GhJZsHGmAIWpFz6uqveBflmF2CtdBbPaKySe/MPnuEhGK2j?= =?us-ascii?Q?mwb88YE2uoLHA3Ajjy4LPfFWbHHM3VjFRUPVM3tUOVcZBhx5ZnBaQxvnVkRN?= =?us-ascii?Q?cRSbiPDzZg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 34b20366-9d2d-4b49-d9b1-08da39f5c468 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2022 00:14:55.1009 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sEWeH/UPsqqWShFRggwIswe/b6aQnABhHsH09HN1oxkcjzcQag043c73uQT1cKYcuazCpQdJ8zGZ7YZZrNhmnA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4363 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon <thomas@monjalon.net> > Sent: Wednesday, April 13, 2022 10:21 PM > To: dev@dpdk.org > Cc: Stephen Douthit <stephend@silicom-usa.com>; Jeff Daly <jeffd@silicom- > usa.com>; Wang, Haiyue <haiyue.wang@intel.com>; Yang, Qiming > <qiming.yang@intel.com>; Wu, Wenjun1 <wenjun1.wu@intel.com> > Subject: Re: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 dev= ices >=20 > Please, could we have a review of this patch? > +Cc new ixgbe maintainers >=20 >=20 > 07/03/2022 23:34, jeffd@silicom-usa.com: > > From: Stephen Douthit <stephend@silicom-usa.com> > > > > 1G Cu SFPs are not officially supported on the X552/X553 family of > > devices but treat them as 1G SX modules since they usually work. > > Print a warning though since support isn't validated, similar to what > > already happens for other unofficially supported SFPs enabled via the > > allow_unsupported_sfps parameter inherited from the mainline Linux driv= er. > > > > Signed-off-by: Stephen Douthit <stephend@silicom-usa.com> > > Signed-off-by: Jeff Daly <jeffd@silicom-usa.com> I think we need a devargs for this feature with well documentation So, it should not break existing behavior by default, but allow people to t= ake risk if they know what they are doing. Thanks Qi > > --- > > drivers/net/ixgbe/base/ixgbe_x550.c | 14 +++++++++++++- > > 1 file changed, 13 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c > > b/drivers/net/ixgbe/base/ixgbe_x550.c > > index 8810d1658e..8d1bc6c80d 100644 > > --- a/drivers/net/ixgbe/base/ixgbe_x550.c > > +++ b/drivers/net/ixgbe/base/ixgbe_x550.c > > @@ -1538,9 +1538,21 @@ STATIC s32 > ixgbe_supported_sfp_modules_X550em(struct ixgbe_hw *hw, bool *linear) > > case ixgbe_sfp_type_1g_lha_core1: > > *linear =3D false; > > break; > > - case ixgbe_sfp_type_unknown: > > + /* Copper SFPs are not officially supported for x550em devices, but c= an > > + * often be made to work at fixed 1G speeds. Pretend they're 1g_sx > > + * modules here to allow g.Fast DSL SFPs to work. > > + */ > > case ixgbe_sfp_type_1g_cu_core0: > > + EWARN(hw, "Pretending that unsupported 1g_cu SFP is > 1g_sx\n"); > > + *linear =3D false; > > + hw->phy.sfp_type =3D ixgbe_sfp_type_1g_sx_core0; > > + break; > > case ixgbe_sfp_type_1g_cu_core1: > > + EWARN(hw, "Pretending that unsupported 1g_cu SFP is > 1g_sx\n"); > > + *linear =3D false; > > + hw->phy.sfp_type =3D ixgbe_sfp_type_1g_sx_core1; > > + break; > > + case ixgbe_sfp_type_unknown: > > default: > > return IXGBE_ERR_SFP_NOT_SUPPORTED; > > } >=20 >=20 >=20 >=20 >=20