From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C33364263E; Tue, 26 Sep 2023 08:04:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 607A540279; Tue, 26 Sep 2023 08:04:46 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 2F34140277 for ; Tue, 26 Sep 2023 08:04:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695708285; x=1727244285; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=b4hebG9xGWE5G0ekySIK6adyaVdFWb83Qw7DS9tC4U0=; b=OC0Sv9i03kEQ5lwUL06vZJo3X7eXnW1XvXXmc1COSZUVqtO4v5IX0LYF 500pw6Ft9p/mXkdrTMk7aQt+i/TgnJFJTnnrWVaJ3GVwUdY4xTZJBG6NX LSVRw26M6+2w+nQ7RzIt14txUjmRe8fych+yL22M8PrAkXgb+lvuCQmBd tALg9WTJGbMGuH8w9KV2oKVTbu1UOBdpbYuGRDeBRSUwwW15zN0SGa6mE G/MWC6CExjArbaLpsVhIyHutD4QfrfJ4aSyD5JqsGW5mRbOYrgPUj5WlE kXT8Zsd4tYylxPsQoJ4yu87uqjhaLafzxL+Yq2juJJ+X9qPJ69He6ikbU A==; X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="385342372" X-IronPort-AV: E=Sophos;i="6.03,177,1694761200"; d="scan'208";a="385342372" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2023 23:04:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10843"; a="922300070" X-IronPort-AV: E=Sophos;i="6.03,177,1694761200"; d="scan'208";a="922300070" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 25 Sep 2023 23:04:41 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Mon, 25 Sep 2023 23:04:41 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Mon, 25 Sep 2023 23:04:40 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Mon, 25 Sep 2023 23:04:40 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.108) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Mon, 25 Sep 2023 23:04:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jInqaawJzqtjDCAs+JzKkIIOgUczErlOsPhMljlPwVtyBUQUQ5IqnfqNB/7pcjfIjsXRpi3g/RnCMDGoT12ynZ1hkzGNd/M0ocjbdKGSBPlxZWsZQGhlPdulcjVEh/rTPN6QB5C2/6lCVaMMAkpjquI6ue/iHEE+IPRrw8xyYaGQ8f81sFTSCdfeJ52O0u96XiJqwyKUqi+RnT8uW4CkV9+Hs+IeNBIXhy6XbZSHOdiIgtzFgvH0q331ZbbiBs/fGQ+oI2UV3YEnzP82zXVle1K9G3XyhzoWXoQxscHrzu99TP90ce/R5ax84i4k89Npi3zFlSi3Hz/c1VtynhgAYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Op2RJxa+KmUKwqaWtFESCm/UZl4OGHg6U3S2aJP7qxM=; b=JIjNY3GAougT5h21O9GxkUaT0ecruO1KkuKmAHLWdFPTEdTkO+WN9KbsIDIuoJmxr8AwN6hehsowSsi9Q9h4ObV1+p6/N+dpQf0iodzqT9xAn2HNWxZ386HXPQJYMAsj0XAdLoJrRibEp4fA789ajetlYCqov/hY/JWZLNl+WjO9imeUO6LgcqL/RRVr2534QBUXN6AS2XjoZ8YuFu2N1i5jEeX65xeBHNOdBZ/jKN2NG9Ie/x/w4VozimfEIBivqy3//4fyYJvybC5t3aAiWI55muStKIJTaVmCss0wXcmhINw7JgZRc7maYxodcEy5HEnp6KpCMysk1xPK1Quyuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by PH7PR11MB5888.namprd11.prod.outlook.com (2603:10b6:510:137::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.28; Tue, 26 Sep 2023 06:04:36 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::27ea:67e:2966:23e3]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::27ea:67e:2966:23e3%3]) with mapi id 15.20.6813.017; Tue, 26 Sep 2023 06:04:35 +0000 From: "Zhang, Qi Z" To: "Xing, Beilei" , "Wu, Wenjun1" , "dev@dpdk.org" , "Zhang, Yuying" Subject: RE: [PATCH v3] net/cpfl: fix datapath function configuration Thread-Topic: [PATCH v3] net/cpfl: fix datapath function configuration Thread-Index: AQHZ8D6KnAGWBk1yqE+HQbeMznKbDLAsnP6AgAABGVA= Date: Tue, 26 Sep 2023 06:04:35 +0000 Message-ID: References: <20230919083237.171374-1-wenjun1.wu@intel.com> <20230926060455.18614-1-wenjun1.wu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|PH7PR11MB5888:EE_ x-ms-office365-filtering-correlation-id: d6a3c7b3-6a5b-4c29-4c24-08dbbe5675f6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fYN3Rm+utg7uLBXdnS/PKFeUUOLSYYwUa67NuWqWti09EvKRVI/QTakOyWcWekAmwe1tf71h7qh0veCdHfU5bXt6r1+g5MUUc07wRXWeVB8ctadatt+2jxE2drNQ3B5hA/wevS078eW4f8sXgmhNNbRulcrTTSaPteF+/eKfiYSUtwRGA9BjQvoVHytS8IzzXlh31EQD2M0raOmTyooyAaw9H298ucqALPUvMNveK0rATmjyKCHFh1nLRBzgMktFLg1bPYALZD2ngyje+vG1jlZAiAD16xeM4eBxvKiyfRiutAPMXuB4yQUOHGmUFpERVHAWRxBvkzumYkgedmgLjy4LYqCeUOKDHwr6V2sDkS5712cauvfb2Rkvf54rAPZoiwBheg5c71GJbMRBj+28bfioz4slsUpC/sx9WGgRxdtJ5nxXl9QPoawBUGtlS0KJMKwzPRCjJ+LnvHBZIObKs2tRZVHxnAjgJAjq1UZRJJbhC04Le6owjUr4UKKAp8++6OWmBRVV34lNel7dw4UBoI1+anRIsUYVaj9fY1iWsh30qqv7psuJz3PHvr11+kR0DqMH5RhySVPidquU1NMxel22acv6I2R4Adv1naYeQgg9ohjJX3VfTTY0FPLqlZr4 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(230922051799003)(451199024)(186009)(1800799009)(26005)(7696005)(8936002)(55016003)(2906002)(83380400001)(5660300002)(64756008)(9686003)(66446008)(66476007)(38100700002)(8676002)(110136005)(66556008)(33656002)(38070700005)(86362001)(508600001)(76116006)(52536014)(66946007)(122000001)(71200400001)(6636002)(53546011)(6506007)(82960400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GlT307oISaAhCEddO6hWBFKzDsO/zovikkDmFdkgHYaxdFvQYSyWzGuFdlCx?= =?us-ascii?Q?mnHsQTTn58LFHB5yN+O+iJPqGoXg69u//lPPb5CI52v+Md1ddX9yUjnsOibX?= =?us-ascii?Q?e5ItbQnEmAOtn9ckXXJhbQ3ZsfVkQNQlPWqr5ebe+eJV0SaFs+YcPM9QPq1W?= =?us-ascii?Q?mtwSOtQ3m7hFdXdejIKk0nYsKXH+A51QF3+ZIYK/nt3OuvBb8aVZXaVdABF0?= =?us-ascii?Q?2bbl/6MsZzJwtB9y22rujXVi3WF8bnoi8wFQofnXIzq/7VWzKq5yMxsmnGb4?= =?us-ascii?Q?NNrjoDgNfbAsywwFnbmXgdelOfpWJ5LHC/top8V6KqGRprgUDceKj3yasNFF?= =?us-ascii?Q?ym2v+kyE1FB6PqE7bLIWiBuDb7Zcv9Q5T88kmZJSzc40nKxtn9qljA8fqoYI?= =?us-ascii?Q?JUsz1nd6YbaeQ9sU93ovwvPsE7UBUADUG6QSnhFSWUAoIvbC/3B1D/KXY0jr?= =?us-ascii?Q?KxYFONFTQC2L53/WZNmtemdlZhEKFyBXQ9O/Wrg0WHaAA0u/dnb/GIQw4gFU?= =?us-ascii?Q?86hIK7AxEooAjOc7qe/oXDswpQkN0ItBXqwFZVMsDV2meWEHofUUdiu84eJO?= =?us-ascii?Q?q8+gVNHoLOX0q7pi0TsFUKn6My2z08S/WuN5r13JzWqjvolexqvYufc219zz?= =?us-ascii?Q?SKb+tRYpj0Sx2kveab81Z3JUjmudE33fxtMdgb/d3jb14nrddN8heW4yoSL8?= =?us-ascii?Q?NdZJl6/pU3+B9u3VvkvQWS/FdjLNiGdJraI+riVp6DKdoJj2N9wdNbsJLPJf?= =?us-ascii?Q?HO+BbZ5V4Zu/uo2WNeEl4+k1HermYNKWB6vytjI7Z1WxhYoRZvmQ6QzO3CYj?= =?us-ascii?Q?IUn8yS9Y91gFcmNXDWT1d3eceHns7KaQWLOEuvii1iDF3l5rcAKmaGxkAvxH?= =?us-ascii?Q?MeDuX2bQToYkqdjfVYLWYB4APrfbljSCOG9bAaE+IVy/+jR8O5F+pXstxN3h?= =?us-ascii?Q?Ui23BqcFrYDxb2Y94c88sH8tusPJMIxkH8cHfa37pdM8+tnK0QtC93NDH6zJ?= =?us-ascii?Q?NAEkiUNFFY6OtNQIB5SfgY9kKT/hHbiOF7E6lZldRZ593sA++9VTZG6MYbaN?= =?us-ascii?Q?7Vc6AdUWbIjHBuPwB/eSPMPbQMjBsgwoWE13yXIUth2uRL79cG2/Iw10QLy4?= =?us-ascii?Q?EvEAEEadudUo53jR7cngxIhlhcoHfez76ihwj+wi4WI8DYJ3RU/ZV7H/KiUV?= =?us-ascii?Q?ckw4nq2aYqnz8WXWQzGdKbtWi1g3sR4iaH+2n5FZunOiKOHe201HvVp+7D/N?= =?us-ascii?Q?NW0yTakqWqgugD6WZCDgHRR5eRMXOXOkSyFfDcoFLgMOk5cZrzm3T7yRqcg7?= =?us-ascii?Q?AreUzGTVuw0Ihxiz9EWvaEgNoEj+vNGl0tkloEja4RycKByBFTnok5iDiZw6?= =?us-ascii?Q?VWeyW9HP47vn7Jq/Kq1lG0mnjRZizYU1qi/1oev8bzbKlzSyJux0jIKxOBCu?= =?us-ascii?Q?waHbd/To/5QPSfuOIUM/b5nVwRHqR5tRYNi10+HOQVVlOc5hYh8iPpZbQXa/?= =?us-ascii?Q?uoiEhlfy/f5ncLQXMQG7wOOoTUeD+wUfS9nwm+0ThWfexk1YD3/QhK4rDD9C?= =?us-ascii?Q?3jLZpUa8pSrzCoxnDyjeXIDN+4kgihwmWATFFch0?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d6a3c7b3-6a5b-4c29-4c24-08dbbe5675f6 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Sep 2023 06:04:35.8452 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TOyPmY9kPrlu3zHp8XSk5XMbgh4aR2Az+YsAWx19dvkWiZDH5UVaCFMNzcSajrCyD8QMVSdUQuTsNh2682dg8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5888 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Xing, Beilei > Sent: Tuesday, September 26, 2023 2:00 PM > To: Wu, Wenjun1 ; dev@dpdk.org; Zhang, Yuying > ; Zhang, Qi Z > Subject: RE: [PATCH v3] net/cpfl: fix datapath function configuration >=20 >=20 >=20 > > -----Original Message----- > > From: Wu, Wenjun1 > > Sent: Tuesday, September 26, 2023 2:05 PM > > To: dev@dpdk.org; Zhang, Yuying ; Xing, Beilei > > ; Zhang, Qi Z > > Cc: Wu, Wenjun1 > > Subject: [PATCH v3] net/cpfl: fix datapath function configuration > > > > Vector datapath does not support any advanced features for now, so > > disable vector path if TX checksum offload or RX scatter is enabled. > > > > Fixes: 2f39845891e6 ("net/cpfl: add AVX512 data path for single queue > > model") > > > > Signed-off-by: Wenjun Wu > > > > --- > > v3: fix log typo. > > v2: disable vector path for scatter cases. > > --- > > drivers/net/cpfl/cpfl_rxtx_vec_common.h | 9 ++++++++- > > 1 file changed, 8 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/cpfl/cpfl_rxtx_vec_common.h > > b/drivers/net/cpfl/cpfl_rxtx_vec_common.h > > index d8e9191196..479e1ddcb9 100644 > > --- a/drivers/net/cpfl/cpfl_rxtx_vec_common.h > > +++ b/drivers/net/cpfl/cpfl_rxtx_vec_common.h > > @@ -25,7 +25,11 @@ > > RTE_ETH_RX_OFFLOAD_TIMESTAMP) > > #define CPFL_TX_NO_VECTOR_FLAGS ( \ > > RTE_ETH_TX_OFFLOAD_TCP_TSO | \ > > - RTE_ETH_TX_OFFLOAD_MULTI_SEGS) > > + RTE_ETH_TX_OFFLOAD_MULTI_SEGS | \ > > + RTE_ETH_TX_OFFLOAD_IPV4_CKSUM | \ > > + RTE_ETH_TX_OFFLOAD_SCTP_CKSUM | \ > > + RTE_ETH_TX_OFFLOAD_UDP_CKSUM | \ > > + RTE_ETH_TX_OFFLOAD_TCP_CKSUM) > > > > static inline int > > cpfl_rx_vec_queue_default(struct idpf_rx_queue *rxq) @@ -81,6 +85,9 > > @@ cpfl_rx_vec_dev_check_default(struct rte_eth_dev *dev) > > struct cpfl_rx_queue *cpfl_rxq; > > int i, default_ret, splitq_ret, ret =3D CPFL_SCALAR_PATH; > > > > + if (dev->data->scattered_rx) > > + return CPFL_SCALAR_PATH; > > + > > for (i =3D 0; i < dev->data->nb_rx_queues; i++) { > > cpfl_rxq =3D dev->data->rx_queues[i]; > > default_ret =3D cpfl_rx_vec_queue_default(&cpfl_rxq->base); > > -- > > 2.34.1 >=20 > Acked-by: Beilei Xing Applied to dpdk-next-net-intel. Thanks Qi