From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7FDA2432E4; Thu, 9 Nov 2023 13:23:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 28FA5402E5; Thu, 9 Nov 2023 13:23:20 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id ECB4240267; Thu, 9 Nov 2023 13:23:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699532598; x=1731068598; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=fuCK90nH5+JKAkiN67HRsyzVnsRHgidBNaqSj0qijj0=; b=CBw6njJxrZ9BLMJOXYFOU7ePzJTSVBkeLYDpXvbGA0V5BQSr9FGA6YZe 3cj5dny1Z9l+/pxmhBfUJfW/9z+PFCqVvY/N8EPaWP1+e4bDktHnQLsGB 72khTeXoIZPGgaOKk041sraw3+shKSLYAqo2Y9ZnhyB4d17yUs5JCimXI ip6qr6NICK6fcYMuT8HdlJ6buGFF0Wyvo1VdqW07xkS0weKbMuWU8pQVn jeoiaxsp7KIL7dTOtk3xkioui6SNj4UFiORus3p2RC7eUko8Cqw7kOaSR 3epMVVRJ1zTcgsvbP3/95qf+PyEDTfhzJ0sXcofckB/+W4CS0QTPKZ8ZN g==; X-IronPort-AV: E=McAfee;i="6600,9927,10888"; a="389775716" X-IronPort-AV: E=Sophos;i="6.03,289,1694761200"; d="scan'208";a="389775716" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2023 04:23:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,289,1694761200"; d="scan'208";a="11519636" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 09 Nov 2023 04:23:16 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 9 Nov 2023 04:23:15 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 9 Nov 2023 04:23:14 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Thu, 9 Nov 2023 04:23:14 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Thu, 9 Nov 2023 04:23:14 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X1Mzen5f+PvINEudDEvb8XoDg9B3taSd6Ic9H6KvH2739gqOAxsxTHr5qLjdaq/1fTO7XoZkGD20geRtSdFvbfkiAVmX/xEJCnu3ZWhW0YJVkY+BhBFCNzTOvHBuUmxVrlUwjXRIP/llBKkiEgwbRbJgY6F1uNI0Q/FtInlrgTT1AaYkNMKf2/BQvo2+ebYTGvbXAth1IeTW7v60fWb2A7bWjh32UOLZS5rW0Qx8JN35C9Rwm5t/9vDc72Ms6e3GfrinZ08uczQLf8MvzSW4n/Cu71YD1WRZzlX58MsWHQy7yD2E24yOglw987rEyUeQ+ZdEqFLJ/ySCqeQfN4DovA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fuCK90nH5+JKAkiN67HRsyzVnsRHgidBNaqSj0qijj0=; b=dr4YBzUORDBj136HLC7V7/ULs4QdKKcMZiZ5UIiQK/Y2E5lXDhyg549PnUiFEmTX4Mfx9AnG6DXwo4MyUfx7DHbDCml+GbSdZFdWYSdqiV8ow2Qc59mXbQhp4CeG80DllfDMI2ye/sTIH2NSLZ7AEnJxlrlGk6+Am5V+nUw3vyr/NJqhVQsUfhN8SAOAJ95m4ILU6Relp9/7xsD+TuLqj8kBuF6WZU+gbOrVOX9hB/54g2+REpq0vM8D8RJX+r9kjjmEcmOyrGZdZ/NGfFZarSHTUOkR3pIbnHLftXJ4RVzdcj4YbWBH+8x0xcI1S/xm6kXYYuCWzD5i2dhNuhvANA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by CH0PR11MB5361.namprd11.prod.outlook.com (2603:10b6:610:b8::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.29; Thu, 9 Nov 2023 12:23:13 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::62e2:b53a:6a07:f136]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::62e2:b53a:6a07:f136%6]) with mapi id 15.20.6954.024; Thu, 9 Nov 2023 12:23:13 +0000 From: "Zhang, Qi Z" To: "Deng, KaiwenX" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Yang, Qiming" , "Zhou, YidingX" , "Deng, KaiwenX" , "Wu, Jingjing" , "Xing, Beilei" , "Zeng, ZhichaoX" Subject: RE: [PATCH v4] net/iavf: fix mbuf release API selection Thread-Topic: [PATCH v4] net/iavf: fix mbuf release API selection Thread-Index: AQHaEs8fLmeLZhhdzEqLZJ4P5yggrLBx6S3A Date: Thu, 9 Nov 2023 12:23:12 +0000 Message-ID: References: <20231102044316.541458-1-kaiwenx.deng@intel.com> <20231109045836.814164-1-kaiwenx.deng@intel.com> In-Reply-To: <20231109045836.814164-1-kaiwenx.deng@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|CH0PR11MB5361:EE_ x-ms-office365-filtering-correlation-id: a8fca130-9096-4881-c98c-08dbe11ea495 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HAgpKAUlUK0LQ/2FJZkXSM5e9+Y3yKhUH7EXaEN3JEqZXdAFS8fLFezb8FCf3z2++WrHC+v7masTaqe2/s+rDFnNCX0CGIFDAX6hIGcLLwQ5O0HGOUFl4H+qyXOeod/ajQf8zwT+TxkCLJt9UGs9RBVoEXZT59gHD1fEuUCF1yy3NWlhAh9RtWtzJCSQhMHL9ThWYo3/M9/TzM8pBtCrDTZIdNoyX9eZz3EhjOT0T7cE6QShcd6kM6yEnsQAbnqbjMMpkDL+6rmPdwu+hupUtHsskx5G6D8JrTS5DVjdnnvOOVE1De+S/vKQaL3nfl3/2LeNtReX8SvJYItSS6rhkubue5oUPeIWs2rswuOTXz5PyaRuEE0NXkxhoV7CSIee6fcX8F2BGs7SjHSyw0WLzlZ8eAFHOpRIlCI445btZgUWYdcdbCu/+hyCN2aVeTO4fazUnhZURtdGD90bAqy7ku4/XyCkw76qTZxEGN5nfBZllTkGGyrkFCovw4cxc5UjtjSEdVVc7Iq487bZVPUB5CtCm/e8wfaAtznrw8tTAxjvs7Tb/Mt9PzwKMPrMvnQljozvJi4+pwBGkMwuA41K573cpb1ci2g2XZe+x7sFse7jQzZcugmmEZa58FKOS0hd x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(396003)(136003)(39860400002)(366004)(346002)(230922051799003)(451199024)(1800799009)(186009)(64100799003)(55016003)(478600001)(86362001)(26005)(38070700009)(82960400001)(33656002)(38100700002)(83380400001)(122000001)(53546011)(7696005)(76116006)(9686003)(107886003)(316002)(66476007)(64756008)(66556008)(66946007)(54906003)(6506007)(71200400001)(110136005)(66446008)(2906002)(4744005)(450100002)(8936002)(8676002)(4326008)(41300700001)(5660300002)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ef1dW2dm/RWPsOvVifWLUaOP/dDUnlR34pwV0yJIAlB4wCzlfykR91jF8Vmz?= =?us-ascii?Q?p4b93XWhxOHkSNTEXJ5R+IVkI92PZqfP0EtKzY5fBNuoUG5UiwrAXh7HRWOo?= =?us-ascii?Q?gtdvhpGuHK28YlE5/9z+H/Y8Tr/xKhNCBzNKZ2ZW3rfC2eugf2kM9sfsuJp8?= =?us-ascii?Q?t2d3bSDG10l3w33qr+LqFzslqtp58C8+g/98uLL517LJnDV4btSynhJvw+UA?= =?us-ascii?Q?dsLluvYhGp6el5oG05CICmk5TVOHZQIecIMUlVXdkw2lViKZ+Bg86t05ptcy?= =?us-ascii?Q?OpsoQPITsocuxFWSBndWtZwGqpZqCXrrPLvQU9ztAe8ykI/1nnwvp06Tbv1m?= =?us-ascii?Q?/j72/batt94bTe77U5Yckr0NZRZ6klKPcDWBdRZy6Df1CXkt/4w+YIZLuGhU?= =?us-ascii?Q?4SUFqfIJwIa8AiZV/DDSRHaYzqVA5OoQARiP2mMtL5GXPt+eDdqOg0ID9aLH?= =?us-ascii?Q?MzzlkHSFAITqcuPjIZzFQWIqE2tNxuhf37V4+L3KCZQOFSYPhRwfFk2Vv3Sx?= =?us-ascii?Q?TpSg+7uE4oWHPH5Z0xFsnFdKUusy67Wrt29rkNmEDAiGd/5f5awOLPY+D6MV?= =?us-ascii?Q?Z2ot0ksxJKTyCjV0pz1BcVC1d7Z8mC9biDIa+eZo/WDTdPkkpMWcE/fu9pjE?= =?us-ascii?Q?fQa6FKNNNC2G0InN/kk4ChR4DCqPh9qGE3zgmewbT4Iyl0eEzBJaNFSsfPwF?= =?us-ascii?Q?YwcVU6j6/DKSnnpHR90g8MiGkZvN52dSCzHaBm05aTDCxp4PtcQiXEA/john?= =?us-ascii?Q?AY2gforiFCFPi/SN7gdn0UerPamxRP07FebmfPE7ZanwBXmoCkinoJzflNYi?= =?us-ascii?Q?zWatf+O6nDuMax2pDhnVkRRyr91fgEGZHfA95jMSrUSw9EGMLzOr+ohczUuu?= =?us-ascii?Q?cmnYFezPa8ix47mHHk8DhNubcRVS1CQtFWE4qwsjQ49yXEAAUkYFZQvHEhnS?= =?us-ascii?Q?1qaN/RqLg96dNF9ZupM0/35umgfc6G5FZWyvoMpgcmUcvaSvgxl25kBEvXoP?= =?us-ascii?Q?25Toj5w4xyvX9u6F/w21m0r1Z7HA+Z1u1vE2ZOWzjpuYCwHqSuhm2808U0uT?= =?us-ascii?Q?y2kxECTN6p9zv6M/q/10tpyZhMPaeU6uZ3Orv9N8NXX2AFtkvKyUQpm34san?= =?us-ascii?Q?xVWaU0Q91M//PrMeVJHwJpvxhxpiAgSlE555a8+ovZyFbK7tALRAaiOhYplL?= =?us-ascii?Q?I+gvqZD2hokjHVYCLp8Cs3Psy7ouMVHezzsXLBwb57t3WGQlYnNmhYNWXcHe?= =?us-ascii?Q?3hZ+kh/K3WMB/d46ZBYuFYYCZLBXpUo3WrwUzlOHPidL89fPYBzK4ye+mAqz?= =?us-ascii?Q?jJi29ibhvJdaOlkcqfo+Vt+4otVxe6ACU1PVYN32srli5WaQ+cXQp1k92CQt?= =?us-ascii?Q?esSpbyiAvmm0T+ant2tp6BxdFL7au54isTfrfbslAD/ccgvR2XaLNOLzxay5?= =?us-ascii?Q?UeMlVjEsbHI5FjN70SP3kf3+lyKcFWfdeiJp4z6cmpnshiJtkDzlqrnzQ9Wv?= =?us-ascii?Q?f3AdkqwnATlaglP58wxEHGBhh3SZWxhy1uBw65e1enytl/bLGuU0zrd+7iyv?= =?us-ascii?Q?7p+xpOYnxUOP7wbnlLZq6aaAQOLWB1Y/APPo9Umt?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a8fca130-9096-4881-c98c-08dbe11ea495 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2023 12:23:12.9013 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ly2rxZ+HmEq/6ZkJcmP47+FGcRdK++i+NObcxUTJibpkLiTY7hdlYYgdd3z5KqNiP2N7MLz6Vb4YFAxV7c6D7Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5361 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Kaiwen Deng > Sent: Thursday, November 9, 2023 12:59 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Yang, Qiming ; Zhou, YidingX > ; Deng, KaiwenX ; Wu, > Jingjing ; Xing, Beilei ; Z= eng, > ZhichaoX > Subject: [PATCH v4] net/iavf: fix mbuf release API selection >=20 > When AVX2 is forcibly selected and outer checksum offload is configured, = the > basic Tx path will be selected. Also, the txq mbuf release API is incorre= ctly set > to iavf_tx_queue_release_mbufs_sse. This causes coredump. >=20 > This commit selects release_txq_mbufs to releasing txq mbufs when selecti= ng > the basic Tx path. >=20 > Fixes: 22f1e7608ebc ("net/iavf: fix AVX2 Tx selection") > Cc: stable@dpdk.org >=20 > Signed-off-by: Kaiwen Deng Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi