From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C234242E5E; Thu, 13 Jul 2023 11:12:10 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 641D240DDB; Thu, 13 Jul 2023 11:12:10 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 1CAB540DDA; Thu, 13 Jul 2023 11:12:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689239529; x=1720775529; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=uVVp2J02yxUQNLu7JjmRkytGMOg6Z3aZv7rDhPcguB0=; b=KV6//6I0IhXoGjIJNVQr+ZrHOV2oU6UHp9OiE+A7DNTZnedCJ6f8IRV4 Nyumtk8v1y3MU3iYxfyIpKtze4ETH3iNlUS3hyXmWVU4Pd1zc8mNpiEEd Q9N9oNX3no+Ti2WPtxqaQYicOb4YIDYSYdYVPzqIh+GvrBjc6Y/R87vNI XdsOvzvq9J8AkZSwojzrzmRRxPdRhZCPhhtBP+h4FEbxSWFhJkspnENE8 bszzCMndfj0zLGqnB9yBcAsTk2p9NG95BPrrK49CHbs7jq8WdRWTb7cAt BbtuI5x7AALC2jrmWCsyJ3XdwAu4IZ9MD0A81XHa9+k9t0AcRV0EeYqFG g==; X-IronPort-AV: E=McAfee;i="6600,9927,10769"; a="344727586" X-IronPort-AV: E=Sophos;i="6.01,202,1684825200"; d="scan'208";a="344727586" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2023 02:11:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10769"; a="1052542972" X-IronPort-AV: E=Sophos;i="6.01,202,1684825200"; d="scan'208";a="1052542972" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga005.fm.intel.com with ESMTP; 13 Jul 2023 02:11:56 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 13 Jul 2023 02:11:56 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Thu, 13 Jul 2023 02:11:56 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.174) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Thu, 13 Jul 2023 02:11:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mq8FDxisqjTg5qAHkxHaJJSuoNx0kfaD38slhZdczeNwimeD0FQb5hf2/YueVIAdUmxu7k4gr4cdbA2pXetkE4y0DFRd2HA7gFgV3Fsvyvr7J7by6+YAr7eCYR51mMVZy59H+LdFsrY71qlbEmc7iR2ivodlXHA3gm/86bG2Eu8QueRBK/XpA2/311QMJTGEekHJCzY/4EQb4fjzakn62F0P07NbEhAJlpTTjx88qnNimOKT7SFbg2U0Iye/gnCOPGMjRzqABnsvK6uPk6oRduPpum3pdoyQYcX712XxeMHr6Z8a4sY/QtkLwMDBUvFlX0/SHM2BE55tyrWilSi9wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uVVp2J02yxUQNLu7JjmRkytGMOg6Z3aZv7rDhPcguB0=; b=FGsc48SpxdIpSElSX4NvucG67jJDKhYW6QdLssVkRTXaL/OP6eGqGO2cOP5zFRi0gaNQCo58VoRsbk5H0VxvBFDz+W0t44te5/ihR3PuMBLMFXEEXIUYy0XKC3/asTF/od0zwiXMbvWfoPVr+lk6Yb6A4bjLWkLMQDkMy7HEvFyF5a9nN5xqKaKPmm8kR/7z18yj0GXpqvIfRTN1V4SChLweN1sK/wOadC4n4CoaCoEjl5JFgogYdt53/8+LcA2GweEWaOztzKx/JbrH4vaX5CmIDS3wPMQxtS3qZQR26JTcqfm7BvS6MeOzVpWD5SKnZ5Di26E+r2TR+fAdk6qaaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by SN7PR11MB8281.namprd11.prod.outlook.com (2603:10b6:806:26b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.24; Thu, 13 Jul 2023 09:11:53 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::d3b4:2f0c:6e6:867f]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::d3b4:2f0c:6e6:867f%6]) with mapi id 15.20.6588.022; Thu, 13 Jul 2023 09:11:52 +0000 From: "Zhang, Qi Z" To: "Zeng, ZhichaoX" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Staszewski, BartoszX" , "Wu, Jingjing" , "Xing, Beilei" , Ferruh Yigit , "Rong, Leyi" Subject: RE: [PATCH] net/iavf: fix the order of closing Rx queue Thread-Topic: [PATCH] net/iavf: fix the order of closing Rx queue Thread-Index: AQHZtIHONebbHEc5bUqG0XaXzhdalK+3avEQ Date: Thu, 13 Jul 2023 09:11:52 +0000 Message-ID: References: <20230712053537.88491-1-zhichaox.zeng@intel.com> In-Reply-To: <20230712053537.88491-1-zhichaox.zeng@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|SN7PR11MB8281:EE_ x-ms-office365-filtering-correlation-id: 5c4515a6-e9dc-48c2-860c-08db838132cb x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RUhDqb1/gN3m2Cyqf+Mn/UM6pJEIwssUMelem6zGRhVjWy8FbjovvLzmMDRk3EUOfbi3dbdQpzYUEAqIIgafOZVJzuSZIxXn5mQKQ8VuFcFfSvXRB0GNYJjL8CJwyF1Hu9RkKVZglXTHWLmOIyWY+/pQbJZclUYar4I4fTdu5FCQQUZ7DsbpxpT5HA5HW0cBvesOBBlwnn/M9PnFhKG5ZMAjeVFvryzOP+Z2t4o5ydoCsO0iiWUgbJyLwSlVWw/OJV+3/Q2u9liGK80x6jl8etgd5Sk6qXfMON31KS22F6ZRBQzp3bEZsnjw28UAocT2bqA7Penav/1ahvyG1fj0i+TnZKUDYfoy6TW+TEBV0mCuEW9+42J44dpTbdM5VpMVNJMSWs3Kyyw8Suteft+L38WamkZjiqwa8LZf7ZwjDbepdTG3OnB6UbUuaHpazI680NaNUZtc8xqF+S9FrAwjIGKdvtfyK+xcn9h5WW71inq4jqpkw8ipbUMX89IZQkAlZ0+v9Py6fxbJPlYlC7uWsHvGk2waJhqUYD2SEV+3FPOJN+6CxxpmLBIA411P9bUUthZTkG8/5d35HxHjQUUxCV0ZdCIRE868/4L7G/YSN4AbA89Ql+9UlTYHiQtcFzR2 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(136003)(366004)(376002)(39860400002)(396003)(346002)(451199021)(450100002)(54906003)(110136005)(316002)(71200400001)(186003)(478600001)(41300700001)(64756008)(7696005)(4326008)(76116006)(66946007)(66556008)(66476007)(66446008)(9686003)(8936002)(8676002)(107886003)(53546011)(6506007)(86362001)(52536014)(26005)(55016003)(5660300002)(33656002)(83380400001)(38070700005)(122000001)(2906002)(4744005)(82960400001)(38100700002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Lda8UIbAi8EaRNwDf35tDi5u+OMliBKfyCgiJOqFo7r6/eFn+GK50h3xLrnq?= =?us-ascii?Q?t7alp4/jqKeK8i/zPKMlQRVt+GKWUPwSX2PaHuqkbJtbReootHUQ+HujQ/ZQ?= =?us-ascii?Q?BnKsijfcuRCmBMiObIzE13COAbUN/IsnyXwYmzKhk8gOtTdDKcqXpxlsITtL?= =?us-ascii?Q?yf/B4lLjlIqGJQKUnuHb6e71Hz+Xr2rQ8BgBzxtisQrtQR9Ra5PJStBlWfCX?= =?us-ascii?Q?rlwtJeKioyqJ1k1n9m6bpP9DSvlv6+NcSAzipS93fRpVionKLCf4HXTPbA6P?= =?us-ascii?Q?PIi4YV5K4094O1ocnG/M6aMbEWU/W/L6RB5J5GB7Qwd7zqbS21CVUMDfGHbA?= =?us-ascii?Q?2SOAfIEV3dNP8oyLf/pB8n/JuYcoY4giVr9k41NWz4fzXXu6vs667Jlc45X0?= =?us-ascii?Q?y9saPseRwsOllJTkg3tw0DE9ia2guRiqpFch/MhQ6XYEj/DeEIfGgPbQANAS?= =?us-ascii?Q?Xhy2SoDISuGZYAgDLEbPU/s+Y1N4gqZ55Xy8mUudVO4RnTnpz3EXkEd+JAm1?= =?us-ascii?Q?UijNjrY3+qHANyO0ez+uVFgT6dTUsDmq0BasLHPMn4RInuLIOfU6qsTuiz0S?= =?us-ascii?Q?ahEBo9wqjLs0940CK54Y19l+6EogU55oWqK1ahG8reNtU6acTABaes3z3cXV?= =?us-ascii?Q?GHLt9p0IDZxaqVT/fsl+jwx6Qeh1rS22/MfdcTsrbcHSwZzFxNvTjAxxbo4Y?= =?us-ascii?Q?aytv6pKk18Bc9Wpjxr5YZ3xZuDelU4LF/VPk8u7m8kIVq5XXlKCpAKomu8wS?= =?us-ascii?Q?w2ZRq+I7jqaa1HameoD7AXqFk5SqveJ9SUllHA8wQXPLzWaY/rIfC1hBv/43?= =?us-ascii?Q?ObqOMFZURfqxvWvWGSlnU9KW/SuVpZPSTU0Yqi2L6jpG55MMcoRCNG0GAzXw?= =?us-ascii?Q?d8tM55vziHaC/l+3DX70qcR/ntILyCx6oGSA4hED8dWROOF5I9Co98LX0cnO?= =?us-ascii?Q?1z8sik+v82twzezVzqx8WeEOuIREvUnh9gbcxS9BBrTe3/UIW9uvdbysaVJA?= =?us-ascii?Q?rdw3ytlbLuLaJ0JSjby9Ef2rdvJS7we2DGUv5NBJMSoed+ysi7YnOYgte9Lq?= =?us-ascii?Q?1Vvw+5U8fkS4bVzYgnVS/gJWCP6eu6Fstms3P1hHYY8c5+ZsLTKFuaqR8st3?= =?us-ascii?Q?heIxSp8FWF73Q91dOkAFqQHUYpT/7XZAdH2x7ITcCc3B69q+n676ts3B76yz?= =?us-ascii?Q?GpfOmsLzHn2/eCYMDQ6KhHDatq8rNNWQKlh3yLhBUqck2PP0jmKf0qHmYjRZ?= =?us-ascii?Q?pAQ+vs4SFtQNz0boL5h1CI8YA8TGhsbttqHkGegk58kI91z1/BFGhPnJ8Hlk?= =?us-ascii?Q?ygH35fIkIS3MuUAzkJcgqcfu+lQndu9CLbKSZQ5uYSPffauXKH60tEmMvlnE?= =?us-ascii?Q?CeSB0Enlvd8c4JF8d4jq4N8WtwNOgwtYUWuXNrXp1kexq4wUrEgA8nSyDJ1/?= =?us-ascii?Q?XojsbRZ6YdfWUq9XG7ma2LDqceVLSGHBKOgioUQ95RK9uz8Q8hXpkroIu6Tk?= =?us-ascii?Q?HbcEtDm1eSXOPRMZi1acDPKs0wvVaq7/KVnpAlVS88/HKnb3dFjRH/5eDQV/?= =?us-ascii?Q?AhyS9TZsCMPOqahOPhuQi35AxWNmhaZ7qw2mLkYn?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5c4515a6-e9dc-48c2-860c-08db838132cb X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2023 09:11:52.9105 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hhuvyVM+tQjAIkTeL5tMrjg5EQS/S2799m/70FD/z4O0k1/+QqDmXa4Y/DzhJc8Eq8oImMJa/BjvlAd7jlJ8ZA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB8281 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Zeng, ZhichaoX > Sent: Wednesday, July 12, 2023 1:36 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Zhang, Qi Z ; Staszewski, Bart= oszX > ; Zeng, ZhichaoX = ; > Wu, Jingjing ; Xing, Beilei ; > Ferruh Yigit ; Rong, Leyi > Subject: [PATCH] net/iavf: fix the order of closing Rx queue >=20 > The current implementation stops queue before disabling the Rx interrupt,= and > when there are still unprocessed packets remaining in the queue, this may > cause the Rx ring to timeout, leading to IOMMU fault. >=20 > This patch disables the Rx interrupt before stopping the queue, ensuring = that > no packets received when disabling the queues. >=20 > Fixes: 02d212ca3125 ("net/iavf: rename remaining avf strings") > Cc: stable@dpdk.org > Signed-off-by: Bartosz Staszewski > Signed-off-by: Zhichao Zeng Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi