From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D6A84221A; Fri, 1 Sep 2023 07:38:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9E00040285; Fri, 1 Sep 2023 07:38:58 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 1853E4014F; Fri, 1 Sep 2023 07:38:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693546736; x=1725082736; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=9ywWNkdMx5XfTT5xuoDWZD+PFq298+iztA3JiI+iBTQ=; b=JFdHL8WSRlfQw1f02ewfNfsD3ggctIdeKZxwkjsvTWNWAve7Y7H7GlYc oB8hYPbpze0Hj5Bse2bfJdF8sDdgyVPcLGw0GRb0DD+cSo2uMAzy9er9d ihfdCS1fmaiMEtiQSmnJlgDShSqphTLZi2GoJQIcn4Ox8pzUvRU7LFoW0 3z9RzXY7h33/OkkTv4+LWmSAy8zGEfAdWwi0XuijGReNN0m+6HhR8OwsN ZfAE2EkVIdQ2bbguGhCcuqu4QCKXEiOJbcduQpmJscmFuYrDCkI0iaPUA hqY/WYLSE9p+Kx4xKcY515MbivkQmFejR/NwgnswpEozHbPH0py0+b8dW g==; X-IronPort-AV: E=McAfee;i="6600,9927,10819"; a="373534765" X-IronPort-AV: E=Sophos;i="6.02,218,1688454000"; d="scan'208";a="373534765" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2023 22:38:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10819"; a="689632893" X-IronPort-AV: E=Sophos;i="6.02,218,1688454000"; d="scan'208";a="689632893" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 31 Aug 2023 22:38:48 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 31 Aug 2023 22:38:48 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Thu, 31 Aug 2023 22:38:48 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.104) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Thu, 31 Aug 2023 22:38:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fRckkYhxn7hXufxx5obqAJ5caq6onP+cKpVzKlF/gV98RlA3Z1TVdzDwjtUZPOYOCah+D4QIJliXpbJHX3XuQMmEnUaN3rlrlkkl5HJzoh6LtjDoS8DMvYy/yB//IJypYTxMHurc1l4nvrm6tbeuMPEgYUIIJneWZSi1Mwy52zRDbd+y6OdtvP9dsXoE89wEk7m/q7i0giUBnO7CFMtHxy2YWc4ZJ63BkyPgoogZg6DyDelUTzgjGTl2KQGQ5FAlXk7sQLpw3incLPCDQiu3RTwNrt4IPLRiuOHtjRg8sXQn2LpGOYjJPOV3mc2vTRLjhc22eUyoN0QKz5yoPRKYPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9ywWNkdMx5XfTT5xuoDWZD+PFq298+iztA3JiI+iBTQ=; b=J8Vh2m8Cf6tCaqrZYrwBi/6QqsP7+tdvEBER6L1qcygcX6kupPnRF93amWcvNqhcbBak2oS15/n4IVuNhNArM8b9YRRdKRW8WSerlxGm1x4qSwedbI4xl1/5JrBBUPSugJj7FNCekvH6HWIGTUFExuoLvGqJsXQN/YuKz8QOur4tu4YD49JBRBgYtJIxB++CjD7/5Wf2mAr/L7bKGSGkWV4Mw08K1b7m92Bve81rlpFfA7L/Ke2yxJ2dEyUiU9B7Wr3D/+7SrUR8e0rXZwyOssfoBYlBEDEzmYocJeDQ+StTbXtfEwS6PMRk8dqiALoXMhNR7uebL91Q4fVK75O7Kw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by BL3PR11MB6339.namprd11.prod.outlook.com (2603:10b6:208:3b3::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.23; Fri, 1 Sep 2023 05:38:45 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::8a49:15a2:ab69:91c3]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::8a49:15a2:ab69:91c3%4]) with mapi id 15.20.6745.023; Fri, 1 Sep 2023 05:38:45 +0000 From: "Zhang, Qi Z" To: "Deng, KaiwenX" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Yang, Qiming" , "Zhou, YidingX" , "Xu, Ting" Subject: RE: [PATCH] net/ice: fix tm configuration cannot be clear Thread-Topic: [PATCH] net/ice: fix tm configuration cannot be clear Thread-Index: AQHZ2kQ8CGuJ5uLMnkCNC0TUdJ6wJbAFdlJw Date: Fri, 1 Sep 2023 05:38:45 +0000 Message-ID: References: <20230829062348.647999-1-kaiwenx.deng@intel.com> In-Reply-To: <20230829062348.647999-1-kaiwenx.deng@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|BL3PR11MB6339:EE_ x-ms-office365-filtering-correlation-id: 04ff9f2c-ca58-4c58-ff32-08dbaaadb5bd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jlRu04DrMhve+OJAUD5s0Wo5TK8fvUqlchb+sIYUlJizGvWfh/fkgd1eST7P+/ziewYgaUuj5Wc4xjKd3Ga1RtQPYiftEzrN0bkqASkbaU0QO1eKv/I9LhlETX6BA2AGfyngmci5pLhUdGh4RsMKN4a64/49hCQReSFFt6I2LI4RB2bSN6tYfzFF2eLWiit4k50AbMqQDxwf39gkMVt3N2h6I/W2i9lCB1OAlI3lISXGO29z+jyDhlrIjRl9cjqf9cv1i2DGFqV0nkAxA2NlId11U3H8mzQWrN9IDp5ZMWGelGGHfnz6AyMPkaIn5O13wYhi2VgafeFDGy7GvZDLKvXC63U/FwIoyWjRZ2kFXuI89TLp96lPyWf5XRFAB5ICdnigWniQRvASfGdft77EBbzKWj45orRRNXtDtBHIj6bWR0Wq3om0tEAJ11MNS8EWqS1RAZZvenPe6OPC+F1UuddTLcqSF1Sf04FBV04Vwe2JUZC1bcXd/Cxi1kL1BHPj5ROXzghYykASIr84BdI7bTqe6CG9xtveJXtFnEcdGtIdvr+8UAy2MWtVq5zuH6HFrMOCyFnjnKInOpJqA3NW2K8VeQApYcxwqlZeKtfthRczCBgW2zFWSDR1Be7wQyAC x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(346002)(376002)(39860400002)(366004)(396003)(451199024)(1800799009)(186009)(122000001)(478600001)(71200400001)(107886003)(110136005)(38100700002)(38070700005)(66556008)(54906003)(64756008)(66476007)(66446008)(53546011)(83380400001)(26005)(66946007)(76116006)(9686003)(82960400001)(7696005)(6506007)(2906002)(5660300002)(8676002)(41300700001)(316002)(55016003)(8936002)(86362001)(4326008)(450100002)(52536014)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kb7R5fZQaer2ZtfDxw3Y66J8HwhXjSet4rcGMVjWmECLHsZrdhNmXC6DUhRL?= =?us-ascii?Q?WWwPnBxSNV9bcwBDI3WTA2AVVfTMPYKu2+egeO4tFLtBwniicN3aNHAUILnV?= =?us-ascii?Q?YFdx9sFgz3N2kT6ZYhUc8T6FWqw9O7k93Mal/zbC3kr0dPeOaXc5wbtx+DT5?= =?us-ascii?Q?3yObB3c1YpFs0RCgrm3CkH0paq5OVyhx52/1xO+PeVGfLWlomb6KjcdZbXqg?= =?us-ascii?Q?SdCa6VeMYjvpPzy8kTL1YKTX1iVLF2JZrhdPtzXlYiksgUqV5S4hzWH1YPEg?= =?us-ascii?Q?TdW88LD1PNl/ThBFQYaoZD6vwNG+pAoib+XYj6SqI0Lxd6QNvmcUDcTSZXSu?= =?us-ascii?Q?hJH7snRpYwdxaDDl/cGd1m4e2r57hhB/+Fn7GIGITAYkWgVHyaE51Cse78T8?= =?us-ascii?Q?Qzy69BatHd1OKUyBfIo5TozU2vUesvhWG2euM1XeYaRAmVV7gqvLHIRc7Qun?= =?us-ascii?Q?dfNhXF0JrHo7ZppZnaSDF4EB5NidzyiZf8rwBsNKugEBJzzJGMiQRt5n8c3d?= =?us-ascii?Q?h6owCppRjqq53XeBSlgiXJIK7WzV1ZCrH8B+7WfW6CRL4vVLayYqMU6r6Eb7?= =?us-ascii?Q?MGTVZHUhQD8mWJe9Ge/cvHv09xfJZPAZm0Lustx5o0cvmXTzhhkVdeJwhVy7?= =?us-ascii?Q?K3VP8biHZ2m6xgo3trVecPiETTqhk5UYO/Qk+lIO4DrovR01IXTe8uCTFgnW?= =?us-ascii?Q?yNLLoFYCrGC8CZ7SnQWtlyB6dmutuYD6cJtUlr6aov9Mj4SBaUHjLhPvbRfa?= =?us-ascii?Q?H/CDyEdc69GLU8pOyeqhFCwbHOnLesQLkZq1CmiaETrAzEB93BIduhCkPNHw?= =?us-ascii?Q?HEmS9j9sjcWTMH4an5b4Y+XycrUDHrx56dsGZdcr/o1QMPACwdyBv2hrdHZ3?= =?us-ascii?Q?li0lonb9FaNCZ3iekepV4hJXpymvYWj0CPSuBJNh9Z0WaslrDmgJCX6rn5mO?= =?us-ascii?Q?xZB5+mGgFdemLb0ZRg2UoMUrSUAz0Yn7uwPE5r+e8NygcesNQ/8Gr4puYbTE?= =?us-ascii?Q?FVPLW2DpyNcdIqML9H0h/7uvUSbNdu+U/twW95EUJIwXT+10fZeWC84QiEwM?= =?us-ascii?Q?GNXwSn8V+ZpTD0t+GnP/JMsQPYVciGlwS1udwtyQumKC3D4uLabRD9RPf19i?= =?us-ascii?Q?syMx+U/TOLjxUKb8WLKOPSkNvqV7y+rsVVk11QYnwbi8oEmsaCJ/vxcorb1+?= =?us-ascii?Q?TwMN7nHbP8YMBhNQ+T+zIC4FYEeDgOtS7XU9duJ6ble7o50TYZRuzpo9p52Q?= =?us-ascii?Q?qIK76FZ7Epze7g0gw2FxbK6Nwt42Rei75kwtksdBPdWNDrLHOwzJbfpBXQUd?= =?us-ascii?Q?KpZJIwQ/tVAgOTxYpuyawX/zpz3issaTq3Q4Ln7Tp332wW528Pk/GjA9QHT4?= =?us-ascii?Q?bafpTfnjs3hyPe2DCvXQs40su3gUke5jKVcuV6uCzdSwiUYcE1362HT7tSK/?= =?us-ascii?Q?MYgIZglOykcSMIGxZ/7kHYfu91NaM2CgxbgrcQZ+yio8ybjwc4uv7xrMAYzC?= =?us-ascii?Q?nhCIyF6zH2iYmSR2B7wgut6PKaFsH/9QBSMWA5CyJsaqUocivLwpLvrseaOy?= =?us-ascii?Q?kvnuxWTV8VKQGiEJnm4AK4USfp6qK1zUbm6G2Yiz?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 04ff9f2c-ca58-4c58-ff32-08dbaaadb5bd X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2023 05:38:45.7806 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bNPnWjUwANCiwIy2tZtbQe5Y1QKfQ6gMJv61z1ecvYJTO8BTMhqvEzAwtNonuQGsOgQULTtk8aiSc3veWppEfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6339 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Deng, KaiwenX > Sent: Tuesday, August 29, 2023 2:24 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Yang, Qiming ; Zhou, YidingX > ; Deng, KaiwenX ; > Zhang, Qi Z ; Xu, Ting > Subject: [PATCH] net/ice: fix tm configuration cannot be clear >=20 > When the device is stopped, DPDK resets the commit flag so that we can > update the hierarchy configuration.=20 Why we need to reset commit flag when device is stopped? If the commit flag indicate all tm configure has been committed, stop devic= e does not change the status, its confusing to reset it. Can we simply prevent additional commit when device is running by only chec= king the stop flag? And why we reject a commit if its already committed? > The commit flag is also used to determine > if the hierarchy configuration needs to be cleared. > When DPDK exits, it always stops the device first and also resets the com= mit > flag result in the hierarchy configuration is not cleared. >=20 > This patch adds a new flag "need_clear" to determine if the hierarchy > configuration needs to be cleared. >=20 > Fixes: 3a6bfc37eaf4 ("net/ice: support QoS config VF bandwidth in DCF") > Cc: stable@dpdk.org >=20 > Signed-off-by: Kaiwen Deng > ---