From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39B8D42C65; Fri, 9 Jun 2023 03:48:10 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E595140E01; Fri, 9 Jun 2023 03:48:09 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 2CB3140A7D for ; Fri, 9 Jun 2023 03:48:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686275288; x=1717811288; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=7R/T96dy1lNz10AzpNa8rsXFrxE3K2tuoAGIA23xEnY=; b=Xo/eNag1NBhPqFveqRKwY0gNbLGKI0bUn/eC6Y4Bn/y1bV52yQEFHsM7 INGJ0bOl2jRUqRV+ZkQKfNzNY4Z/TPphmnH4Sk5HNNlHLmMqDq1TNQ5X+ tJimXDSeV7dNNcIeTPsPMyZwvq4JX6j70VVgKXGbVoqk/40TLB+jNAZdF 72Yk9iZ+1Cr4idCtrjUQg8lNSmzcW+FyXCJh0GNbDXLDxs08ZI6zk8kcW 01ytWCY3ePFPbaasKm7+B81FvKBhN/qp2IJOLi9/snzo2MUacC6M0n8LR 9/8f8eBV5Te19CiyGJAMyjR+b4pa6NIz+wgki38hScxwa/KZLk1gjPqQM A==; X-IronPort-AV: E=McAfee;i="6600,9927,10735"; a="359972402" X-IronPort-AV: E=Sophos;i="6.00,228,1681196400"; d="scan'208";a="359972402" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2023 18:48:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10735"; a="775317930" X-IronPort-AV: E=Sophos;i="6.00,228,1681196400"; d="scan'208";a="775317930" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga008.fm.intel.com with ESMTP; 08 Jun 2023 18:48:02 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 8 Jun 2023 18:48:02 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 8 Jun 2023 18:48:02 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 8 Jun 2023 18:48:02 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 8 Jun 2023 18:48:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BjzeCqvvPBFADMjvu7dEGTvJHCYu1e8WQ0aGUslnnwBNyMyZ87sCMgR+h02pzhsfM4R5r2d/A6ieV2oSPPGkGnUI3qFdnV6bOCUZfgHW1VpCzcxS719+T3PmwYNQwG059atg+mAYGxwJ5Yl12SqHINv6N2HOU1maXya64TTSqhDy/A2ffGlkRPgXagGzE+5p29FoAMoqr9R/oe68d7ade7iSirrLXuQxgpU7wtvg7LG8PTdqa9GHqZDxorOdsqqjInNnHjZAm+CECsR+y89RAS6wLdnHmgYKzYLkvrjnEHhuumYXnTka3xwiGnLGzhzwY/Py76MWHL6Xa38hg4XW2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WoWiRM04NUxWjhAcUQyDn+ltyoahq19uiQ7EgLb9FTI=; b=IOKaKUryyE9fbx1rIWuLuObUOI9ne0kHR76kW5eW+PqBkCssCI+lLd3q5i5tbTmDpOZ96j986bkoP7dRhyohZNV3Wx4PKXLVbWf5iUwi0yjCOgd0Ffhrczcn4U06UTz3QaNeOjIxi0b00ilSV+hRyD0rVE55VDsX4adyLxG96/3l1RYCurZpgHdd6V42hC2A/FE0xx+16++15MjgAfCojDvB7fBkejueLjWqRMuMxyFBd6Xz1eg3972hHVgY7c8gqY39Hss0UvoT2zyVfpxCz9Wl26LKCR+gsMIE2N+92i/ahzQazi3MZwftva/UtNy14UFes9qsCk7GGqIvO/8ZJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by MW3PR11MB4620.namprd11.prod.outlook.com (2603:10b6:303:54::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Fri, 9 Jun 2023 01:47:59 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e570:d9a7:df1b:1589]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e570:d9a7:df1b:1589%6]) with mapi id 15.20.6455.030; Fri, 9 Jun 2023 01:47:59 +0000 From: "Zhang, Qi Z" To: "Ye, MingjinX" , "dev@dpdk.org" CC: "Yang, Qiming" , "Zhou, YidingX" , "Ye, MingjinX" , "stable@dpdk.org" , "Wu, Jingjing" , "Xing, Beilei" Subject: RE: [PATCH] net/iavf: fix abnormal disable HW interrupt Thread-Topic: [PATCH] net/iavf: fix abnormal disable HW interrupt Thread-Index: AQHZmdL+I848w4U1/k+6isYKcDm7HK+Bs5Pw Date: Fri, 9 Jun 2023 01:47:58 +0000 Message-ID: References: <20230608062305.99819-1-mingjinx.ye@intel.com> In-Reply-To: <20230608062305.99819-1-mingjinx.ye@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|MW3PR11MB4620:EE_ x-ms-office365-filtering-correlation-id: ecefe6b3-af49-473e-d438-08db688b8d9c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wCc47P22fUS1T7Ij9XbdvRXLuZVqQm8FX3xd8gQBtN+xtWfczILe9MAbTxgvvBa5zloN7UzGEWGgXXxycWyzwbmZ5chT2Mey2gPGWz0mEmR6vgAGNJ+zUYXQtHfaXFyDIWxXNC0kErZbf+5uGVAti7/dCgLB33yUS7HnYs4SakksRxiraawHevmguVCB5pZ4/V4d0uK3XIuBTedZVORb3uq+XjeDXhLVXYFnHfgFmyfjLndEF3SrhJ+aMqCuhvz1ZK22cGTy8EgDPSiA/ZWVw4ZZ7Ree/aCf+MJ1wqi2VpZcGu6RjeonpiZQEMynWHTdN1nMs6Upj/mNT2wam19pgdzJmmHNu8R9ZN5XSMNd2cKOt3N3DAhOn1o7z+FkLBaWlZJZd9kNbe/MZ3pNvF+EfVYL+5Btl3L8K7lJOhrLI9ecUtmmE7XMe9H68BDfGDx3E2IDybQoyQDFgbMWgFOfS1B8K4eO7ueBbzvvYf9GqTEpMPq5h61y0fwq53SGc+kfGtQzC7cfIcm2RH5mpmg5Ue5wdWHKQvlCT+pMDPs1gPR229HV+EVYyxZdZjCqrdfs/BipYFpSzEO80RB6s5GkJlOCNezZDvf/u2NyOMbBW6ARWd3qkwhNC4Bs8F8B0Gs9 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(366004)(39860400002)(376002)(346002)(136003)(451199021)(38070700005)(316002)(41300700001)(478600001)(450100002)(64756008)(66556008)(55016003)(66446008)(33656002)(2906002)(52536014)(5660300002)(66946007)(86362001)(8936002)(66476007)(122000001)(38100700002)(82960400001)(8676002)(76116006)(4326008)(110136005)(7696005)(54906003)(83380400001)(186003)(71200400001)(53546011)(26005)(9686003)(107886003)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?++S0U2rWNuXstlZwdmciq5FuTBmDIGpe4FIeNE82xBhUNZBlbPV3t+hpnzMa?= =?us-ascii?Q?q9g2yGlXUVdepsYVIXnK+lZkrVsjkeLGuSshQWMiTJ/wQmYikzbBBm4SjglV?= =?us-ascii?Q?e8deLRPzC7B89ilgIsK672n83UXMpJIH83rOcJx0C/f6SuuGXNs7KFcSPHw7?= =?us-ascii?Q?3K4G9P+Yj8o6amUOMAGPunehiTELJCZRv1C0Ft6s/HlCXsDcoDnmeNkLrCNJ?= =?us-ascii?Q?UOMnEA9blgn8EvtMlAh1XYci2jxrGJHZHZUk1GdaR7UeDGs59d0nq+32xSAf?= =?us-ascii?Q?xEY2PPU6O3jEakO1mjvYxoelimtIf6dAHfMRJ5sMfPz4TjeU1KaG7181v1ny?= =?us-ascii?Q?rzRSswgSJuqTwoL/YQfWOJbaLMVTcIW+zrYyNrGwyMdaZijwlgc0PAgJu7NQ?= =?us-ascii?Q?ZoQhE+yao4dPuI2jgIIEQNLjZbHyhZxcZ+2UzjKs32Rsa8ry10aNKXhVGmc+?= =?us-ascii?Q?3HO/TLiBHG/F83YIyC85KV0Q7TVAo3h4MtkT5LlO7q27oKbXdIzdofSbg8QQ?= =?us-ascii?Q?lGPoCFYOPgIjjEVHzlfDvaFqUwBxZqJvWjOUoNz/09BP/E4gswZAKyXIhIvl?= =?us-ascii?Q?yvzzXfsj8r0HwLPq7fxuz6qkWHIGGQ9fmHCx+/m6c9R7h7QMFwHtj7L9YCU6?= =?us-ascii?Q?LYcbhiaAMnn4b7RYfLf/DV9MpdlEp2VEBWenP+L7fL5ROHceOKkn/adHp8IP?= =?us-ascii?Q?ChcCqOVDKbRvw0vT9gGhZRzIa2sRZxe5jy9sQzDopbc8NlvHGa4cPqwX1uuY?= =?us-ascii?Q?iRTZkM2VM0k0uPswU1WIR/T3muVgejfBDsctV1o7qUr7MewZqgMXF/siOuBd?= =?us-ascii?Q?3lSV40xbwBhNUQtB0zKz5UKmo8kniBk0AYq+UbLqW+qz4eF4E2OhUU8+pYLe?= =?us-ascii?Q?+ftrf+zOtcKuCB8txziLObfVP79A9QNXH2dW5rD1xfnnSzhplWufA9Czm+u2?= =?us-ascii?Q?fIuthNmhPmsvaBHd4doo9ujIdZdbJa65jj69ig5UtlXVDdu1BkCfDgfy16av?= =?us-ascii?Q?Y48ejhqS0sJNA1ssjCpwIvX72hBXxpXrSavvvElo6b91Y6N1ANKAmMAgNz16?= =?us-ascii?Q?uPl6Btuao9mSU2tF/A3iBCfLsmXZ4Kw9quBGr1N46QA+SO8gJ1pX/WwsAbB5?= =?us-ascii?Q?Wt2oBGqPYwvLEn4b1XWg7uBefiJKO1O/dvxFyLRGzwTfikZDwrPYuAvs+gEq?= =?us-ascii?Q?K3Bls2AJFCWPEy9Is0AIhEVEw/ZvqcU+XmIrJQOVM+ybhikvrDaN1vhq5l5C?= =?us-ascii?Q?nD/jkGxUz1kAZpyWynmT09WGktWODDMCxaX6HYrHfboSg47SmuR6xOM8ji79?= =?us-ascii?Q?U5wzp5ndMlRIIxVcKnDcd4U4QUDloS1dt/+rOjsjW/NPa80/e8SO7MZ18M5o?= =?us-ascii?Q?cypUXKGMLuzyrsQpd6WJzntyuCszUH+iZ/WP5ym0+WE8YftaKjqSe/yHvBNt?= =?us-ascii?Q?aqbZ4lHtvNMWiVZcTULFuPAm7JaHnChcUDFjnGOGTuGK7u+bbkbcEAHcKIJ7?= =?us-ascii?Q?5FfNigfLOTGwNXdYJjYQ560WjFtS9boqqUXtlgPjww6icUaR9jBXVn6KXgP9?= =?us-ascii?Q?mm5xJDtcojO3Pk95GBmlB1vjVxL18bKL1lHLoTBN?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ecefe6b3-af49-473e-d438-08db688b8d9c X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jun 2023 01:47:58.8300 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Lj5aqbLR9AKTlsRlnPQ8DSS7J4H7v5qUw3PWhEzzwN1y05Uu+dKjfvDPYqpHBIAc1n/dZYCYZ90IKQlTQc95Mg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4620 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Mingjin Ye > Sent: Thursday, June 8, 2023 2:23 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhou, YidingX > ; Ye, MingjinX ; > stable@dpdk.org; Wu, Jingjing ; Xing, Beilei > > Subject: [PATCH] net/iavf: fix abnormal disable HW interrupt >=20 > For command VIRTCHNL_OP_REQUEST_QUEUES, polling access to the admin > queue has the issue of access overruns after disabling interrupt. That re= sults > in FW disabling HW interrupt for protection purposes. >=20 > The updates/changes in this patch: > 1. Remove the polling admin queue processing and use the generic interrup= t > processing instead. > 2. Release redundant queue resource before stopping processing interrupt > events. >=20 > Fixes: 22b123a36d07 ("net/avf: initialize PMD") > Fixes: ef807926e148 ("net/iavf: support requesting additional queues from > PF") > Fixes: 84108425054a ("net/iavf: support asynchronous virtual channel > message") > Cc: stable@dpdk.org >=20 > Signed-off-by: Mingjin Ye > --- > drivers/net/iavf/iavf_ethdev.c | 25 +++++++++--------- > drivers/net/iavf/iavf_vchnl.c | 48 +++++++--------------------------- > 2 files changed, 23 insertions(+), 50 deletions(-) >=20 > diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethde= v.c > index e6cf897293..ba5c88a1ec 100644 > --- a/drivers/net/iavf/iavf_ethdev.c > +++ b/drivers/net/iavf/iavf_ethdev.c > @@ -2756,6 +2756,19 @@ iavf_dev_close(struct rte_eth_dev *dev) > } >=20 > ret =3D iavf_dev_stop(dev); > + > + /* > + * Release redundant queue resource when close the dev > + * so that other vfs can re-use the queues. > + */ > + if (vf->lv_enabled) { > + ret =3D iavf_request_queues(dev, > IAVF_MAX_NUM_QUEUES_DFLT); > + if (ret) > + PMD_DRV_LOG(ERR, "Reset the num of queues > failed"); > + > + vf->max_rss_qregion =3D IAVF_MAX_NUM_QUEUES_DFLT; > + } > + > adapter->closed =3D true; >=20 > /* free iAVF security device context all related resources */ @@ - > 2772,18 +2785,6 @@ iavf_dev_close(struct rte_eth_dev *dev) > if (vf->promisc_unicast_enabled || vf->promisc_multicast_enabled) > iavf_config_promisc(adapter, false, false); >=20 > - /* > - * Release redundant queue resource when close the dev > - * so that other vfs can re-use the queues. > - */ > - if (vf->lv_enabled) { > - ret =3D iavf_request_queues(dev, > IAVF_MAX_NUM_QUEUES_DFLT); > - if (ret) > - PMD_DRV_LOG(ERR, "Reset the num of queues > failed"); > - > - vf->max_rss_qregion =3D IAVF_MAX_NUM_QUEUES_DFLT; > - } > - > iavf_shutdown_adminq(hw); > if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_WB_ON_ITR) > { > /* disable uio intr before callback unregister */ diff --git > a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c index > 8cc5377bcf..579c0d0d70 100644 > --- a/drivers/net/iavf/iavf_vchnl.c > +++ b/drivers/net/iavf/iavf_vchnl.c > @@ -323,6 +323,7 @@ iavf_execute_vf_cmd(struct iavf_adapter *adapter, > struct iavf_cmd_info *args, >=20 > switch (args->ops) { > case VIRTCHNL_OP_RESET_VF: > + case VIRTCHNL_OP_REQUEST_QUEUES: > /*no need to wait for response */ > _clear_cmd(vf); > break; Have you tested the "large VF" case ( > 16 queue) with this patch. I assume event VIRTCHNL_EVENT_RESET_IMPENDING need to be handled here then = to trigger a device reset. But I didn't see related part in your patch.