From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 614B5A0540; Tue, 13 Dec 2022 02:50:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4262C40684; Tue, 13 Dec 2022 02:50:58 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 348BB40146 for ; Tue, 13 Dec 2022 02:50:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670896256; x=1702432256; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=9nXVX6EcjSEAUG8U3wJ3Ki3lUjAxX05h3DkASkP0WAg=; b=WR0IL6ClMkAnBAvpiVvEVylX+Hbm62DHpVpaK4nwfXyqcMSMF9iIRI+b UAHuWOUHBFWurmUzlugkhZhFj3ipbF+bCifnpxPbKvWKCQBhTdpQytQPF Uk27pM+gRtfoZAe3kLoCji3S2QZp6RvdtqMwvWytIH39JPudlEDQp8Jyn AfqzcgKzrmWVP4P+X5ceb95CqLGBLCzepaX+eurk+fT0aYHd8lvSvEaXG hfsnaaTflJcUhcSwZ7qB9YZ4P437oxqpQRH8Xa7yHGmehkqlulXCtFmWa D28SlpUhe+KnJdhMs8AOA8/GuMWvHURBLePPDTFxz/keUDHug4gAaf0pL g==; X-IronPort-AV: E=McAfee;i="6500,9779,10559"; a="297696004" X-IronPort-AV: E=Sophos;i="5.96,240,1665471600"; d="scan'208";a="297696004" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Dec 2022 17:50:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10559"; a="737205484" X-IronPort-AV: E=Sophos;i="5.96,240,1665471600"; d="scan'208";a="737205484" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by FMSMGA003.fm.intel.com with ESMTP; 12 Dec 2022 17:50:55 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 12 Dec 2022 17:50:54 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 12 Dec 2022 17:50:54 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.102) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 12 Dec 2022 17:50:54 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ItCoPByZeGa1zdwUKC44Yy6+kSYxhI/MUT21byuyvie4nzuSXQIOEvhtxfonkk050rFyDnLoGE0t4TEN91ImzprokXY4x1T37vqITCmnuwbV0bpdC85WbgKT6jtDVIoorhdhtSgcdXKEOe3Dh5bX8latb6baf22YIFKGZJ68oux9TbNV9a69gfCOCFvTYJPrLwdcM2T2vtW9ANgc8nIr97Ni1XhT51YDq290+sYCvKpCeh0ZHparrz1VW2ErRNPSFelnJO+Kn4TtYnD3VYpyKVoMHfcnOQyw6NXKN5xno3m5nDcmY2AQjDMrjtpC2Ja7lTNMO4/xwm3VSZ8M47L+VQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=76ApUSy3F9DUYkT2fEtDmAQt/YtnRJkskv+7tqYCQCs=; b=fQO+tmYRgIiJ+lPKrQr28qKslVCjCTm0Uas9/KoyAGwif2THc4QRtulGsVsbrXozT1++FDhJz9iGibFC64E4Zd2N5mL+KUP3dRPvB6j8ri2JS6HSCT6Is+3esmLmEn5Kp+cYyR47FTpMOoHNYkUvgeftqdQZolaNQxsEbVCfovNbfK643+NFe7XufE7qQhCV4w32Uqt763eQ6qwLCAdXmCn1gTTCkRm7nduPK9wE76iuO2Yt2atOjfFj45mjDmhRqVUun1wXBVo62nb4j7h4wfxV7u0NuHaMDPYMsQWrkhtD2MYubEuGSML+5flkF+2XcbVSBQr2yVpHDXECJfXnPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by SA1PR11MB6821.namprd11.prod.outlook.com (2603:10b6:806:29d::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.19; Tue, 13 Dec 2022 01:50:52 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::f465:abe3:b917:a641]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::f465:abe3:b917:a641%7]) with mapi id 15.20.5880.019; Tue, 13 Dec 2022 01:50:52 +0000 From: "Zhang, Qi Z" To: Shuang Han , "dev@dpdk.org" CC: "Yang, Qiming" Subject: RE: [PATCH] net/ice: fix link status error when dev start Thread-Topic: [PATCH] net/ice: fix link status error when dev start Thread-Index: AQHY/zkQeNEJ6iGPkEuFF/spOq3KJq5rK33Q Date: Tue, 13 Dec 2022 01:50:52 +0000 Message-ID: References: <1669207333-8769-1-git-send-email-hanshuang87@gmail.com> In-Reply-To: <1669207333-8769-1-git-send-email-hanshuang87@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|SA1PR11MB6821:EE_ x-ms-office365-filtering-correlation-id: fe0d8ccb-809c-4680-cd23-08dadcac77a0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: quPcDIcHvNYZFiew/wzFvnakDXBHygcc022p9jycYdS/juHZ4O0z9jVQP4DiJ+k6+gqTQ95FINPcimyXXlP+adTsk994ax6sYZZgPdkWz8QVmqm9lZoS1GtjjKzARklukTOfwejipVzVC6v4Jt6IwCF9HtqxGizf4jJNUsiqLzr1euWVNLI3pnQXRmw36xON892kVdD2eJNGnoNBa8hlAk1EULoCAFG4yoLWdcSmKjsLeY65VXV6JidKXeEE6E3RWvNKPm0iHVk8CCgJI9Ot+MxBstQSj4Y5yAr1t2yT5ViUjqnCZvzOhyh6bNJRL9X1MeKPPWflCCT77P0jJjgNxIFSp7E3fMDoM6iF/wwZ6kFwqVPbANGGx9K8Ft6HpjT7mJicbJ1yB56i7OYwwKwTWTPxy50qpbu6iOtW1c4uvZyzwhe3b1+ITEaBBOzAzzkX3gFWW9pQJEblfEUtq9nsV79LX5w8pns3fvkKjcV6CybdVTb6yATIQqhI4GZ8kz3IyYI8kvFat15/x3KzrsFHVuqoQ8Sbv1CPXkOJCVuk7dmMeUm0vHZ9zhvUMJ+QNrakz1B6qdiqesk9saWoR7Jee2df79e+f2xN0NU3cYcd/fpeql8BRBf2XkvcHcS05llW4TLqODeb1VqZRBHzw5o0qG+VPC6CKj6U6EFyBJFMCKZitTKbTzwsPPYr9FVSDIwNFg6w62Eac++S44uv41xbRA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(39860400002)(396003)(376002)(346002)(366004)(136003)(451199015)(9686003)(86362001)(110136005)(33656002)(4326008)(76116006)(316002)(8676002)(38070700005)(82960400001)(122000001)(38100700002)(186003)(26005)(53546011)(83380400001)(6506007)(7696005)(107886003)(66556008)(52536014)(478600001)(5660300002)(66946007)(71200400001)(55016003)(66446008)(64756008)(8936002)(66476007)(2906002)(41300700001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UF0anr3lRi+axObXMQoyWoIPzHWxbgHnqJgxiJ+XXXQiRPbP9XOh3EMGR2X2?= =?us-ascii?Q?Szel8OftqGCcvdiXwvA0UjqUx3PlokZ4aS1qNRfCOw2MiCKobB54y6jFgeDD?= =?us-ascii?Q?91vyaVla109xdDXEjI99uAIY6nYud/f2aBkKnifQ4jDipQN72xL7z/DMb1mq?= =?us-ascii?Q?tH0vq37ndKGrwUqxRv0uGOVHhEiAM/V1s8Xoaf97fuGEhaRiSttkQpvvYswI?= =?us-ascii?Q?tBRkz2f3AEeMcQ+ShvvEvODtBKElMXN18BzdpEEIniUC0VbaTVuPCw3urU/t?= =?us-ascii?Q?KTwNbFYhrK+l/QfjrzLEbjacKAoO/DwPdbREpvUQFTr2MjTSZj/QE8THlH7B?= =?us-ascii?Q?carqBeelgsKERoO5E/mWLpX8FJHoxPe3rIQVqnlypsoTAxEIuJHNcRBap460?= =?us-ascii?Q?+bwz8zf+PjYLaBuNWsehr5qxOm9GuFC5B85yGu1XK06sQfYcp5BziC/eq7WZ?= =?us-ascii?Q?7CzKmhhIQeLRBsSve4slmBSxoIZuqkKsyYvXfpqfSPOny2Y3GwRNu8kuEwbR?= =?us-ascii?Q?XDXX+eftznLQ8lJ1psvtzeFD5RRST/wIpLmBAkTkYDeIHI36dndH2HdWy0Yt?= =?us-ascii?Q?ZNm8tdhe+rzU4ny1jM4/nVHIsj4+lxV1IpTNdOKSCstrIFVoeLlJKj7ANzgC?= =?us-ascii?Q?/HP5yFhdRbr4aoJ6FDKlPXUDSIEbFGUpQymBsRbs5Z+OCCUFaAvAEK0pr/dg?= =?us-ascii?Q?8kQpm1YZW+CoO2C/DywP8i5j6YjuOCNDdQwKZhdG5XK7boK4ADV5AUKd53RU?= =?us-ascii?Q?qNpL9trUaqMhQG7H/lTFGfQz+WnNzPKiW2aJQXGvOCxtDyd2Q/Y9Z/JiM/Sp?= =?us-ascii?Q?bWxMFGYKS8r/sp2AUzz/gt+t2yGglrg2zR7D7HMxaJkHqJ2BzaRzB6aUDtCw?= =?us-ascii?Q?U4GjhIDFay5S6+C1QX7AmrF1eZQHwqCN5pdvKgHUbI+UElNutGjEyddcNWA2?= =?us-ascii?Q?SPlUpnMX4W1hqvkVMDa9UdZDUHNrnFWnQxUNXpn2n1JReKRi56RkzpWNRU91?= =?us-ascii?Q?k4VocdymV1E42krZPL4WP3LTcpNjSOeZK1L2TIaLnhSRLnleub1GUg4EPIBh?= =?us-ascii?Q?LCgqMEKx842eTUflNXpDfXf/g+oQGPcEqJvD8HNaucbuuT3Yk0+IR7jeJQ1B?= =?us-ascii?Q?u3CVBEReRhtGRw8wilUkvqzGJajJc45jYeMOLHn10erpGMWS1kBaK6WUnBXx?= =?us-ascii?Q?CuxrYXQrDFl+NoYdjqOL0tylQR6Q8coJIU/0+FYVYV38Z+7BaAEgzzrvKLde?= =?us-ascii?Q?3PV2mJqsNQsLGgI3EInI+zYmLO2ZeElYZxzldjy895R3YPWkf+i8yfUr7Uhs?= =?us-ascii?Q?BYgrcds6UsY0jpP507L5rOl0LMrGwBsFtQRnd5Qnv5f6MF6dpryq4BZaV+1D?= =?us-ascii?Q?5Flynp1nZPRmfipzZmWbLW5s+8nei0w9mOhdNoKkMGGontRCTuwMKSw6LbQR?= =?us-ascii?Q?6W1y+hOP5JOZsoM9Mq8SFTETMnwu8aCTklYif1S9OMOOA63s349uR1D3rOEZ?= =?us-ascii?Q?lmXhnFb1VWLuFteZWleOMdDZ5LrWky3bLNUK91iZGuhFjPh/zTLm+UkvzHcv?= =?us-ascii?Q?idI3SousVEjeS9c/WI+8sDlwXQT0aVEncac6L2Ot?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fe0d8ccb-809c-4680-cd23-08dadcac77a0 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Dec 2022 01:50:52.5702 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: w/Q0WImf/OSEg6Plq8bZJsx5kG2owhVrKRcAvH0CLJUXjaaRIMEi4pKnCCT/3IW7QaWtemrv3qc2Dm1mDYFC7Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6821 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Shuang Han > Sent: Wednesday, November 23, 2022 8:42 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Shuang Han > Subject: [PATCH] net/ice: fix link status error when dev start >=20 > ice_link_update get port link status and wait for one second when dev sta= rt. > If the device need almost one second for link up, ice_link_update will en= ter > the last rte_delay_ms(CHECK_INTERVAL) with link down, in the meantime > link interrupt raised, the interrupt handler update dev->data->dev_link t= o up. > After a while the rte_delay_ms(CHECK_INTERVAL) finished and update dev- > >data->dev_link to down. >=20 > Signed-off-by: Shuang Han > --- > drivers/net/ice/ice_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c = index > 0bc739d..316ba5a 100644 > --- a/drivers/net/ice/ice_ethdev.c > +++ b/drivers/net/ice/ice_ethdev.c > @@ -4013,9 +4013,9 @@ static int ice_init_rss(struct ice_pf *pf) > RTE_ETH_LINK_SPEED_FIXED); >=20 > out: > - ice_atomic_write_link_status(dev, &link); > if (link.link_status =3D=3D old.link_status) > return -1; > + ice_atomic_write_link_status(dev, &link); This looks like a workaround, I think we may need some lock to prevent ice_= link_update be re-entered from different thread at same time. >=20 > return 0; > } > -- > 1.8.3.1