From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Li, Xiaoyun" <xiaoyun.li@intel.com>,
"Loftus, Ciara" <ciara.loftus@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH] net/af_xdp: allow using copy mode in XSK
Date: Mon, 13 Jun 2022 23:38:21 +0000 [thread overview]
Message-ID: <DM4PR11MB5994C4A17D0CFF4272479727D7AB9@DM4PR11MB5994.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220613151231.1359592-1-xiaoyun.li@intel.com>
> -----Original Message-----
> From: Li, Xiaoyun <xiaoyun.li@intel.com>
> Sent: Monday, June 13, 2022 11:13 PM
> To: Loftus, Ciara <ciara.loftus@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; dev@dpdk.org
> Cc: Li, Xiaoyun <xiaoyun.li@intel.com>
> Subject: [PATCH] net/af_xdp: allow using copy mode in XSK
>
> DPDK assumes that users only want AF_XDP socket (XSK) into zero copy mode
> when the kernel supports it. However, sometimes kernel driver doesn't
> support it well and copy mode is more stable and preferred.
rename "no_zerocopy" to "force_copy" looks better?
This aligned with the comment on the macro definition in kernel
#define XDP_COPY (1 << 1) /* Force copy-mode */
And also make the below code more smooth.
if (internals->force_copy)
cfg.bind_flags |= XDP_COPY;
next prev parent reply other threads:[~2022-06-13 23:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-13 15:12 Xiaoyun Li
2022-06-13 23:38 ` Zhang, Qi Z [this message]
2022-06-14 8:23 ` Li, Xiaoyun
2022-06-14 9:10 ` [PATCH v2] " Xiaoyun Li
2022-06-23 10:52 ` Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR11MB5994C4A17D0CFF4272479727D7AB9@DM4PR11MB5994.namprd11.prod.outlook.com \
--to=qi.z.zhang@intel.com \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).