From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85014A09F0; Mon, 14 Nov 2022 01:52:36 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2ADCA40150; Mon, 14 Nov 2022 01:52:36 +0100 (CET) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id B57E24014F; Mon, 14 Nov 2022 01:52:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668387154; x=1699923154; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=HF2Y1DbuYGvqJyzEp9mvpWW4xH87sxNKBQWdSNForHw=; b=gTgOBqNqfH5OTn5xbpMc9w/L5Yb9aviNbx2rzk/FAWMg2je8i7N8xTAH 5zkvc+ZTPImpNq2oeaxnmfSMAed3jSeUGNXzZGaeYBy71uUdCHvZ+SWLm j3UGjSbM7hkTBrYICwlEIE6Lni1BAfEiNaf12kdScOc7RlX6H9hkRBvMV N+UoMy8aajPy313/ulgyHKbgDKpVkUesVpqmXPZwjxljYR4AsiG2vhkiu fwV/F+Try/fk71ARlDMN6k7Ji5k0iXbBLZi+fwsTUc2fGKJOKeQlUs7yD a8jJuV7Ldu2vnzd4o5qBaP9nin0IL3PcjgCBRkm+N7SixLMELqWeunUQ3 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10530"; a="373983109" X-IronPort-AV: E=Sophos;i="5.96,161,1665471600"; d="scan'208";a="373983109" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Nov 2022 16:52:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10530"; a="727331198" X-IronPort-AV: E=Sophos;i="5.96,161,1665471600"; d="scan'208";a="727331198" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by FMSMGA003.fm.intel.com with ESMTP; 13 Nov 2022 16:52:32 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 13 Nov 2022 16:52:31 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 13 Nov 2022 16:52:31 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Sun, 13 Nov 2022 16:52:31 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.174) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Sun, 13 Nov 2022 16:52:31 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QVCq82M4b/nAeQI3uWzklmko39ZyM8jGB3qLYBLHkimnSOFsSBqg5BuZwOBeeCAUUulN9BLneMHtzR7TqLPgdMok7Bx7qLZ214rPn/uTpXb1/xXylhOhpVCjIwcVTdHKnKt4edfvj4megkTjVR/yJd3mOLiHjosKXxe9Yn2hNuzUTbUnP7mPQMVZHbfpw8NGL1ZI0ROq3MRDU1LhSCAAsronCvNbTLBmCPofRosY6fL5vDDvmTMAA/ktxkg2zERcaiKiXYtezjii7FzXV0kRp8Q++GqXRtuTWAO5T5tAs1+GwJfyjVKCFAkDNuaJM0OeVEHMc/H2Iem/FKmJ6bj4/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HF2Y1DbuYGvqJyzEp9mvpWW4xH87sxNKBQWdSNForHw=; b=QVw0DkhtJ/8/v9CcpVDJDhkvjDiwpENkGkjtHaI5ypHC59yj8HGZJq8xKPS9kNQViHVtaM1V55YN0viZpnGw81XnL6lDNX6QTpkPdTIX6WCEpL96S/cyHh8PuOCOlh6vTA2TwRMIuVDdoeNetQXmmf2GogcTbLOV13BFrFbUIO7wxaCTG+n8VEUPJYYKmw4C1FMhzKC6Y4sPqLvrTSXgkhXU5KMCg49dpOzgzcz/9Iw0n7pPaufi9df9ieNvf5qhi6PPrGcJQc1wfSDvAydWnJEcJR91wgalSff6W9JIX8o0Ap+8w4KPwdov5mKeOLRwrAKPaQA3FJxc+ajLzw77NA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by SJ0PR11MB5600.namprd11.prod.outlook.com (2603:10b6:a03:3ab::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17; Mon, 14 Nov 2022 00:52:29 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e2ac:cde3:4d74:3fa7]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e2ac:cde3:4d74:3fa7%3]) with mapi id 15.20.5813.016; Mon, 14 Nov 2022 00:52:29 +0000 From: "Zhang, Qi Z" To: "Zhou, YidingX" , "dev@dpdk.org" , "Yang, Qiming" CC: "ktraynor@redhat.com" , "stable@dpdk.org" Subject: RE: [PATCH v5] net/iavf: revert fix VLAN insertion Thread-Topic: [PATCH v5] net/iavf: revert fix VLAN insertion Thread-Index: AQHY93zc+nMFWq+x5EWMk62EJruOZ649l6eA Date: Mon, 14 Nov 2022 00:52:29 +0000 Message-ID: References: <20221018102602.217673-1-yidingx.zhou@intel.com> <20221113163031.1975916-1-yidingx.zhou@intel.com> In-Reply-To: <20221113163031.1975916-1-yidingx.zhou@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|SJ0PR11MB5600:EE_ x-ms-office365-filtering-correlation-id: 59331594-714b-45be-0c56-08dac5da816c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mP9HquEeFXBHPCJ0jXU7znPZta+h6w9GvmsP1Sx2+8nxi2bSDh3jGsxzVtVTKplyNyVSj0irt9O2/EQQzW91eccjRCxlGZKkbNv3oCabO16C4Mjf8s3pyBoa0M4DUKtDzFfsyC8DG0fFaGrbjzJgaekuwakgNXpdJj/nyYIwEeJFbNOUsu5vA9aDGskvBZ4537VJ2IookJwF+qeep0MddDxQHhp+0lVJHMirbQmElNUFW8J7loP/x2paJYzgAcFCwCE+l+Pz2Pdg8gMxohQof4566cz5XCABX0+GNOTvZGtKvFfE+cf8f4unsxSPJNfJ1qlRw4Ac80DbkuDKDU2si2jFWvptQLJ6/iHjSKhj99xv5liJxoP1uKrUAvrZG/Ih5qsZnt8sDBGmUfsGzOJaX8PaifBi2xjj6pbdMDypIdcEImfRmPWIwbixAjcdo0hZ+zTB8+WZGfeHSS/ucr4Tocb6Z8s3jexFsCgFwb9pBTE79aJ2Evar9qUk1PXsEfydxCVR1udEDZz8P/AMfXSeVTNUTKDY1fyNHbj5g9lYl8D4mqA9c+2pqHwPXIUTQWA+RJOCLXglGsUGUkXWDB7N1sJi8847yBqoXD/E3H0hfvNTMdWmUo3l0QUozxrYI/LxIn1idDCG9nO+CFmt0hT+OFStcUjBaA1BCDqU0x+Kp0R86+OnOXd1YQQwtiMCHjtrLAISGLuHHLuBwKh4F/lbmPxISozyAQ5Be3q3I70jWlUoUHHDYHgU+LijZf/8k2yJCqZw0BiQFJxCO8YjYjV/uQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(346002)(366004)(396003)(376002)(39860400002)(451199015)(478600001)(55016003)(71200400001)(52536014)(6636002)(8936002)(5660300002)(41300700001)(110136005)(316002)(54906003)(33656002)(64756008)(66446008)(76116006)(4326008)(66476007)(66556008)(8676002)(86362001)(66946007)(38070700005)(83380400001)(6506007)(38100700002)(122000001)(82960400001)(9686003)(186003)(7696005)(53546011)(26005)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RBE2s1qrnpsy7BDOIQqO6DzcxyWgB+MzRGgtFTUwR7K9/bTALuhmsd0ghgMQ?= =?us-ascii?Q?AJCvhvF0pzsM13QZ4SwE6GDrjQCDe1bnIn0swFIeNz8WuWe2gDFT4Q2YRfuA?= =?us-ascii?Q?4RLOO1hQ7uAYPrJknNnotSHiASu+A5UJEphGDRz3rtJLZ0WlxxOpq/YXapLy?= =?us-ascii?Q?6khLQbAHpm9Qy8DpBGcpxmuaJQxJ+hL/j1iQB/5PVb9Vhp1hWQxx/Ix9maSJ?= =?us-ascii?Q?RnDaZ4l6RPxPhYKakg8qCL38B8rVc10zQBHk51uudqouk3IIH3PgThDf7vui?= =?us-ascii?Q?qGIKGG0xNcwk7uuNG6+p7SvWTjXKEXYLlfbNR3Px9DVEC/RO7b0ANeNn6IJE?= =?us-ascii?Q?XjMR1TAPQgno6gXY3X+JtWE4adeICPRnCgzHyMFtdTr4HYH3qhzZAyNGtZ0M?= =?us-ascii?Q?+acLor4KFzBSeFVzfo8lQTspcj+nSd/owhkZ9ermbjA151SdA7eijjIbheT6?= =?us-ascii?Q?J6/GK/wtrJTI3aWUjbe5ZPr0JnEI+QfzVw4u4qkag4LTAlhVA06I++gv8Cup?= =?us-ascii?Q?379mV7P18lbsMcGQmscEHWVZG1zfhFujq60wGVooJaQsEAJEhIFJFchBsWq1?= =?us-ascii?Q?M1rxKY8FeNTYWAbsb/lWQZspblmlqXWpKAklQVHIZA64jJcRSmqSLiPLCFDX?= =?us-ascii?Q?W4C1VL+Cue2LdlndeXUoGj+9vELmYGCpvxAgG/wG1DU8rydL5prwweAi9Kqu?= =?us-ascii?Q?RriKt33+WLOKAqKvyTIIIx2yET+ifsjdICfqTa3OXSOgNPNbjTneOUnZKTnh?= =?us-ascii?Q?UboShm5vuk68Ujz8fIz+82E6rSkuBiNulzDys4ecN9jSqKetZGY0O06Kuffa?= =?us-ascii?Q?ysE5LHmXr98IjOfmvA5+H2lV1ORksaZitrleCuVsumjIDfdLYNuqKBG5XiT4?= =?us-ascii?Q?D1wSiEetSPxg5UoNM29NGyAkBSJMjrCdyMNe2+0KVMFsmYn3wYSl+PzeFWYE?= =?us-ascii?Q?7GiDkBk+jzh00b4x7obmlUME3XWtdezBE5gZhfp2vcROGoMg6L4mzaSs3caR?= =?us-ascii?Q?3cKFypzOxhNnigUvpkyhbc6n184Qh4bgDwvjHAx7UK+Lxzq6ZeRMX3iLLcsr?= =?us-ascii?Q?8HslEf15cJt02dlCIKLt3K3F8m6jwfnAsvVdwy4jqVL3STwUnMVJUBAXjn3A?= =?us-ascii?Q?zbOBjNtW1NYHURBZN9Stu5xrfD7Lz4B230rnk17+BzpcmwZfsHcsT/N2mVPs?= =?us-ascii?Q?m2ak4mjPI5TGQ+8lgAZbpwksujnZ4PEVnRj7rgbJvb3VxFVTkHXVk3bjmxSw?= =?us-ascii?Q?H4YhZUbd8BO9UlaQ5DyTSncfFNm1D93nuW0Ts+ukK1oUK8FNQinLA39q9r1d?= =?us-ascii?Q?/FE4QvwOCvFx0u3nzHKKC8sRuQiZCZkwHxjIO3kqeQGEIjr9WpRWmhyvValI?= =?us-ascii?Q?KN+BQnsGvXsIIOZi/Q+DFNUZQQHsDjZTxNzkB1iYo8ncvXsuTLaKa0bm2MRm?= =?us-ascii?Q?/Ow56MyiCkAADjR0hw9vbNVLV+oVdPGlq8hDqAl5+kPOtcuBBMwIibyvuSpP?= =?us-ascii?Q?mKPwOAyVyKRavoec7nPFP2QaD8Hp7Am+MSzWIbWw/Vr1GkoLf9VsPYlVCRmn?= =?us-ascii?Q?V6uqDZ5tfLvDtVhG1JWJNgILGl8mTldBJzwF1AGR?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 59331594-714b-45be-0c56-08dac5da816c X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2022 00:52:29.1074 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: akBkkDv0Kupg7rqKOh0kAl9mAhFSgPrLRof9HaZrQh9eoYRbDdRy+nHa6B1kVuo6esZwrzNtTDjwr8mt8GcNdw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5600 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Zhou, YidingX > Sent: Monday, November 14, 2022 12:31 AM > To: dev@dpdk.org; Yang, Qiming > Cc: Zhang, Qi Z ; ktraynor@redhat.com; Zhou, > YidingX ; stable@dpdk.org > Subject: [PATCH v5] net/iavf: revert fix VLAN insertion >=20 > The vector Tx path does not support VLAN insertion via the L2TAG2 field, = but > the scalar path supports. The earlier commit was to force to select scala= r > path as soon as kernel driver requests to use L2TAG2. That logic is incor= rect. > Because other case like VLAN offloading not required but scalar path sele= cted > would have a significant performance drop. >=20 > Therefore the following commit was reverted accordingly. >=20 > commit 0d58caa7d6d1 ("net/iavf: fix VLAN insertion") >=20 > After reverting this commit, the AVX512 Tx path would insert the VLAN tag > into the wrong location(inner of QinQ) when the kernel driver requested > L2TAG2. This is inconsistent with the behavior of PF(outer of QinQ). >=20 > It is currently known that ice kernel drivers newer than 1.8.9 will reque= st the > use of L2TAG2. User can set parameter '--force-max-simd-bitwidth' to > 64/128/256 to avoid this issue. >=20 > Fixes: 0d58caa7d6d1 ("net/iavf: fix VLAN insertion") > Cc: stable@dpdk.org >=20 > Signed-off-by: Yiding Zhou Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi