From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7EEA742B14; Wed, 17 May 2023 04:26:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B587410E4; Wed, 17 May 2023 04:26:07 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 38AD440EE1 for ; Wed, 17 May 2023 04:26:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684290366; x=1715826366; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=FPgRLH2plgYnrj5IYW+e59u6Aj3GBN3GJKM/zVi3Zt8=; b=YQgeDY1HqS/mWRyu7FNB1GL2VnvUcMbNeBGsQf4mXc7iv2kHvaVO0OYK ywDXU2E+QCQb6r8inonIJyaMYqYHepO1d0/r1a4jFCZxTEuoUG6Gjw0wW 5U8/EWA0XCiPhvWeJV7+wXilRkp7EEYTKjBG1wuIl7DUAqA9+Y6CfUonM nTngGvO3qIVC9PfBlZij0N2R6F347crGQEJ1lOCuZ0t0p3CSThi9Y/sPt I7kY+VoOvTanADFBo0HsjFxh/nq3Wo4T52fT/6Dnj89gpe+16Yavx5tEL TDAIb2KgQWf5JgbpKq/kAiEFBxa5BFs4kJTD1qXiBthwMKSfVrWQA5VMs Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10712"; a="331258907" X-IronPort-AV: E=Sophos;i="5.99,280,1677571200"; d="scan'208";a="331258907" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2023 19:25:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10712"; a="652057954" X-IronPort-AV: E=Sophos;i="5.99,280,1677571200"; d="scan'208";a="652057954" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga003.jf.intel.com with ESMTP; 16 May 2023 19:25:54 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 16 May 2023 19:25:53 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 16 May 2023 19:25:53 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 16 May 2023 19:25:53 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.171) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 16 May 2023 19:25:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wyou/3bHl5S4QWXdiK5Knn27BX4Z6qU8knTi5Uups9r6+QoWgN/lcbH/TVV2hO8HHMNkC8QnIR612/5pJguQY/Zd8nqc6wdRkLrDlsQSyis3FDcLPjxQuZjZvQiq9OVOwVUOLDtNiV76OH9KwR0FT9O6Tx5Dza7FrZaPmFdMgCrlGqc8xrzWoWyPND1KU+2aieiddZg0C0fYuFSsJCF7NGERgaHgacg7e+lEuBms54V38hUQT1EIr9r/MYyFVqF/uProaRSVA3dSWNoE77uY2pUu0lOX1LDCZrzxroxvQHpgx8gorsFO7uQcDr9ZTrRG/bFC5Snk58Yd5FsNfa6QJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KuBzsyFLh7L+QKbRJpb8IAyflWRLq0RISyzSf06WOI0=; b=oYAM6Caf0A1lNOSTZWbEyR0chqZViHwNbNDbdD12Vs6asu8ztN+wTU51GEzJax+m+PXCLMKa5lYwArZBmUsJaeI1eQd9IxtlJTqiVmq3yZ41YFfe8Uh2lET1NSDIY6rxi5oDH+5wuyG64IG3PuCjbjiWwlrlREiLPbhQGI+1Td5PGEbxhEkKTwSpPI+toZv7QQ3km5tV28tSnDx/2dLPNeOc1Dfqh58e7M16w1NaC644OwcWukooP34GrzEgqkh42N7Dkl/ck+oI2CVeehRiVqggI/Zl8vkOYKdPwUa4duftwMg47Slr1DPEA6I6fTgxpcOpN0ZOQn4oE4cmSQXT3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by PH7PR11MB6746.namprd11.prod.outlook.com (2603:10b6:510:1b4::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.33; Wed, 17 May 2023 02:25:46 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e570:d9a7:df1b:1589]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e570:d9a7:df1b:1589%6]) with mapi id 15.20.6387.033; Wed, 17 May 2023 02:25:46 +0000 From: "Zhang, Qi Z" To: Feifei Wang , "Richardson, Bruce" , Konstantin Ananyev , "Zhang, Yuying" , "Xing, Beilei" , David Christensen , Ruifeng Wang CC: "dev@dpdk.org" , nd , Honnappa Nagarahalli , nd Subject: RE: [PATCH v2] net/i40e: remove redundant judgment Thread-Topic: [PATCH v2] net/i40e: remove redundant judgment Thread-Index: AQHZYUb6pZ3945Elkku6Wif5jzf/xa8+8XYwgBvtiGCAAZEaAIABmwTw Date: Wed, 17 May 2023 02:25:45 +0000 Message-ID: References: <20211220054246.4031616-1-feifei.wang2@arm.com> <20230328072828.386576-1-feifei.wang2@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|PH7PR11MB6746:EE_ x-ms-office365-filtering-correlation-id: 880274e9-ace6-4f90-e6d2-08db567e0572 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Z4A+gZNNOvzFvp7LnI0uYbq3UxwwGvkOQtdSPD0ERWvj2qopVFY64MPdPI2vRydtyaWSSiWWld4rMkYekndTuLVGA+Y5I5w8X0vucunfayYOIZe8/h/6aVDZ7lG+j3I/BEWgRHnjrNKENrxoWUI6J6SByIo3jnR5vfcnQxbHO01/o2oVnL7sr5cjj0RAj0Wa2ViJC0cUPpN+N5/W9MrfDwV1Ur7wXG+sC5RIqoLU+fYdk6NVDSF1d/LaGf3/yiT9MZTvQAAVkQg1JQQOS/ywuvCCnu6qDVN6k9SCRTL9F5apLOv9idPrcC0RPQ75BSVCg0UyTMNyiLdJJQuxIF6lpG2NZj/xr1+hTEK1RSr8APc0f5TjvQVCZX1yu+hsbftThQuQKtEtsmDRIMbl9Y+qpZp60da+KvkiEI2kAbbCRaFRnI9Fpb9A5EIW3dXlr5Ih54lJjiY26FbN4pT70yOCGZWFMcdpU1Ymu2F8ZhnuDS3Z+Y4l+KWm52n3975YhEUQWdeKa5jw7kJcmrnWhf0SHIPsKkHfeWTm1E6HhAzNqHM/7qQkIaTOw/wPN2UXMjzjD4nKNLxLY5P0HqU9pso5MpIKwTGapQ0lK0DByYITh3e/+bHBTTJEuDUT2GKVv5/YGDzXul6gdyQA9xex8IdqBg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(346002)(376002)(366004)(136003)(39860400002)(396003)(451199021)(52536014)(8676002)(8936002)(66946007)(83380400001)(86362001)(53546011)(38070700005)(122000001)(38100700002)(921005)(55016003)(82960400001)(4326008)(316002)(41300700001)(64756008)(5660300002)(26005)(66476007)(66446008)(66556008)(54906003)(186003)(6506007)(7696005)(478600001)(9686003)(33656002)(71200400001)(76116006)(110136005)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2Q0dHpk5oCjQB6WFntPsDU+WEPRAmuOaVDnGrWGOIRipfBXL+wDRd7JlOYh0?= =?us-ascii?Q?7HlGjFtXgWQR7nA+XqEoYhJs92hn9gI4+M5919+3fx0kI4wNv9ykM9IE7+u1?= =?us-ascii?Q?BbzPTRgCSYnCP86coh1aP+A9W/izPxHKlNS61/Qw7m1br/dQYsvE1jC3lyo8?= =?us-ascii?Q?IzaNFV7X8gdkLjyVXsz1jeRECB1YpADEdu11JAX5664lAvir1IVamMj5903O?= =?us-ascii?Q?8NIe64OZdohELuBKH8uYcuXiWM2hmPYW7dGUBu+9kRou63wasI8P/S+WB7OH?= =?us-ascii?Q?XYI3EcNrGjTctpedX+0xcXq5QcELeyFKF2ubgZeHu92BIQF+lBsUS/xRuZqo?= =?us-ascii?Q?ewZ3cTjKC3fQG0A3iSzK93pS3SEYWzp3dePYwI2ddZ0Wjjx25SMLHR+aOpAe?= =?us-ascii?Q?i9KYYN74w+1H0wJAzGQiOm78ehilOeNM6t7uhCbXLf+OlmeL4WirGCYkG61b?= =?us-ascii?Q?tKB1FQ35DzwBc+7KOWF7iC7jOY3mkKLb5H0xsUZQd6c/LAvej9Qy1Hv+Tsy5?= =?us-ascii?Q?09ZkN/UxICPqpWFuHbzzcV4OCyvvGGNXxCpaZeznGrbH1Dn71PB4TQQeS8YW?= =?us-ascii?Q?anqTtzw/D/+bo38CXUtcK8fOgnSDG+T6dMAH+T7USNp3MZnVKCziX86GmSAE?= =?us-ascii?Q?izr4XkKm/sl88z8AQ2Fykru+dMXSbep4c7HwXGM4OtjTp1P97vNV00KF5Q+0?= =?us-ascii?Q?tdZhFwYbbzfsraMo/QtnUjMuU7JHsyk0dN22QzCtuZKUE+qURuzFtgMOZlv3?= =?us-ascii?Q?iV2I7S/7s2apHFeI14/Ukydltd93T6LmrkMmSoJrtKtjjl2EbtqZ+1HPBWbW?= =?us-ascii?Q?Let06BaJRQ95gp52p3sjbv+qdUQHEFpIuHw/28vuf8RbBcZaJm9lu8KLzi6F?= =?us-ascii?Q?s9joAtWBuIedMsylrG7krlj/Wz6Azc4oMesgoahcpYFFjXigemoIswm9l/f/?= =?us-ascii?Q?LaRO3bP0VxFqGhoalfaXYPWE2Z+tt3Vk6z7cJGWhELoJGNrnbg3EMpIDCRUj?= =?us-ascii?Q?XOqbM6J97UNJ5pOyBqr3nMeUhMkEbK+dKs2PwbIo742BUES/YRm2kaiqaPYD?= =?us-ascii?Q?JMp/WbUZLHdOKXx11FBtfZenpJYGgmYDtUL0pWuz48colUQDOKXDWDGJF31o?= =?us-ascii?Q?I3ciO4nTBc342yWAg4v7bL7TSBij8fGC2xXguRN8otUA+at9saqv1OTg3CtL?= =?us-ascii?Q?/4p/FR4PNKs/WlAOovpw1ekTNLS09jINfncN4HD12ej/UulMR8a6xw4bEMB1?= =?us-ascii?Q?myRg2E2xUPyoqGPH/lchAgrQnbVl3u/avNtbIBB1+55ly9K3t5ypSN6+tSWQ?= =?us-ascii?Q?ir1XuTp7FgZStCq4Fl6usm8lXL+xyzFUa1v1f81M2WBvIub9VfCPjQ9OHB6Z?= =?us-ascii?Q?7iiORozvtlHGDAs9YTZw0EEO5UqG5QFoQ4izpJlDzFUUfhnKui4w4xiyS8gm?= =?us-ascii?Q?9uAbKNab3i1gt4pNRfT2EEnmzSdifuB/Bxq5xU2vxPVBGwTpuUWMA/hqOozo?= =?us-ascii?Q?PNnm6gsqUATlboq98emCQxY5nqGLizNrl+of4ekh6obCR5OHfmoKx949LTZc?= =?us-ascii?Q?SpOVMyy8Exlx4kFo4AbSmiyXMmAkt/OV20eV4cJU?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 880274e9-ace6-4f90-e6d2-08db567e0572 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2023 02:25:45.9828 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /6WHOJUSVlHAPIBLv/F5T1pU8klQWx9q0LyKiA2GlEI2VM3/Z0EEZLjk3mLoszBuIBcL87X3qtgkxbKfL9bkKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6746 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Feifei Wang > Sent: Tuesday, May 16, 2023 9:54 AM > To: Zhang, Qi Z ; Richardson, Bruce > ; Konstantin Ananyev > ; Zhang, Yuying > ; Xing, Beilei ; David > Christensen ; Ruifeng Wang > > Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli > ; nd > Subject: RE: [PATCH v2] net/i40e: remove redundant judgment >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Monday, May 15, 2023 9:59 AM > > To: Zhang, Qi Z ; Feifei Wang > > ; Richardson, Bruce > > ; Konstantin Ananyev > > ; Zhang, Yuying > > ; Xing, Beilei ; David > > Christensen ; Ruifeng Wang > > > > Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli > > > > Subject: RE: [PATCH v2] net/i40e: remove redundant judgment > > > > > > > > > -----Original Message----- > > > From: Zhang, Qi Z > > > Sent: Thursday, April 27, 2023 3:38 PM > > > To: Feifei Wang ; Richardson, Bruce > > > ; Konstantin Ananyev > > > ; Zhang, Yuying > > > ; Xing, Beilei ; > > > David Christensen ; Ruifeng Wang > > > > > > Cc: dev@dpdk.org; nd@arm.com; Honnappa Nagarahalli > > > > > > Subject: RE: [PATCH v2] net/i40e: remove redundant judgment > > > > > > > > > > > > > -----Original Message----- > > > > From: Feifei Wang > > > > Sent: Tuesday, March 28, 2023 3:28 PM > > > > To: Richardson, Bruce ; Konstantin > > > > Ananyev ; Zhang, Yuying > > > > ; Xing, Beilei ; > > > > David Christensen ; Ruifeng Wang > > > > > > > > Cc: dev@dpdk.org; nd@arm.com; Feifei Wang > ; > > > > Honnappa Nagarahalli > > > > Subject: [PATCH v2] net/i40e: remove redundant judgment > > > > > > > > Merged variable updates under the same condition. It reduces branch= . > > > > > > > > In ampere-altra, there is no performance improvement with this patc= h. > > > > In x86 sse and avx2 path, there is also no performance improvement. > > > > > > Thanks for sharing the results. While the code implements some best > > > practices, such as reducing branching and adding compiler hints, > > > which should generally improve performance, it's not necessary to > > > highlight that it didn't provide benefits on certain specific platfor= ms. > > > > > > Would it be ok to remove the last two lines when merging the patch? > > > > Ping > > > Sorry for I did not reply this. I agree with this when merging the patch= . > Thanks for the comments~. > > > > > > Otherwise > > > Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi