From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93C89424E6; Mon, 4 Sep 2023 04:31:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2939A402AE; Mon, 4 Sep 2023 04:31:00 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id CF209402A9; Mon, 4 Sep 2023 04:30:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693794658; x=1725330658; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=hGcjIj+FOyXRa0OrZ0n5/XvV/w2sptXunT1YUSLzfU4=; b=kIsroie80MPDwd8tJBmaHrLIxXQxKLfIrPToFDZiw/OfcJe9I+FJ96SI mYAPGhZfMpMynr0uL6Y1HGhlt3Hh+29CE4+t2cafjtE19WyUarxMr+/Kz f7r0qIkooPP3bkCGjMnHMukyB44HGTEBOXsemJFuVgfodATpDhonprsPx 4n/yzto8DzP8JwIEo/Vy3iBGeXlJj+9XeyojuWEDvAeKP/D+BPUhfJywS IXBJJIH8vj08P08tbRDiv1vRhDKpow10FiYibk9b7SAEDpE8ABF8Mn/Bu NjIT7r44u2YifozKMboSp5ziOrtJZbOH1hp5KArDzfYcXnvU38eKHdmyI A==; X-IronPort-AV: E=McAfee;i="6600,9927,10822"; a="361520425" X-IronPort-AV: E=Sophos;i="6.02,225,1688454000"; d="scan'208";a="361520425" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2023 19:30:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10822"; a="830747702" X-IronPort-AV: E=Sophos;i="6.02,225,1688454000"; d="scan'208";a="830747702" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by FMSMGA003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 03 Sep 2023 19:30:53 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Sun, 3 Sep 2023 19:30:52 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Sun, 3 Sep 2023 19:30:52 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Sun, 3 Sep 2023 19:30:52 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Sun, 3 Sep 2023 19:30:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Khrd9PMTG4JGiYsPJ9yXMf1+YoljeTwqnT/cZaHDttHysOXnA8qju8HOAmK7daZSGk1SQebXmUX+h+hoEF+ELSSeh95bhx4WPsnGKmDwkk+7yFEISzX7IVqGxjFqf+ujM3k9s+7UJSu2s6OkRvRGsOP6/nYqV8j/cMTJstxsem1dp53pjEq7IaxkOqAnH03xpYvBdQgx5tflKsAn6gF/A+6c6R0Mz5wq/fTAdQdm8Q1n4IM/L7+2rAsEVmZLNG/Xm9HUhWa3IGUDLSCC/czjphIYIj4Y624hylYmg8f2x+eZJsq+VsuLrUKu9feRA7kSsvAEXfESvVFydnOpZJXFDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hGcjIj+FOyXRa0OrZ0n5/XvV/w2sptXunT1YUSLzfU4=; b=MIDqGkJREIPFZ4vhaL/3BrCX9njMyj9Hnh9v1cp0iz+AhKQ9Py0H5SK8QAXIkBz2OSR1KJpANcuzKp8rd5I2LsjRDl+vKMy8iT3Hb7dya1gU1ZT5JnTvm4wiCCM1s7bHNg55vWvGXbYihFQwjqXWS5XcA8toy+cPgqnjvHGbg8nc5ZORdtJAeIJ8PMHuU6PJAJgDuihO9seJSw3Q+K1CEOoB+399u2zOUrZxY3iD9TtinsnQ4zk/Br6RJxSPGoaXvxr7Ho2dICDk9mE1nKxPOz6K8ysuL2KOS5fYe9+HE1+tgTz25xV30Wi56ursM7M77UKi0YlkCoQagMSp9CGliA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by PH0PR11MB7165.namprd11.prod.outlook.com (2603:10b6:510:1e9::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.30; Mon, 4 Sep 2023 02:30:50 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::8a49:15a2:ab69:91c3]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::8a49:15a2:ab69:91c3%4]) with mapi id 15.20.6745.030; Mon, 4 Sep 2023 02:30:50 +0000 From: "Zhang, Qi Z" To: "Lu, Wenzhuo" , "Richardson, Bruce" , "dev@dpdk.org" CC: "Wu, Jingjing" , "stable@dpdk.org" Subject: RE: [PATCH v2 2/4] net/iavf: fix buffer leak on Tx queue stop Thread-Topic: [PATCH v2 2/4] net/iavf: fix buffer leak on Tx queue stop Thread-Index: AQHZ3AeXFE83EslzV0Wuxg/+oyt6pLAJ8+WAgAADnXA= Date: Mon, 4 Sep 2023 02:30:49 +0000 Message-ID: References: <20230830155919.592390-1-bruce.richardson@intel.com> <20230831123337.871496-1-bruce.richardson@intel.com> <20230831123337.871496-3-bruce.richardson@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|PH0PR11MB7165:EE_ x-ms-office365-filtering-correlation-id: bbe66b85-5f33-4ac9-f9c3-08dbaceef409 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iII6SzHdJm71BG72yk66mTMQfFKxIWHkIaStwUt1T9WJZlVlvj5OszSltG0MDJ30ZW9zJHxAuDhffOGR02wz08RMY40Ut9k7kOPqQlFR+R0RLK2/k9I4dG5bHZMEiEIHhKoQkz/bAnXiVpMb5+bt8sdxmO0erHK3o39KEHQh3pTKu3C2xhyZqFrqGGTPrXXQ1gaPw9EnMLBfuwBXD+ot60iLhATAkR+2VHfRA6zEIrqlDpE9eFyB4jzFlDsQOmnxaswIX/y6yE/1fkHkx8T7Z1mhzqhvCeowJV6gbTPg0/8fahqO88f/FzfQjKZJA8hDgmMbYa6wa9veCsIXagjYCEpvFahEDf3861yM/Wqwj/imXvpkDKM7ktfhvqOaevnRMLOWrf3fqRWEeJ3KvnH7Api8ALVQElWqHu9CkeIZ+tSbkJY3fMVEyaVOVYQRALwRriBAMUxKymccxJdj53ZXtEIgebHHEUyjfLRt3/S82iyp8zbj9liW2jMcu0JK6P+0v8qS7diCFF+A41XVwZYu3H4SaeqzmmW71e6Gu8tolyV7sxczEB/YUW5t4RvcBVb4VCEGUn7PufMxVkJnGXNxxyVE4LabHJV6+hmjmvOLYIQkcdp92At+/X7AGqT+JKff x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(136003)(376002)(346002)(39860400002)(366004)(186009)(1800799009)(451199024)(478600001)(71200400001)(110136005)(66946007)(66556008)(64756008)(76116006)(66446008)(66476007)(26005)(7696005)(54906003)(9686003)(6506007)(2906002)(450100002)(4326008)(8676002)(8936002)(316002)(53546011)(41300700001)(52536014)(5660300002)(86362001)(33656002)(122000001)(82960400001)(38100700002)(38070700005)(83380400001)(55016003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?h7gRV5Ym1EBCgXfWdmpqRtDnAN7aG+axQyPSGf+GQK9KV8zdRYIB/3xTNQW4?= =?us-ascii?Q?mLbzzjpetyP0CwmNBUnZNW1TZz3PhHgpgCQKjHmwRREWnqrXEtuLQOgAM02P?= =?us-ascii?Q?AwX3Dj3PLLge0uOutWGys/HaGq7ulp05uhXY1jjz5XEn7purZA0UW+B29BUX?= =?us-ascii?Q?j9HGDEjBpol9HMeRN7TFCd7iCBzqL/5Ht6B22wvEVQZB+JUzLjgP7a9XLqjt?= =?us-ascii?Q?nLWS2pnDtuEpPrXbCTOxK9tThu1Kq6cAJliWvUlj4PCK0FEf/zgu5wtvP1Kl?= =?us-ascii?Q?uFch5SeVZgT/Gm/y1P4iIDdYvc5t/1lj6sptA8t9jw6IIf4Fbc5amWyeH+wr?= =?us-ascii?Q?J9W4SRKo28pX/FSBnZiaoBq9sSMgNjBX3uURlcwCjGCGDHnrJzYVXD0yzoAu?= =?us-ascii?Q?pcbzJJ9BLFD2/klT8XZsK7szqgsigBb9utT0aJdP8Tm/WKHnQuuNmcdqBun7?= =?us-ascii?Q?iie3VSNSMT6S474b8UzHmJxYvwXqovzw5ZlWtyrAgxc5Yokk/qinDMH53Cj9?= =?us-ascii?Q?8sh0+pMe/X75Z9OAUdBr9MoMca+/nGvKU9Ktwv7LeZDJ+9BIN1alb2eaSfnv?= =?us-ascii?Q?jGIWE33L1R2qYi9zQYIO78soYI0aUsp65GzsJrNqUiGY9OTWJdrIB1vdgXqf?= =?us-ascii?Q?TQSFKxXHra8v56LfbKjMqEPEyOeRME0RjE5SLI0z/W/dJwVtSqSRBIhzhL+B?= =?us-ascii?Q?6DOVF1O3j0i2vces7CAjPGIginTbaUUxldbaanEqsZT8oUIMiFh4acgSQcHa?= =?us-ascii?Q?SPAoAf1AygAGoIpog+SqLEieX9ZugVtSL4zrjaWI7CekJga4AnLOEtqju2ll?= =?us-ascii?Q?EDrufIBnnH59D8xoqmITCjk0AZdYlXMZTAdmxQXYvi+X4uj+lVg0GZdkz8DG?= =?us-ascii?Q?qxgEGytvirmMUx7e04EDUDr/CD1UOfSouAqZ1wHVVyd+5+5d1h8zlBr8VGJo?= =?us-ascii?Q?M5ywj6V/G8QWXvi6ljDkialeIf6wlQdzN5jJL78b0mZg+StapS8pqjf4felp?= =?us-ascii?Q?8HMDxIepwF8tXG5GvaxuUHj7oPkyXokenOUdm70UMHCnlixJSWnoaEBH+EQf?= =?us-ascii?Q?SknJx5+AtZpxXObSADn+ZJYkLf41b02BVZF4S+qJB0D6LYp0nnlq7qP76m8p?= =?us-ascii?Q?q+I1qzXwpvkqnPbARa+K2eSkGEnOprOi45OpEymbH3eu/g/4/ZH7vzgNgQ22?= =?us-ascii?Q?QCCRbTgZiIz3P7juHLjcPwfVK3iDsB5pMZUVrUSODZkQIFLw3zCJk8oAEdDF?= =?us-ascii?Q?fPZK9rhdmSFtd6wsRzBVZK2S0AHZt3KzW31XcPEFkABv50oO+piUOj2dtSPh?= =?us-ascii?Q?Mn45J6dMjuIJAqGj5z8MNxWM0o6T6snD/sKtCKzx+IrucVrJ+xJCd+NupASD?= =?us-ascii?Q?zUvloIKBrUCRbHg2ybPC0EaoPuzTGpomM5r4ddwhqK22GoLz5Q/X5VIUPYM4?= =?us-ascii?Q?+S2nlEbW0eMninV9VHosqRGNJ1dXPyQHWByasjdlkJ/LQXsSV+YPRGGxGxur?= =?us-ascii?Q?4bEA60Dksgt1KCJJdUQYLg5ZVyBgDjDBMetTEA06obs1wcQApe5cyMYSoJ1H?= =?us-ascii?Q?Rp85z2vpkSbGKWC+vAOPehKK6YSAgtP8bZ3yUtjQ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bbe66b85-5f33-4ac9-f9c3-08dbaceef409 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Sep 2023 02:30:49.9022 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lWHL2O+0W5704jYUjJCa6T12RkIU2f4MfBkuihv6dxKjRZUR3d0ytjW8KYkys44NLuoiX3OS7H6PzB1rQwXWqw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7165 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Lu, Wenzhuo > Sent: Monday, September 4, 2023 10:18 AM > To: Richardson, Bruce ; dev@dpdk.org > Cc: Wu, Jingjing ; stable@dpdk.org > Subject: RE: [PATCH v2 2/4] net/iavf: fix buffer leak on Tx queue stop >=20 >=20 >=20 > > -----Original Message----- > > From: Richardson, Bruce > > Sent: Thursday, August 31, 2023 8:34 PM > > To: dev@dpdk.org > > Cc: Richardson, Bruce ; Lu, Wenzhuo > > ; Wu, Jingjing ; > > stable@dpdk.org > > Subject: [PATCH v2 2/4] net/iavf: fix buffer leak on Tx queue stop > > > > When a queue is stopped all buffers are meant to released from it, and > > then a new set of buffers reallocated on start. For the iavf code when > > using vector Tx, some buffers were left in the ring, and so those > > buffers were leaked. The buffers were missed as the release code only > > handled one side of a wrap-around case in the ring. > > > > Fix the issue by doing a single iteration of the ring freeing all > > buffers in it, handling wraparound through a simple post-increment chec= k. > > > > Fixes: 319c421f3890 ("net/avf: enable SSE Rx Tx") > > Fixes: 9ab9514c150e ("net/iavf: enable AVX512 for Tx") > > Cc: wenzhuo.lu@intel.com > > Cc: jingjing.wu@intel.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Bruce Richardson > Acked-by: Wenzhuo Lu Applied to dpdk-next-net-intel. Thanks Qi