From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0A6A2A0545; Wed, 25 May 2022 02:11:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9F088400EF; Wed, 25 May 2022 02:11:24 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id A7E5B400D6 for <dev@dpdk.org>; Wed, 25 May 2022 02:11:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653437482; x=1684973482; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ZMbudzUp3IzQo63SokutjPyT+eprPIq+fI95X3vsI04=; b=JQvLwx/QHf5ZySZlS14FWEBnefZ+jxyxmHrGkkEfqafFMP6314bl+YyU 2WOKy3i2GiWbka7q6/NC9NB9BVT61OboftoLo5M95mInKmmm4EcNWFeUk YyeeFAgw6RrNYqU6WcXA74CfG10OXAwdmxoCRxcfiL6rLE7uCkfgftIU9 PkVmonm51Hkszs2VBZujFTPGGXJDDerLWtKpyrXp0dM03Y2Fe1eFG+KSK JXFXeEx6T+ubPeIVFB/1bYBzZQBZxuu9viiFNjbpqdfNzuhd5ln9pRP9g RUth4ID+y6r5+nZq/YqaSnrrctKqiWFPN6AfPnsRlDogeh78UvNOKLSHG g==; X-IronPort-AV: E=McAfee;i="6400,9594,10357"; a="336733081" X-IronPort-AV: E=Sophos;i="5.91,250,1647327600"; d="scan'208";a="336733081" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2022 17:11:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,250,1647327600"; d="scan'208";a="664180549" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by FMSMGA003.fm.intel.com with ESMTP; 24 May 2022 17:11:19 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 24 May 2022 17:11:18 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 24 May 2022 17:11:18 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 24 May 2022 17:11:18 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.104) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 24 May 2022 17:11:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iITF3EM7St62PHLvCKDCLr7IQYgat5Ndxwoy4l+hOz0P5aSsMeZUucnZWizA3t301gQbxp94i0Q5NAF+fh7O8NzfqeE1huiALIjJ8GZOFpEZ1kUgw5xlkRNWWI2N04rLJg7hnrQZwgKoQrgG+SbQBdYCY9j/g2E3IV81eXiRyvGRJaLw+CJVRb3QPDKuhJ8udU3Z4vq0LA/F/vZsLOWjNsaDc4BroAT0YBXD1t+3MCeN7t1Vf6vmjmNc4xlki7lvoyV43lmdqFH4ckPvYR2cHOmUjBlu8z9KAcgAE8rue8mEWlGRaPeyqS1k14x/cC2bgDVLr1CRB9vRF3iVta6xog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bhKDZ4b06188BhrZibQEtZWHZxuazdAIhHf397LN4v4=; b=CxjG8Qdg2x68e7dbS2mkTK5McSceh2QLkzOQYxNZ582XouJAI8cnpUere6FJfU7DX2KBQf+69skgFBr0ciQ8NetUV2WQBGnkVPQG5t/dZFIa7pI+NqdquvTh3GjptpK8dQ6SEeaSt8EsBtn1vThtIZKny4iWoYk9KjQdrS5VB9ZSdGXiaW6IwG9x67X7GPR529dJ41z17SuWgC46xXFbMUku9bUQ8EF1YKLUVn/9STX1LgqynHWC7iFm8gHhAdQWgPs96aD5TrSvQOokVGxlkw1drmCP9YDclWyKvi9ohxkXFY4GjEtIAQu+RWSTfqepvg9UHQZCRLihaH3EzifxzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by SJ0PR11MB5024.namprd11.prod.outlook.com (2603:10b6:a03:2dd::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Wed, 25 May 2022 00:11:13 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::b4f6:f68:2e31:ddf7]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::b4f6:f68:2e31:ddf7%8]) with mapi id 15.20.5293.013; Wed, 25 May 2022 00:11:13 +0000 From: "Zhang, Qi Z" <qi.z.zhang@intel.com> To: Thomas Monjalon <thomas@monjalon.net> CC: "Daly, Jeff" <jeffd@silicom-usa.com>, "dev@dpdk.org" <dev@dpdk.org>, "Wang, Haiyue" <haiyue.wang@intel.com>, "ferruh.yigit@amd.com" <ferruh.yigit@amd.com>, "andrew.rybchenko@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>, "Richardson, Bruce" <bruce.richardson@intel.com>, "Mcnamara, John" <john.mcnamara@intel.com> Subject: RE: [PATCH v2] ixgbe/base: Manual AN-37 for troublesome link partners for X550 SFI Thread-Topic: [PATCH v2] ixgbe/base: Manual AN-37 for troublesome link partners for X550 SFI Thread-Index: AQHYOWgI/FvuTNVQ3E+3m88sjeNJdq0kIZXQgAohkwCAAAM7wIAAU/QAgAB9gTA= Date: Wed, 25 May 2022 00:11:13 +0000 Message-ID: <DM4PR11MB5994D1B7CA617AA38792116ED7D69@DM4PR11MB5994.namprd11.prod.outlook.com> References: <20220316181544.7251-1-jeffd@silicom-usa.com> <11811318.eQLIkvUDd3@thomas> <DM4PR11MB59945D8CC8A16C2C19FB2677D7D79@DM4PR11MB5994.namprd11.prod.outlook.com> <4594196.1oUyQt6lIG@thomas> In-Reply-To: <4594196.1oUyQt6lIG@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 28a254d4-2de5-4389-5cfb-08da3de31435 x-ms-traffictypediagnostic: SJ0PR11MB5024:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: <SJ0PR11MB5024D2DB27BE16FCA65B3D24D7D69@SJ0PR11MB5024.namprd11.prod.outlook.com> x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xHuKltC51o0VAFMHal63SzeVTMUEgU7VUGJ09+v6iENnCwSCiS/typ+0lxmLZhL78AscLBvK/9aMgThNgnlsrpqwW4dk9GntLtOt6DboiLXktvz5NBJ9yJbwNQg7fAn5ipn9A0VcJ14BpjvZbnNgcYMrXUOEVprx+Z/t0ifpeEqAQ40klpWjOnJNeiGwD+IsCMCPw4pmRegmqL3VOIe8BJ7g1iy9+jl8DZiZplC3qniSDrnTNKjW3I+lny8r+Oun6V/KQd4Y7Fo+y7Wi0V8WiEqNsQCPJUke1CCiXoqz3SqVHYyiPA+6wGoiH90bSyHEhFCx4p5tZkN7TIlQVsOVkrWFrvzZdqLBQIX11fPDKfOdX/pILFGVNUxGiPk5iu6jj5ar5qlHUPQuEwP6sdQYproTVSaDgTwJ7wJWZTfcRyTvs7IFyIzdESyX2kVnT3BH9jsyfJSPJzFz/jbbIQLhrSqhNKT3oGRBfnBHmZvmiS74jBG2bO9Tfu18+uO8D+AiwF3sHsh3UEYIf1XW6EUxBl3LVyDfVYjn+z8aoy71oGG/GkPWPQyN7TLiZg0q754VXqmfLTqaW3n+iIhD4rteF1NG36DZohINDyPNfKxC9NLoESrLnlimFmGMp4YIyCBbyei7uRQ3myCp2HASUrXrNONCQDIdiXCMr2DGaW2eS/YTrJb0RJV3rSQHCMmu/O3mfOMdfI9iUPxqbBvnW4ayjQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(508600001)(71200400001)(26005)(186003)(33656002)(86362001)(107886003)(55016003)(9686003)(2906002)(52536014)(5660300002)(6916009)(38100700002)(54906003)(316002)(6506007)(76116006)(83380400001)(7696005)(53546011)(66446008)(66946007)(66556008)(82960400001)(122000001)(66476007)(8676002)(64756008)(4326008)(38070700005)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CtOOFm8B0G0xeqVm1v8QK8KIzpnTYWZ5IZZ+Nd1P+vxn8MXPxusMSRUQJvAI?= =?us-ascii?Q?P0Al4Vvyv7MxroI1P7TpPBO84zNivEDYE/Fn0CV5JkbNA8gT+e8+v/T18fSD?= =?us-ascii?Q?I0Wy3xcuRgs01/T/aAqEePUG+vj+anLKe4CIG7P34Mdt4me8Fpfuwq3uRDOh?= =?us-ascii?Q?L8KzhN+ylZa/6I6cNxLznsM+PgQt+JVwM7Yvxkc1zz6igCgDp5n6fPKKdbSW?= =?us-ascii?Q?GFxPQ242rgaZMp2IiDCBypcSY0gN9fy82iT7aWG56ZvDkXO0vnDpzVIHgItM?= =?us-ascii?Q?tjZXcKAW7VsKwumwhoEBNtVc4lXn2XbbPVehyVbnuFdhvKxQRkJAPzOqk1fg?= =?us-ascii?Q?s30LvUldKS9hBkcWR1yt4pg2hGtnoDGCIB9TejqMCghFbu1/qCqe2UU2tJv4?= =?us-ascii?Q?SrjuLGZFLMj3YqemzBSx3wmZH7aXLjelRGghA4tlj3c62mlEUEQhwrtwxlQj?= =?us-ascii?Q?fMDxkPjyjdntgdtRD2GLXoIZSAYmZploTqtzdBMgnluMmSqfP17Gve+IOaG0?= =?us-ascii?Q?cMTIh6nDfzVWSntTIVYDAikNHGlzolKf9ewMjghWyKNz1tkGzN4HXu+0M9uS?= =?us-ascii?Q?lMis25jlm4NobuVbmK1CxH7YF/bbtA994VhhR9BvwVZrXHoMlyVeKJTqGXgI?= =?us-ascii?Q?XpYW9YswCF+SeXSLmMhomP3qTnqEzrrN3ewWzpP6YvdbqIYSlMQ6O0gum/6G?= =?us-ascii?Q?h+DDkXV6xGYUeUOIF50K9YrpckPRBmIP4UFBrCPKf+itN6MGdVnIPUjj8A8D?= =?us-ascii?Q?EdZG5WtcgBcS4gFXAJmIZt3iTdBurW7faWMl1JJTgcUxtOkEju0okqBzsdYU?= =?us-ascii?Q?haEuJYJTWx5GEW2H1g74xJjoLBZLUCVsXp1MhRKoWrb7tfrDB0eoyQH1eemM?= =?us-ascii?Q?M+0W/QJPXz9Uf8OfNj4vJvs5cXaYSS2wHpPcOIBnlYJEeO9DCktrK+ayuYm7?= =?us-ascii?Q?Hc1BSbjBa2rBHE7dOhq0vw2iOY+ig0m9x+AA6dNUK375dlM0RWPe4Sa6ZNQx?= =?us-ascii?Q?TKzNiBDmgVNXVIH1DHLjRYIVkEFnZ1Q7WJtfW0AYK986c4+fzyAtT62ZH/bJ?= =?us-ascii?Q?jbIWaKftUyCA4UgWqgLWk4NlMUGKOLdAYExT6oz7yWchtBGeiuAq2OxFPVSn?= =?us-ascii?Q?1Zsn8Rq6O03F3U11f0IET12m1Il7G2AJ53RXWWIR7bilaZJKC4muu06Q5X09?= =?us-ascii?Q?GkK7o2+dNWk9ZTYfclM5Jji3j8NeikXqyOa+PJs127w9ibBjQxYXFhHu5oLW?= =?us-ascii?Q?imIzj7EYsUoBzWr2zPiqCEYjV6TtC4KZm/rQ2XnVQiNXlv7/YCb3Vh5Gs06h?= =?us-ascii?Q?/jCbObc/e6Fu1Iucjy+cyLSWsxUf0A50C9jbjYq9R6WV8Oj2JhLbonRsWPEF?= =?us-ascii?Q?p8gdeiKtpKTWW+PK2sKs2MeEiiOD4Gx3zj/dk1fCLDyu1/Vp7+lOY9eRRIq/?= =?us-ascii?Q?IqmRwNON3IFB+yj0b36iayhfSfsm3dpyJLzPEU4aodj/DZ7+xNKB8nNK3C1Z?= =?us-ascii?Q?JmCLtTP+3CMmOkmqpx9ftrCfvSgSVQi3/SWK0No+rJrJfyidEnKO0T0putld?= =?us-ascii?Q?i56YEB8ZeQTXYw47igRsZg25PEadqwxENcBsxvThbK1RlbUnOi9jKKFyKHCv?= =?us-ascii?Q?YB8LSfjQ447H6tj8eKGYQpvx1rCrXOpFfPQ/0rAJRmMWtfqN9T3kUSO2DAjw?= =?us-ascii?Q?GhBCYNFqXcznipeYkkaJqTyhlNiaphF1iFo/sV/oKGXTpiXhckWfC6yiorLS?= =?us-ascii?Q?uJDnGiaVFg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28a254d4-2de5-4389-5cfb-08da3de31435 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 May 2022 00:11:13.1466 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NkTRu7s4jQYS6DejzxbZwVoWiixTlWlWswG2T4INZLCL3jM4G3u9325Gr2xEY+aUr2V8jurfrH5yxTHpN8cRww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5024 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon <thomas@monjalon.net> > Sent: Tuesday, May 24, 2022 11:55 PM > To: Zhang, Qi Z <qi.z.zhang@intel.com> > Cc: Daly, Jeff <jeffd@silicom-usa.com>; dev@dpdk.org; Wang, Haiyue > <haiyue.wang@intel.com>; ferruh.yigit@amd.com; > andrew.rybchenko@oktetlabs.ru; Richardson, Bruce > <bruce.richardson@intel.com>; Mcnamara, John > <john.mcnamara@intel.com> > Subject: Re: [PATCH v2] ixgbe/base: Manual AN-37 for troublesome link > partners for X550 SFI >=20 > 24/05/2022 15:42, Zhang, Qi Z: > > From: Thomas Monjalon <thomas@monjalon.net> > > > 18/05/2022 02:03, Zhang, Qi Z: > > > > From: Jeff Daly <jeffd@silicom-usa.com> > > > > > > > > > > Some SFP link partners exhibit a disinclination to autonegotiate > > > > > with X550 configured in SFI mode. This patch enables a manual > > > > > AN-37 restart to work around the problem. > > > > > > > > This fix for some specific hardware in base code, unfortunately > > > > Intel DPDK team don't have the device and the knowledge to approve > > > > this, > > > > > > That's why the work is collaborative. > > > You should get and trust knowledge from partners. > > > The only concerns of a maintainer should be: > > > - good feature design > > > - good code quality > > > > These are the questions we can't answer, we don't understand the > > design, what is " change mode enforcement rules to hybrid " means, > > what is manual AN-37 here and what those numbers in the patch means. >=20 > So these are the basic questions you should ask to be made clear in the p= atch. > That's the same for everybody: we must understand the reason and the > intent of any change. >=20 > > Of cause we trust knowledge from our partners, but anyway this is an > > Intel product, >=20 > The DPDK driver is not an Intel product. > This a community effort where anyone should be able to participate. I'm taking about the hardware not the driver. >=20 > > only Intel have the right to authenticate this. >=20 > What do you mean by "authenticate"? >=20 > > unfortunately none of the active ixgbe DPDK maintainers and I have the > > knowledge Meanwhile if this is an issue on DPDK, it could also be an > > issue on kernel driver that's why we suggest to submit to Linux > > community first where will be right people to answer above questions. >=20 > Why Linux community is more able to review than DPDK, or FreeBSD, or > Windows, or any other community? Of cause DPDK could be able to, if the people have the corresponding knowl= edge that works on it I would say on this very specific domain, DPDK community has the gap that d= epends on Intel, Nothing else, we just try to provide workable suggestion based on current s= ituation, meanwhile we will escalate. =20 >=20 > > > - no regression in known cases > > > > > > the base code is delivered by our kernel software team, I will > > > > suggest you can send this to the kernel community to get the right > > > > expert to review. > > > > > > Which kind of expert do you imagine to review? > > > Intel team or Silicom people who are pushing these improvements? > > > > > There is another problem with asking Linux kernel change first: > > > the patch will land in GPL code, bringing difficulties to move in > > > BSD-licensed base code. > > > > Only if the author agree to share the copy right to Intel, so Intel is > > able to re-license it to BSD as same as other base code. >=20 > Yes we should be able to grant such copyright in the commit message. >=20 > > > I suggest we make this process more flexible: > > > 1/ a contributor sends a patch for DPDK base code > > > with an explicit grant for backporting in any license. > > > 2/ Intel checks that there is no DPDK regression > > > 3/ patch is merged in DPDK > > > 4/ Intel merges it in the internal base code > > > 5/ Linux kernel team can backport the fix to Linux > > > 6/ Any other OS can backport the fix in its driver > > > > Right now, our base code in kernel is GPL license only, code with > > BSD-3-clause can't be distrusted without change our license strategy, > > so it's the same effort if someone want to backport DPDK changes to > > kernel (shared the copy right to Intel) > > > > but I like your suggestion (if I understand correctly), have a dual > > licenses in kernel base code make things smoothly to backport from > > DPDK to kernel, I will feedback this. > > > > > Let's make the DPDK process open for everybody. > > > > For sure, we should. >=20 >=20