* [PATCH] common/iavf: do not copy desc/buff in async mode
@ 2022-09-05 1:42 Steven Zou
2022-09-05 2:00 ` Zhang, Qi Z
0 siblings, 1 reply; 2+ messages in thread
From: Steven Zou @ 2022-09-05 1:42 UTC (permalink / raw)
To: dev; +Cc: qi.z.zhang, guang3.yang, Steven Zou
If cmd_details are defined or async flag is set,
don't copy the desc/buff back to temp.
Signed-off-by: Steven Zou <steven.zou@intel.com>
---
drivers/common/iavf/iavf_adminq.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/common/iavf/iavf_adminq.c b/drivers/common/iavf/iavf_adminq.c
index 0bf5af0cbe..2e59820b3b 100644
--- a/drivers/common/iavf/iavf_adminq.c
+++ b/drivers/common/iavf/iavf_adminq.c
@@ -784,7 +784,8 @@ enum iavf_status iavf_asq_send_command(struct iavf_hw *hw,
}
/* if ready, copy the desc back to temp */
- if (iavf_asq_done(hw)) {
+ if (iavf_asq_done(hw) &&
+ !details->async && !details->postpone) {
iavf_memcpy(desc, desc_on_ring, sizeof(struct iavf_aq_desc),
IAVF_DMA_TO_NONDMA);
if (buff != NULL)
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [PATCH] common/iavf: do not copy desc/buff in async mode
2022-09-05 1:42 [PATCH] common/iavf: do not copy desc/buff in async mode Steven Zou
@ 2022-09-05 2:00 ` Zhang, Qi Z
0 siblings, 0 replies; 2+ messages in thread
From: Zhang, Qi Z @ 2022-09-05 2:00 UTC (permalink / raw)
To: Zou, Steven, dev; +Cc: Yang, Guang3
> -----Original Message-----
> From: Zou, Steven <steven.zou@intel.com>
> Sent: Monday, September 5, 2022 9:42 AM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Guang3
> <guang3.yang@intel.com>; Zou, Steven <steven.zou@intel.com>
> Subject: [PATCH] common/iavf: do not copy desc/buff in async mode
>
> If cmd_details are defined or async flag is set, don't copy the desc/buff back
> to temp.
>
Added
Fixes: e5b2a9e957e7 ("net/avf/base: add base code for avf PMD")
Cc: stable@dpdk.org
> Signed-off-by: Steven Zou <steven.zou@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-05 2:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-05 1:42 [PATCH] common/iavf: do not copy desc/buff in async mode Steven Zou
2022-09-05 2:00 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).