From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4378EA04FD; Thu, 10 Nov 2022 11:01:36 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E3F9B40150; Thu, 10 Nov 2022 11:01:35 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 5D535400EF for ; Thu, 10 Nov 2022 11:01:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668074494; x=1699610494; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=hExGJWaVkw5dBnoVK2aCTqBOJpRHszeNVmxLshIJ24U=; b=NM8yBs1aaHD6Kj1LlfRgU6a20on61ddx66BFzcLSAtCeZyAtWiRdLz8a xHMLgnpAOTBeM8FR9TMWyIBm2kBO4gZ5VwOW0gRgQ37ER/6k80iBREkh3 0DVB0+IzhrCBlZHxTOuh3MFATcnchAyjur+tO0QgHDU0AD7/HOF2pEWq+ dCOueFcfcTfz1lDn6yW2ghTbF3J/rsw/7fnPRANlHF7074pmqqOrPBVSw jwD2MkN7rrj3d39Y6oWqtF8+rB6RnZxJrq1ZhyjvZzTNQrwUVrbAE+ynV xFfo3YolKeszi5RQTJl3FAps4FN7seB5UW/ICeGUhcTuxQNHAXtivLbPL Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10526"; a="311270642" X-IronPort-AV: E=Sophos;i="5.96,153,1665471600"; d="scan'208";a="311270642" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2022 02:01:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10526"; a="706087783" X-IronPort-AV: E=Sophos;i="5.96,153,1665471600"; d="scan'208";a="706087783" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP; 10 Nov 2022 02:01:33 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 10 Nov 2022 02:01:32 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 10 Nov 2022 02:01:32 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.46) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 10 Nov 2022 02:01:32 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B9Y4wHPMyw3KbvAHUNPtOhiz3M2dFdH4aDyZWmc5uEpEsLqJSXcdFR8XNJ47lAr0PSFmC1CJIQs5j+GuO0SVLfABS6c/t7WpbAj6kEYOMHN+nD0UtuflRv6R5Yn6oF1A3s7PBxG/BBRpYzIvxYMJxc6N7Biu+Whxe52QsUwZjd4K8nPGy/5pI7o5YoSis04L9cJ8lLi485IZ6k+VDiL8DwBdjvPCod2eqb8gdK2P+KHJl3fpPO89dMLdN6WT0Hf6eOimOEwdrTAOK1H9Sg1UH0Y5RXcrMxAdbbfhbdvJ+HerC8n0enmD0eD8zkVv6iDTR5XEvG7VDe8hCZbaJXZZ/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hExGJWaVkw5dBnoVK2aCTqBOJpRHszeNVmxLshIJ24U=; b=BqzvayoiJU31EzfLE9BAT9rhDmGpS/VJVH1Di61nigM0DVFLtucbegjoUGw+PZx8OKD/WJ+oXgAelT9KSdihE9iImFK/eD8GLKexyGJa9NoKS7Xv66jkoUlrWyYy1Z1pXRcpaapK8VvJkoU1AyitnCIhUGQ8j6TNK2khB/U7LfLCI44zEcpKJkxwVIH/aFtZHSkeIYSIBywxOwLqU3uiDI4eHYFa3PtOSFwL5PK1TGQ0ecXkq57Lpl6aUT6TGvcorc3c61pEgKgWiPrSMCRM1i73Rmwt55lV+wDvpW3+1O075ywYM/yw1230gWuqxTToQN+fx0aLbRZRNRox4aaO1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM4PR11MB5994.namprd11.prod.outlook.com (2603:10b6:8:5d::20) by DM4PR11MB6501.namprd11.prod.outlook.com (2603:10b6:8:88::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Thu, 10 Nov 2022 10:01:31 +0000 Received: from DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e2ac:cde3:4d74:3fa7]) by DM4PR11MB5994.namprd11.prod.outlook.com ([fe80::e2ac:cde3:4d74:3fa7%3]) with mapi id 15.20.5791.025; Thu, 10 Nov 2022 10:01:31 +0000 From: "Zhang, Qi Z" To: "Yang, SteveX" , "dev@dpdk.org" CC: "Wu, Jingjing" , "Xing, Beilei" , "Yang, SteveX" Subject: RE: [PATCH v2] net/iavf: fix taninted scalar Thread-Topic: [PATCH v2] net/iavf: fix taninted scalar Thread-Index: AQHY9OB/3/BWr7uWmUGvMXUcQbQeLa437O4w Date: Thu, 10 Nov 2022 10:01:31 +0000 Message-ID: References: <20221110072529.132523-1-stevex.yang@intel.com> <20221110083052.133399-1-stevex.yang@intel.com> In-Reply-To: <20221110083052.133399-1-stevex.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM4PR11MB5994:EE_|DM4PR11MB6501:EE_ x-ms-office365-filtering-correlation-id: 7223842d-5503-4d0d-2b0b-08dac3028ac2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: s1JoXmepvvnbC0gx4FNZPkDNzt2gFFHx7j5YpmpBldIek0SB2eTLN7KwXbHTMEn7H99BypAc52mHuU9mIMBLZ2UyB6yIPYPNBiu97dP4pERO+3az8o0ysH4JfiQNRUB9wFPdUEGrzEnIwNMNx+r6OQND/G/ZZFlwidrYvPg9lDTeV2UXGnGRK2aEmb6dM9BNJYgKNmORlBT2MxVJUpJPBfM/At006cz/gitIjp1y276q1m30rtTqfb510nchWiGIuF/x69VLXWjYgLCkFdI5IG6e1k9jPPtp9S3saRCStFbn/0KkVW+tEklbyioQUeZsnPct22Lo1+hGVaNe3uuBxAiTbJfzWFcMGxq+uyWGvDmTxx+huw0ScBWj0aq6hiUqAmWkdlmMr4JtgYVZkW4IEV4I2FaKhtZsv7mjv7NSuexcdYORZtkqPStGX7Aexk4AwYW4KZPzGm3gpPw3FubIAR25EVaGBE4Qr0txfUfXaEwvF1rv2VdMsKoUZgTQhlEzw/MkDQeuG3x4ysktTe32rrzH6NdK2gTTrytg0CwOdHdcE4C+ch/ds4EzelRyKF3mWrucHmcduW3FffjXU5rZrFzKETSaKOdL0WC4Lx7zWTxunY7ro0liE68GH+8fCPbUIrSgxJUNUVnz2BdX5hPdF9S22IrA5qGU7Rd9OPPZ8Da4TV4hLdAgJiH7jbrgDaYuJfSTnbSuk+lvqRwzcJZ6zBywIhHgJJF56xU4kxaJyj55qpGpjmpT2vCBfMqFt9QnummeThARBWG7FwPWnREMGQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5994.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(346002)(39860400002)(376002)(366004)(396003)(451199015)(82960400001)(122000001)(33656002)(38100700002)(478600001)(55016003)(53546011)(38070700005)(83380400001)(86362001)(4744005)(2906002)(6506007)(186003)(9686003)(7696005)(76116006)(8676002)(8936002)(64756008)(5660300002)(107886003)(71200400001)(52536014)(66556008)(41300700001)(54906003)(316002)(26005)(110136005)(4326008)(66476007)(66946007)(66446008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ikOX8LKYaFpEuqIXy7S0rhjd9X1EvMkp9ZVsQQVmKmSetHoUSiELfwyEgR88?= =?us-ascii?Q?7zL39R1XGhVyy0xxEi/WwI6cENuNoFDLnX952USDfgQqxgrj1JD5/4MzsKVA?= =?us-ascii?Q?n5JLtj3f6/YDuubAGDgbXnRhXKO++uHTNnjfHHvmSk4obZjOCsNZu+AXciHV?= =?us-ascii?Q?wd5pllKT9BcvYT9s59HQUw2y23rIvOXpRkjbk7kpORwSqAf9tBqOIweGuHQE?= =?us-ascii?Q?rVriOPEM2DPoLCj2BZmun64PYy9fR8bjowezgjFOJALtoycc9BzVqJry4hR8?= =?us-ascii?Q?OQFVeDmIAxI21PEUJGJHXxVpkthACn7wb6CDEg4tCDjTl0CIJxpf3nm9Eiz+?= =?us-ascii?Q?l2JnPlB/3sYhqSItOQZu1Yf/paKwpy1gKjSEQC/LPKZmNILPicFFK537uy86?= =?us-ascii?Q?KMbLtbVB8tevrtqUk43j8muMXY780ZBtys0T0oGGS6iQBw3hUCf9DoM59Kfw?= =?us-ascii?Q?bKVH6OvquAxLk6AawviI3H31AGchvKpcVS2Qeq4h1akN8SqhjQ+5gIZg9yK1?= =?us-ascii?Q?D+xOi9OwF4+z4znM49vh+ctp+uZur9niVoAWkAKEwghxKKjaVLmmmHm5qG8u?= =?us-ascii?Q?bLrnAyCvu3U8o4/13+nbTr1OJU0pq6pXGB2OP52KVSjYKYIQc+qU1K2VTQn7?= =?us-ascii?Q?WLqjZ4y4vnZGtpgUEjFOhRgmnaqbI/3sKyPihdYuW8i89Sya6pFcYC6Due9+?= =?us-ascii?Q?vy7WWnx7WaE9BXqnosg/JJPJNtlCOzR2nO8ojV4+2FwH2/6lCww0DQLjIQbQ?= =?us-ascii?Q?XFhH5bJYnvWGEQjdKcYHykEtp4njdeU+DyX2eotryjQb6ZGCnaZBNU9X7zYO?= =?us-ascii?Q?ZyWuXswCwzpdrfjCG3+Zqkx8MZcgDxM/3znsctBPmgbS+eC9pfz8QYwXB3F8?= =?us-ascii?Q?OJXQ8MrMJR+w/zfCS8xwlPPc23ZT1Vcp2M8tqeFyeSANdNhA/okCBENjZ/zJ?= =?us-ascii?Q?QUM2g+SHqVoLfoR6WUB6U9kPkpPnG+4EMyOJ507y9JEec2eesT02psEZyhO0?= =?us-ascii?Q?oVj05uUqOsIz1oD9vMIiGLMtFpNO9hLqzmP8oQcfh0pw/Yvb1YTnizUF6ttp?= =?us-ascii?Q?2Or62zAr0B2OXPf+tLNNKZFjMQgHVhfAN7D4WMhb/DKnW7yi0OmT5wJ57DgZ?= =?us-ascii?Q?c3Y+6o78gkUL82EthHvBZ5VsPnMKyujX1+wsC8PKLyjuBkiZTYz7q6AVnJyV?= =?us-ascii?Q?cXD+00163qDMQiK7hhFcmOn7iogDP7frrNg4Ws/3WNOIvmC8tiw9FBqEfeEQ?= =?us-ascii?Q?RmwiZqPfimJsh+FUJ+NSk9OWNbAYlAlWUl3lSJGLrOeE5un1JollG4WI15TW?= =?us-ascii?Q?HlAWPko6c3EJMW94CIriKMlhTdVimKrgEehzR/EgUjFgvTtoxmRbLXsbjU2S?= =?us-ascii?Q?2aF7U+1NCvigv/7mCNRyCMQq6D10lY7+B8tcFq5398z7JHGyGVONFRtv60Ak?= =?us-ascii?Q?dpx7beNmqhqwKOEFfKGGucB4jxD5kRiwgzR06MYX8ostJSQTPyjAWi78dX/H?= =?us-ascii?Q?xukQ/sFXfhSbBY6OACULYgeiUq9EMBGPQZXNleqque+kct3pOllHv9cTgv93?= =?us-ascii?Q?dqnKAUfxMoVlkYEZJGOMxBxDFRjXkOKwe4HtdeKH?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5994.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7223842d-5503-4d0d-2b0b-08dac3028ac2 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2022 10:01:31.1209 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sNtBcu5Hm/wevi00FYtrbLwvxHoK/lWGXkMSobkEdUqNdvhE7OXmbC+xOQbm2uJTpPVhuw+95Hv3cELN7lXx2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6501 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Steve Yang > Sent: Thursday, November 10, 2022 4:31 PM > To: dev@dpdk.org > Cc: Wu, Jingjing ; Xing, Beilei ; > Yang, SteveX > Subject: [PATCH v2] net/iavf: fix taninted scalar >=20 > tainted_data_downcast: Downcasting match_item->meta from void * to > struct virtchnl_proto_hdrs implies that the data that this pointer points= to is > tainted. >=20 > var_assign_var: Assigning: proto_hdrs =3D match_item->meta. > Both are now tainted. >=20 > var_assign_var: Assigning: rss_meta->proto_hdrs =3D *proto_hdrs. Both are > now tainted. >=20 > Passing tainted expression "rss_meta->proto_hdrs.count" to > "iavf_refine_proto_hdrs", which uses it as a loop boundary. >=20 > Removed temporary variable 'proto_hdrs', and copied whole memory of > match_item meta with exact structure size to avoid data downcast. >=20 > Coverity issue: 381131 >=20 > Fixes: 91f27b2e39ab ("net/iavf: refactor RSS") >=20 > Signed-off-by: Steve Yang Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi