From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Zeng, ZhichaoX" <zhichaox.zeng@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
"Liao, TingtingX" <tingtingx.liao@intel.com>,
"Yang, Qiming" <qiming.yang@intel.com>
Subject: RE: [PATCH] net/ice: fix DCF port statistics not cleared
Date: Wed, 1 Nov 2023 00:51:38 +0000 [thread overview]
Message-ID: <DM4PR11MB5994D576431C9A0AAA85ED7AD7A7A@DM4PR11MB5994.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20231031070426.843086-1-zhichaox.zeng@intel.com>
> -----Original Message-----
> From: Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> Sent: Tuesday, October 31, 2023 3:04 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Liao, TingtingX <tingtingx.liao@intel.com>; Zeng,
> ZhichaoX <zhichaox.zeng@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Wang,
> Haiyue <haiyue.wang@intel.com>
> Subject: [PATCH] net/ice: fix DCF port statistics not cleared
>
> As the kernel driver does not reset the statistics after exiting testpmd, the
> previous statistics being retained the next time testpmd is started.
Please describe the issue in general but not testpmd specific.
>
> Call 'ice_dcf_stats_reset' during the initialization of the DCF in order to clear
> any statistics that may exist from the last use of the DCF and to avoid statistics
> errors.
>
> Fixes: 7564d5509611 ("net/ice: add DCF hardware initialization")
> Cc: stable@dpdk.org
>
> Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>
> ---
> drivers/net/ice/ice_dcf_ethdev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ice/ice_dcf_ethdev.c b/drivers/net/ice/ice_dcf_ethdev.c
> index 065ec728c2..29699c2c32 100644
> --- a/drivers/net/ice/ice_dcf_ethdev.c
> +++ b/drivers/net/ice/ice_dcf_ethdev.c
> @@ -1937,6 +1937,8 @@ ice_dcf_dev_init(struct rte_eth_dev *eth_dev)
> return -1;
> }
>
> + ice_dcf_stats_reset(eth_dev);
> +
> dcf_config_promisc(adapter, false, false);
> return 0;
> }
> --
> 2.34.1
next prev parent reply other threads:[~2023-11-01 0:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 7:04 Zhichao Zeng
2023-11-01 0:51 ` Zhang, Qi Z [this message]
2023-11-02 1:50 ` [PATCH v2] " Zhichao Zeng
2023-11-02 4:08 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR11MB5994D576431C9A0AAA85ED7AD7A7A@DM4PR11MB5994.namprd11.prod.outlook.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
--cc=tingtingx.liao@intel.com \
--cc=zhichaox.zeng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).